ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
35,049 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

26122 Commits

Author SHA1 Message Date
Shawn Hoffman f5b05ae080 remove an outdated comment 
seems to have been solved 5 years ago by
b707e199c2
 2021-07-17 17:46:57 -07:00
Léo Lam 5021a13aa9
DSPHLE: Fix running and is_stream checks in AX HLE 
A voice is considered running if and only if `running` equals 1,
not if `running` is not equal to 0.

This fixes https://bugs.dolphin-emu.org/issues/12508 because for some
reason *The Sims 2 - Castaway* sets `running` to 8 when a stream
finishes playing; previously our AX HLE would just loop the voice
and eventually crash after accessing invalid memory addresses.

Thanks to JMC47 and delroth's help, I've verified that this is the
correct check for the following ucodes:

GC:
* 0x3ad3b7ac
* 0x3daf59b9
* 0x4e8a8b21
* 0x07f88145
* 0xe2136399
* 0x3389a79e

Wii:
* 0x347112ba
* 0xfa450138
* 0xadbc06bd

And while I was fixing the running check, I noticed that the is_stream
field was also being handled incorrectly, so I've fixed that as well.
 2021-07-14 19:21:35 +02:00
Léo Lam 887fcfc99a
DSPHLE: Remove redundant accelerator end check for AX Wii 2021-07-14 19:20:25 +02:00
Connor McLaughlin 9b17805be9
Merge pull request #9881 from blaahaj/postprocessing-fix 
PostProcessing: Fix OpenGL UBO linking with configuration options
 2021-07-14 13:14:17 +10:00
Léo Lam b0d2df727a
Merge pull request #9686 from Dentomologist/convert_adapter_tooltip_to_balloontip 
GeneralWidget: Convert Adapter tooltip to BalloonTip
 2021-07-13 03:33:42 +02:00
Léo Lam de54856fbb
Merge pull request #9846 from jordan-woyak/report-dup-setting 
Config: Add an ini setting to control real Wii Remote report duplication.
 2021-07-13 03:32:49 +02:00
Léo Lam 162af2a7bb
Merge pull request #9870 from OatmealDome/ui-thread 
macOS: Move UI API calls to the main thread
 2021-07-13 03:29:49 +02:00
Tilka 8fcda4c315
Merge pull request #9889 from leoetlino/ax-symbols 
DSPHLE: Prevent AX GC and AX Wii symbol mixups
 2021-07-13 01:41:44 +01:00
Markus Wick edc4396603
Merge pull request #9888 from JosJuice/jitarm64-logicalimm-everywhere 
JitArm64: Stop using hand-encoded logical immediates
 2021-07-12 23:03:31 +02:00
JosJuice 3af21d3d22 JitArm64: Optimize FloatCompare's CR value emitting 
Setting bit 32 is only needed in the case where EQ and GT are set
but SO and LT are not, which is not a possible outcome of a compare.
 2021-07-12 22:54:37 +02:00
JosJuice 8af5095ff4 JitArm64: Stop using hand-encoded logical immediates 2021-07-12 22:25:49 +02:00
Léo Lam 474adcc601
DSPHLE: Prevent AX GC and AX Wii symbol mixups 
Putting AX functions from AXVoice.h in an anonymous namespace does
successfully prevent compilers from merging those functions and
allows us to avoid ODR violations.

However, tools such as gdb still mix up AX GC and AX Wii functions
and variables because those have the exact same symbol names.

This can be fixed by using inline namespaces which are transparent
at the source code level but forces AX GC and AX Wii symbols to be
different.
 2021-07-12 16:30:15 +02:00
CrystalGamma beb6ec0569 VideoCommon: fix generic build 
On x86/ARM Common/Assert.h is included by way of
VideoCommon/VertexLoader{X64,ARM64}.h, on other platforms it is missing.
 2021-07-12 04:30:43 +02:00
Pokechu22 b880be0aa5 Use separate fmt::formatters for each indirect matrix column 
This also fixes a bug where the float version of row 1 actually showed row 0 again.
 2021-07-11 15:01:42 -07:00
Pokechu22 f467c02d1a Ignore the top bit of the indirect texture matrix scale 
This fixes the Zora eye coloration in Twilight Princess.
 2021-07-11 15:01:37 -07:00
Tilka 20a8e9c872
Merge pull request #9876 from Pokechu22/skyward-sword-map 
Fix indirect textures when format is not ITF_8
 2021-07-11 22:59:23 +01:00
Tillmann Karras bd5c604718 GameFile: don't download covers for empty game IDs 2021-07-11 17:14:43 +01:00
Markus Wick 88fd9fd577
Merge pull request #9869 from JosJuice/jitarm64-constexpr-isimmlogical 
JitArm64: Encode logical immediates at compile-time where possible
 2021-07-11 12:55:48 +02:00
JosJuice f903853cf7 JitArm64: Fix ps_cmpXX 
Passing a width of 64 and registers encoded as double to
DUP resulted in an invalid instruction. The registers should
be encoded as quads in this situation.

Fixes https://bugs.dolphin-emu.org/issues/12575.
 2021-07-11 11:43:19 +02:00
JosJuice 0f3b9a8874 JitArm64: Minor mcrfs optimization 2021-07-10 20:44:22 +02:00
JosJuice 9e80db123f JitArm64: Encode logical immediates at compile-time where possible 
Manually encoding and decoding logical immediates is error-prone.
Using ORRI2R and friends lets us avoid doing the work manually,
but in exchange, there is a runtime performance penalty. It's
probably rather small, but still, it would be nice if we could
let the compiler do the work at compile-time. And that's exactly
what this commit does, so now I have no excuse for trying to
manually write logical immediates anymore.
 2021-07-10 20:43:59 +02:00
JosJuice 10861ed8ce JitArm64: Turn IsImmLogical into a constexpr constructor 2021-07-10 20:31:28 +02:00
JosJuice ab024b218e JitArm64: Accept LogicalImm struct as bitwise inst parameter 2021-07-10 20:13:11 +02:00
Markus Wick f6ca70d094
Merge pull request #9822 from JosJuice/jitarm64-ps-cmpxx 
JitArm64: Implement ps_cmpXX
 2021-07-10 19:20:48 +02:00
JosJuice adbf6d55da JitArm64: Implement ps_cmpXX 2021-07-10 19:08:55 +02:00
Markus Wick 4ba4d7cc7d
Merge pull request #9878 from JosJuice/jitarm64-addmex 
JitArm64: Implement addmex/subfmex
 2021-07-10 10:11:20 +02:00
Dentomologist 59292a5c65 GeneralWidget: Convert Adapter tooltip to BalloonTip 
Use a BalloonTip to inform the user when their selected backend (i.e.
OpenGL or NULL) doesn't support adapters, instead of using the default
tooltips.
 2021-07-09 10:10:36 -07:00
JosJuice afe9c6fb9a
Merge pull request #9880 from OatmealDome/windows-updater 
UpdaterCommon: Use File::Copy() on non-macOS platforms
 2021-07-09 19:02:42 +02:00
OatmealDome a39b7a45c0 UpdaterCommon: Use File::Copy() on non-macOS platforms 2021-07-09 12:56:23 -04:00
JosJuice fc60e62622 JitArm64: Implement addmex/subfmex 2021-07-09 16:44:33 +02:00
Admiral H. Curtiss c9e4489e17 Core/MMU: Fix inverted condition in HostIsInstructionRAMAddress(). 2021-07-09 05:48:17 +02:00
Pokechu22 a379456f38 Fix indentation for alphabump 2021-07-08 15:48:14 -07:00
Pokechu22 2feced2e33 Fix indirect textures when format is not ITF_8 2021-07-08 15:48:14 -07:00
Markus Wick cfcc994f6c
Merge pull request #9840 from JosJuice/jitarm64-mffsx 
JitArm64: Implement mffsx
 2021-07-08 14:15:24 +02:00
Markus Wick a390d3f327
Merge pull request #9820 from JosJuice/jitarm64-simplify-addex 
JitArm64: Simplify addex/subfex
 2021-07-08 13:46:48 +02:00
Markus Wick f67f0488d2
Merge pull request #9844 from JosJuice/jitarm64-fctiwzx-constant 
JitArm64: Improve fctiwzx constant generation in double case
 2021-07-08 13:43:09 +02:00
Markus Wick 9df6f65834
Merge pull request #9867 from JosJuice/jitarm64-unconditional-exception-exit 
JitArm64: Add the ability to emit an unconditional exception exit
 2021-07-08 13:08:05 +02:00
Markus Wick 1827cb9cd8
Merge pull request #9874 from JosJuice/jitarm64-unconditional-farcode 
JitArm64: Get rid of an unconditional branch to farcode
 2021-07-08 13:01:21 +02:00
Markus Wick 98098edad7
Merge pull request #9859 from JosJuice/jitarm64-stwbrx-sthbrx 
JitArm64: Implement stwbrx/sthbrx
 2021-07-07 21:45:06 +02:00
blåhaj debeb09dee PostProcessing: Fix OpenGL UBO linking with configuration options 2021-07-07 21:28:22 +02:00
JosJuice a6700a074d JitArm64: Get rid of an unconditional branch to farcode 
If a branch is unconditional, its target should not be in farcode,
since that defeats the purpose of farcode (putting seldom executed
code in farcode to keep it out of the icache when possible).
 2021-07-07 14:11:07 +02:00
Léo Lam de12890588
Merge pull request #9873 from JosJuice/jitarm64-tbz-encoding 
Arm64Emitter: Fix 64-bit TBZ/TBNZ encoding
 2021-07-07 12:39:07 +02:00
Léo Lam 2c66a08fd3
Merge pull request #9848 from Pokechu22/di-hw-resets 
Implement resetting DI via HW_RESETS
 2021-07-07 12:35:35 +02:00
Léo Lam 1450e97c28
Merge pull request #9522 from AdmiralCurtiss/host-read-optional 
Core/MMU: Add HostTryRead/HostTryWrite functions to allow specifying the desired address space, and return whether it succeeded.
 2021-07-07 12:32:47 +02:00
JosJuice cbbd3d3956 Arm64Emitter: Fix 64-bit TBZ/TBNZ encoding 
We haven't actually used 64-bit TBZ/TBNZ anywhere in Dolphin, so
this mistake hasn't broken anything, but let's fix it regardless.
 2021-07-07 12:21:07 +02:00
Léo Lam 4b5dabff33
Merge pull request #9871 from OatmealDome/leftrightclick 
Core: Use proper names for left, right, and middle click on Quartz ciface
 2021-07-07 12:15:41 +02:00
Léo Lam 925379cb9f
Merge pull request #9872 from JosJuice/jitarm64-msr-ee 
JitArm64: Check MSR.EE for external exceptions, not MSR.FE0
 2021-07-07 12:13:16 +02:00
JosJuice 0642ff8b25 JitArm64: Check MSR.EE for external exceptions, not MSR.FE0 
Fixes a 58698b8380 regression. (The EXCEPTION_EXTERNAL_INT
immediate being wrong meant that we never took the branch,
masking the problem of the MSR.EE immediate being wrong...)
 2021-07-07 11:55:53 +02:00
Admiral H. Curtiss c292351faa Core/MMU: Add HostTryWrite*() functions. 2021-07-07 04:26:28 +02:00
Admiral H. Curtiss b59fcae70a Core/MMU: Add HostTryRead*() functions. 2021-07-07 04:26:28 +02:00