2631243379
EXI_DeviceMemoryCard: Rename variables to follow our naming conventions
2020-11-20 18:51:16 +01:00
730f9cb7bd
Android: Fix IllegalStateException on startup
...
See https://github.com/dolphin-emu/dolphin/pull/9095#pullrequestreview-535576465
2020-11-20 18:33:00 +01:00
542c49bab0
Core: Fix invalid lambda captures
...
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.
Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
2020-11-20 18:27:56 +01:00
f45a4a5916
Merge pull request #9263 from lioncash/core-log2
...
Core: Convert logging over to fmt pt.2
2020-11-20 16:36:47 +01:00
88cc1b7c8a
DSP: Fix one DEBUG_LOG call
2020-11-20 16:21:05 +01:00
a0f9b041a0
Core: Convert logging over to fmt pt.2
...
Continues the core migration of logs up to the EXI handling code.
2020-11-20 10:05:44 -05:00
419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks
...
Common/Log: Add compile-time format string checks
2020-11-20 16:05:25 +01:00
a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case
...
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:
Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
2020-11-20 12:23:34 +01:00
c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all
...
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-20 11:35:22 +01:00
7ded075561
DolphinQt: Add Show/Hide All options to gamelist region menu
2020-11-19 20:39:49 -08:00
858d7612ef
Merge pull request #9170 from JosJuice/android-extension-hack-2
...
Android: Remove hacks for Wii Remote extension setting, round 2
2020-11-20 02:47:23 +01:00
30bffca5c3
Merge pull request #9193 from JosJuice/android-clear-motioncontrolsenabled
...
Android: Re-add motionControlsEnabled to clearWiimoteNewIniLinkedPreferences
2020-11-20 02:37:51 +01:00
7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto
...
WiimoteEmu: Implement extension encryption edge case.
2020-11-20 02:28:17 +01:00
bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging
...
FrameDump Logging: Separate log type and migrate to fmt
2020-11-20 02:21:57 +01:00
5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder
...
Fix updater not always cleaning up temp directory
2020-11-20 02:01:43 +01:00
eff566b318
Merge pull request #9258 from lioncash/core-log
...
Core: Convert logging over to fmt pt. 1
2020-11-19 20:32:19 +01:00
958cbf38a4
Core: Convert logging over to fmt pt. 1
...
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
2020-11-19 14:21:06 -05:00
e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey
...
Add a Skip EFB Access Hotkey
2020-11-19 17:28:45 +01:00
dde6090e98
Common/MsgHandler: Add compile-time format string checks
2020-11-19 17:09:24 +01:00
62eeb05519
Common: Validate the number of {} fields in format strings
...
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].
As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.
[1] https://github.com/fmtlib/fmt/issues/492
2020-11-19 17:09:24 +01:00
47c91696ee
Common/Log: Check format strings
...
Helps with catching incorrect format strings.
PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
2020-11-19 17:09:24 +01:00
83c235b7cb
WiiUtils: Create Wii Shop log files when installing a WAD.
...
Fixes https://bugs.dolphin-emu.org/issues/12269
2020-11-19 03:26:27 +01:00
4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt
...
VideoCommon: Migrate over to fmt
2020-11-18 11:10:48 +01:00
3d9b2aa005
VideoCommon: Migrate over to fmt
...
Migrates off the printf-based formatting where applicable.
2020-11-17 21:23:58 -05:00
eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot
...
DolphinQt: Don't return 0x04 bytes from tr
2020-11-18 02:31:13 +01:00
31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel
...
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
2020-11-18 02:14:51 +01:00
0339889806
Merge pull request #9251 from sepalani/sockopt
...
IP/Top: Add missing sockopt
2020-11-18 02:10:37 +01:00
b8bc6c3c86
Merge pull request #9256 from JosJuice/android-keep
...
Android: Add @Keep annotation to things accessed using JNI
2020-11-18 01:01:34 +01:00
52c615f1b1
Remove a redundant i18n comment
2020-11-17 18:23:27 +01:00
a8d385c705
Android: Add @Keep annotation to things accessed using JNI
...
This acts as a hint to both people and automated tools
that a variable or method shouldn't be renamed or removed.
2020-11-17 14:11:51 +01:00
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
6dcf7643e5
Fix updater not always cleaning up temp directory
...
Updater was only deleting TempUpdate folder when an error occured.
2020-11-13 12:25:53 -08:00
53da97208a
DolphinQt: Don't return 0x04 bytes from tr
...
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
2020-11-12 19:44:44 +01:00
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
93212049ac
Merge pull request #9242 from lioncash/disc-panic
...
DiscIO: Make use of fmt-capable panic alerts
2020-11-12 02:22:21 -05:00
9e3e325add
Merge pull request #9243 from JosJuice/android-input-overlay-null
...
Android: Add null check for InputOverlay
2020-11-11 11:22:41 +01:00
32ad2dcec3
Android: Add null check for InputOverlay
...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12316 .
2020-11-11 10:38:49 +01:00
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
ae83685b0b
Merge pull request #9237 from lioncash/msghandler
...
Common/MsgHandler: Add fmt-capable variants of the alert macros
2020-11-11 00:34:45 -05:00
f44b13ffcd
FrameDump Logging: Separate log type and migrate to fmt
2020-11-10 17:17:43 +01:00
0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt
...
ShaderGenCommon: Rename WriteFmt() to Write()
2020-11-09 22:08:42 -05:00
7b21f7af2e
Common/MsgHandler: Add fmt-capable variants of the alert macros
...
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
2020-11-09 08:48:17 -05:00
43e2f0e88f
Merge pull request #9235 from lioncash/ui-log
...
UICommon: Migrate logging over to fmt
2020-11-09 07:28:28 -05:00
8181a7b3dd
Android: Remove unnecessary ANativeWindow_release call
...
This is already handled by SurfaceDestroyed. In the worst case,
the extra code could even race with SurfaceDestroyed if they
are triggered at the same time, but this is highly improbable.
2020-11-09 10:38:50 +01:00
d982afd1ef
Android: Fix alert messages when EmulationActivity is being destroyed
...
The previous commit made this easy to reproduce when launching
an invalid disc image with the phone rotated incorrectly.
2020-11-09 10:38:50 +01:00
ee52f465b1
Android: Fix rotating EmulationActivity after boot fails
...
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
2020-11-09 10:38:49 +01:00
d06830b274
Android: Only show emulation menu toast if boot succeeds
2020-11-09 10:33:53 +01:00
0280f3557c
Android: Finish EmulationActivity from C++
...
This makes EmulationActivity automatically close if booting
fails, and lets us get rid of s_emulation_end_event.
2020-11-09 10:33:52 +01:00
21dd7a8ebb
Vulkan: Migrate logging over to fmt
...
Migrates the vulkan backend over to the fmt-capable logger.
2020-11-09 03:26:16 -05:00
23a8baa605
Software: Migrate logging over to fmt
...
Migrates the software backend over to the fmt-capable logger.
2020-11-09 03:14:01 -05:00
413d64e7fc
OpenGL: Migrate logging over to fmt
...
Migrates over to the fmt-capable logger.
2020-11-09 03:09:09 -05:00
4d9a7c7a54
D3DCommon: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:03:26 -05:00
2345d5f98d
D3D: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:02:00 -05:00
d7834bd6b4
D3D12: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 02:59:51 -05:00
52f2fadb36
UICommon: Migrate logging over to fmt
...
A very simple change that continues the migration of the logs over to
fmt.
2020-11-09 02:39:55 -05:00
a5b28f1f07
ShaderGenCommon: Rename WriteFmt() to Write()
...
Now that we've converted all of the shader generators over to using fmt,
we can drop the old Write() member function and perform a rename
operation on the WriteFmt() to turn it into the new Write() function.
All changes within this are the removal of a <cstdarg> header, since the
previous printf-based Write() required it, and renaming. No functional
changes are made at all.
2020-11-09 02:31:49 -05:00
a9ef7e0e43
Merge pull request #9225 from JosJuice/android-convertfragment-path
...
Android: Rename path variable in ConvertFragment
2020-11-09 02:16:59 -05:00
db83c7ec8d
Merge pull request #9227 from JosJuice/android-menu-scrollbar
...
Android: Make scrollbar for in-game menu always visible
2020-11-09 02:16:34 -05:00
98726400bc
Merge pull request #9230 from JosJuice/android-savesettings-onstop
...
Android: Call saveSettings in EmulationActivity.onStop
2020-11-09 02:15:21 -05:00
418f9faa9d
Merge pull request #9228 from JosJuice/android-jclass
...
Android: Fix jobject/jclass warnings
2020-11-09 02:15:04 -05:00
766fab2561
Merge pull request #9231 from Ebola16/ASW
...
Android: Remove unnecessary WrongConstant warning suppression
2020-11-09 02:14:26 -05:00
add2b44eb7
Merge pull request #9197 from lioncash/uber-pixel
...
UberShaderPixel: Migrate over to fmt
2020-11-09 02:13:57 -05:00
77dc289517
CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23)
2020-11-08 14:27:24 +01:00
cae741584b
InputCommon: Return error, if any, from ControlReference::SetExpression().
2020-11-08 01:04:33 +01:00
e4793cfb39
Android: Don't name unused JNIEnv/jobject/jclass parameters
2020-11-07 12:08:48 +01:00
57dc54144d
Android: Fix jobject/jclass warnings
...
Static methods use jclass, and non-static methods use jobject.
2020-11-07 12:06:57 +01:00
cd52da959c
Android: Remove unnecessary WrongConstant warning suppression
2020-11-07 01:35:59 -05:00
a1a4d12b62
Android: Call saveSettings in EmulationActivity.onStop
...
I didn't realize that onSaveInstanceState doesn't get called
when finishing the activity.
2020-11-06 22:40:29 +01:00
2acd3abe35
Merge pull request #9223 from Ebola16/D
...
Android: Suppress warnings in EmulationActivity
2020-11-06 19:57:06 +01:00
5afda5efe3
Merge pull request #9209 from Ebola16/AIRSDS
...
Android: Update IR sensitivity default values
2020-11-06 19:56:53 +01:00
b6e236ef86
Android: Make scrollbar for in-game menu always visible
...
Some users aren't noticing that the in-game menu can be scrolled.
I hope this will help with that, though I'm not sure by how much.
2020-11-06 11:40:38 +01:00
a348efe947
Fix dereferencing nullptr BootParameters
2020-11-06 09:34:53 +01:00
56122f38bb
Android: Rename path variable in ConvertFragment
...
Not sure why I named it path, because it isn't a path.
2020-11-05 18:16:07 +01:00
4e32ec35a7
IP/Top: Add missing sockopt
2020-11-05 19:51:20 +04:00
0a239cc1bd
Android: Suppress warnings in EmulationActivity
2020-11-04 20:34:25 -05:00
28aa04312c
Common/LinearDiskCache: Replace std::fstream with File::IOFile
...
File::IOFile is better suited to this type of task.
Split out from a future PR.
2020-11-05 00:31:17 +01:00
a9c643e698
WiimoteEmu: Implement extension encryption edge case.
2020-11-04 15:22:06 -06:00
069840fb7e
Merge pull request #9218 from JosJuice/aarch64-hle-hooks
...
JitArm64: Implement HLE function hooking
2020-11-04 10:29:37 +01:00
3cd4c56645
Merge pull request #9203 from nick-michael/virtual-notches
...
Logic & UI for "Virtual Notches"
2020-11-03 17:10:54 -06:00
55dd3d7337
Virtual Notch settings and UI for octagonal stick
2020-11-03 22:06:27 +00:00
d2f80a4595
Merge pull request #9138 from martymac/VK_NULL_HANDLE-fix
...
Fix build on FreeBSD i386 - nullptr vs VK_NULL_HANDLE
2020-11-03 08:28:11 -06:00
fe986b6161
JitArm64: Implement HLE function hooking
...
Closely based on the x86-64 implementation.
Fixes https://bugs.dolphin-emu.org/issues/10965 .
2020-11-03 09:48:22 +01:00
d456e2e391
Resolve VkDeviceMemory/nullptr type mismatch to fix build on FreeBSD i386
2020-11-03 07:47:43 +01:00
d5c0a9a185
Merge pull request #9215 from JosJuice/android-pointer-portrait
...
Android/InputOverlayPointer: Don't assume surface covers whole screen
2020-11-02 18:05:47 -05:00
4e2875eec3
Merge pull request #9217 from JosJuice/android-touch-checks
...
Android: Remove some touchscreen checks from EmulationActivity
2020-11-02 18:05:15 -05:00
cbaf8f82ec
Merge pull request #9214 from OatmealDome/macos-bind
...
Top: Set port when connecting a socket to find the default interface
2020-11-02 22:17:38 +01:00
5b9cd83137
Merge pull request #8758 from sepalani/so-shutdown
...
Socket: Abort pending operations on shutdown
2020-11-02 21:52:28 +01:00
dd688f4eb0
Top: Set port when connecting a socket to find the default interface
2020-11-02 13:27:38 -05:00
8123263631
Android: Remove some touchscreen checks from EmulationActivity
...
It's better to directly check whether we have an InputOverlay
than to check a proxy for it.
2020-11-02 11:05:21 +01:00
f6ef6a317d
Android: Don't reset savestate time on load
2020-11-02 10:47:39 +01:00
a66afc864f
Android/InputOverlayPointer: Don't assume surface covers whole screen
...
This assumption is false both in portrait mode (where it only
covers the top half of the screen) and when using two apps at once.
Fixes https://bugs.dolphin-emu.org/issues/12307 .
2020-11-02 10:23:57 +01:00
4bb0ac918b
Simplify Arm64GPRCache::Flush
...
`flush = cond ? flush : true` makes little sense when `flush`
is always true at that point.
2020-11-01 19:48:57 +01:00
407ef8b596
Add a Skip EFB Access from CPU Hotkey
2020-10-29 21:03:06 -03:00
9999cf05f3
Android: Update IR sensitivity default values
2020-10-29 17:58:16 -04:00
f665ddae51
Merge pull request #9202 from WamWooWam/patch-http-requests
...
Fix logger related crash when HTTP response is empty.
2020-10-29 22:07:24 +01:00
650638c069
Merge pull request #9091 from shuffle2/pch
...
Add some files to pch
2020-10-29 21:29:28 +01:00
72e1131123
Common: Fix logger related crash when HTTP response is empty
2020-10-29 21:20:59 +01:00
d7fa75ef64
modify file export to create folder in OS when explicitly extracting a directory
2020-10-29 15:20:46 -04:00
Léo Lam