ebd029973a
Merge pull request #604 from magcius/wip/emu-cleanup-2
...
Start cleaning up the input interface
2014-07-15 12:11:17 -04:00
01cd90deef
Merge pull request #544 from LPFaint99/memcard
...
GCI Folder fix compatibility with games that relocate the save after first use
2014-07-15 12:09:56 -04:00
0720a36c99
Merge pull request #624 from phire/fix-334-issue
...
Fix another protential issue with casting.
2014-07-15 12:04:16 -04:00
79eb0f8d0c
Merge pull request #623 from phire/sw-xfb-clamping
...
Fix incorrect clamping in SWRenderer.
2014-07-15 12:04:06 -04:00
b8695a57da
Fix incorrect clamping in SWRenderer.
...
A previous PR changed a whole lot of min/maxes to std::min/std::max
but made a mistake here and used a templated min which cast it's
arguments to unsigned instead of casting return value.
This resulted in glitchy artifacts in bright areas (See issue 7439)
I rewrote the code to use a proper clamping function so it's cleaner
to read.
2014-07-15 21:15:49 +12:00
8cc11de94a
Merge pull request #625 from lioncash/logging
...
Remove some unnecessary defines in Log.h
2014-07-15 02:37:16 -04:00
4063694d20
VideoCommon: fix ifdef expression
2014-07-15 04:15:49 +02:00
198d137ca0
GCI Folder fix compatibility with games that relocate the save after first use
2014-07-14 18:52:29 -07:00
8087a89afd
Remove some unnecessary defines in Log.h
2014-07-14 15:51:28 -04:00
d4a2afe345
Fix another protential issue with casting.
...
Another issue from #334 with the casting moved from the output of
min to it's inputs.
This is a non-issue on 64 bit machines, but if dolphin is compiled
on an OS with size_t == u32 (say ARM) then remainingSize could be
truncated.
Restored the casting to the original order before #334 .
2014-07-15 01:38:05 +12:00
d4cfddcf8d
Revert "DolphinWX: Use non-deprecated flags for the monospace debugger font"
2014-07-14 21:37:27 +12:00
3ac4e9f171
Merge pull request #608 from lioncash/compat
...
DolphinWX: Remove the use of some wx 1.0 compatibility function calls.
2014-07-14 01:56:09 -07:00
0c6eeaff05
Merge pull request #617 from Tilka/clang_bug
...
VideoCommon: fix clang version check
2014-07-14 01:55:31 -07:00
1464cfee13
Merge pull request #619 from lioncash/dpl2
...
Correct the function casing for DPL2Decoder
2014-07-14 10:21:20 +02:00
2c73472671
Correct the function casing for DPL2Decoder
...
Brings it more in-line with the rest of the codebase.
2014-07-14 03:34:40 -04:00
b66eb03b2f
OGL: Correctly guard against array bounds of s_encodingPrograms
...
s_encodingPrograms is defined as an array with a length of 64
NUM_ENCODING_PROGRAMS is also defined as 64.
However 64 is out of bounds, so we want to be comparing for "equal to or
greater than here"
2014-07-14 00:48:14 -04:00
d931637d63
DolphinWX: Remove two c_str calls in ISOProperties.cpp.
2014-07-13 23:43:41 -04:00
5c57a1ef4b
DolphinWX: Remove the use of some wx 1.0 compatibility functions.
...
Uses the recommended replacements.
2014-07-13 23:42:37 -04:00
dbc30c6c76
VideoCommon: make version check easier to read
2014-07-14 03:05:56 +02:00
dee6f226a3
Merge pull request #614 from Tilka/branch_prediction
...
[RFC] Common: add macros for assisting branch prediction
2014-07-14 03:00:08 +02:00
0be03252cc
VideoCommon: fix clang version check
...
That was... er... a typo!
2014-07-14 02:59:31 +02:00
3f67ec0d50
Merge pull request #611 from Tilka/clang_bug
...
VideoCommon: version-check clang for workaround
2014-07-13 17:52:54 -07:00
b6f3ae23bc
VideoCommon: version-check clang for workaround
...
The bug was fixed in clang 3.4.
2014-07-14 02:12:48 +02:00
5c701f6e82
Merge pull request #610 from lioncash/delete
...
DolphinWX: Remove the need for an explicit new/delete in ISOProperties
2014-07-14 01:55:11 +02:00
d398e9ef61
Common: add macros for assisting branch prediction
2014-07-14 01:52:14 +02:00
aa2495205e
Shutdown the Core before other components.
...
Other components depend on the EmuThread being stopped.
2014-07-13 23:47:59 +02:00
8876ee120a
Change libav* autodetection to support framedumping on Ubuntu 14.04
...
Add an "ugly" workaround in the AVIDump code, but looking at other project this
seems to be the most common way to handle this API change.
2014-07-13 23:06:20 +02:00
3cabacde9d
Merge pull request #613 from lioncash/uninitialized
...
Core: Fix potential uninitialized var usage in WII_IPC_HLE_Device_usb
2014-07-13 14:03:02 -07:00
fae0cf3698
Core: Fix potential uninitialized var usage in WII_IPC_HLE_Device_usb
...
If "if (ReadStoredLinkKey->read_all == 1)" is not true, then
num_keys_read would be used uninitialized.
2014-07-13 15:41:35 -04:00
9d3c0102fc
Core: Get rid of an unnecessary struct typedef in Boot.h.
2014-07-13 15:28:50 -04:00
5b649902dc
DolphinWX: Remove the need for an explicit new/delete in ISOProperties
...
Just use a normal constructor call and call Destroy to close the window.
2014-07-13 15:06:03 -04:00
16582a0459
Merge pull request #543 from RachelBryk/patches
...
Fix patches not being loaded when running real gc bios.
2014-07-13 06:25:39 +02:00
0563960dbc
Merge pull request #603 from lioncash/debugger-font
...
DolphinWX: Use non-deprecated flags for the monospace debugger font
2014-07-13 06:21:02 +02:00
12fa5ba8b4
Merge pull request #607 from Tilka/fix_warnings
...
Fix warnings unearthed by #579
2014-07-13 06:20:45 +02:00
0ccee6c87b
Fix warnings unearthed by #579
2014-07-13 02:16:51 +02:00
64801008a0
NoGUI: Add missing call to Core::Shutdown().
...
Fixes a crash when exiting the application.
2014-07-13 01:05:09 +02:00
ff918df889
Frame: Fix RendererHasFocus
...
The logic of RendererHasFocus was extremely convoluted beforehand and
was too brittle and broke in certain circumstances, like when the
GCPad window was active. Simplify it and leave a comment explaining the
new logic. This fixes the GCPad window not working when Background Input
is unchecked.
2014-07-12 07:29:49 -04:00
26f3867e20
DolphinWX: Allow short-hand searching in the code window
...
Lessens the restrictions on the searching in the code view.
Now typing out the full 8 digit hex number isn't needed. For example, you don't need to type 000000FF to go to FF, you just literally type FF.
Also makes JumpToAddress a boolean function to remain consistent with the DSP code view.
This will also change the address search box to have a red background if
either an invalid hex number is given, or if it's longer than 8 characters
2014-07-11 18:32:32 -04:00
58c58d2f92
InputCommon: Use enums instead of defines within GCPadStatus.h
2014-07-11 17:18:11 -04:00
e4eec2002b
ControllerEmu: Remove focus-checking code from the rest of ControllerEmu
2014-07-11 14:08:29 -04:00
74f3083381
ControllerInterface: Gate the input based on our new background input setting
2014-07-11 13:38:52 -04:00
5abc028ace
ControllerEmu: Make BackgroundInput a global setting through the virtualization
...
This will allow us to simplify the checks for background input and push
them further down into the architecture, into the ControllerEmu layer.
The new setting isn't actually used yet, though.
2014-07-11 13:38:37 -04:00
0d49bf65a7
ControllerEmu: Virtualize settings
...
This will allow us to move Background Input to a global setting rather
than a local setting.
2014-07-11 13:32:58 -04:00
a6dc3c47a9
ControllerEmu: Change the GetState interface to remove range/base
...
Do the scaling in the code that interprets the results.
This also removes the templatization of things and changes the interface
to always take a double.
This does add a bit more code to the users of GetState, especially when
having to deal with focus management, but this will be cleaned up very
soon, as focus and focus-related options will be centralized inside the
input platforms themselves, rather than spread out across all the input
plugins.
2014-07-11 13:32:57 -04:00
0d11081a3b
ControllerEmu: Clean up the code that applies the modifier
...
This makes it more clear and pretty much the analog stick code bog standard.
2014-07-11 13:32:57 -04:00
c29d5ff989
ControllerEmu: Always convert to polar coordinates and back
...
Most users will have something in the radius or deadzone fields, so
don't bother filtering out 'extra' work. This also lets us clean up
the modifier implementation.
2014-07-11 13:32:57 -04:00
f2d4f10fc9
ControllerEmu: Remove support for the "Square Stick" option
...
It was only used for really old joypads which we really don't want to
support. If users have these joypads, they should look into using
something at the OS level, as games shouldn't need to have this
transformation; it should be done by the OS and driver.
2014-07-11 13:32:57 -04:00
07c4925059
InputConfigDiagBitmaps: Clean up the FORCE drawing code as well
2014-07-11 13:32:57 -04:00
4d2a39090b
InputConfigDiagBitmaps: Rewrite the stick visualization code
...
Change our DrawCoordinate helper method to take raw coordinate
positions, and draw the rectangle using that. This is a lot better
and more friendly than applying various crazy constants in the GetState
for the base/range.
2014-07-11 13:32:57 -04:00
8abff435e6
InputConfigDiagBitmaps: Clean up code a bit more
...
Split out some math into a utility.
2014-07-11 13:32:57 -04:00
3c411c33e8
InputConfigDiagBitmaps: Start a cleanup by splitting code out
...
This doesn't have any functional changes, it just removes part of the
mess by killing indentation.
2014-07-11 13:32:57 -04:00
68a4979f35
Nunchuk: Stop the dereference dance
2014-07-11 13:32:56 -04:00
e20a0265de
Remove UDPWiimote feature
...
It substantially complicates the code and doesn't really provide any
functionality. According to the forums, the Android app is out of date
and has been broken for quite a while.
If we want to add this back, I'd write an app that speaks a more native
Wiimote protocol, and we can hook that up to the backend quite easily.
It could even be over our NetPlay protocol!
2014-07-11 13:32:56 -04:00
c11672b2d8
ControllerEmu: Constructors go on top
2014-07-11 13:32:18 -04:00
d468c38335
ControllerEmu: Fix code style
2014-07-11 13:32:18 -04:00
0c9f6c2a2b
ControllerEmu: Remove unnecessary include
2014-07-11 13:32:18 -04:00
6885bac05f
DolphinWX: Use non-deprecated flags for the monospace debugger font
2014-07-11 13:11:11 -04:00
7e79806efc
remove unused globals
...
Also change globals into statics which are only used in one file
2014-07-11 16:10:20 +02:00
81ed17be53
avoid the extern keyword in .cpp files
2014-07-11 16:10:20 +02:00
6d3f249dcc
mark all local variables as static
2014-07-11 16:10:20 +02:00
22e1aa5bb4
mark all local functions as static
2014-07-11 16:07:23 +02:00
326af097d9
Merge pull request #593 from neobrain/master
...
Use uniform capitalization in VideoConfigDiag
2014-07-11 13:26:23 +02:00
75c6575f37
Merge pull request #601 from lioncash/pad-struct
...
Change SPADStatus struct name to GCPadStatus
2014-07-11 06:20:33 +02:00
896d7e5685
Change SPADStatus struct name to GCPadStatus
...
Also get rid of the typedef, since this is unnecessary in C++
2014-07-10 22:02:38 -04:00
ef510a4f73
Merge pull request #594 from lioncash/another-clamp-removal
...
DolphinWX: Remove yet another clamp method
2014-07-11 02:48:27 +02:00
6f9483d161
DolphinWX: Remove unnecessary true within event Skip calls
2014-07-10 20:39:26 -04:00
32d53c7d1d
DolphinWX: Get rid of an unneccessary cast in CodeWindow
...
CFrame inherits from CRenderFrame which inherits from wxFrame which
eventually inherits from wxWindow, so this cast is not required.
2014-07-10 20:29:55 -04:00
6def4ead01
FPSCounter: Flush the logs every second and close them when the renderer is shut down.
2014-07-10 23:11:28 +02:00
1754cbda9d
Move FPSCounter calls to RenderBase.
2014-07-10 23:11:09 +02:00
bc655d1a82
Merge pull request #515 from Armada651/threading
...
Make the emulation stop asynchronous to prevent deadlocks.
2014-07-10 21:02:47 +02:00
15c1250d9d
Merge pull request #596 from delroth/master
...
AVIDump: fix FFV1 encoding
2014-07-09 18:02:40 -07:00
da697df6ee
AVIDump: fix FFV1 encoding
...
ffmpeg 2.0 changed requirements for the FFV1 encoder and made them more strict,
requiring more fields of the input frame to be initialized. Explicitly setting
pixfmt, width and height solve the EINVAL issues with FFV1 encoding.
Original fix from http://ffmpeg.org/pipermail/libav-user/2013-October/005759.html
2014-07-10 02:53:12 +02:00
dbdefd074b
DolphinWX: Remove yet another clamp method
2014-07-09 16:17:13 -04:00
ff0f90efa1
VideoConfigDiag: Use uniform capitalization.
...
Nouns should be written capitalized for consistency.
2014-07-09 21:52:04 +02:00
7b95bc78aa
Merge pull request #592 from Armada651/pref_log
...
FPSCounter: Change format string to match value.
2014-07-09 13:56:52 -04:00
09304cab57
FPSCounter: Change format string to match value.
2014-07-09 19:45:56 +02:00
7b754d6f99
Merge pull request #591 from Armada651/pref_log
...
FPSCounter: Add "Log render time to file" feature.
2014-07-09 18:06:57 +02:00
95b579746f
Replace "Log FPS to file" by the "Log render time to file" feature.
2014-07-09 17:56:11 +02:00
61d44cf73f
FPSCounter: Use a Timer for the FPS update time.
2014-07-09 17:53:41 +02:00
efeadb7fe9
FPSCounter: Add "Log render time to file" feature.
...
Allows for a more accurate performance measurement.
2014-07-09 17:53:31 +02:00
36bc494a0b
Fix code style in WII_IPC_HLE_Device_net.h/.cpp.
2014-07-09 05:26:04 -04:00
29873a7c55
Merge pull request #585 from lioncash/sprintfs
...
DolphinWX: Kill off sprintf calls in CheatsWindow.cpp
2014-07-09 02:36:22 +02:00
beeed520a5
Merge pull request #582 from lioncash/casts
...
DolphinWX: Remove redundant casts in ISOProperties
2014-07-09 02:35:05 +02:00
4df00ae544
Movie: Do not attempt to record input when the emulation has not started yet.
...
Fixes a null pointer exception when the user starts the recording during a state transition.
2014-07-08 22:32:35 +02:00
db7e746cb4
Check whether the core is running instead of checking if it is unitialized.
...
This properly handles the stopping state and more accurately represents the intended check.
2014-07-08 22:30:44 +02:00
54105a8bba
DolphinWX: Kill off sprintf calls in CheatsWindow.cpp
2014-07-08 16:19:34 -04:00
1f25f3c1c9
Merge pull request #584 from lioncash/bind
...
DolphinWX: Bind the drop handling function to the frame with Bind, not Connect
2014-07-08 16:11:08 -04:00
d2ddf40ccb
DolphinWX: Bind the drop handling function to the frame with Bind, not Connect.
2014-07-08 15:41:21 -04:00
ad1b61af2e
FrameTools: Update GUI and disable Play button when in stopping state.
2014-07-08 21:21:25 +02:00
49eade69a3
Core: Return CORE_STOPPING even if hardware is already uninitialized.
2014-07-08 21:21:24 +02:00
b30d5dccbe
Frame: OnClose now handles asynchronous behaviour of DoStop().
2014-07-08 21:21:24 +02:00
3266394dfb
Make the emulation stop asynchronous to prevent deadlocks.
...
This may expose bugs which relied on the Main Thread to be suspended in the stopping state.
2014-07-08 21:21:23 +02:00
2eb12dee55
DolphinWX: Remove a wx 2.9.0 and 2.8.0 version check in GameListCtrl
2014-07-08 14:42:10 -04:00
5fe293af9d
DolphinWX: Remove redundant casts in ISOProperties
...
These are both int, so the cast isn't necessary
2014-07-08 14:31:12 -04:00
3bde3988eb
Merge pull request #576 from lioncash/shader-string
...
D3D: Use std::strings for Compile[x]Shader and CompileAndCreate[x]Shader
2014-07-08 12:10:14 +02:00
a523a6d1bf
D3D: Use std::strings for Compile[x]Shader and CompileAndCreate[x]Shader
...
With strings, we don't need to care about passing in a length, since it internally stores it. So now, we don't even need a length parameter for these functions anymore as well.
This also kills off some sprintf_s calls.
2014-07-07 19:32:03 -04:00
b0b70381f7
Revert "Don't add segfault handler in interpreter mode"
2014-07-07 05:30:06 +02:00
ec1e52de53
VideoCommon: Get rid of an snprintf call in VideoConfig.cpp
2014-07-06 15:33:08 -04:00
cc3dda5b22
Merge pull request #362 from Tilka/ffmpeg_libav_new
...
AVIDump: use new ffmpeg/libav API
2014-07-06 19:33:27 +02:00
4ec8c3714d
Merge pull request #328 from Tilka/enum_cpubackend
...
Don't add segfault handler in interpreter mode
2014-07-06 19:28:10 +02:00
Lioncash