83f307ec7e
D3D12: Only use framebuffer integer descriptor if allocated
...
Verify that DXFramebuffer's integer RTV descriptor's cpu_handle has been
allocated before using it, and if it hasn't use the non-integer RTV
descriptor instead. This fixes a Dolphin crash in Twilight Princess, and
possibly other games (Issue 13312).
As an optimization to save space in the descriptor heap, DXFramebuffer's
integer descriptor is only initialized if the given abstract texture
format has different integer and non-integer RTV formats. This
previously wasn't accounted for by GetIntRTVDescriptorArray, which could
cause DX12::Gfx::BindFramebuffer to call OMSetRenderTargets with an
invalid descriptor which would lead to a crash.
Triggering the bug was fortunately rare because integer formats are only
used when blending is disabled and logic ops are enabled. Furthermore,
the standard integer abstract format is RGBA8 which has different
integer and non-integer RTV formats, causing the integer descriptor to
be initialized and avoiding the bug.
The crash started appearing in a2702c6
2023-08-04 13:17:33 -07:00
f2b8baa82c
Translation resources sync with Transifex
2023-08-01 21:06:37 +02:00
a912a2c3f5
Merge pull request #12047 from AdmiralCurtiss/nand-stats-user
...
Add file size stats to NAND Check.
2023-07-30 21:51:07 +02:00
30c4ac34b0
Merge pull request #12073 from AdmiralCurtiss/wiimote-win32error
...
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-29 18:54:10 +02:00
163c97e242
Merge pull request #12078 from iwubcode/imgui_netplay_fix
...
VideoCommon: update NetplayChatUI's chat message to avoid imgui error
2023-07-29 13:54:21 +02:00
dca7c67105
VideoCommon: update NetplayChatUI's chat message input to use a hidden label. This avoids an error thrown by imgui
2023-07-29 00:27:07 -05:00
a2a6473962
Merge pull request #12065 from iwubcode/imgui_update
...
Externals / VideoCommon: update imgui to 1.89.7 (and implot to 0.15)
2023-07-28 17:22:20 -04:00
ed8911b204
Merge pull request #12019 from Dentomologist/gekkodisassembler_remove_unused_member_and_parameter
...
GekkoDisassembler: Remove unused member and parameters
2023-07-28 20:02:19 +02:00
bed3874497
Merge pull request #12076 from JosJuice/android-when-or
...
Android: Fix SettingsActivity.onActivityResult
2023-07-28 19:13:16 +02:00
b5b8282ca9
Android: Fix SettingsActivity.onActivityResult
...
`or` is the bitwise or operator.
Fixes file pickers in the settings not saving your choice.
2023-07-28 18:45:07 +02:00
fb9274c359
WiimoteReal/IOWin: Use correct error type in the default case.
2023-07-28 08:10:54 +02:00
cd923718c3
CommonFuncs: Add GetWin32ErrorString().
2023-07-28 08:10:01 +02:00
3c6ea825c2
GekkoDisassembler: Remove unused parameter dmode from fdabc function
...
With the removal of m_flags, dmode is no longer used in fdabc.
2023-07-27 10:47:46 -07:00
33dc2a9e6a
GekkoDisassembler: Remove unused parameter dmode from ldst function
...
With the removal of m_flags, dmode is no longer used in ldst.
2023-07-27 10:47:46 -07:00
b3c5021fc4
GekkoDisassembler: Remove unused parameter dmode from rrn function
...
With the removal of m_flags, dmode is no longer used in rrn.
2023-07-27 10:47:46 -07:00
a177c8bcb1
GekkoDisassembler: Remove unused parameter dmode from dab function
...
With the removal of m_flags, dmode is no longer used in dab.
2023-07-27 10:47:45 -07:00
a732647e5a
GekkoDisassembler: Remove unused parameter dmode from nooper function
...
With the removal of m_flags, dmode is no longer used in nooper.
2023-07-27 10:47:45 -07:00
317bb629b9
GekkoDisassembler: Remove unread variable m_flags
...
Writes to m_flags are pointless as it's never read.
2023-07-27 10:47:41 -07:00
c2b495586d
Externals: add misc/cpp/imgui_stdlib to imgui build in order to use std::string in InputText
2023-07-27 12:08:07 -05:00
350e51951b
VideoCommon: update imgui to 1.89.7 (and implot to 0.15); fix issues with upgrade; keep the demo code in case someone wants to reference it but don't compile it by enabling 'IMGUI_DISABLE_DEMO_WINDOWS' in config
2023-07-27 11:47:34 -05:00
17fa9dfc4e
Merge pull request #12046 from AdmiralCurtiss/nand-stats-unit-test
...
UnitTests: Enable cluster check in FileSystemTest.GetDirectoryStats.
2023-07-27 18:44:34 +02:00
8f1b2280ae
Merge pull request #12068 from SuperSamus/manual-texture-game
...
Qt/GameConfigWidget: Add Manual Texture Sampling
2023-07-27 16:54:59 +02:00
44d25602a0
Translation resources sync with Transifex
2023-07-26 15:32:36 +02:00
1e5e319783
Qt/GameConfigWidget: Add Manual Texture Sampling
2023-07-25 00:45:13 +02:00
41f81aca69
Qt/GameConfigWidget: Rename `m_enable_fast_disc` to `m_emulate_disc_speed`
2023-07-25 00:45:10 +02:00
0892998af1
Qt/GameConfigWidget: Add `reverse` argument for `{Save,Load}CheckBox`
...
In order to not hard code `if (key == "FastDiscSpeed")`
2023-07-24 20:48:32 +02:00
0a2afa48b7
Merge pull request #12045 from tupfold/master
...
[Minor Bugfix] Extremely rare HostID collision bugfix
2023-07-24 03:55:45 +02:00
553824e5aa
Merge pull request #11853 from noahpistilli/update-curl
...
Externals: Update libcurl
2023-07-24 02:27:36 +02:00
2b80605e7e
Merge pull request #12067 from Pokechu22/debugging-ui-text-show-enable
...
Rename "Show Debugging UI" to "Enable Debugging UI"
2023-07-24 01:15:04 +02:00
c468ca2107
Merge pull request #12057 from iwubcode/config_core_timing_refresh_only
...
Core: save core timing parameters into variables updated during refresh
2023-07-24 01:14:18 +02:00
7e38ff496c
Rename "Show Debugging UI" to "Enable Debugging UI"
...
This will hopefully reduce confusion on e.g. https://bugs.dolphin-emu.org/issues/13306 .
2023-07-23 15:17:04 -07:00
e54b7ac356
Core: save core timing parameters into variables updated during refresh
2023-07-23 14:03:21 -05:00
eb79bf37e2
Merge pull request #12052 from mitaclaw/profiling-is-something
...
Announce RSCRATCH clobbering in Jit64::Cleanup() when profiling is enabled
2023-07-23 20:12:43 +02:00
a76cc146e1
Merge pull request #12055 from iwubcode/skip_dump_async
...
VideoCommon: skip the texture dump if a custom texture is available, regardless if it is loaded or not
2023-07-23 19:53:25 +02:00
c1a4b3f350
Merge pull request #12051 from mandar1jn/J-documentation-improvements
...
Skylanders: Update J command documentation
2023-07-23 19:23:29 +02:00
dd3caa48b2
Merge pull request #12063 from SuperSamus/audio-name
...
cubeb: Change name to "Dolphin Emulator"
2023-07-23 19:15:24 +02:00
e3ef3cb752
Merge pull request #12062 from iwubcode/custom_textures_debug
...
VideoCommon: add startup message to know if custom textures are installed
2023-07-23 03:45:22 +02:00
b5be399fd4
cubeb: Change name to "Dolphin Emulator"
...
To avoid conflicts with KDE's file manager.
2023-07-22 23:12:34 +02:00
3d9bc85912
Merge pull request #12058 from noahpistilli/android-wiilink
...
Add Enable WiiLink checkbox to Android GUI
2023-07-22 08:14:18 +02:00
6f55e44365
Update libcurl to 8.1.2
2023-07-21 21:59:55 -04:00
fb2b3753b5
Merge pull request #12015 from nyanpasu64/gc-adapter-sleep-detach
...
Fix GC Adapter breaking and burning a full CPU core after sleep-wake on Linux
2023-07-22 03:38:45 +02:00
fd74244339
VideoCommon: add custom texture message to provide a dirty means of debugging whether custom textures are installed correctly
2023-07-21 20:13:27 -05:00
2569d10b3d
Add Enable WiiLink checkbox to Android GUI
2023-07-21 17:46:37 -04:00
eba5291ec7
Skylanders: Update J command documentation
...
I initially thought the 0x01 side was both sides (equavalent to just C. However, this turned out to be something I forgot I implemented in my personal interface. 0x01 does not seem to change any colors.
Recently discovered how exactly the last 2 bytes of the J command for timing data
2023-07-20 23:58:33 +02:00
f7e78742cf
VideoCommon: skip the texture dump if the texture is using a custom texture, regardless of whether or not it is loaded yet
2023-07-19 23:44:41 -05:00
2764978beb
Merge pull request #12054 from noahpistilli/forecast-patch
...
Add Forecast Channel buffer patch
2023-07-19 19:28:54 -04:00
84e8516341
Add Forecast Channel buffer patch
2023-07-19 18:30:40 -04:00
d1ce2e51ff
Merge pull request #12050 from iwubcode/custom_asset_compiler_warning_fixes
...
VideoCommon: fix some compiler warnings for CustomAsset
2023-07-20 00:26:54 +02:00
70b3db93e0
Announce RSCRATCH clobbering in Jit64 when profiling is enabled
2023-07-19 14:15:42 -07:00
79f202ea5c
VideoCommon: fix some compiler warnings for CustomAsset. FreeBSD compiler complained about a defaulted move constructor due to the mutex being implicitly deleted. Additionally, the const owning library deleted the copy constructor.
2023-07-16 19:45:55 -05:00
Dentomologist