ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
39,648 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

33778 Commits

Author SHA1 Message Date
Admiral H. Curtiss 9c0226b7e3
JitBase: Avoid System::GetInstance() and ppcState. 2023-03-25 02:37:00 +01:00
Admiral H. Curtiss b568cf5268
Interpreter: Remove remaining System::GetInstance() and global ppcState. 2023-03-24 21:58:41 +01:00
degasus 196c684ac1 Vulkan: Enable subgroupShuffle. 
It is used as workaround for the missing subgroupBroadcastDynamicId flag on SPIR-V < 1.5.
 2023-03-24 21:53:23 +01:00
JosJuice 7de01597c6
Merge pull request #11686 from t895/index-fix 
Android: Ignore input from invalid pointer identifier
 2023-03-24 17:57:19 +01:00
Admiral H. Curtiss 2edb69f89f
Merge pull request #11682 from lioncash/queue 
Common: Move FixedSizeQueue into Common namespace
 2023-03-24 12:55:10 +01:00
Robin Kertels 43d346aba4
Android: Open DocumentProvider directly when tapping the File Manager button 2023-03-24 00:33:42 +01:00
Charles Lombardo df806125b9 Android: Ignore input from invalid pointer identifier 2023-03-22 21:44:37 -04:00
Pierre Bourdon eb7d7836fd
Merge pull request #11685 from shuffle2/updater-test 
test-updater.py: include space and unicode in paths to test
 2023-03-22 23:40:24 +01:00
Shawn Hoffman fdc1626308 test-updater.py: include space and unicode in paths to test 2023-03-22 11:08:58 -07:00
Shawn Hoffman 3961afdbb9 windows: temporarily hardcode VCToolsVersion to 14.34.31931.0 
this should be reverted after next beta is built
see https://bugs.dolphin-emu.org/issues/13206
 2023-03-22 10:42:32 -07:00
Lioncash 0f326c6067 Common: Move FixedSizeQueue into Common namespace 
Gets this out of the global namespace.
 2023-03-22 01:23:15 -04:00
Charles Lombardo ce66d5875f Android: Fix long press action for leanback game cards 2023-03-21 19:12:28 -04:00
Charles Lombardo cf0706c239 Android: Remove deprecated use of launchWhenStarted/Resumed 2023-03-21 18:53:48 -04:00
Lioncash 0888c93d48 Common: Move FPU-related helpers into Common namespace 
Makes these utilities' namespace consistent with the majority of the
Common library.
 2023-03-21 10:58:13 -04:00
Pokechu22 df451b3d9e msvc: Nest implot under Externals 2023-03-20 22:27:39 -07:00
Admiral H. Curtiss 8f16fd60dd
JitArm64: Use 64-bit register for pointer when falling back to interpreter. 2023-03-21 02:46:29 +01:00
Robin Kertels 93fce0e4b6
VideoCommon:VertexManagerBase: Only calculate remaining indices once 
Before, both of those were calculated 3 times due to the ASSERTs.
 2023-03-20 20:59:50 +01:00
Robin Kertels 408b09da31
VideoCommon:VertexShaderManager: Inline SetVertexFormat & UpdateValue/Offset 2023-03-20 20:59:38 +01:00
Mai 9807961ff2
Merge pull request #11671 from AdmiralCurtiss/deglobal-interpreter 
Deglobalize Interpreter
 2023-03-20 15:55:14 -04:00
Robin Kertels c1be9628fc
VideoBackends:Vulkan: Use WorkQueueThread 2023-03-20 16:40:32 +01:00
Robin Kertels 9d422d14d5
WorkQueueThread: Fix WaitForCompletion 2023-03-20 16:31:40 +01:00
Robin Kertels 9186050daa
VideoBackends:Vulkan: Clean up submission thread BlockingLoop usage 2023-03-20 16:23:35 +01:00
Robin Kertels 7703fef3a4
VideoCommon:VertexLoaderManager: Only update vertex format in shader manager if necessary. 2023-03-20 00:41:16 +01:00
JosJuice 002a96adb0
Merge pull request #11662 from t895/kotlin-settings 
Android: Convert Settings to Kotlin
 2023-03-19 17:15:22 +01:00
Admiral H. Curtiss 454d2fd9ab
Interpreter: Avoid ppcState global (Interpreter_SystemRegisters.cpp). 2023-03-19 03:11:22 +01:00
Admiral H. Curtiss c582aad0c7
Interpreter: Avoid ppcState global (Interpreter_Paired.cpp). 2023-03-19 03:11:18 +01:00
Admiral H. Curtiss 514a7af473
Interpreter: Avoid ppcState global (Interpreter_LoadStorePaired.cpp). 2023-03-19 03:11:13 +01:00
Admiral H. Curtiss 9af8410e4c
Interpreter: Avoid ppcState global (Interpreter_LoadStore.cpp). 2023-03-19 03:11:09 +01:00
Admiral H. Curtiss 8b13349886
Interpreter: Avoid ppcState global (Interpreter_Integer.cpp). 2023-03-19 03:11:05 +01:00
Admiral H. Curtiss 2ce86a890a
Interpreter: Avoid ppcState global (Interpreter_FloatingPoint.cpp). 2023-03-19 03:11:01 +01:00
Admiral H. Curtiss d4ca591e02
Interpreter: Avoid ppcState global (Interpreter_Branch.cpp). 2023-03-19 03:10:56 +01:00
Admiral H. Curtiss 68ab623764
Interpreter: Avoid ppcState global (Interpreter.cpp). 2023-03-19 03:10:42 +01:00
Admiral H. Curtiss 3d67c11b91
Interpreter: Move global state into class, move instance to System. 2023-03-19 03:05:20 +01:00
Admiral H. Curtiss 919182eda2
Interpreter: Pass Interpreter to CPU instruction functions. 2023-03-19 03:05:11 +01:00
Admiral H. Curtiss a4d3342419
Merge pull request #11665 from JosJuice/fix-movie-wii-save 
Core: Fix starting movie recording with existing Wii save
 2023-03-19 01:46:21 +01:00
Admiral H. Curtiss fb7a371ac0
Merge pull request #11666 from AdmiralCurtiss/updater-spaces 
WinUpdater: Quote path for args when relaunching Dolphin.
 2023-03-18 18:32:35 +01:00
Pierre Bourdon 04915d6749
Merge pull request #11670 from JosJuice/android-open-mode 
Android: Translate C++ "w" to ParcelFileDescriptor "wt"
 2023-03-18 18:20:17 +01:00
JosJuice 8e363c0995 Android: Translate C++ "w" to ParcelFileDescriptor "wt" 
Previously we were translating "w" to "w", which unlike in C++ doesn't
truncate. See https://issuetracker.google.com/issues/180526528, and for
reference, https://en.cppreference.com/w/cpp/io/c/fopen and
https://en.cppreference.com/w/cpp/io/basic_filebuf/open.

This issue was brought to my attention by the recently published issue
CVE-2023-21036 in the screenshot editing tool on Pixel phones. I'm not
aware of any code in Dolphin that actually uses "w" with an existing
file on Android (when we ask the user for a location to save to using
SAF, a new file is always created), but still, best to fix this.
 2023-03-18 13:44:01 +01:00
Admiral H. Curtiss 33d0ec97e9
WinUpdater: Quote path for args when relaunching Dolphin. 2023-03-17 12:48:39 +01:00
TellowKrinkle d037c60caf CMake: Use proper dependency tracking command for storyboard compiling 2023-03-17 01:28:33 -05:00
TellowKrinkle 66936f2087 CMake: Use generator expressions to get codesigning targets 
Also works around a bug where CMake's ninja generator doesn't properly handle ||'s on POST_BUILD commands, making the || apply to the whole build like `<link> && custom0 || custom1`
 2023-03-17 01:28:16 -05:00
Pokechu22 4dd658f4da Remove PPCTables::UsesFPU 
We don't have getters for other flags, so it's not useful to have that.
 2023-03-16 18:39:41 -07:00
Pokechu22 164ea57790 Split PPCTables from Interpreter_Tables 
This also allows use of constexpr in both places. Some additional work was needed in PPCTables due to mutable data associated with each opcode.
 2023-03-16 18:36:25 -07:00
Pokechu22 cd627d1232 PPCTables: Fix OPLOG system 
Since OPLOG is defined in PPCTables.cpp only, it isn't visible elsewhere. This broke in 3ede866c37.
 2023-03-16 18:36:25 -07:00
Pokechu22 34f39ee22e JitArm64_Tables: Use C++20 features 2023-03-16 18:36:25 -07:00
Pokechu22 ec7432ef36 Jit64_Tables: Use C++20 features 2023-03-16 18:36:25 -07:00
Pokechu22 14a93d24e1 Common: Add constexpr Fill function 2023-03-16 18:36:25 -07:00
JosJuice d179acef38 Core: Refactor InitializeDeterministicWiiSaves 
Some simple deduplication.
 2023-03-16 22:49:46 +01:00
JosJuice 9e7409e71e Core: Fix starting movie recording with existing Wii save 
A change made in 0d095b4 didn't take into account that the movie system
doesn't set sync_titles.
 2023-03-16 22:45:40 +01:00
JosJuice 6b545eaada
Merge pull request #11659 from JosJuice/android-after-dirinit-runner-cleanup 
Android: Clean up AfterDirectoryInitializationRunner
 2023-03-16 17:12:58 +01:00
Pierre Bourdon d623871f3e
Merge pull request #11664 from OatmealDome/macos-updater-test-mode 
MacUI: Add stub implementation of UI::IsTestMode()
 2023-03-16 15:24:49 +01:00
OatmealDome bbe2bd5fec MacUI: Add stub implementation of UI::IsTestMode() 2023-03-16 02:44:36 -04:00
Charles Lombardo a32d66e5ec Android: Upgrade Kotlin to 1.8.10 2023-03-15 23:58:11 -04:00
Charles Lombardo f06c0897ab Android: Update gradle to 8.0 2023-03-15 23:58:11 -04:00
Charles Lombardo de34c962d7 Android: Upgrade AGP to 7.4.2 2023-03-15 23:58:11 -04:00
Charles Lombardo 7e84285047 Android: Upgrade dependencies 
Desugar JDK 2.0.0 -> 2.0.2
Androidx Appcompat 1.6.0 -> 1.6.1
Androidx Exif Interface 1.3.5 -> 1.3.6
Material Components 1.7.0 -> 1.8.0
Androidx recyclerview 1.2.1 -> 1.3.0
Androidx viewmodel ktx 2.5.1 -> 2.6.0
Androidx viewmodel 2.5.1 -> 2.6.0
 2023-03-15 23:58:11 -04:00
Charles Lombardo 805f921b55 Android: Remove unused benchmark flags 2023-03-15 23:57:47 -04:00
Charles Lombardo 2782318b8c Android: Update ndk version to 25.2.9519653 2023-03-15 23:57:47 -04:00
Charles Lombardo 9020b6aeb9 Android: Convert SettingsAdapter to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 673c8d9cb2 Android: Convert SettingsActivity to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 4cbbe15e77 Android: Convert SettingsFragment to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo cea882181d Android: Convert SettingsActivityPresenter to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 3b32ff6980 Android: Convert SettingsFile to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 92f39a98d6 Android: Convert SwitchSettingViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 49e480ee53 Android: Convert SubmenuViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 760417b08f Android: Convert SliderViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 9b79f5fa5d Android: Convert SingleChoiceViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 917a0c2287 Android: Convert SettingViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 7b7ee13162 Android: Convert RunRunnableViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 6a08b12c9b Android: Convert InputStringSettingViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo bc6d10e29a Android: Convert HeaderViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 789493b722 Android: Convert HeaderHyperLinkViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 220cdafbaa Android: Convert FilePickerViewHolder to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo f0304d80ef Android: Convert SettingsViewModel to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 508e56e2bf Android: Convert SettingsFragmentView to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo 656d91cd18 Android: Convert SettingsFragmentPresenter to Kotlin 2023-03-15 17:35:48 -04:00
Charles Lombardo c78cde2e18 Android: Convert SettingsActivityView to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo dc77ee140d Android: Convert MenuTag to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 2af8efdd72 Android: Convert SwitchSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo ab11b44938 Android: Convert SubmenuSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 065c80fb4d Android: Convert SliderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 3c6bb9e0c9 Android: Convert SingleChoiceSettingDynamicDescriptions to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo d51f504629 Android: Convert SingleChoiceSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 1fc9f03b27 Android: Convert RunRunnable to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 62679bacc1 Android: Convert PercentSliderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 72be338d56 Android: Convert LogSwitchSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 56c33890b9 Android: Convert InvertedSwitchSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 2369977e14 Android: Convert IntSliderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 826e849a7b Android: Convert InputStringSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo fc97c4d35a Android: Convert HyperLinkHeaderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo f95fd7788e Android: Convert HeaderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 1e2e9e004b Android: Convert FloatSliderSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo f7ad065408 Android: Convert FilePicker to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 1553477c09 Android: Convert StringSetting to Kotlin 2023-03-15 17:35:34 -04:00
Charles Lombardo 2c560e05a8 Android: Convert Settings to Kotlin 2023-03-15 17:35:21 -04:00
Charles Lombardo dee85cead8 Android: Convert PostProcessing to Kotlin 2023-03-15 17:35:21 -04:00
Charles Lombardo 42f4fb815f Android: Convert NativeConfig to Kotlin 2023-03-15 17:35:21 -04:00
Charles Lombardo 7c59640f8e Android: Convert IntSetting to Kotlin 2023-03-15 17:35:21 -04:00
Charles Lombardo 46e68171b9 Android: Convert FloatSetting to Kotlin 2023-03-15 17:34:49 -04:00
Charles Lombardo 3ac72855e3 Android: Convert BooleanSetting to Kotlin 2023-03-15 17:34:21 -04:00
Charles Lombardo 84c23c14db Android: Convert AdHocStringSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo a8f3d4291a Android: Convert AdHocBooleanSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo f1028b4652 Android: Convert AbstractStringSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 32f9e48257 Android: Convert AbstractIntSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo baeeaa2a43 Android: Convert AbstractFloatSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 5bc2b46983 Android: Convert AbstractBooleanSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 21e0b5b9d9 Android: Convert AbstractSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 43fa5cf5e4 Android: Convert SettingsItem to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 6dc6720250 Android: Convert StringSingleChoiceSetting to Kotlin 2023-03-15 15:49:37 -04:00
Charles Lombardo 98ab893be7 Android: Create extension functions for serializables 
Getting serializables without explicitly stating the type is deprecated in Android 13. However we still need a way to get a serializable in versions below that. Now with these we can avoid repeating the same if block.
 2023-03-15 14:26:37 -04:00
Pierre Bourdon 91fca0783e
Merge pull request #11647 from AdmiralCurtiss/perfquery-inconsistency 
Fix PerfQuery inconsistencies across backends.
 2023-03-15 15:20:11 +01:00
JosJuice fe8be906f3 Android: Use LifecycleOwner instead of subtype 2023-03-14 23:03:13 +01:00
JosJuice 846f5f6671 Android: Clean up outdated comment in AfterDirectoryInitializationRunner 2023-03-14 23:03:13 +01:00
Mai 4281606838
Merge pull request #11641 from JosJuice/android-remove-old-config 
Android: Remove support for the old config system
 2023-03-14 15:48:04 -04:00
Pierre Bourdon e83b6e19ab
Merge pull request #11655 from AdmiralCurtiss/dtk-heap 
HW/DVDInterface: Avoid heap allocation in DTK callback.
 2023-03-14 13:45:41 +01:00
Admiral H. Curtiss 4c21cdd0e6
HW/DVDInterface: Do DTK math in blocks instead of in samples. 2023-03-14 13:19:44 +01:00
Pierre Bourdon aceafc9d26
Merge pull request #11652 from t895/header-padding 
Android: Make header padding appear even
 2023-03-14 13:03:19 +01:00
Admiral H. Curtiss 66b6a60afe
HW/DVDInterface: Avoid heap allocation in DTK callback. 2023-03-14 10:58:03 +01:00
Pierre Bourdon 3783bedc25
Merge pull request #11635 from Dentomologist/wiimote_fix_disconnection_deadlock 
ControllerInterface: Fix deadlock when Wii Remote disconnects
 2023-03-14 02:41:36 +01:00
Admiral H. Curtiss aac9647ba2
Divide by MSAA for PerfQuery in all backends. 2023-03-14 02:13:25 +01:00
Admiral H. Curtiss ddd2b598da
Return quarter value for PerfQuery in all backends. 2023-03-14 02:08:20 +01:00
Pierre Bourdon 970ddf0ea0
Merge pull request #11651 from JosJuice/android-profile-off-by-one 
Android: Fix per-game profile setting off-by-one
 2023-03-14 02:02:00 +01:00
Admiral H. Curtiss 43a5d506c8
Merge pull request #11644 from deReeperJosh/trapteamaudio 
Skylander Portal: Play Trap Team Audio
 2023-03-14 01:29:20 +01:00
Admiral H. Curtiss 26605c0184
Merge pull request #11649 from Pokechu22/tas-controller-input-update-widgets 
DolphinQt: Fix TAS widgets not updating with enable controller input
 2023-03-14 01:21:17 +01:00
Pierre Bourdon 5c962ea71f
Merge pull request #11650 from AdmiralCurtiss/more-system 
More passing of System instead of using the singleton.
 2023-03-13 23:36:17 +01:00
Pierre Bourdon 936c05e600
Merge pull request #11599 from shuffle2/vs17.5 
vs: update to 17.5
 2023-03-13 20:43:48 +01:00
Charles Lombardo 4f610bb354 Android: Make header padding appear even 2023-03-13 15:27:09 -04:00
JosJuice 5818685911 Android: Fix per-game profile setting off-by-one 2023-03-13 18:30:55 +01:00
Admiral H. Curtiss 3006c23c85
Core/CPUThreadGuard: Fetch System from Guard. 2023-03-13 18:13:20 +01:00
Admiral H. Curtiss 31d33d0efd
HW/ProcessorInterface: Store reference to System in class. 2023-03-13 18:13:20 +01:00
Admiral H. Curtiss ba852a7812
HW/Memmap: Store reference to System in MemoryManager. 2023-03-13 18:13:20 +01:00
Admiral H. Curtiss 026b6a3e0f
HW: Pass System to functions. 2023-03-13 18:13:20 +01:00
Mai 137b9d1da1
Merge pull request #11646 from AdmiralCurtiss/si-class 
HW/SerialInterface: Refactor to class.
 2023-03-13 13:09:51 -04:00
Pierre Bourdon a6b2655631
Merge pull request #11636 from shuffle2/updater-test 
Add test for Updater
 2023-03-13 15:47:37 +01:00
Pokechu22 3f6b931150 DolphinQt: Fix TAS widgets not updating with enable controller input 
This regressed in 0300b44d23. Specifically, the sliders and the stick/IR widgets did not update, but the spin boxes did update.
 2023-03-12 17:58:48 -07:00
Joshua de Reeper f27e8216a5 Skylander Portal: Play Trap Team Audio 
Asserts and length handling
 2023-03-13 13:01:48 +13:00
Admiral H. Curtiss bf2f901a99
HW/SerialInterface: Refactor to class. 2023-03-12 16:08:56 +01:00
Robin Kertels 784ce78eaf
Android: Use $applicationId for DocmentProvider authority 
Fixes side by side installation of debug, benchmark and release builds.
 2023-03-12 15:28:21 +01:00
Admiral H. Curtiss d371b17f37
HW/SerialInterface: Pass System to ISIDevice. 2023-03-12 14:19:38 +01:00
Mai ab05dfc263
Merge pull request #11642 from shuffle2/winupdater-fail 
winupdater: improve wording of UI::Error
 2023-03-12 04:11:16 -04:00
Mai ee28d332b0
Merge pull request #11640 from AdmiralCurtiss/vi-class 
HW/VideoInterface: Refactor to class.
 2023-03-11 18:00:24 -05:00
Shawn Hoffman ab3da5e4ce winupdater: improve wording of UI::Error 2023-03-11 13:25:38 -08:00
Shawn Hoffman 06cb4ffa64 winupdater: fix CR getting into parsed VCToolsUpdateURL 2023-03-11 12:58:33 -08:00
Shawn Hoffman 0a8725e4a9 updater: add test for update flow 
currently windows-only
 2023-03-11 12:58:33 -08:00
Shawn Hoffman de0bc06856 updater: flush log after each write 2023-03-11 12:58:33 -08:00
JosJuice 804b94ee9e
Merge pull request #11524 from K0bin/document-provider 
Android: Implement DocumentProvider
 2023-03-11 19:24:19 +01:00
JosJuice 08334015f9 Android: Remove SettingsActivityView parameters from Settings 
No longer used for anything.
 2023-03-11 18:49:43 +01:00
JosJuice 99600ef781 Android: Rework the "global" settings functions 
getXGlobal() is now identical to getX(), and setXGlobal(int, X) is now
identical to setX(int, X) in the cases where setX(int, X) exists.
We can remove/rename them.
 2023-03-11 18:49:43 +01:00
JosJuice 58fc347f8d Android: Don't require Settings object for reading a setting 
Made unnecessary by the previous commit.
 2023-03-11 18:49:43 +01:00
JosJuice 68fd133057 Android: Remove support for the old config system 
All settings that we care about from an Android perspective are now
supported by the new config system, so we can remove all the Android code
for the old config system. This should have no impact on users.
 2023-03-11 17:51:59 +01:00