b6d476241a
CodeViewWidget: Fix memory leak
...
Per https://doc.qt.io/qt-6/qabstractitemview.html#setItemDelegateForColumn setItemDelegateForColumn does not take ownership of the parameter, so it was not being deleted. Specifying a parent to QObject (via QStyledItemDelegate's constructor) will allow it to automatically be deleted, per https://doc.qt.io/qt-6/objecttrees.html . The other instance of a QItemDelegate in IOWindow.cpp already used this.
2023-02-17 18:29:32 -08:00
1c5e223532
MemoryViewWidget: Fix memory leaks
...
bp_item/row_item/item were never deleted, and the normal Qt ownership system wasn't applying to them because they were being cloned.
2023-02-17 18:17:01 -08:00
8802f96b7e
Fix uninitialized variable warnings (C26495)
2023-02-15 19:18:39 -08:00
5b6784432c
Follow-up fixes for "Properly lock CPU before accessing emulated memory"
2023-02-14 18:44:16 +01:00
6f0266e8de
DolphinQt: Only update call stack if paused
...
This avoids a pseudo infinite loop where CodeWidget::UpdateCallstack
would lock the CPU in order to read the call stack, causing the CPU to
call Host_UpdateDisasmDialog because it's transitioning from running to
pausing, causing Host::UpdateDisasmDialog to be emitted, causing
CodeWidget::Update to be called, once again causing
CodeWidget::UpdateCallstack to be called, repeating the cycle.
Dolphin didn't go completely unresponsive during this, because
Host_UpdateDisasmDialog schedules the emitting of Host::UpdateDisasmDialog
to happen on another thread without blocking, but it was stopping certain
operations like exiting emulation from working.
2023-02-12 12:50:28 +01:00
7cecb28bdf
DolphinQt: Properly lock CPU before accessing emulated memory
...
This fixes a problem I was having where using frame advance with the
debugger open would frequently cause panic alerts about invalid addresses
due to the CPU thread changing MSR.DR while the host thread was trying
to access memory.
To aid in tracking down all the places where we weren't properly locking
the CPU, I've created a new type (in Core.h) that you have to pass as a
reference or pointer to functions that require running as the CPU thread.
2023-02-12 11:27:50 +01:00
3bd655463d
MemoryViewWidget: Fix warning: enumeration value ‘Null’ not handled in switch [-Wswitch]
2023-02-09 16:23:02 -08:00
5c8d8383e2
CodeWidget: Fix shadowing warning
2023-02-09 16:23:02 -08:00
8adabb86cf
Debugger: Avoid ppcState global.
2023-01-27 15:22:45 +01:00
61ba516570
PowerPC: Move a few functions to PowerPCState.
2023-01-27 15:22:44 +01:00
c13ca271d8
PowerPC: Parametrize CTR macro.
2023-01-27 15:22:43 +01:00
0f301829d2
PowerPC: Remove rPS macro.
2023-01-27 15:22:42 +01:00
8fccefa3aa
PowerPC: Remove GPR macro.
2023-01-27 15:22:42 +01:00
be8d0b76ca
PowerPC: Remove PC macro.
2023-01-27 15:22:41 +01:00
e5b91f00b0
Common: Replace StringBeginsWith/StringEndsWith with std equivalents
...
Obsoletes these functions in favor of the standard member functions
added in C++20.
2023-01-24 14:58:20 -05:00
d0da689eeb
DolphinQt: Add i18n comments for strings containing the word "watches"
...
These new strings could use the same clarification as we have for
the existing string "&Delete Watch".
2023-01-23 20:49:22 +01:00
653e0ccf28
Merge pull request #11365 from iwubcode/cheat_manager_freeze_value
...
DolphinQt: add ability to lock / freeze values in the watches window
2023-01-09 18:41:28 +01:00
74e1577a2c
HW/ProcessorInterface: Refactor to class, move to Core::System.
2023-01-04 03:00:10 +01:00
3611045a6c
DolphinQt: Add more i18n comments
2022-12-24 08:32:49 +01:00
190cf5af30
DolphinQt: add multiselection to WatchWidget
2022-12-23 12:31:33 -06:00
7d7fcdddd3
DolphinQt: add lock state to WatchWidget
2022-12-23 12:31:33 -06:00
41c9d706cb
DolphinQt: cleanup WatchWidget
2022-12-23 11:59:23 -06:00
b56411b84b
Fix MemoryViewWidget background colour
2022-12-17 10:37:37 +01:00
a17fbe7c65
Expand conditional breakpoints to memory breakpoints
2022-12-04 11:25:33 -07:00
2b93d5e0d7
Merge pull request #11273 from TryTwo/PR_Conditional_BP_Callstack
...
Debugger: add callstack to conditional breakpoints
2022-12-04 14:16:12 +01:00
2bd47d1435
Merge pull request #11232 from TryTwo/PR_MemoryView_highlighting
...
Debugger MemoryViewWidget: always highlight target address
2022-12-04 14:07:19 +01:00
76bf1b5f7d
Add callstack to conditional breakpoints. Checks entire stack for value.
...
Use: callstack(0x80000000).
!callstack(value) works as a 'does not contain'.
Add strings to expr.h conditionals.
Use quotations: callstack("anim") to check symbols/name.
2022-12-03 20:52:17 -07:00
3d6bfcd236
JITWidget: Convert to fmt
2022-12-01 17:44:41 -08:00
6a6d24550e
Clean up DisassembleBlock and JitInterface::GetHostCode
2022-12-01 17:43:35 -08:00
5842b90bee
Show JIT blocks widget when selecting 'PPC vs Host' in code widget
...
Before, I just assumed this feature was broken since I didn't know what widget it used. Now, it behaves like show memory and show code elsewhere.
2022-12-01 17:43:35 -08:00
0ccfa31ec8
Fix code widget not becoming visible when selecting 'view code' or similar
...
This affected the memory and registers widgets (and possibly others). I'm pretty sure it regressed in 5f629abd8b
2022-12-01 17:43:35 -08:00
4f4bd57fe9
Fix crash when stopping emulation while the JIT widget is in use
...
The call to analyzer.Analyze breaks when it attempts to read an instruction, as it eventually tries to read memory when Memory::m_pRAM is nullptr. Trying to read when execution is not paused in general seems like a bad idea (especially as analyzer.Analyze uses PowerPC::TryReadInstruction which can update icache - this is probably still a problem).
2022-12-01 17:43:34 -08:00
700eca1baa
MemoryViewWidget set target address as selected. Fix focus call. Always color selected item blue.
2022-11-30 16:38:56 -07:00
dd2282324b
Debugger BreakpointWidget: Allow editing breakpoints
2022-11-26 03:38:25 +01:00
2a81fa6c26
Merge pull request #11015 from TryTwo/Conditional_Breakpoints
...
Conditional breakpoints
2022-11-13 01:06:52 +01:00
cf533df814
MemoryWidget: Split Actions into Import and Export.
2022-11-05 23:05:15 +01:00
89bc1649e3
Merge pull request #11111 from TryTwo/PR_MemoryView_TableUpdates
...
MemoryViewWidget refactor memory table
2022-11-05 22:59:44 +01:00
431301add3
Merge pull request #10771 from TryTwo/PR_AutoStep
...
Debugger: Implement base code tracing logic. and feature to auto-step through code.
2022-11-04 23:32:54 +01:00
950e1f94dc
Merge pull request #11185 from TryTwo/PR_MemoryWidget_Address_Input_History
...
MemoryWidget: Make search address a combobox that holds address history.
2022-10-30 04:21:14 -04:00
053320b7cf
MemoryWidget: Make search address a combobox that holds address history.
...
Always update the combobox when a new target address is sent.
2022-10-29 22:41:30 -07:00
e2f4400f49
Make SetPatch responsible for overwriting old patches
2022-10-26 22:46:49 -05:00
063c2739b3
Merge pull request #11135 from AdmiralCurtiss/ppcanalyst-unused-stats
...
PPCAnalyst: Remove unused variables and methods in BlockStats and BlockRegStats.
2022-10-23 21:22:54 +02:00
e2df81b0c1
Add logging and error reporting to Breakpoint Conditionals.
2022-10-23 08:22:35 -07:00
6f4f4e057e
MemoryViewWidget refactor memory table.
...
Don't re-create the table on every update.
2022-10-22 17:52:39 -07:00
f9fe25291d
Remove most uses of StringFromFormat in favor of fmt
2022-10-12 16:50:47 -07:00
1ed6028af4
NewBreakpointDialog: Add a help message for conditionals.
2022-10-08 13:23:24 -07:00
1abffc0b05
PPCAnalyst: Remove unused variables in BlockStats.
2022-10-08 03:30:56 +02:00
fb79c04cf1
MemoryView auto updateDebugger. Implement base codetrace logic. Add register breakpoints. Add CodeViewWidget autostepping to track a value.Debugger
2022-10-06 22:17:22 -07:00
7842f9a715
Debugger: Initial implementation of conditional breakpoints
...
Expression class to store compiled expressions and associated variable list.
Co-authored-by: TryTwo <taolas@gmail.com>
2022-10-06 21:34:44 -07:00
87f84d4f54
Debugger/CodeWidget: Update callstack/callers/calls on symbol changes
...
Before, only the symbols box would update. However, if you edit the symbol of a function in the call stack (which seems like something that would happen reasonably often while debugging), the call stack would be out of date until it was updated by clicking on it. Callers and calls were more of an edge case; for them to be out of date, you would need to right-click on an instruction in a function other than the one containing the currently-selected instruction (though it would also affect recursive functions).
2022-09-28 21:01:37 -07:00
50db8f35b8
Debugger MemoryWidget: Create mini-menu at top of sidebar. Move dump buttons and "set value from file" to the menu.
2022-09-08 16:36:36 -07:00
48fdbcde23
Merge pull request #10809 from TryTwo/PR_CodeWidget_Filters
...
Debugger CodeWidget: Add filter boxes to callstack, function calls, a…
2022-08-22 15:47:20 -04:00
76fe7b6497
NetworkCaptureLogger: Add GameCube BBA support
2022-07-12 13:35:49 +04:00
d0b33c7adf
Debugger CodeWidget: Add filter boxes to callstack, function calls, and function callers. Move symbols search box to align with changes.
2022-07-05 12:57:41 -07:00
2f228310af
Merge pull request #10794 from TryTwo/PR_MemoryWidget_Cell_Edit
...
Debugger MemoryViewWidget: Allow direct editing of memory cells.
2022-07-02 13:05:39 +02:00
bd59b0a490
Debugger MemoryViewWidget: Allow direct editing of memory cells.
2022-07-01 17:30:24 -07:00
bf68211878
RegisterWidget: Fix crash when right-clicking when there is no selected cell
2022-07-01 17:13:00 -07:00
a334883c47
Qt/MemoryViewWidget: Don't elide text
...
Before, the Hex 32 display would get truncated on Linux.
2022-06-20 18:53:23 -07:00
177dae6a1a
Add options for BreakpointWidget, WatchWidget, and CheatSearches to send address to Memory Widget
2022-06-01 01:53:15 -07:00
828ce0f3cf
Qt/MemoryViewWidget: Fix resizing.
2022-05-10 12:35:37 +02:00
7f94e62dd5
Qt/MemoryViewWidget: Remove the behavior that clicking anywhere in the table centers the table on that row.
2022-05-08 23:14:37 +02:00
88dd9e57f3
Qt/MemoryViewWidget: Add a custom scrollbar.
2022-05-08 23:14:37 +02:00
4e153212a0
Qt/MemoryViewWidget: Convert into QWidget that has the table as a member.
2022-05-08 23:14:36 +02:00
0e1e2323ea
Qt/MemoryViewWidget: Keyboard navigation should observe the number of bytes per row instead of assuming 16.
2022-05-08 23:14:36 +02:00
95175bbb96
Debugger RegisterWidget: Add context options to change entire column's display type.
2022-04-29 17:21:39 -07:00
787e3efeb8
Qt/MemoryViewWidget: Detect row breakpoint cell by cell data instead of cell position.
2022-04-24 16:22:36 +02:00
6920a24f1d
Qt/MemoryViewWidget: Add option to copy the actually displayed cell value to clipboard.
2022-04-24 16:22:36 +02:00
54ec0bd0d0
Qt/MemoryViewWidget: Don't use a member variable to hold information about the current mouse click.
2022-04-24 16:14:42 +02:00
26f9c8b847
Qt/MemoryWidget: Don't force a fixed size for the sidebar.
2022-04-24 05:24:20 +02:00
a7111e3910
Dual View any size.
2022-04-23 02:46:25 -07:00
cc22f1a558
MemoryWidget add dual views for two separate column types. Force first column to be Hex32.
2022-04-17 00:15:44 -07:00
a2aecc3794
Debugger MemoryWidget: More display types, use combo box for display options. Add alignment and riw length options.
2022-04-15 22:00:51 -07:00
c5b0b92513
MemoryWidget: Load Files to Memory
2022-04-10 21:02:33 -05:00
23508cafb2
Merge pull request #7675 from TryTwo/Debugger_Code_Features
...
Debugger: Get target memory in load/store instructions
2022-04-08 05:28:22 +02:00
5b658e77df
MemoryWidget: Fix preview of zero as float/double
2022-04-07 11:55:23 +04:00
ed96b8e308
Debugger MemoryWidget: add float and integer inputs. Add input preview. Change input logic. Use combobox for options.
2022-04-06 16:20:55 -07:00
25c173cefc
Merge pull request #8732 from dreamsyntax/debugger-function-differencing
...
Qt/Debugger CodeWidget: Record and find specific functions by differencing
2022-04-02 05:42:33 +02:00
8f85e384c3
Debugger MemoryViewWidget: fixed, tighter spacing
2022-03-29 14:16:25 -07:00
88a1acdfc0
implement CodeDiffTool Feature
...
Add Diff button to CodeWidget
Add Code Diff Tool window for recording and differencing functions. Allows finding specific functions based on when they run.
2022-03-26 11:41:08 -07:00
d5916fd14c
MemoryWidget: Add negative offset search support
2022-03-24 23:06:25 +04:00
53cf78d413
Gekko constistancy changes. Add context item to codeview to show or copy a load/store target memory address from instructions at or near PC when paused.
2022-03-17 12:53:38 -07:00
9ebfdff6b4
Merge pull request #10423 from Pokechu22/improperly-exclusive-radio-buttons
...
Fix improperly exclusive radio buttons
2022-02-18 21:20:14 +01:00
50d9349926
Fix integer sign difference comparison warnings
2022-02-13 14:38:59 -08:00
99b3ac21e4
NewBreakpointDialog: Fix improperly behaving radio buttons
2022-02-12 11:40:53 -08:00
a05dd6b7e6
MemoryWidget: Fix improperly behaving radio buttons
2022-02-12 11:40:53 -08:00
6e5f4125e3
Use Common::ToLower and Common::ToUpper
2022-01-16 17:00:12 -08:00
e08171fa24
Config: Port remaining Core settings to new config system (partial).
2022-01-05 00:54:15 +01:00
d6331c1e71
Config: Port remaining Interface settings to new config system.
2021-12-31 17:40:04 +01:00
5bcbc8fcef
CodeViewWidget: Fix undefined behavior when centered around address 0
2021-12-08 21:42:15 -08:00
78bfd25964
Fix all uninitialized variable warnings (C26495)
2021-10-13 12:32:16 -07:00
94cba46467
MemoryWidget: Simplify the search logic
...
Fix leading nul bytes being ignored in hex search
2021-09-20 20:46:26 +04:00
0a973ddcbb
DolphinQt: Don't update NetworkWidget when hidden
...
Like 92a655c
2021-09-18 14:41:11 +02:00
f17584fc06
DolphinQt: Fix divide by zero in JITWidget::Update
...
I ran into this while fiddling with the debugger.
2021-08-27 10:30:18 +02:00
87924f2ddd
DolphinQt: Remove Windows dialog help buttons
2021-08-21 10:53:12 -07:00
6c908f8ddb
DolphinQt: Set default focus for NewBreakpointDialog
...
I found it a little bit annoying that you can't start typing
the desired address immediately after opening the window.
Also getting rid of the window's ? button while I'm at it.
2021-08-13 10:56:11 +02:00
bcf2c6b9b9
MemoryViewWidget: Remove unnecessary column
...
This column would end up containing junk data after changing the data type.
2021-07-22 17:39:35 -07:00
e149ad4f0a
treewide: convert GPLv2+ license info to SPDX tags
...
SPDX standardizes how source code conveys its copyright and licensing
information. See https://spdx.github.io/spdx-spec/1-rationale/ . SPDX
tags are adopted in many large projects, including things like the Linux
kernel.
2021-07-05 04:35:56 +02:00
736de8abf6
Merge pull request #9527 from sepalani/watch-items
...
WatchWidget: Add new/delete/clear toolbar items
2021-05-18 04:08:58 -04:00
61198541a0
Merge pull request #9562 from sepalani/dis-icons
...
Breakpoints: Change icon when disabled
2021-03-07 12:14:12 +01:00
1e6dfc6b91
BreakpointWidget: Use QSignalBlocker
2021-03-05 13:35:33 +04:00
Pokechu22