Commit Graph

12177 Commits

Author SHA1 Message Date
Shawn Hoffman 7733463e65 commit 1a428de189 introduced a bug by using a signed enum in a bitfield, the value of which is then used in a ldmxcsr instruction. The sign-extension corrupts the value, causing an exception by attempting to load mxcsr with an invalid value. 2014-03-05 10:19:29 -08:00
Matthew Parlane 0c613a5f5b Merge pull request #132 from Sonicadvance1/Arch-clean
OS X likes to be different. It reports the host processor type as i386 i...
2014-03-05 10:01:12 +13:00
Ryan Houdek 4dc2d71e34 OS X likes to be different. It reports the host processor type as i386 instead of x86 or x86_64 like a typical sane system. 2014-03-04 14:45:50 -06:00
Matthew Parlane 09212d4912 Merge pull request #120 from Sonicadvance1/Arch-clean
Make our architecture defines less stupid.
2014-03-05 09:26:02 +13:00
Ryan Houdek 4f02132f93 Make our architecture defines less stupid.
Our defines were never clear between what meant 64bit or x86_64
This makes a clear cut between bitness and architecture.
This commit also has the side effect of bringing up aarch64 compiling support.
2014-03-04 09:36:59 -06:00
Pierre Bourdon d1ccd964cd Merge pull request #131 from lioncash/file-monitor-simplifications
Simplify ShowSound() in FileMonitor.cpp.
2014-03-04 15:14:17 +01:00
lioncash 2c8b9735ae Add two other formats to the list of extensions in IsSoundFile
.adx is used in various games, so this should definitely be here.
2014-03-04 08:57:07 -05:00
lioncash f39c757edf Simplify ShowSound() in FileMonitor.cpp.
Now if more sound types are found, they just need to simply be added to
the unordered set.

- Also changed ShowSound() to IsSoundFile()
- Fixed IsSoundFile’s definition in FileMonitor.h. This whole time it
has been defined as a void method, when in reality it was a bool
function.

- Changed the FileMonitor’s string parameters to be constant references.
2014-03-04 08:39:25 -05:00
Pierre Bourdon 6fa39c28fe Merge pull request #118 from neobrain/videosoftware-bypass-xfb-hack
Software renderer: Restore FifoPlayer support by emulating hardware backend behavior.
2014-03-03 19:05:35 +01:00
Tony Wasserka 1bdf232fed videosoftware: More coding style fixes. 2014-03-03 19:03:15 +01:00
Pierre Bourdon 91676ad930 Merge pull request #128 from lioncash/normalize-debug-interface-func-names
Change the DebugInterface, PPCDebugInterface, and DSPDebugInterface to use CamelCase function names.
2014-03-03 18:58:36 +01:00
Pierre Bourdon 9ef627f2b6 Merge pull request #129 from Tilka/128bit_fix
Fix 32 bit non-Windows build
2014-03-03 18:50:55 +01:00
Tillmann Karras 891b334f52 Fix 32 bit non-Windows build 2014-03-03 10:46:08 +01:00
Lioncash 279a8c0148 Change the DebugInterface, PPCDebugInterface, and DSPDebugInterface to use CamelCase names.
This is the standard coding convention in the codebase, so our interfaces should use it too.
2014-03-03 00:39:08 -05:00
Pierre Bourdon 32e0544088 Merge pull request #127 from lioncash/cheat-dlg-simplification
Make the base calculation in CheatsWindow simpler.
2014-03-03 04:16:43 +01:00
Lioncash 10f3d90f83 Make the base calculation in CheatsWindow simpler.
First and foremost this should test the checked state, not its direct value.
This should never have used multiplication at all. Seriously, what the hell?

The only values it would have given is true or false, so the only cases are 0*6 and 1*6.
2014-03-02 22:15:01 -05:00
Matthew Parlane bd99e4a689 Merge pull request #126 from delroth/master
UnitTests: ensure the Binaries/Tests directory exists before linking.
2014-03-03 16:05:41 +13:00
Pierre Bourdon 177ef615d7 UnitTests: ensure the Binaries/Tests directory exists before linking. 2014-03-03 04:03:53 +01:00
Matthew Parlane 3d281593ba Merge pull request #125 from delroth/master
Unittests: Always use GTest from Externals (recommended way from GTest FAQ).
2014-03-03 15:49:17 +13:00
Pierre Bourdon 9ea845310d Unittests: Always use GTest from Externals (recommended way from GTest FAQ). 2014-03-03 03:38:46 +01:00
Matthew Parlane 2d6810be9f Merge pull request #124 from delroth/master
Do not hard fail when running 'make unittests' without GTest.
2014-03-03 15:15:13 +13:00
Pierre Bourdon 2d71571be5 Do not hard fail when running 'make unittests' without GTest. 2014-03-03 03:12:58 +01:00
Matthew Parlane 6176424ac4 Merge pull request #119 from delroth/unittests
Add support for GTest based UnitTests
2014-03-03 14:53:24 +13:00
Lioncash 34b5a7871f Rename the JIT function Default() to FallBackToInterpreter(). Communicates intent way better in terms of telling the reader what's going on.
Also did some minor cleanup in functions that used Default.
2014-03-02 19:59:20 -05:00
Pierre Bourdon e7ae1fe9d8 Merge pull request #123 from lioncash/tas-bugfix
Fix a case where the wrong placeholders were being assigned for the up and down D-Pad buttons in the TAS dialog.
2014-03-03 01:01:59 +01:00
Lioncash 445d257641 Fix a case where the wrong placeholders were being assigned for the up and down D-Pad buttons in the TAS dialog. 2014-03-02 18:58:54 -05:00
Pierre Bourdon a4ee187711 Tests: Add more MMIO tests as an example. 2014-03-03 00:25:41 +01:00
Pierre Bourdon d4ed4adace Add the infrastructure required to easily add unit tests and test it with a very simple test file. 2014-03-03 00:25:41 +01:00
Ryan Houdek c028513285 Merge pull request #121 from lioncash/remove-clamp
Remove another clamp function laying in the codebase and replace it with the one in MathUtil.h.
2014-03-02 13:40:10 -06:00
Lioncash 13a007abed Remove another clamp function laying in the codebase and replace it with the one in MathUtil.h. 2014-03-02 13:57:27 -05:00
Matthew Parlane 70b3749d4b Merge pull request #109 from lioncash/file-io-clarifications
Eliminate the magic constants in the switch statement in WII_IPC_HLE_Device_FileIO.cpp's Seek function.
2014-03-02 18:29:48 +13:00
Pierre Bourdon 747021e0c8 CMake: detect GTest if it is installed 2014-03-02 04:15:33 +01:00
Tony Wasserka c6c6d20014 videosoftware: Provide a more elaborate comment on the FifoPlayer support hack. 2014-03-01 18:52:19 +01:00
Scott Mansell 17231418ef videosoftware: Added hack to bypass xfb just so fifoplayer works.
Fifoplayer depends on the old behaviour of videosoftware (and the other
hardware backends in non virtual/real xfb modes) where the framebuffer
gets rendered directly to the screen.

Really fifoplayer should call BeginFrame/EndFrame when it finished
rendering a frame, but adding this hack back in is simpler.
2014-03-01 18:45:24 +01:00
Lioncash 3bc082be52 Fix WII_SEEK_END seeking. 2014-02-28 19:56:42 -05:00
Pierre Bourdon 0942bdae1c Merge pull request #116 from Tilka/misc_fixes_fix
Fix the Windows build (broken in 315a8ba)
2014-03-01 01:36:32 +01:00
Tillmann Karras 7c93f2dc23 Fix the Windows build (broken in 315a8ba) 2014-03-01 01:33:19 +01:00
Pierre Bourdon bc844a168f Merge pull request #100 from Tilka/misc_fixes
Misc fixes
2014-02-28 23:08:56 +01:00
Pierre Bourdon 1a7e3b3227 Merge pull request #80 from Tilka/dsp
DSP: add inline opcode documentation
2014-02-28 22:50:37 +01:00
Pierre Bourdon c8a169ae6e Merge pull request #115 from Parlane/polarssl_detect_support
Makes the detection of shared PolarSSL more inline with usage.
2014-02-28 22:43:51 +01:00
Tillmann Karras 892012dc02 Remove own round() implementation
1. It's not correct, it rounds x.5 down to x.
2. It is visible across the whole project (!).
3. VS2013 finally supports this:
   http://msdn.microsoft.com/en-us/library/dn353646.aspx
   http://msdn.microsoft.com/en-us/library/dn329049.aspx
2014-02-28 12:43:23 +01:00
Tillmann Karras 7a66a3ded1 ArmEmitter: make it more readable 2014-02-28 12:43:22 +01:00
Tillmann Karras 46e7c0657f Crypto: small cleanup 2014-02-28 12:43:22 +01:00
Tillmann Karras 315a8ba1c0 Various changes suggested by cppcheck
- remove unused variables
- reduce the scope where it makes sense
- correct limits (did you know that strcat()'s last parameter does not
  include the \0 that is always added?)
- set some free()'d pointers to NULL
2014-02-28 12:43:20 +01:00
Tillmann Karras 5f0a8008f4 Convert MemoryUtil.cpp to Unix-style line endings 2014-02-28 12:28:21 +01:00
Tillmann Karras 1a428de189 x64FPURoundMode: move things around a bit 2014-02-28 12:28:21 +01:00
Tillmann Karras 269e2aefa7 CMake: fix escaping in miniupnpc test 2014-02-28 12:28:20 +01:00
Tillmann Karras 6914eca167 Fix various warnings reported by clang
- mostly remove unused variables
- rename some generic JIT identifiers
2014-02-28 12:28:19 +01:00
Pierre Bourdon ea34ae0a70 Merge pull request #113 from Parlane/fix_wifi
Randomise the mac address and store it in the config.
2014-02-28 11:25:29 +01:00
Matthew Parlane c68cd3a8ea Randomise the mac address and store it in the config.
This stops error 20115 when trying to go online.
2014-02-28 22:53:00 +13:00