Dentomologist
486a25dd2b
Touchscreen: Add override specifiers
...
Fix -Winconsistent-missing-override warnings on Android
2021-03-07 10:10:02 -08:00
Dentomologist
1fd332d3b7
ControllerInterface: Fix unused-result warning
...
Add ! before unused variables to 'use' them.
Ubuntu-x64 emits warnings for unused variables because gcc decides
it should ignore the void cast around them. See thread for discussion:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425
2021-03-07 10:10:02 -08:00
Dentomologist
7ff8e3367f
GraphicsWidget: Remove unused field
...
Fixes warning on freebsd-x64
2021-03-07 10:10:02 -08:00
Dentomologist
fa61fc4f9c
Fix shadowing warnings
...
Fixes type/variable shadowing warnings on debian and ubuntu
2021-03-07 10:10:02 -08:00
Dentomologist
636bf38824
IOS: Add maybe_unused attribute to variables
...
Fixes Wunused-const-variable warning on freebsd-x64 and android
2021-03-07 10:10:00 -08:00
Dentomologist
95c86ee48b
FreeLookCamera: Add override specifiers
2021-03-07 10:10:00 -08:00
Dentomologist
1c71d33ed5
FreeLookCamera: Remove unused variable
2021-03-07 10:10:00 -08:00
Dentomologist
692aaed60c
FreeLookController: Fix signed/unsigned warning
...
Loop index int i was being compared against GetControllerCount() which
returned a size_t. This was the only place GetControllerCount() was
called from so the change of return type doesn't disturb anything else.
Changing the loop index to size_t wouldn't work as well since it's
passed into GetController(), which takes an int and is called from many
places, so it would need a cast anyway on an already busy line.
2021-03-07 10:09:59 -08:00
Dentomologist
686314b548
Arm64Gen: Move constant and make constexpr
...
Namespace-scope variable was only used in one function so move it there
2021-03-07 10:09:59 -08:00
Dentomologist
dffcbcc6c4
Arm64Gen: Remove unused constant
2021-03-07 10:09:59 -08:00
Léo Lam
61198541a0
Merge pull request #9562 from sepalani/dis-icons
...
Breakpoints: Change icon when disabled
2021-03-07 12:14:12 +01:00
Pokechu22
df81210e96
Use formatters in GetBPRegInfo; add missing commands
...
BPMEM_TEV_COLOR_ENV + 6 (0xC6) was missing due to a typo. BPMEM_BP_MASK (0xFE) does not lend itself well to documentation with the current FIFO analyzer implementation (since it requires remembering the values in BP memory) but still shouldn't be treated as unknown. BPMEM_TX_SETMODE0_4 and BPMEM_TX_SETMODE1_4 (0xA4-0xAB) were missing entirely.
2021-03-06 19:27:20 -08:00
Pokechu22
70f9fc4e75
Convert BPMemory to BitField and enum class
...
Additional changes:
- For TevStageCombiner's ColorCombiner and AlphaCombiner, op/comparison and scale/compare_mode have been split as there are different meanings and enums if bias is set to compare. (Shift has also been renamed to scale)
- In TexMode0, min_filter has been split into min_mip and min_filter.
- In TexImage1, image_type is now cache_manually_managed.
- The unused bit in GenMode is now exposed.
- LPSize's lineaspect is now named adjust_for_aspect_ratio.
2021-03-06 19:27:19 -08:00
Pokechu22
db8ced7e4e
Add FogParam0::FloatValue and FogParam3::FloatValue
...
This value will be used in the register description; so expose it in a way that can be re-used instead of calculating it in 2 places later.
2021-03-06 19:27:18 -08:00
Pokechu22
f2bea67709
Fix typo with ztex2 op in UseVertexDepthRange
2021-03-06 19:27:17 -08:00
Pokechu22
762fe33a3d
Rename BPMEM_EFB_BR to BPMEM_EFB_WH
2021-03-06 19:27:16 -08:00
Pokechu22
81b84a5ebe
Use XFMEM_REGISTERS_START/END in XFRegWritten and LoadXFReg
2021-03-06 19:27:15 -08:00
Pokechu22
8c80369373
Add names and descriptions for regular XF memory
2021-03-06 19:27:15 -08:00
Pokechu22
2d6ec7457d
Add names and descriptions for XF registers to the FIFO analyzer
2021-03-06 19:27:14 -08:00
Pokechu22
aab81d5aa0
Convert XFMemory to BitField and enum class
...
Additionally a new ClipDisable union has been added (though it is not currently used by Dolphin).
2021-03-06 19:27:14 -08:00
Pokechu22
953e09428f
Add names and descriptions for CP registers to the FIFO analyzer
2021-03-06 19:27:14 -08:00
Pokechu22
f749fcfa9f
Convert CPMemory to BitField and enum class
...
Additionally, VCacheEnhance has been added to UVAT_group1. According to YAGCD, this field is always 1.
TVtxDesc also now has separate low and high fields whose hex values correspond with the proper registers, instead of having one 33-bit value. This change was made in a way that should be backwards-compatible.
2021-03-06 19:27:08 -08:00
Pokechu22
c27efb3f1f
Create constants for CP registers and masks
2021-03-06 17:34:05 -08:00
Pokechu22
d702f3b4ad
DolphinNoGUI/PlatformX11: Work around X.h's None being undefined
2021-03-06 17:34:04 -08:00
Pokechu22
f697e17dd1
Create BitFieldArray
2021-03-06 17:34:03 -08:00
Pokechu22
1273c5e395
Add fmt support to BitField
2021-03-06 14:58:32 -08:00
Pokechu22
cf95deaf6d
Allow specifying StorageType for BitField
...
This is useful for BitFields that are bools.
2021-03-06 14:57:44 -08:00
Pokechu22
6653bd7199
Create EnumFormatter
2021-03-06 14:57:42 -08:00
Léo Lam
5f7d935b0a
Merge pull request #9533 from sepalani/mmu-is-ram
...
MMU: Fix IsRAMAddress not working
2021-03-05 11:49:55 +01:00
JMC47
fc86e554e0
Merge pull request #9559 from iwubcode/gdb-stub-raii
...
Common / Core: add raii object that cleans up WSA on destruction in gdb-stub
2021-03-05 05:28:31 -05:00
Léo Lam
adcdeda372
Merge pull request #9565 from sepalani/qt-blocker
...
BreakpointWidget: Use QSignalBlocker
2021-03-05 10:44:44 +01:00
Léo Lam
a4de2502c5
Merge pull request #9550 from endrift/gba-flush
...
SI/DeviceGBA: Ensure data socket isn't backed up
2021-03-05 10:38:55 +01:00
Sepalani
1e6dfc6b91
BreakpointWidget: Use QSignalBlocker
2021-03-05 13:35:33 +04:00
Sepalani
fd7eeb7221
BreakpointWidget: Fix delete deleting both MBP and BP at address
2021-03-05 13:01:32 +04:00
Sepalani
359a539f25
Breakpoints: Change icon when disabled
2021-03-05 11:21:37 +04:00
Léo Lam
1e3e5680db
Merge pull request #9561 from sepalani/fix-watches
...
Watches: Fix Save and Load from strings
2021-03-05 00:57:40 +01:00
iwubcode
7d5052896d
IOS: update network/ip/top to use the RAII winsock context
2021-03-04 13:55:20 -06:00
iwubcode
e4f74bea42
Core: Use RAII winsock object to cleanly create and destroy WSA in gdb-stub
2021-03-04 13:47:32 -06:00
iwubcode
00bc7e6b38
Common: Add RAII object that initializes and cleans up winsock
2021-03-04 13:44:12 -06:00
Sepalani
ef977123d5
BreakpointWidget: Emit BreakpointsChanged to update views
2021-03-04 21:10:37 +04:00
Sepalani
6786340a7c
Watches: Fix Save and Load from strings
2021-03-04 17:55:52 +04:00
Léo Lam
be500a98e2
Merge pull request #8779 from sepalani/open-dump
...
NetworkWidget: Reorganise SSL options group box
2021-03-04 13:37:10 +01:00
Léo Lam
511e9dcd2f
Merge pull request #9542 from InusualZ/toggle-bp
...
BreakpointWidget: Allow breakpoints to be toggled between enable/disable
2021-03-04 12:34:03 +01:00
Léo Lam
48a5846aee
Merge pull request #9548 from AdmiralCurtiss/fastmem-active-regions
...
Core/Memmap: Memory mapping logic fixes.
2021-03-04 12:18:59 +01:00
Léo Lam
9c6c77351f
Merge pull request #9556 from JosJuice/cmake-msvc-latest
...
CMake: Build with -std:c++latest for MSVC
2021-03-04 12:12:06 +01:00
Léo Lam
00db622d50
Merge pull request #9560 from JosJuice/cmake-msvc-wil
...
CMake: Include WIL headers
2021-03-04 12:08:05 +01:00
JosJuice
2cb3f663bc
CMake: Include WIL headers
...
MSBuild does this, so CMake should too. Fixes a Windows build error.
2021-03-04 10:26:31 +01:00
JosJuice
0cb71d3f47
CMake: Disable warning C5054 on DolphinQt
...
Same as 33c0abd
.
Also removing -D_SILENCE_CXX17_RESULT_OF_DEPRECATION_WARNING
to match MSBuild. Qt is no longer triggering that warning.
2021-03-04 09:29:30 +01:00
Dentomologist
6e13d35026
DolphinQt: Removed unused this capture in lambda
...
The Host constructor sets a callback on a lambda that in turn calls
Host_UpdateDisasmDialog. Since that function is not a member function
capturing this is unnecessary.
Fixes -Wunused-lambda-capture warning on freebsd-x64.
2021-03-03 13:18:17 -08:00
JMC47
d2eb846e6a
Merge pull request #9549 from Dentomologist/ppcstate_off_to_s32
...
JitArm64: Fix unsigned/signed argument/parameter mismatch
2021-03-03 14:56:40 -05:00