Léo Lam
07be82d64f
Merge pull request #9253 from JosJuice/positional-arguments
...
Use positional arguments in all translatable fmt strings
2020-11-17 18:02:39 +01:00
JosJuice
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
LC
4c9b226bd6
Merge pull request #9252 from JosJuice/fmt-version-requirement
...
CMake: Bump fmt version requirement to 7.1.0
2020-11-16 07:12:54 -05:00
JosJuice
56e68e7b72
CMake: Bump fmt version requirement to 7.1.0
...
We use make_args_checked, which was added in 7.1.0.
2020-11-16 13:06:20 +01:00
Léo Lam
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
Léo Lam
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
Léo Lam
c991f00479
Merge pull request #9244 from lioncash/input-panic
...
InputCommon: Migrate over to fmt-capable panic alerts
2020-11-12 14:41:50 +01:00
Lioncash
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
LC
93212049ac
Merge pull request #9242 from lioncash/disc-panic
...
DiscIO: Make use of fmt-capable panic alerts
2020-11-12 02:22:21 -05:00
JosJuice
9e3e325add
Merge pull request #9243 from JosJuice/android-input-overlay-null
...
Android: Add null check for InputOverlay
2020-11-11 11:22:41 +01:00
JosJuice
32ad2dcec3
Android: Add null check for InputOverlay
...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12316 .
2020-11-11 10:38:49 +01:00
Lioncash
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
LC
ae83685b0b
Merge pull request #9237 from lioncash/msghandler
...
Common/MsgHandler: Add fmt-capable variants of the alert macros
2020-11-11 00:34:45 -05:00
LC
0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt
...
ShaderGenCommon: Rename WriteFmt() to Write()
2020-11-09 22:08:42 -05:00
Lioncash
7b21f7af2e
Common/MsgHandler: Add fmt-capable variants of the alert macros
...
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
2020-11-09 08:48:17 -05:00
LC
43e2f0e88f
Merge pull request #9235 from lioncash/ui-log
...
UICommon: Migrate logging over to fmt
2020-11-09 07:28:28 -05:00
JosJuice
72997c17d0
Merge pull request #9229 from JosJuice/android-emulationactivity-finish
...
Android: Handle failed boots correctly
2020-11-09 10:46:08 +01:00
JosJuice
8181a7b3dd
Android: Remove unnecessary ANativeWindow_release call
...
This is already handled by SurfaceDestroyed. In the worst case,
the extra code could even race with SurfaceDestroyed if they
are triggered at the same time, but this is highly improbable.
2020-11-09 10:38:50 +01:00
JosJuice
d982afd1ef
Android: Fix alert messages when EmulationActivity is being destroyed
...
The previous commit made this easy to reproduce when launching
an invalid disc image with the phone rotated incorrectly.
2020-11-09 10:38:50 +01:00
JosJuice
ee52f465b1
Android: Fix rotating EmulationActivity after boot fails
...
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
2020-11-09 10:38:49 +01:00
JosJuice
d06830b274
Android: Only show emulation menu toast if boot succeeds
2020-11-09 10:33:53 +01:00
JosJuice
0280f3557c
Android: Finish EmulationActivity from C++
...
This makes EmulationActivity automatically close if booting
fails, and lets us get rid of s_emulation_end_event.
2020-11-09 10:33:52 +01:00
Lioncash
21dd7a8ebb
Vulkan: Migrate logging over to fmt
...
Migrates the vulkan backend over to the fmt-capable logger.
2020-11-09 03:26:16 -05:00
Lioncash
23a8baa605
Software: Migrate logging over to fmt
...
Migrates the software backend over to the fmt-capable logger.
2020-11-09 03:14:01 -05:00
Lioncash
413d64e7fc
OpenGL: Migrate logging over to fmt
...
Migrates over to the fmt-capable logger.
2020-11-09 03:09:09 -05:00
Lioncash
4d9a7c7a54
D3DCommon: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:03:26 -05:00
Lioncash
2345d5f98d
D3D: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:02:00 -05:00
Lioncash
d7834bd6b4
D3D12: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 02:59:51 -05:00
Lioncash
52f2fadb36
UICommon: Migrate logging over to fmt
...
A very simple change that continues the migration of the logs over to
fmt.
2020-11-09 02:39:55 -05:00
Lioncash
a5b28f1f07
ShaderGenCommon: Rename WriteFmt() to Write()
...
Now that we've converted all of the shader generators over to using fmt,
we can drop the old Write() member function and perform a rename
operation on the WriteFmt() to turn it into the new Write() function.
All changes within this are the removal of a <cstdarg> header, since the
previous printf-based Write() required it, and renaming. No functional
changes are made at all.
2020-11-09 02:31:49 -05:00
LC
a9ef7e0e43
Merge pull request #9225 from JosJuice/android-convertfragment-path
...
Android: Rename path variable in ConvertFragment
2020-11-09 02:16:59 -05:00
LC
db83c7ec8d
Merge pull request #9227 from JosJuice/android-menu-scrollbar
...
Android: Make scrollbar for in-game menu always visible
2020-11-09 02:16:34 -05:00
LC
98726400bc
Merge pull request #9230 from JosJuice/android-savesettings-onstop
...
Android: Call saveSettings in EmulationActivity.onStop
2020-11-09 02:15:21 -05:00
LC
418f9faa9d
Merge pull request #9228 from JosJuice/android-jclass
...
Android: Fix jobject/jclass warnings
2020-11-09 02:15:04 -05:00
LC
766fab2561
Merge pull request #9231 from Ebola16/ASW
...
Android: Remove unnecessary WrongConstant warning suppression
2020-11-09 02:14:26 -05:00
LC
add2b44eb7
Merge pull request #9197 from lioncash/uber-pixel
...
UberShaderPixel: Migrate over to fmt
2020-11-09 02:13:57 -05:00
Tilka
b4110aec52
Merge pull request #9233 from altimumdelta/CPU_Fix-Comment-ZEN+2-PDEP-PEXT
...
CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23)
2020-11-08 18:42:32 +00:00
altimumdelta
77dc289517
CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23)
2020-11-08 14:27:24 +01:00
JosJuice
e4793cfb39
Android: Don't name unused JNIEnv/jobject/jclass parameters
2020-11-07 12:08:48 +01:00
JosJuice
57dc54144d
Android: Fix jobject/jclass warnings
...
Static methods use jclass, and non-static methods use jobject.
2020-11-07 12:06:57 +01:00
Ryan Meredith
cd52da959c
Android: Remove unnecessary WrongConstant warning suppression
2020-11-07 01:35:59 -05:00
JosJuice
a1a4d12b62
Android: Call saveSettings in EmulationActivity.onStop
...
I didn't realize that onSaveInstanceState doesn't get called
when finishing the activity.
2020-11-06 22:40:29 +01:00
JosJuice
2acd3abe35
Merge pull request #9223 from Ebola16/D
...
Android: Suppress warnings in EmulationActivity
2020-11-06 19:57:06 +01:00
JosJuice
5afda5efe3
Merge pull request #9209 from Ebola16/AIRSDS
...
Android: Update IR sensitivity default values
2020-11-06 19:56:53 +01:00
Jordan Woyak
6a4ac74ec4
Merge pull request #9226 from JosJuice/bootparameters-nullptr
...
Fix dereferencing nullptr BootParameters
2020-11-06 10:38:53 -06:00
JosJuice
b6e236ef86
Android: Make scrollbar for in-game menu always visible
...
Some users aren't noticing that the in-game menu can be scrolled.
I hope this will help with that, though I'm not sure by how much.
2020-11-06 11:40:38 +01:00
JosJuice
a348efe947
Fix dereferencing nullptr BootParameters
2020-11-06 09:34:53 +01:00
JosJuice
56122f38bb
Android: Rename path variable in ConvertFragment
...
Not sure why I named it path, because it isn't a path.
2020-11-05 18:16:07 +01:00
LC
4d1c1bea34
Merge pull request #9222 from JosJuice/cache-fstream
...
Common/LinearDiskCache: Replace std::fstream with File::IOFile
2020-11-05 11:39:17 -05:00
Ryan Meredith
0a239cc1bd
Android: Suppress warnings in EmulationActivity
2020-11-04 20:34:25 -05:00