YoshiRulz
ea5e8b70d3
Fix compilation of ext. tools
2022-07-25 11:16:42 +10:00
YoshiRulz
8dcea24703
Fix `GameInfo.NullInstance` having a name... why did it have a name
2022-07-25 11:15:19 +10:00
YoshiRulz
d796210437
Cancel tool loading when services aren't satisfied ( fixes #3329 )
...
also cleaned up other calls
2022-07-25 10:52:02 +10:00
YoshiRulz
070e7035b3
Ensure there can be no edge cases involving SGXCD sysID
...
breaks config, in case you care about setting a custom save dir for PCE
2022-07-25 08:15:24 +10:00
YoshiRulz
3d42b19797
Pass `VSystemID.Raw.NULL`, not `null`, for `SystemId`
2022-07-25 08:15:17 +10:00
CasualPokePlayer
cb468ba806
pull in latest sameboy master, add stub camera pixel callback to prevent nondeterminism, wire disabling joypad bounce as a sync setting, various cleanup
2022-07-24 04:35:03 -07:00
zeromus
e2a36c7242
DisplayConfig defaults button should whack the padding back to 0
2022-07-22 16:38:42 -04:00
zeromus
3b181ba6e4
DisplayManager - fix crashes when setting absurdly large padding values ( fixes #3321 )
2022-07-22 16:09:49 -04:00
tom_mai78101
6eafdf7156
Fixed issue where the Copy button in Basic Bot is not toggled on/off properly.
...
If the Copy button is enabled, but there is no best attempt recorded, it will crash BasicBot / EmuHawk if it attempts to copy a null Log of the best attempt.
2022-07-23 05:49:50 +10:00
CasualPokePlayer
d8fc32f1a8
[mGBA] Add in missing save types
2022-07-21 15:38:59 -07:00
YoshiRulz
0f6e6a5a03
Enable MA0084 and fix noncompliance (except in Cores)
...
"Local variable should not hide other symbols"
2022-07-22 07:28:32 +10:00
YoshiRulz
d142555ec3
Enable MA0066 and fix noncompliance
...
"Hash table unfriendly type is used in a hash table"
2022-07-22 07:28:31 +10:00
YoshiRulz
41d46dd37d
Fix `%recent%` in Paths config
...
broken since introduction in 017743133
(pre-1.0 according to GitHub)
also enabled MA0052 "Replace constant Enum.ToString with nameof", which is what
tipped me off to this
2022-07-22 07:28:25 +10:00
YoshiRulz
0309cdc4bc
Disable MEN015 "Use Preferred Terms" (spellcheck)
...
you're supposed to be able to configure this but I couldn't figure it out
2022-07-22 05:39:03 +10:00
YoshiRulz
9211007a18
Fix bug in `PlayMovie.PreHighlightMovie` heuristics
...
for the record, the bug was that it had `_movieList[indices[0]]` in the loop
instead of `_movieList[indices[i]]`
2022-07-22 05:06:05 +10:00
YoshiRulz
3f2a07e582
Fix remaining MA0098 code style warnings
...
"Use indexer instead of LINQ methods"
fixes 17df5673d
, forgot I was in the middle of this when I pushed
2022-07-22 04:51:56 +10:00
YoshiRulz
17df5673d2
Enable MA0098 and fix noncompliance
...
"Use indexer instead of LINQ methods"
2022-07-22 03:51:47 +10:00
YoshiRulz
ee11385f10
Enable MA0031 and fix noncompliance
...
"Optimize Enumerable.Count() usage"
2022-07-22 03:51:47 +10:00
YoshiRulz
b1ad34839a
Enable MA0029 and fix noncompliance
...
"Combine LINQ methods"
2022-07-22 03:51:47 +10:00
YoshiRulz
26b6a1c4a9
Enable MA0020 and fix noncompliance
...
"Use direct methods instead of LINQ methods"
2022-07-22 03:51:47 +10:00
YoshiRulz
697c10e3e6
Enable MA0015 and fix noncompliance
...
"Specify the parameter name in ArgumentException"
needed to update package because this rule was broken until now
2022-07-22 03:51:46 +10:00
YoshiRulz
92c4714be1
Enable CA2208 and MA0043 and fix noncompliance
...
"Instantiate argument exceptions correctly" and
"Use nameof operator in ArgumentException"
2022-07-22 03:51:45 +10:00
YoshiRulz
5a8a24e936
Enable MA0054 and fix noncompliance
...
"Embed the caught exception as innerException"
2022-07-22 03:51:43 +10:00
YoshiRulz
8ac4dabaf7
Enable MA0012 and MA0014 and fix noncompliance
...
"Do not raise reserved exception type" and
"Do not raise System.ApplicationException type"
now mostly compliant with
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/using-standard-exception-types
2022-07-22 03:51:43 +10:00
YoshiRulz
a2fef59fe1
Add Analyzer rule to prohibit `typeof(T).ToString()`
2022-07-22 03:51:43 +10:00
YoshiRulz
f3f90a4cd5
Add Analyzer rules to prohibit `this.GetType()`
...
seriously Meziantou is a godsend
2022-07-22 03:51:42 +10:00
YoshiRulz
dcc8957be3
Fast-fail Analyzer properly, fix typo
...
thanks to https://www.meziantou.net/working-with-types-in-a-roslyn-analyzer.htm
2022-07-22 03:51:36 +10:00
YoshiRulz
4956bae3a2
Improve error message for `IToolFormAutoConfig` ext. tool missing menu
2022-07-22 02:02:01 +10:00
CasualPokePlayer
480ce3b925
fix minor miscompilation of gambatte-linux, update LibGambatte to reflect API changes wrt CameraCallback
2022-07-20 23:35:29 -07:00
CasualPokePlayer
a8f709a8a4
[Gambatte] ensure cameraBuf_ is signed, misc cleanup
2022-07-20 23:29:53 -07:00
CasualPokePlayer
d209ba289f
various gambatte updates / bugfixes
2022-07-20 22:51:28 -07:00
YoshiRulz
4a7ed563b6
Revert "Pin and downgrade Nix Docker image"
...
This reverts commit 93bb90b584
.
2022-07-20 21:09:06 +10:00
YoshiRulz
84886b7395
Nix expr: quick fix for deps
...
fixes 6b4e526a4
2022-07-20 01:59:48 +10:00
YoshiRulz
9bb96fbadc
Update doc comments to reflect thrown exception change
...
fixes 4f98733c2
2022-07-19 03:20:43 +10:00
James Groom
8434a2fd70
Add another note about which .NET target the BizHawk projects use
2022-07-18 18:37:25 +10:00
YoshiRulz
6b325ff56c
Refactor `BasicBot.IsBetter`
2022-07-18 18:22:59 +10:00
Thompson Lee
008a5953f6
Fixed code logic error in BasicBot
...
It was comparing with itself when it's comparing the Tie Breaker 3 value.
2022-07-18 17:33:41 +10:00
CasualPokePlayer
c02975c757
merge aresv129, enable SIMD RSP
2022-07-17 18:52:59 -07:00
nattthebear
89972a3579
Remove dobie core
...
This never really worked. Besides being unusuably slow and not very accurate, there was a miscompliation problem that caused release builds to not function.
2022-07-17 15:02:42 -04:00
CasualPokePlayer
8289c1051b
add hash for newly discovered GBC-GBA bootrom
2022-07-16 22:03:47 -07:00
YoshiRulz
aa708992e9
Use nicer error message for starting MAME in non-MAME build
2022-07-16 16:25:59 +10:00
tom_mai78101
efbef0bbda
Fixed Basic Bot anchor points.
...
Also fixed a misaligned label.
2022-07-16 16:20:39 +10:00
tom_mai78101
e2fb6017b7
Added missing NOT operators from the dropdown menu.
2022-07-16 16:11:16 +10:00
James Groom
7e54322901
Add contributor's guide (squashed PR #3292 )
...
Includes primitive contributor license agreement; when creating a PR, contributors will need to check a box confirming they're not infringing on any copyrights.
2022-07-15 23:25:27 +10:00
YoshiRulz
94e85f1079
Set `Form.Owner` to MainForm for Lua-made forms
2022-07-15 22:26:08 +10:00
YoshiRulz
3fddcdb2c5
Add Analyzer rule to enforce throwing in `[FeatureNotImplemented]`
2022-07-15 22:22:28 +10:00
YoshiRulz
26e02033f2
Do the analysis for BHI1005 properly
2022-07-15 22:22:28 +10:00
YoshiRulz
6b4e526a44
Actually run all the Analyzers for ext. tools, update Analyzers
...
fixes 6f372820a
2022-07-15 22:22:19 +10:00
tom_mai78101
ece2d8d68c
Added NOT operator to Basic Bot.
2022-07-15 16:02:00 +10:00
YoshiRulz
5379de9a6e
Enable MA0019 and fix noncompliance
...
"Use EventArgs.Empty" (instead of ctor)
2022-07-15 09:34:52 +10:00