ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do the analysis for BHI1005 properly

This commit is contained in:
YoshiRulz 2022-07-15 20:50:31 +10:00
parent 6b4e526a44
commit 26e02033f2
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
3 changed files with 33 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
ExternalProjects/BizHawk.Analyzer/HawkSourceAnalyzer.cs
View File

@ -1,6 +1,5 @@
namespace BizHawk.Analyzers;
using System;
using System.Collections.Immutable;
using Microsoft.CodeAnalysis;
@ -66,9 +65,16 @@ public class HawkSourceAnalyzer : DiagnosticAnalyzer
{
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
context.EnableConcurrentExecution();
INamedTypeSymbol? invalidOperationExceptionSym = null;
INamedTypeSymbol? switchExpressionExceptionSym = null;
context.RegisterSyntaxNodeAction(
static snac =>
snac =>
{
if (invalidOperationExceptionSym is null)
{
invalidOperationExceptionSym = snac.Compilation.GetTypeByMetadataName("System.InvalidOperationException")!;
switchExpressionExceptionSym = snac.Compilation.GetTypeByMetadataName("System.Runtime.CompilerServices.SwitchExpressionException");
}
switch (snac.Node)
{
case AnonymousMethodExpressionSyntax:
@ -84,21 +90,9 @@ public class HawkSourceAnalyzer : DiagnosticAnalyzer
snac.ReportDiagnostic(Diagnostic.Create(DiagNoQueryExpression, snac.Node.GetLocation()));
break;
case SwitchExpressionArmSyntax { WhenClause: null, Pattern: DiscardPatternSyntax, Expression: ThrowExpressionSyntax tes }:
if (tes.Expression is ObjectCreationExpressionSyntax oces)
var thrownExceptionType = snac.SemanticModel.GetThrownExceptionType(tes);
if (thrownExceptionType is null)
{
// to resolve edge-cases involving aliases, you're supposed to use `snac.SemanticModel.GetTypeInfo(oces.Type).ConvertedType?.Name`, but I couldn't get it to work
if (((oces.Type as IdentifierNameSyntax)?.Identifier)?.ToString() is "SwitchExpressionException" or nameof(InvalidOperationException))
{
// correct usage, do not flag
}
else
{
snac.ReportDiagnostic(Diagnostic.Create(DiagSwitchShouldThrowIOE, tes.GetLocation(), ERR_MSG_SWITCH_THROWS_WRONG_TYPE));
}
}
else
{
// code reads `throw <something weird>`
snac.ReportDiagnostic(Diagnostic.Create(
DiagSwitchShouldThrowIOE,
tes.GetLocation(),
@ -107,6 +101,11 @@ public class HawkSourceAnalyzer : DiagnosticAnalyzer
properties: null,
ERR_MSG_SWITCH_THROWS_UNKNOWN));
}
else if (!invalidOperationExceptionSym.Matches(thrownExceptionType) && switchExpressionExceptionSym?.Matches(thrownExceptionType) != true)
{
snac.ReportDiagnostic(Diagnostic.Create(DiagSwitchShouldThrowIOE, tes.GetLocation(), ERR_MSG_SWITCH_THROWS_WRONG_TYPE));
}
// else correct usage, do not flag
break;
}
},

18
ExternalProjects/BizHawk.Analyzer/RoslynUtils.cs Normal file
View File

@ -0,0 +1,18 @@
namespace BizHawk.Analyzers;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp.Syntax;
internal static class RoslynUtils
{
private static ITypeSymbol? GetThrownExceptionType(this SemanticModel model, ExpressionSyntax exprSyn)
=> exprSyn is ObjectCreationExpressionSyntax oces
? model.GetTypeInfo(exprSyn).Type
: null; // code reads `throw <something weird>`
public static ITypeSymbol? GetThrownExceptionType(this SemanticModel model, ThrowExpressionSyntax tes)
=> model.GetThrownExceptionType(tes.Expression);
public static bool Matches(this ITypeSymbol expected, ITypeSymbol? actual)
=> SymbolEqualityComparer.Default.Equals(expected, actual);
}

BIN
References/BizHawk.Analyzer.dll
View File

Binary file not shown.