Commit Graph

18502 Commits

Author SHA1 Message Date
YoshiRulz 3ccd10bb36
Add missing access modifier 2021-01-16 07:35:55 +10:00
SuuperW f2747b31b0
add an option to capture the Lua without capturing the full OSD, when… (#2527)
* add an option to capture the Lua without capturing the full OSD, when recording an AVI

* revert designer changes from commit 146022c not related to the new CaptureLuaMenuItem

* improve code readability
2021-01-15 15:03:46 -06:00
SuuperW 889d3262b1
Input roll scrolling (#2528)
* Change the BranchView's ScrollSpeed property to 1. The MarkerControl's is 1, and I assume that ScrollSpeed used to be pixel-based and the value of 13 is an accidental left-over.

* Standard behavior for scroll bars across a majority of other applications is for the up/down buttons to scroll 1 unit at a time while wheel may scroll multiple units at a time. So, do this. (Previous behavior was that both methods of scrolling would scroll by the same amount.)
2021-01-15 15:03:18 -06:00
SuuperW b3e69782dd
Drive states2 (#2542)
* Expose new backing store type functionality for ZwinderBuffer.

* implement drive states for reserved states

* Include version numbers in Zwinder custom file formats, and for newer files rely on the separately loaded settings. With this, TempFile store types are supported when saving/loading.
2021-01-15 15:02:00 -06:00
SuuperW 6c5447f5da
ZwinderStateManager: Use the gap buffer for forced capture to avoid crowding the "current" buffer and thus reducing it's actual span of covered frames. (#2569)
also remove a redundant conditional
2021-01-15 14:54:47 -06:00
SuuperW 961e7f2808 move this piece of init code; fixes: opening TAStudio after starting a .tasproj would fail 2021-01-15 11:52:04 -06:00
SuuperW 302cda6d17 ZwinderStateManager: don't erase states that should be reserved! 2021-01-15 11:36:35 -06:00
SuuperW 69af966a2d TAStudio undo history form: make use of TAStudio methods, so that rewinds necessary to stay inside the greenzone happen. (also refresh after "to here" un/redo) 2021-01-15 11:16:23 -06:00
SuuperW b6d77586af Do not attempt to remove what isn't there. (fixes: removing a marker before a state was reserved would throw an exception.) 2021-01-15 09:38:08 -06:00
nattthebear 6424e35c6a Revert "Replace unnecessary init props w/ ctors, remove hack for init props"
This reverts commit af8a330422.

I like the `init;` feature in modern C# and see it as an improvement on constructor parameters for initializing immutable "data" classes.  Feel free to disagree in code you maintain.
2021-01-15 08:47:09 -05:00
YoshiRulz dd39e95be6
Fix passing the wrong string as param for Bk2LogEntryGenerator ctor
fixes 0d2f01462, see #2567
not sure if the fallback in LogGeneratorInstance is a good idea but it works
2021-01-15 22:44:39 +10:00
YoshiRulz 85f24ca486
Remove file extension check from SharpCompressDearchivalMethod
caused .lsmv to not be recognised (it's .zip), wasn't strictly necessary anyway
2021-01-15 22:14:43 +10:00
YoshiRulz af8a330422
Replace unnecessary init props w/ ctors, remove hack for init props 2021-01-15 21:39:43 +10:00
alyosha-tas 7f0947108c Fix importing DSM files, fixes #2114 2021-01-14 21:32:47 -05:00
nattthebear 7a5408995e sameboy: a bit more cleanup with the printer callback 2021-01-14 19:24:06 -05:00
nattthebear 6981dc781b Make a few small GBHawk cleanups I forgot from the other commit
No need to preemptively LockGPU before calling a scanline callback, that all Just Werkz now.
2021-01-14 19:20:20 -05:00
nattthebear 0b432994df
Rework GB GPU memory areas API (#2566)
* Rework GB GPU memory areas API

All cores can easily implement it now with no copying or awkward garbage.  Also fix the scanline callback and printer callback in Sameboy, which had been broken for some time.

Fixes #2564
2021-01-14 19:17:40 -05:00
YoshiRulz e71506ac6a
Refactor OpenTK gamepad management (the static stuff)
maybe fixes #2429
2021-01-15 05:39:24 +10:00
YoshiRulz d2fb794340
Pass forced core through other paths in RomLoader
fixes c0b6bf61b; not sure if this matters currently (PCE-CD maybe?) but it may
become important if we add more alternate cores
2021-01-15 04:33:14 +10:00
alyosha-tas e65e77e7cd GB GPU Viewer: Bounds check tile drawing for OBJ window, seems to resolve random crashing 2021-01-14 09:50:46 -05:00
YoshiRulz c0b6bf61b1
Pass through queued movie's Core header to RomLoader and load only it 2021-01-14 03:52:32 +10:00
alyosha-tas 428e2fe006 GBHawk: Onl save audio cycles in SubGBHawk where it's needed, fixes state integrity checker in TAStudio 2021-01-13 09:11:40 -05:00
alyosha-tas 72e8fa031e
Fix for state gap when frame advancing and painting input (#2563)
* Fix for state gap when frame advancing and painting input

* simplify
2021-01-12 20:32:44 -06:00
nattthebear 39c0011d09 Move around some error messages
See #2561.  From the point of view of romloader, this is all pretty simple:  It asks for a particular settings type.  It should either get null back (indicating there was nothing, use defaults), or an object of that type.  Providing a completely unrelated type is baloney.  So this check here is a stupid defensive check that shouldn't be needed.  MainForm cannot be trusted.
2021-01-12 09:32:58 -05:00
YoshiRulz 733862b070
Update note re: SDK requirement 2021-01-12 22:25:48 +10:00
alyosha-tas 47c98c6a5e GBHawk: fix debugger disassembler 2021-01-10 14:02:01 -05:00
zeromus 5529b8787c update libgambatte to have fix for CDL 1st opcode byte. fixes #2551 2021-01-10 12:37:22 -05:00
YoshiRulz f79b7e5be4
Fix order of arguments to GetRelativePath
These have been backwards since the feature was added (5f2e2f39b). Does the
Windows implementation of GetRelativePath not return weird results?
2021-01-10 22:43:40 +10:00
YoshiRulz ea0d6b04d8
Fix code style 2021-01-10 19:30:18 +10:00
alyosha-tas bcee6d4d39 Fix syncless recorder 2021-01-09 22:20:16 -05:00
alyosha-tas a67d01f04d Update cheat inde on button press: Fixes #2550 2021-01-09 20:05:10 -05:00
nattthebear 75a655fdd8 Fix screwup in romloader xmlgame handling
This may have only affected Saturn in practice.  Whoops!  Fixes #2557.
2021-01-09 11:45:16 -05:00
YoshiRulz 9ed56cdc6e
Remove cached global ICodeDataLogger (emu core) in CDL (fixes #2553)
fixes 234642ed0; this was never going to work because the setter will only be
called by `ServiceInjector.UpdateServices` during a core restart, at which time
the previous core should already have been `Dispose`d. If you want to call
`.SetCDL(null)` on the core when restarting (even though closing the CDL window
already does that three times?), do it in the core's `Dispose` implementation.
2021-01-09 23:13:36 +10:00
YoshiRulz 71ad6deff3
Ensure existing global IEmulator is disposed when reassigning it 2021-01-09 23:02:22 +10:00
YoshiRulz 5078ac392b
Simplify null-safety checks in GetEnumFromDescription<T : Enum> 2021-01-09 05:13:57 +10:00
YoshiRulz 979afcb54d
Do something cleverer than throwing NRE in a few places 2021-01-09 05:08:09 +10:00
YoshiRulz e976e0c2ad
Use nameof in DeepEquality, fix typo 2021-01-09 04:54:02 +10:00
nattthebear ecafbde89d Let's not break the entire fucking program brahs 2021-01-08 13:41:15 -05:00
YoshiRulz 0272684cdf
Fix domain names in GBHawk CDL (fixes #2552)
fixes 7e00b7892
2021-01-09 02:55:14 +10:00
nattthebear 5a8c58de3c Look mom, I'm using the new C# 2021-01-08 08:52:24 -05:00
nattthebear cbdcba9643 Fix BS93 garbage
Probably.  Not sure what this does anymore, but 4 is right and 6 is wrong.
2021-01-06 11:20:37 -05:00
YoshiRulz 0ea597ded5
Fix GBA Game Shark code conversion (fixes #2545) 2021-01-06 18:47:05 +10:00
YoshiRulz fa5ed36f63
Add boilerplate for unit testing GameSharkDecoder
should fail without the following commit
2021-01-06 18:46:36 +10:00
YoshiRulz ab3846906f
Use type checks for DecodeResult/InvalidCheatCode 2021-01-06 17:25:05 +10:00
YoshiRulz 966b8a974a
string.Trim doesn't remove NUL
I'm also skeptical of the `if (bs93/*=br.ReadBytes(6)*/ == "BS93") { ... }` just
after this, it doesn't seem the condition can ever be met...
2021-01-06 16:54:23 +10:00
YoshiRulz c1a734a04d
Update the NuGet deps which should be safe to update 2021-01-02 20:31:54 +10:00
YoshiRulz 4e668612c7
Convert LoadCueJob.TrackInfo to a readonly struct 2021-01-02 20:15:17 +10:00
YoshiRulz 84a6c5a426
Convert CUE_File.Command.* to readonly structs with a superinterface 2021-01-02 20:05:06 +10:00
YoshiRulz 277f57eebd
Convert CompileCueJob.CompiledCueIndex to a readonly struct 2021-01-02 18:35:00 +10:00
YoshiRulz d87066c634
Convert Blob_ECM.IndexEntry to a readonly struct 2021-01-02 18:14:12 +10:00