afb0b8a435
maybe fix tests?
2022-08-10 02:55:01 -07:00
4ce1ec2e37
Fix test execution on Linux / GitLab CI
2022-08-10 17:35:32 +10:00
5be8b0aab9
Zstd Compression ( #3345 )
...
Deflate compression in rewinder is now zstd compression
Binary blobs in zip files are zstd compressed (text is uncompresed for user ease).
All wbx cores and resources are re-compressed with zstd, wbx build scripts are changed to account for this. Shaves off a bit with download size and it's faster to decompress to.
2022-08-09 23:33:28 -07:00
32e8afcedc
Implement hardware accelerated CRC32 and SHA1, using them if possible ( #3348 )
...
* Implement hardware accelerated CRC32 and SHA1, use them if possible.
CRC32's generic function is also replaced with zlib's as it is much more performant than our implementation
Full hash of a ~731MB disc took only ~369 ms with this, and the generic CRC32 isn't so far behind at ~659 ms
SHA1 should perform 4x faster if the user's CPU supports the SHA instructions.
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2022-08-09 23:30:17 -07:00
0236a820ec
Unindent `RomLoader.MakeGameFromDisc`
2022-08-06 09:22:51 +10:00
8f153fd503
Restore PS2 sysID and add some others from RomLoader
2022-08-06 09:22:51 +10:00
5cd37c76b2
dobie removal cleanup
...
fixes 89972a3579
2022-08-05 03:32:09 -07:00
1452f831af
Fix Lua Wiki export, add more notes to fill in some of the holes
...
frameadvance loop is documented now so for the first time you can write a script
without reading someone else's :O imagine that
2022-08-05 11:41:24 +10:00
7bb4b28093
Remove dumb in `MainForm.WindowTitle` so you can see FPS w/ chromeless
...
(window title is shown in the toolbar / application switcher on Win and Linux)
2022-08-05 07:23:43 +10:00
22a328cd36
Remove unused service props
...
unused since 1ce8a368d70e0954f2
2022-07-30 09:26:18 +10:00
5c48cb96fd
When starting new `.tasproj` from SaveRAM, don't clone array twice
2022-07-30 09:26:06 +10:00
d3c42f5dfc
Only shift right by 1 for volume with Gambatte, sounds very close to SameBoy, probably resolves #3338
2022-07-28 17:27:30 -07:00
ccc11be896
Explicitly discard required-but-unused `IStatable` service prop
2022-07-28 05:51:38 +10:00
787b413913
Change Basic Bot's addresses to `ulong?`
...
fixes empty address fields being saved as `0x0`, see #3326
2022-07-28 05:48:05 +10:00
5f572442c4
Save game info to `.bot` files and check when loading ( resolves #3340 )
2022-07-28 05:27:13 +10:00
140e340a8d
Add Analyzer rule to warn of `FirstOrDefault` on list of structs
2022-07-28 03:06:01 +10:00
8453c0e44d
Fix exception on opening Play Movie dialog with multiple movies
...
fixes 9211007a1
2022-07-27 05:08:33 +10:00
bd58bde07c
Hopefully block edge cases where global `GameInfo` is uninitialised
...
`Game == null` conditions in `MainForm` ctor looked unreachable, so I changed
them to `Game.IsNullInstance()` which is what I assume was intended, and added
an assert to `RomLoader` in case a bug is introduced later
2022-07-26 07:59:57 +10:00
d84da4ec4b
wire up sameboy's rumble
2022-07-25 00:10:46 -07:00
ea5e8b70d3
Fix compilation of ext. tools
2022-07-25 11:16:42 +10:00
8dcea24703
Fix `GameInfo.NullInstance` having a name... why did it have a name
2022-07-25 11:15:19 +10:00
d796210437
Cancel tool loading when services aren't satisfied ( fixes #3329 )
...
also cleaned up other calls
2022-07-25 10:52:02 +10:00
070e7035b3
Ensure there can be no edge cases involving SGXCD sysID
...
breaks config, in case you care about setting a custom save dir for PCE
2022-07-25 08:15:24 +10:00
3d42b19797
Pass `VSystemID.Raw.NULL`, not `null`, for `SystemId`
2022-07-25 08:15:17 +10:00
cb468ba806
pull in latest sameboy master, add stub camera pixel callback to prevent nondeterminism, wire disabling joypad bounce as a sync setting, various cleanup
2022-07-24 04:35:03 -07:00
e2a36c7242
DisplayConfig defaults button should whack the padding back to 0
2022-07-22 16:38:42 -04:00
3b181ba6e4
DisplayManager - fix crashes when setting absurdly large padding values ( fixes #3321 )
2022-07-22 16:09:49 -04:00
6eafdf7156
Fixed issue where the Copy button in Basic Bot is not toggled on/off properly.
...
If the Copy button is enabled, but there is no best attempt recorded, it will crash BasicBot / EmuHawk if it attempts to copy a null Log of the best attempt.
2022-07-23 05:49:50 +10:00
d8fc32f1a8
[mGBA] Add in missing save types
2022-07-21 15:38:59 -07:00
0f6e6a5a03
Enable MA0084 and fix noncompliance (except in Cores)
...
"Local variable should not hide other symbols"
2022-07-22 07:28:32 +10:00
d142555ec3
Enable MA0066 and fix noncompliance
...
"Hash table unfriendly type is used in a hash table"
2022-07-22 07:28:31 +10:00
41d46dd37d
Fix `%recent%` in Paths config
...
broken since introduction in 017743133
2022-07-22 07:28:25 +10:00
0309cdc4bc
Disable MEN015 "Use Preferred Terms" (spellcheck)
...
you're supposed to be able to configure this but I couldn't figure it out
2022-07-22 05:39:03 +10:00
9211007a18
Fix bug in `PlayMovie.PreHighlightMovie` heuristics
...
for the record, the bug was that it had `_movieList[indices[0]]` in the loop
instead of `_movieList[indices[i]]`
2022-07-22 05:06:05 +10:00
3f2a07e582
Fix remaining MA0098 code style warnings
...
"Use indexer instead of LINQ methods"
fixes 17df5673d
2022-07-22 04:51:56 +10:00
17df5673d2
Enable MA0098 and fix noncompliance
...
"Use indexer instead of LINQ methods"
2022-07-22 03:51:47 +10:00
ee11385f10
Enable MA0031 and fix noncompliance
...
"Optimize Enumerable.Count() usage"
2022-07-22 03:51:47 +10:00
b1ad34839a
Enable MA0029 and fix noncompliance
...
"Combine LINQ methods"
2022-07-22 03:51:47 +10:00
26b6a1c4a9
Enable MA0020 and fix noncompliance
...
"Use direct methods instead of LINQ methods"
2022-07-22 03:51:47 +10:00
697c10e3e6
Enable MA0015 and fix noncompliance
...
"Specify the parameter name in ArgumentException"
needed to update package because this rule was broken until now
2022-07-22 03:51:46 +10:00
92c4714be1
Enable CA2208 and MA0043 and fix noncompliance
...
"Instantiate argument exceptions correctly" and
"Use nameof operator in ArgumentException"
2022-07-22 03:51:45 +10:00
5a8a24e936
Enable MA0054 and fix noncompliance
...
"Embed the caught exception as innerException"
2022-07-22 03:51:43 +10:00
8ac4dabaf7
Enable MA0012 and MA0014 and fix noncompliance
...
"Do not raise reserved exception type" and
"Do not raise System.ApplicationException type"
now mostly compliant with
https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/using-standard-exception-types
2022-07-22 03:51:43 +10:00
a2fef59fe1
Add Analyzer rule to prohibit `typeof(T).ToString()`
2022-07-22 03:51:43 +10:00
f3f90a4cd5
Add Analyzer rules to prohibit `this.GetType()`
...
seriously Meziantou is a godsend
2022-07-22 03:51:42 +10:00
dcc8957be3
Fast-fail Analyzer properly, fix typo
...
thanks to https://www.meziantou.net/working-with-types-in-a-roslyn-analyzer.htm
2022-07-22 03:51:36 +10:00
4956bae3a2
Improve error message for `IToolFormAutoConfig` ext. tool missing menu
2022-07-22 02:02:01 +10:00
480ce3b925
fix minor miscompilation of gambatte-linux, update LibGambatte to reflect API changes wrt CameraCallback
2022-07-20 23:35:29 -07:00
a8f709a8a4
[Gambatte] ensure cameraBuf_ is signed, misc cleanup
2022-07-20 23:29:53 -07:00
d209ba289f
various gambatte updates / bugfixes
2022-07-20 22:51:28 -07:00
CasualPokePlayer