Commit Graph

21319 Commits

Author SHA1 Message Date
Morilli 4c39a81228 Remove unnecessary duplicated actions in TAStudio
this should not change any behavior.
2024-07-06 17:39:52 +02:00
Morilli d161215754 Don't control reboot in TAStudio
There seems to be no good reason for why this would be necessary. TAStudio behaves just fine when the MainForm reboots itself.
2024-07-06 01:56:13 +02:00
Morilli 74970cc576 Remove unnecessary Thread.Sleep(0)
In this same loop we are already sleeping when necessary, so this Thread.Sleep(0) could only add unwanted delay
2024-07-05 19:21:42 +02:00
James Groom 91fdb23d18
Wrap readme badges to next line 2024-07-06 02:29:02 +10:00
YoshiRulz dbc6acc8fb
Nix expr: Document nix-shell for dev and Kate 2024-07-05 22:33:34 +10:00
YoshiRulz 43c6e04a9d
Add more GitHub Actions badges to readme 2024-07-05 21:56:52 +10:00
YoshiRulz 0146625f2e
Update detailed instructions for getting dev builds 2024-07-05 21:56:35 +10:00
YoshiRulz b04a6d3b4e
Fix formatting of readme badges 2024-07-05 21:44:59 +10:00
YoshiRulz 985c81cbe3
Revert readme screenshot replacement
The screenshots should reflect the *out-of-the-box-experience* i.e. the default core preferences.
Also, your font is ugly :P
2024-07-05 21:03:58 +10:00
CasualPokePlayer e48e6c69f2 respect GreenZoneSettings.txt even if greenzone is missing; fix ClientSettings.json loading (probably regressed in 42aa9d991dc3dde03234a15ddfdc2efdebf1c097?) 2024-07-04 21:34:09 -07:00
YoshiRulz a8b4e76c63
Explicitly disable some diagnostics (just as a note for later really) 2024-07-04 07:37:43 +10:00
YoshiRulz b523a8cb80
Enable MA0155, MA0156, and MA0157 re: `async` 2024-07-04 07:30:43 +10:00
YoshiRulz da7331632d
Enable MA0136 (protects against accidental CRLFs) 2024-07-04 07:23:24 +10:00
YoshiRulz 1c302e56db
Fix default arguments in `override`s which don't match the declaration
not enabling the relevant Analyzer rule MA0061 since that also triggers
when the override omits the default argument
2024-07-04 06:43:43 +10:00
YoshiRulz 1f7d75b7d2
Enable MA0044 and fix noncompliance
"Remove useless ToString call" (on a `string`)
2024-07-04 06:36:57 +10:00
YoshiRulz 9f0009b972
Use `HashCode.Combine` instead of `string.GetHashCode` + XOR
may write an Analyzer for this later
2024-07-04 06:31:44 +10:00
YoshiRulz 8546618c9a
Remove unused import
fixes da25438b1
2024-07-04 06:23:26 +10:00
YoshiRulz da25438b1f
Remove redundant `Stream.Read` result check in `LsmvImport`
fixes a7e1c8fd0
2024-07-04 06:18:54 +10:00
YoshiRulz b818f5325a
Enable MA0040 and silence remaining case
"Flow the cancellation token"
2024-07-04 05:48:35 +10:00
YoshiRulz a7e1c8fd09
Enable MA0060 and fix noncompliance (except in Cores)
"The value returned by Stream.Read/Stream.ReadAsync is not used"
2024-07-04 05:12:58 +10:00
YoshiRulz 6bb60c1b76
Enable MA0078
"Use 'Cast' instead of 'Select' to cast"
2024-07-03 23:12:01 +10:00
YoshiRulz a329d44e41
Enable MA0090 outside of Cores project
"Remove empty else/finally block"
2024-07-03 23:11:48 +10:00
YoshiRulz c4498685c2
Enable MA0091 and fix noncompliance
"Sender should be 'this' for instance events"
2024-07-03 23:10:57 +10:00
YoshiRulz 67edf3f047
Enable MA0070 and fix noncompliance
"Obsolete attributes should include explanations"
2024-07-03 23:10:19 +10:00
YoshiRulz 152b3ad6f5
Enable MA0057 and fix noncompliance
"Class name should end with 'Attribute'" (when subclassing `Attribute`)
2024-07-03 23:08:23 +10:00
YoshiRulz 3fb0afa05e
Use a global import for `MS.VisualStudio.TestTools.UnitTesting.*` 2024-07-03 22:51:48 +10:00
YoshiRulz ccb69b18a9
Use a global import for `System.*` 2024-07-03 22:51:48 +10:00
YoshiRulz c0b676647b
Enable MA0104 and silence remaining cases
"Do not create a type with a name from the BCL"
2024-07-03 22:51:47 +10:00
YoshiRulz 1be3531e7c
Rename `GBHawk.Timer` to `GBHawk.GBTimer` 2024-07-03 22:51:47 +10:00
YoshiRulz 91c48117a3
Rename `BizHawk.BizInvoke.ParameterInfo` to `InvokerParameterInfo` 2024-07-03 22:51:47 +10:00
YoshiRulz db2782ca1b
Enable MA0140 and fix noncompliance (except in Cores)
"Both if and else branch have identical code"
see 618951403
2024-07-03 22:51:47 +10:00
YoshiRulz c188feb50c
Move `SimpleGDIPDisplayManager` to `BizHawk.Client.Common` 2024-07-03 22:51:19 +10:00
YoshiRulz db8454a0ff
Fix testroms project compilation
fixes e8c957a7a
2024-07-03 22:49:01 +10:00
YoshiRulz c6101a190e
Update StyleCop and other Analyzers 2024-07-03 20:44:25 +10:00
YoshiRulz 504ba590b1
Switch to `string.Replace(char, char)` and `string.LastIndexOf(char)` 2024-07-03 20:44:21 +10:00
YoshiRulz 0067dd4b0a
Extract helper method `HawkFile.PathContainsPipe` 2024-07-03 20:38:46 +10:00
YoshiRulz 43d16473d8
Backport `string.Contains(char)` and `string.EndsWith(char)` 2024-07-03 20:35:35 +10:00
YoshiRulz ad8b4653d4
Simplify `MovieImporter.SingleSpaces` 2024-07-03 19:43:43 +10:00
YoshiRulz 759784a648
Fix bug in PCEHawk's tracelog 2024-07-03 19:39:38 +10:00
YoshiRulz 17a268934e
Remove outdated comment
fixes b842f3ed1
2024-07-03 18:47:16 +10:00
feos fd40b32277 uae: for testing writing to floppy 2024-07-02 21:38:42 +03:00
Morilli 04e9bf054e Fix core reboot flag on preference change
This now checks core names instead of system ids
2024-07-02 02:14:07 +02:00
YoshiRulz 2534c9288e
Downgrade Roslyn to 4.8.0 (to continue supporting earliest .NET 8 SDK)
partially reverts 4d1e852d2
2024-07-02 06:49:11 +10:00
YoshiRulz 57b5e77712
Add unit tests for first-party Analyzers 2024-07-02 05:59:31 +10:00
YoshiRulz 867b560a1d
Fix BHI3300 being raised twice for offending accessors 2024-07-02 05:59:31 +10:00
YoshiRulz 4d1e852d2d
Bump Roslyn and testing deps 2024-07-02 05:59:31 +10:00
YoshiRulz 8055cd1343
Nix expr: Set up Kate with OmniSharp 2024-07-02 05:59:31 +10:00
feos 97dc7108c3 uae: "support" rds and reduce magic 2024-06-30 15:48:08 +03:00
CasualPokePlayer 86943143f3 Fix SGM domains using stale arrays after state load 2024-06-28 22:37:56 -07:00
Morilli 384b08a7b7 Fix customization options dialog text overrun
Should now display all text on screen without cutting off.
2024-06-27 20:43:59 +02:00