Fix default arguments in `override`s which don't match the declaration
not enabling the relevant Analyzer rule MA0061 since that also triggers when the override omits the default argument
This commit is contained in:
parent
1f7d75b7d2
commit
1c302e56db
src/BizHawk.Client.Common/Api/Classes
|
@ -188,7 +188,8 @@ namespace BizHawk.Client.Common
|
|||
public IReadOnlyCollection<string> GetMemoryDomainList()
|
||||
=> DomainList.Select(static domain => domain.Name).ToList();
|
||||
|
||||
public uint GetMemoryDomainSize(string name = null) => (uint) NamedDomainOrCurrent(name).Size;
|
||||
public uint GetMemoryDomainSize(string name)
|
||||
=> (uint) NamedDomainOrCurrent(name).Size;
|
||||
|
||||
public string GetCurrentMemoryDomain() => Domain.Name;
|
||||
|
||||
|
|
|
@ -55,7 +55,7 @@ namespace BizHawk.Client.Common
|
|||
return lg.GenerateLogEntry();
|
||||
}
|
||||
|
||||
public void Save(string filename = null)
|
||||
public void Save(string filename)
|
||||
{
|
||||
if (_movieSession.Movie.NotActive())
|
||||
{
|
||||
|
|
|
@ -51,7 +51,7 @@ namespace BizHawk.Client.Common
|
|||
return "Database Opened Successfully";
|
||||
}
|
||||
|
||||
public string WriteCommand(string query = null)
|
||||
public string WriteCommand(string query)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(query)) return "query is empty";
|
||||
if (_dbConnection == null) return "Database not open.";
|
||||
|
@ -71,7 +71,7 @@ namespace BizHawk.Client.Common
|
|||
return result;
|
||||
}
|
||||
|
||||
public object ReadCommand(string query = null)
|
||||
public object ReadCommand(string query)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(query)) return "query is empty";
|
||||
if (_dbConnection == null) return "Database not open.";
|
||||
|
|
Loading…
Reference in New Issue