Enable MA0104 and silence remaining cases

"Do not create a type with a name from the BCL"
This commit is contained in:
YoshiRulz 2024-07-03 21:08:19 +10:00
parent 1be3531e7c
commit c0b676647b
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
5 changed files with 9 additions and 1 deletions

View File

@ -307,7 +307,7 @@ dotnet_diagnostic.MA0102.severity = silent
# Use SequenceEqual instead of equality operator
dotnet_diagnostic.MA0103.severity = error
# Do not create a type with a name from the BCL
dotnet_diagnostic.MA0104.severity = silent
dotnet_diagnostic.MA0104.severity = error
# Use the lambda parameters instead of using a closure
dotnet_diagnostic.MA0105.severity = error
# Avoid closure by using an overload with the 'factoryArgument' parameter

View File

@ -11,7 +11,9 @@ namespace BizHawk.Client.Common
// user -> Input -> ActiveController -> UDLR -> StickyXORPlayerInputAdapter -> TurboAdapter(TBD) -> Lua(?TBD?) -> ..
// .. -> MovieInputSourceAdapter -> (MovieSession) -> MovieOutputAdapter -> ControllerOutput(1) -> Game
// (1)->Input Display
#pragma warning disable MA0104 // unlikely to conflict with System.Windows.Input.InputManager
public class InputManager
#pragma warning restore MA0104
{
// the original source controller, bound to the user, sort of the "input" port for the chain, i think
public Controller ActiveController { get; private set; }

View File

@ -4,7 +4,9 @@ using System.Windows.Forms;
namespace BizHawk.Client.EmuHawk
{
// http://www.codeproject.com/Articles/2130/NET-port-of-Joe-s-AutoRepeat-Button-class
#pragma warning disable MA0104 // unlikely to conflict with System.Windows.Controls.Primitives.RepeatButton
public class RepeatButton : Button
#pragma warning restore MA0104
{
private readonly Timer _mTimer;
private bool _down;

View File

@ -1,6 +1,8 @@
namespace BizHawk.Common
{
#pragma warning disable MA0104 // unlikely to conflict with System.Windows.Media.Colors
public static class Colors
#pragma warning restore MA0104
{
/// <remarks>This is just <c>Color.FromArgb(alpha, red, green, blue).ToArgb()</c> with extra steps.</remarks>
public static int ARGB(byte red, byte green, byte blue, byte alpha = 0xFF) => unchecked((int) ((uint) (alpha << 24) | (uint) (red << 16) | (uint) (green << 8) | blue));

View File

@ -7,7 +7,9 @@ using System.Runtime.CompilerServices;
namespace BizHawk.Common.CollectionExtensions
{
#pragma warning disable MA0104 // unlikely to conflict with System.Collections.Generic.CollectionExtensions
public static class CollectionExtensions
#pragma warning restore MA0104
{
public static IOrderedEnumerable<TSource> OrderBy<TSource, TKey>(
this IEnumerable<TSource> source,