15f69cf80e
put bad code back in that keeps a stopped movie hanging around in memory, until tastudio is refactored. This "fixes" a lot of crash bugs when opening movies with tastudio
2020-04-28 17:12:50 -05:00
ba17c1fe2b
MovieSession - simplify gambatte name getting
2020-04-20 09:20:00 -05:00
72c4e19183
MovieSession - hold on to a copy of the IEmulator instance, and use it instead of Global.Emulator
2020-04-20 09:20:00 -05:00
91dd8c938e
MovieSession.QueueNewMovie - reduce dependencies
2020-04-19 14:18:09 -05:00
70633419ac
Refactor TasMovie and add interface ( #1940 )
...
* create ITasMovie interface, still lots of todos
* interface for TasMovie.ChangeLog
* rename method
* interface more TasMovie things
* file rename
* interface more ITasMovie things
* make Bk2Movie and TasMovie internal, rely on interfaces for behavior and MovieService for instantiation
* MovieService cleanup
* cleanup TasBranch handling and simplify ITasMovie api
* more branch logic cleanup and ITasMovie simplificaiton
* more cleanup of branch handling
* more ITasMovie simplification
* nitpick cleanup
* Use IMovie.GetInputLogEntry instead of GetLogEntries
* more ITasMovie cleanup
* move come ITasMovie properties to TasBranchCollection
* TasMovie cleanup
* simplify ITasMovie more
* cleanup
2020-04-19 13:38:45 -05:00
918fbe6367
fix Tastudio .tasproj loading broken in previous commits (this code is a mess), MovieSession - remove setter on Movie property
2020-04-18 15:37:43 -05:00
4e3aa0eb15
move Bk2 -> TasMovie conversion logic from Tastudio to MovieSession, fix crashing when loading .bk2 movies from the tastudio menu
2020-04-18 14:50:25 -05:00
7a77861896
Conisstently use MovieSession.StopMovie instead of stopping the movie directly, derefrence the movie on stopping instead of letting it hang around in memory
2020-04-18 14:50:25 -05:00
1611ff3aef
IMovieSession - rename a property, add documentation
2020-04-18 14:50:25 -05:00
fa552cab81
restrict access to IMovieSession.QueuedMovie
2020-04-18 12:05:16 -05:00
dc9fa1acf3
movie code cleanup
2020-04-18 11:54:49 -05:00
189a47ad3c
move more movie loading logic out of Mainform and into MovieSession and also some extension methods
2020-04-18 11:25:37 -05:00
3ec6662dc9
move core preference setting shenangians from MainForm.StartNewMovie() to MovieSession
2020-04-18 10:55:41 -05:00
d50bf21da9
move some logic from mainform to moviesession, remove TasMovie check that makes no sense
2020-04-18 10:09:47 -05:00
19095bb7e5
simplify
2020-04-18 09:55:57 -05:00
9928a88d2c
simplify movieSession core preference shenanigans
2020-04-18 09:55:57 -05:00
dfe7f8e3ab
refactor core preferences to be a dictionary<string, string> to be stored in config, and consolidate subnes and subgb into just another core selection
2020-04-18 09:55:57 -05:00
b736d48911
use constants for core string names and simplify core core name getting logic
2020-04-18 09:55:57 -05:00
eb3ddab060
Cleanup IMovieSession method names to be a bit more conscise
2020-04-16 12:25:42 -05:00
0aa8d71a3f
more MovieSession refactoring
2020-04-15 20:37:50 -05:00
0d794f2b12
refactor MultitrackRecording to keep up with PlayerCount rather than use Globals
2020-04-15 18:06:31 -05:00
5c5d662f1b
MovieSession cleanup
2020-04-15 14:41:57 -05:00
c0fde42a0c
don't expose Bk2Controller, clients need to depend on an interface and rely on the Movie (well, MovieSession currently) to generate an IMovieController instance, since different implementations of IMovie need to be able to create their own controller implementations
2020-04-14 21:35:44 -05:00
f2e52988c1
simplify some IMovieSession stuff
2020-04-14 21:23:47 -05:00
189a2d7cfc
nitpick
2020-04-14 21:15:56 -05:00
ab7225c955
remove MovieSession convenience property that isn't that convenient anyway
2020-04-14 20:58:02 -05:00
0d2f014621
refactor Bk2LogEntryGenerator to be stateless, refactor some IMovieSession shenangians
2020-04-14 20:50:21 -05:00
cdfeda8b71
rename IMovieController methods and classes to better describe what they are
2020-04-14 20:10:50 -05:00
aa80c3a0d6
majorly refactor Bk2Controller more
2020-04-14 19:33:49 -05:00
13e58cbac5
refactor IMovieController
2020-04-14 19:05:17 -05:00
2b17c6d310
simplify some LogGenerator code
2020-04-14 16:44:37 -05:00
4152dce1ca
Simplify some core name shenanigans with an extension method
2020-03-15 18:18:00 -05:00
6d5c444252
Move Global controller adapters into InputManager, it's a step in the right direction
2020-03-15 17:50:48 -05:00
1f617221fc
Make InputManager not static, but make a static instance in globals, phase 1 of some refactoring
2020-03-15 17:19:11 -05:00
079a0a4104
HeaderKeys - CONSTANTSDONTNEEDTOBEALLCAPS
2020-03-01 16:36:47 -06:00
8b59754349
warn about mismatching cycle counts for gambatte
2020-02-08 20:02:00 +03:00
f43d7c5b1b
MovieSession - add a PopupMessage method, will be used later
2020-02-08 10:50:05 -06:00
6990b6f51f
when loading GB/GBC movies, store the core and auto-switch between gamebatte and gbHawk, fixes #1805
2020-02-02 12:27:45 -06:00
880f584674
cleanup variable naming in IMovieSession
2020-02-02 12:19:41 -06:00
45221eb0ad
do non-timeline movie state logic after the core is loaded, fixes input display when loading a state in read-only mode, which has been broken since 2014
2020-02-02 11:52:05 -06:00
4c9ebf6ed4
MovieSession - rename hacky step 1 and 2 to meaningful names
2020-02-02 11:39:54 -06:00
8f7b0aaac9
Movie Session - move some logic out of hacky step 1 and into hacky step 2
2020-02-02 11:38:12 -06:00
8c99e87867
MovieSession - cleanup
2020-02-02 11:06:30 -06:00
32f638107d
delete unused code in MovieSession
2020-02-02 11:04:29 -06:00
ef13754f79
consistent variable naming in config.cs
2020-01-25 10:57:39 -06:00
a8408ed3be
Improve exception docs in BizHawk.Client.Common
2020-01-02 21:51:27 +10:00
b80b367831
refactor IMovie to expose the movie mode, and make extension methods that do IsPlaying type logic. This way there can be direct checks, and more variety of methods without cluttering the interface
2019-12-21 16:34:29 -06:00
64f32983f6
misc movie code cleanups
2019-11-25 08:37:11 -06:00
ab9c7699ec
misc cleanups
2019-11-15 15:15:13 -06:00
00691b58a2
misc cleanups in Client.Common movie and watch files, mostly typos and C#7isms
2019-10-31 19:25:11 -05:00
adelikat