ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

IMovieSession - rename a property, add documentation

This commit is contained in:
adelikat 2020-04-18 13:11:50 -05:00
parent 5238d660cd
commit 1611ff3aef
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BizHawk.Client.Common/movie/MovieSession.cs
View File

@ -40,7 +40,7 @@ namespace BizHawk.Client.Common
public IMovie Movie { get; set; }
public bool ReadOnly { get; set; } = true;
public bool MovieIsQueued => _queuedMovie != null;
public bool NewMovieQueued => _queuedMovie != null;
public string QueuedSyncSettings => _queuedMovie.SyncSettingsJson;
public IMovieController MovieController { get; set; } = new Bk2Controller("", NullController.Instance.Definition);

5
BizHawk.Client.Common/movie/interfaces/IMovieSession.cs
View File

@ -8,7 +8,10 @@ namespace BizHawk.Client.Common
IMovie Movie { get; set; }
bool ReadOnly { get; set; }
bool MovieIsQueued { get; }
/// <summary>
/// Gets a value indicating whether or not a new movie is queued for loading
/// </summary>
bool NewMovieQueued { get; }
/// <summary>
/// Gets the sync settings from a queued movie, if a movie is queued

6
BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -2269,7 +2269,7 @@ namespace BizHawk.Client.EmuHawk
private void CoreSyncSettings(object sender, RomLoader.SettingsLoadArgs e)
{
if (MovieSession.MovieIsQueued)
if (MovieSession.NewMovieQueued)
{
if (!string.IsNullOrWhiteSpace(MovieSession.QueuedSyncSettings))
{
@ -3608,7 +3608,7 @@ namespace BizHawk.Client.EmuHawk
// movies should require deterministic emulation in ALL cases
// if the core is managing its own DE through SyncSettings a 'deterministic' bool can be passed into the core's constructor
// it is then up to the core itself to override its own local DeterministicEmulation setting
bool deterministic = args.Deterministic ?? MovieSession.MovieIsQueued;
bool deterministic = args.Deterministic ?? MovieSession.NewMovieQueued;
if (!Tools.AskSave())
{
@ -3774,7 +3774,7 @@ namespace BizHawk.Client.EmuHawk
JumpLists.AddRecentItem(openAdvancedArgs, ioa.DisplayName);
// Don't load Save Ram if a movie is being loaded
if (!MovieSession.MovieIsQueued)
if (!MovieSession.NewMovieQueued)
{
var movieIsActive = MovieSession.Movie.IsActive();
if (File.Exists(Config.PathEntries.SaveRamAbsolutePath(loader.Game, movieIsActive)))