move some logic from mainform to moviesession, remove TasMovie check that makes no sense

This commit is contained in:
adelikat 2020-04-18 10:09:47 -05:00
parent 3940187800
commit d50bf21da9
2 changed files with 5 additions and 7 deletions

View File

@ -227,6 +227,11 @@ namespace BizHawk.Client.Common
/// <exception cref="MoviePlatformMismatchException"><paramref name="record"/> is <see langword="false"/> and <paramref name="movie"/>.<see cref="IMovie.SystemID"/> does not match <paramref name="emulator"/>.<see cref="IEmulator.SystemId"/></exception>
public void QueueNewMovie(IMovie movie, bool record, IEmulator emulator)
{
if (movie.IsActive() && movie.Changes)
{
movie.Save();
}
if (!record) // The semantics of record is that we are starting a new movie, and even wiping a pre-existing movie with the same path, but non-record means we are loading an existing movie into playback mode
{
movie.Load(false);

View File

@ -11,13 +11,6 @@ namespace BizHawk.Client.EmuHawk
{
public bool StartNewMovie(IMovie movie, bool record)
{
// SuuperW: Check changes. adelikat: this could break bk2 movies
// TODO: Clean up the saving process
if (movie.IsActive() && (movie.Changes || !(movie is TasMovie)))
{
movie.Save();
}
try
{
MovieSession.QueueNewMovie(movie, record, Emulator);