9fa4bac8d4
Path extensions - address nullability in a few places
2020-03-15 15:47:12 -05:00
33a14327b7
move most logic from PathManager to extension methods in BizHawk.Common
2020-03-15 15:45:11 -05:00
348cbd18df
Remove PathManager code that had dependencies on Globals ( #1881 )
...
* move one usage of Firwmare method into Firmware config where it is better suited
* PathManager - remove unused code
* move some PathEntry specific logic out of PathManger and into PathEntryCollection extension methods
* PathManager - detangle some exe pathing logic from Global.Config usage, clarify what a completely broken method should actuall do
* move more logic from PathManager to PathEntryCollection extension method
* move absolute path creation to PathEntryCollection, lots of refactoring and simplifying of PathEntries usage
* simplify PathEntryColleciton usage more
* simplify PathEntryCollection more
* break PathEntry classes into separate files, a bit of cleanup
* move Rom path logic out of PathManager into PathEntryCollectionExtensions
* move config UseRecentForRoms and LastRomPath into PathEntries, note that this is a breaking change for previous configs, those values will revert back to default values
* move SaveRamPath logic from PathManager to PathEntryCollections
* move cheats path logic from PathManager to PathEntryCollection
* move another method out of PathManager
* move some Retro hacks to PathEntryCollections, exposes more implicit dependencies
* move savestate logic out of PathManager to PathEntryCollection
* move more logic out of PathManager
* move some savestate logic out of PathManager, move most to MainForm where it is used, detangle some implicit dependencies from SaveSlotManager
* rename method
* move more logic from PathManager to PathCollectionEntry
* movie final Global.Config.PathEntries logic out of PathManager and into PathEnties
2020-03-15 15:12:36 -05:00
38e89f01ee
quicknes: add jetson's to blacklist
2020-03-15 11:24:12 -04:00
c66243254c
remove unused GameInfo parameter in some core constructors
2020-03-15 10:19:01 -05:00
f4b1d3f747
oops, meant to check this in
2020-03-15 10:15:30 -05:00
d3f37a5beb
remove CoreComm.Clone(), it is now safe to pass around into subcores
2020-03-15 10:12:20 -05:00
3c519b0249
refactor CoreFileProvider instantiation, require ICoreFileProvider in CoreComm constructor and remove setter for CFP
2020-03-15 10:09:32 -05:00
8c7b0c6ff1
delete some vestigial coreComm/CoreFileProvider code
2020-03-15 09:57:54 -05:00
983a9a3a11
fix CoreComm documentation
2020-03-15 09:48:18 -05:00
3c638f018f
refactor CoreComm usage in remaining cores
2020-03-15 09:44:47 -05:00
79aec475a9
refactor CoreComm usage in sega cores
2020-03-15 09:42:48 -05:00
899f8662c0
refactor CoreComm usages in more cores
2020-03-15 09:38:54 -05:00
c532b96245
refactor CoreComm usage in nes cores
2020-03-15 09:35:12 -05:00
b5c0bfa141
remove coreComm from N64 core
2020-03-15 09:32:29 -05:00
8973e5e521
refactor CoreComm usage in GBHawk and related cores
2020-03-15 09:31:07 -05:00
028bc83c88
refactor CoreComm usage in some Gameboy cores
2020-03-15 09:28:27 -05:00
5886416cbf
refactor CoreComm usage in more cores
2020-03-15 09:22:58 -05:00
8833ce61c4
refactor coreComm in waterbox
2020-03-15 09:16:45 -05:00
095b22d489
refactor CoreComm usage in atari cores
2020-03-15 09:14:33 -05:00
9fa59bad42
refactor CoreComm usages in Computer cores
2020-03-15 09:10:13 -05:00
d6af18accb
remove CoreComm from MAME, easily added back if firmware is needed
2020-03-15 08:58:17 -05:00
0a33940704
remove CoreComm from IEmulator, and remove it from NullEmulator
2020-03-15 08:54:56 -05:00
da95c1f56f
remove RomAnnotation fields on CoreComm and use the service instead
2020-03-14 22:10:57 -05:00
015043fd50
add IRomInfo service
2020-03-14 21:43:53 -05:00
42dc7edd23
pass in rom annotation details to Octoshock so it can set coreComm, ideally the core should figure all this out but this works okay
2020-03-14 21:36:51 -05:00
3cacb88e48
a few cleanups in octoshock
2020-03-14 21:27:05 -05:00
6360d9934c
simplify MainForm UpdateDumpIcon() some
2020-03-14 21:05:22 -05:00
fb5e1abedb
Update Usage > Cores section
2020-03-15 08:28:22 +10:00
a884282fa4
remove CoreComm NominalX/Y, those values never different from buffer w/h for cores that set them which were only the gb/gba platforms and the original dualGb. The result defaulted to a very random 640x480. Instead just use the buffer w/h, which is a very reasonable video default
2020-03-14 17:06:42 -05:00
dd062b3ca7
replace CoreComm screenofsets with an emulator service
2020-03-14 16:35:54 -05:00
870d7df6f2
cleanup some unneeded code
2020-03-14 16:09:25 -05:00
190118d7c4
rip out libretro hack from CoreComm, making it a param on LoadRom isn't great but better
2020-03-14 15:43:17 -05:00
fc0e0840e0
delete more stuff that is no longer used in CoreComm
2020-03-14 15:29:43 -05:00
9037c82985
use switch expressions on CoreSystemEnum converters, and add some enums that haven't been there for a long time (does anyone use this?)
2020-03-14 15:24:46 -05:00
2c007e5049
remove a few more psp references
2020-03-14 15:18:58 -05:00
d8d12cac8b
kill more psp, and remove some methods from coreComm that were only used by the former psp core
2020-03-14 15:14:31 -05:00
9825963261
kill off the dead PSP core
2020-03-14 15:10:29 -05:00
211883889b
simplify CoreCom copying by implementing a Clone method, simplifies all the cores that have cores in them, this copies a lot more things than the original code had but it seems that's either fine or fixing broken stuff
2020-03-14 15:08:24 -05:00
a50467846c
simplify CoreFileProvider
2020-03-14 14:50:50 -05:00
235ff78e9f
Simplify CoreFileProvider - make Firmware private and an explicit dependency
2020-03-14 14:27:13 -05:00
6c5dc8532f
remove some useless regions
2020-03-14 14:23:13 -05:00
d72d8e79ff
remove Global.Game from retro methods of CoreFileProvider, fix exposed bug that the retroarch core was getting path stuff based on Global.Game before it was being set to the new game
2020-03-14 14:22:23 -05:00
cd7d907c0d
get rid of CoreFileProvider SubFileDirectory
2020-03-14 14:02:19 -05:00
e655ad3abd
remove obsolete ICoreFileProvider.PathSubfile(), and instead pass in the neccessary base path the the bsnes core that needs it
2020-03-14 13:56:20 -05:00
b2066d9a73
remove obsolete ICoreFileProvider string GetFirmware method and replace the one usage for ti83 shenangians with an inline FirmwareManager usage
2020-03-14 12:39:45 -05:00
104689655f
remove unused ICoreFileProvider method and implementation
2020-03-14 12:29:30 -05:00
eba20781b4
add to ICoreFileProvider and remove casting to CoreFileProvider shenanigans in RomLoader
2020-03-14 12:28:19 -05:00
16781fa212
FirmwareManager - don't depend on Global.Config
2020-03-14 12:20:28 -05:00
d1623c32b7
Firmwares manager - depend on Global.Config less
2020-03-14 12:10:53 -05:00
adelikat