250b839e2c
Extract method from `LoadBranchToolStripMenuItem_Click`
2023-01-03 06:49:29 +10:00
007d862c58
Finish renaming quicksave slot 0 to 10 ( resolves #3112 )
2023-01-03 06:49:28 +10:00
7f33a8836d
Invert some conditionals in `MainForm` to reduce indent level
2023-01-03 06:49:28 +10:00
fcf7ac1fab
Change first param of `{Save,Load}QuickSave` from string to int
...
also swapped bool params of `SaveQuickSave`
2023-01-03 06:49:28 +10:00
22ba0d5c25
Dedup click handlers for `File` > `Save State` and `Load State`
...
`File` > `Save Slot` already did this
2023-01-03 06:49:28 +10:00
4b30cab993
Check the correct integer type for tastudio.setplayback
...
New lua actually has integers so this is a long instead of a double
2022-12-31 18:10:36 -08:00
05ff3ab40c
merge some mGBA upstream commits, partially revert c891cc2cb5 (upstream commits makes our changes not really needed)
2022-12-22 20:26:11 -08:00
00d450075e
oops forgot a colon here
2022-12-21 00:43:52 -08:00
c7c5ed229d
add pc2 extension for wonderswan
...
these are pocket challenge v2 roms, which is some handheld system which is actually just a wonderswan inside so these roms work anyways with cygne
2022-12-21 00:41:42 -08:00
603530d540
set gcAllowVeryLargeObjects to allow 2GB+ arrays
2022-12-21 07:43:34 +01:00
79857a3b71
Revert "make a new "FixedGrowthList" and use it for the StringLogs"
...
This reverts commit da5fae0b01
2022-12-21 07:42:31 +01:00
66c19cfcb2
Support marshalling arrays of length 0 through BizInvoker
...
Such arrays will be marshalled with valid and unique pointers that can be compared but not read from or written to.
2022-12-20 18:04:41 -05:00
5b0fe947df
fix #3498
2022-12-20 10:40:03 -08:00
6678fb4296
More cleanup of switch in `RetroAchievements.SystemIdToConsoleId`
2022-12-20 18:58:17 +10:00
7703ee5f37
Refactor `IGameboyCommon.IsCGBMode`
2022-12-20 18:58:17 +10:00
a54c94230f
Restore system menu behaviour re: SGB
...
fixes 81fe56fa6
2022-12-20 18:58:12 +10:00
81fe56fa6e
provide correct sysid in BsnesCore
2022-12-20 04:22:23 +01:00
aa0e2d6a5f
Use new CartRAM domain name in GBHawk's CDL impl. ( fixes #3497 )
...
fixes 7e00b7892
2022-12-19 13:20:37 +10:00
cee263e272
oops didn't mean to checkin this experiment (it doesn't do anything actually)
2022-12-17 21:53:47 -08:00
339915c013
check-in NLua to main repo
...
combine NLua with KeraLua (KeraLua is "gone" now I guess)
make it use the BizInvoker (so now it can properly handle the liblua5.4.so and lua54.dll names differing), also delete the liblua54.so.
minor speedup when creating a new empty table
make lua default to UTF8 internally, so we don't need to manually change the state's encoding
2022-12-17 21:51:10 -08:00
a1da5753ee
check-in NLua to main repo
...
combine NLua with KeraLua (KeraLua is "gone" now I guess)
make it use the BizInvoker (so now it can properly handle the liblua5.4.so and lua54.dll names differing), also delete the liblua54.so.
minor speedup when creating a new empty table
make lua default to UTF8 internally, so we don't need to manually change the state's encoding
2022-12-17 21:50:56 -08:00
55fdcbb3d1
Don't set modifiers for key release events
...
this fixes a bug in 1df6ce4e38
2022-12-18 06:03:55 +01:00
8db15d6951
Show warning dialog when running as Superuser/Administrator
2022-12-18 12:21:43 +10:00
767e30eee5
Also rename bundled CPC firmware files (see #3494 )
...
fixes 5be8b0aab
2022-12-18 12:02:23 +10:00
8d5f7b5478
make selecting user shaders not crash with the default empty string path
...
Path.GetDirectoryName throws if it is handed an empty string apparently
2022-12-17 12:16:03 -08:00
a680739c6e
Rename bundled ZX Spectrum firmware file ( resolves #3494 )
...
fixes 5be8b0aab
2022-12-17 22:47:57 +10:00
58beef8a46
remove speex use in melonDS (see 5f0e6a2242 for unmanaged side changes)
2022-12-16 23:04:35 -08:00
5e9e9ac289
remove libspeexdsp use in old bsnes core
2022-12-16 20:45:25 -08:00
c794d90878
Revert switch to system-wide Lua install on Linux
...
reverts ab355d46925795d237
2022-12-17 13:35:14 +10:00
25795d2372
remove GetErrorMessage call for Linux dep checks
2022-12-16 15:26:11 -08:00
ab355d4693
check some system lib deps on Linux and force user to provide their own liblua54 from package managers
2022-12-16 15:03:39 -08:00
767cc9059d
Improve handling of RA http requests, add some handling in case RA sound files are missing. Normally this shouldn't be needed as docs specify if the wav file fails to load it plays the default beep sound, except actually it just throws in practice???
...
The 2.9 rcs apparently have the "overlay" folder missing, so the sound files aren't present. I'm assuming there's some issue with build scripts there for releases...
2022-12-15 23:45:29 -08:00
f3ee3e7956
mGBA update, various cleanups and some reorg
2022-12-15 01:00:36 -08:00
f6503adfb8
Update virtualpads immediate when the movie status changes, huge improvement when using tastudio and virtualpad together as the record checkbox toggle now changes the readonly status of the pad
2022-12-13 08:39:29 +10:00
27f6800d45
fix #3489 (InitializeWork is called by itself for each gamedb file #include'd, so the event would have been set once the first gamedb file is loaded, oops), do some other cleanup here
2022-12-10 23:42:08 -08:00
b3c7f0fa48
IPlatformLuaLibEnv -> ILuaLibraries / Win32LuaLibraries -> LuaLibraries, cleanup usage of it, fix doc error in client.gettool
2022-12-10 21:46:22 -08:00
f101cb5a54
Additional corrections to newly-added Lua documentation
...
fixes 49cd836e1c7781d1c1
2022-12-11 13:35:29 +10:00
cbb335fec2
Fix Lua `require` not looking in Lua dir on Linux
...
see #3485
thanks to @CasualPokePlayer for research and initial implementation
2022-12-11 13:16:07 +10:00
9e4836d300
libretro handling cleanup, reorg some of this, fix some input cases, better domain names
...
funsie found in this cleanup: can't use `in` params with the BizInvoker as it doesn't like the read only semantics (results in some exception in CreateType)
2022-12-10 04:45:00 -08:00
64d693e63f
call retro_unload_game before retro_deinit (libretro api specifies retro_unload_game be called before retro_deinit, in practice cores don't really care but best fix this)
2022-12-08 23:18:37 -08:00
29443dae49
fix #3484
2022-12-08 14:26:23 -08:00
c4f4c793da
Remove unused `IPlatformLuaLibEnv` implementation
2022-12-09 05:41:49 +10:00
5197c36a5d
Remove `[Lua*StringParam]` as they're no longer relevant
...
fixes 45fbdb484
2022-12-09 05:40:31 +10:00
5c0143d6f6
Minor corrections to newly-added Lua documentation
...
fixes 1452f831a82c3b471ab687dea1b49cd836e1
2022-12-09 05:28:36 +10:00
49cd836e18
log warning when using the deprecated lua bit functions
2022-12-08 04:26:54 -08:00
56d66ca555
add reset support to libretro, resolves #3482
2022-12-07 19:54:59 -08:00
4caa99afe3
Remove Lua in Mono warning as it's no longer relevant
...
fixes 45fbdb484
2022-12-07 18:46:25 +10:00
01ab9416b5
Make script paths in .luases relative to .luases path
...
Restore behavior before 99dc0e03df
2022-12-07 18:24:21 +10:00
df4df517b8
Add `IMovieApi.PlayFromStart`/`movie.play_from_start` ( resolves #384 )
2022-12-07 18:16:13 +10:00
7fdc3f992d
Propagate success through to caller for movie load/restart
2022-12-07 18:16:13 +10:00
0076c8802b
Add `saveChanges` parameter to `IMovieApi.Stop`/`movie.stop`
2022-12-07 18:16:13 +10:00
e0a7a39b0d
Have `IMovieApi.Stop` implementation use `MainForm.StopMovie`
2022-12-07 18:16:13 +10:00
596e8d9198
Call `onexit` and cleanup when removing lua script
2022-12-07 18:15:31 +10:00
50fc7e28da
Make "Stop all scripts" behave the same as toggling them off
2022-12-07 18:15:31 +10:00
817b258a79
Remove relative path manipulation in `LuaConsole`
2022-12-07 18:15:31 +10:00
f625771cd0
Don't create FileSystemWatcher for missing directories
2022-12-07 18:15:31 +10:00
cf2b83b102
Disable lua script if loading fails
2022-12-07 18:15:31 +10:00
bd53807b0f
Store `LuaFile` `FileSystemWatcher` in dictionary
...
Avoid path string comparisons, `FileSystemWatcher` events may format relative paths differently
2022-12-07 18:15:31 +10:00
6aa7c48402
Update Lua registered functions window after restart
...
Make registered functions window show functions for new LuaImp after core restart/reopening the Lua console
2022-12-07 18:15:31 +10:00
ee66faba0b
Clean up old LuaImp before creating new one
...
Prevents memory/resource leak
Causes open forms to be closed on core restart
2022-12-07 18:15:31 +10:00
3a70fb65f8
Refactor disabling Lua script into separate method
2022-12-07 18:15:31 +10:00
7c7ac64ae6
Stop discarding Lua session save directory
...
Previously any path would into ".\foo.luases" and be saved in exe dir
2022-12-07 18:15:31 +10:00
9ee788195a
Improve Lua `FileSystemWatcher` thread safety
...
Make FSW invoke the entire event handler on main thread.
Avoids theoretical race condition and thread safety issues with the linq query.
2022-12-07 18:15:31 +10:00
733a8bee88
Dispose FileSystemWatchers in LuaConsole
2022-12-07 18:15:31 +10:00
28d6415190
Remove running scripts before loading session
...
Clean up scripts instead of just clearing script list
2022-12-07 18:15:31 +10:00
cc10de4033
Refactor removing Lua scripts into separate method
2022-12-07 18:15:31 +10:00
564a1e4a67
Remove obsolete `LuaConsole.RunLuaScripts`
...
Method is mostly a duplicate of `EnableLuaFile`, only called when loading a session or an already loaded script.
In either case it didn't actually start the scripts due to an inverted condition, and would stop running scripts without doing the required cleanup.
2022-12-07 18:15:31 +10:00
5d143ca879
Properly start scripts after loading Lua session
...
Previously, scripts would display as enabled but not actually run until toggled off and on.
2022-12-07 18:15:31 +10:00
0effd435f6
Fix issues when opening same Lua script multiple times
2022-12-07 18:15:31 +10:00
14e713837b
Change remaining `Config.DisableLuaScriptsOnLoad` refs to Settings
...
Resolve inconsistent use of duplicate property on `Config` and `LuaConsoleSettings`, finishes partial refactoring from 324a50a
2022-12-07 18:15:31 +10:00
a8e0192281
Use FLPs so UI scale doesn't break Record Movie dialog (see #2605 )
...
disables resizing the dialog; default is big enough and the `TextBox`es can
scroll
2022-12-07 15:43:25 +10:00
632f063073
Cleanup `RecordMovie` ctor
2022-12-07 15:43:24 +10:00
400b1b589b
Inline `RecordMovie.InitializeComponent` (Designer file)
2022-12-07 15:43:21 +10:00
102874e480
Fix N64 header detection being swapped ( fixes #3477 )
...
fixes abeaa2a10
2022-12-07 14:34:52 +10:00
62f6f3b471
Fix Win32LuaLibraries init'ing incorrectly on `DeveloperBuild = false`
2022-12-07 14:27:19 +10:00
def5df44fa
Fix double call to `UIHelper.ScaleX` in `ControllerConfig` (see #2605 )
...
fixes 93c47b87b
2022-12-07 05:29:27 +10:00
5e6c4a2bbd
fix justifier controller never working oops
2022-12-06 19:42:30 +01:00
96cc3f8745
BSNESv115: implement an extended gamepad controller with 4 extra buttons
...
this is a breaking change for existing movies, but only when a non-gamepad controller was used, which is rare
2022-12-06 19:21:08 +01:00
339994c5a7
change these to using var
2022-12-06 09:46:12 -08:00
b687dea1b0
change every IntPtr<->int cast to IntPtr<->long. we got 64 bit integers with lua now, and a pointer is 64 bits, so might avoid some dumb bug due to truncations and some ungodly amount of ram being used
...
TODO: see if we can skip this cast nonsense. the lua tests indicate IntPtr should pass through fine, being considered "userdata", probably better so the user can't just pass raw numbers for the handle.
2022-12-06 04:53:35 -08:00
bc79664461
fix implicit lua number to .net conversion
...
fix .net exceptions not halting the running script
fix inconsistency with stdout and lua console printing errors, both should end in a newline now
print the inner exception of a lua exception (i.e. the .net extension) if possible
2022-12-06 02:52:57 -08:00
eb00019c86
fix passing numbers for string args in .net lua functions (old engine had this behavior, granted "bad user" if they relied on this), add appropriate test
...
fix passing sbyte/char as args, add appropriate tests
cleanup the lua auto unlock hack, using a nice ref struct + dispose to handle it
2022-12-05 23:21:23 -08:00
920682688b
deprecate lua bit functions which have direct operator counterparts in new lua
2022-12-05 18:23:11 -08:00
dcd570bf87
fix mainmemory.write_bytes_as_dict
2022-12-05 16:46:22 -08:00
4a49fc174b
Improve LsmvImport in numerous ways
...
- previously, every second frame was empty (lol), since 2016 i believe
- now imports as (sub)bsnes115 movie instead of bsnes, allowing to import subframe inputs and delayed resets
- imports controller types correct(er)ly
2022-12-05 16:28:22 +01:00
10ba45d462
BSNESv115+: actually provide IBoardInfo properly
2022-12-04 22:48:29 +01:00
abeaa2a106
Be less lazy about N64 header detection in byteswapper
...
fixes 82c3b471a9660c16a0
2022-12-05 04:54:19 +10:00
9660c16a0a
fix N64 roms coming through multidisk bundler in ares
2022-12-04 01:35:58 -08:00
3dd36f5f07
revert the explicit try/finally use for PeekByte/PokeByte monitor domain methods, testing seems to show the ref struct use makes EnterExit allocation (now forced to the stack) a non-issue performance wise
2022-12-03 18:30:09 -08:00
f01463e2b3
Convert EnterExitWrapper to a readonly ref struct, this should be a speedup in all cases. Will need to experiment to see if this mean the try/finally from #3296 can be avoided
2022-12-03 17:46:49 -08:00
d508b734d6
Fix `MemoryApi.{Read,Write}ByteRange` edge cases
2022-12-04 09:23:28 +10:00
af44a85cfd
Add unit tests for `IMemoryApi.{Read,Write}ByteRange`
2022-12-04 09:23:28 +10:00
dc4efc3644
Fix typos and whitespace in `MemoryApi.cs`
2022-12-04 09:23:27 +10:00
1bdff05442
Use read-only collection types in `IMemoryApi`
2022-12-04 09:23:25 +10:00
cba206efec
Add `IUserDataApi.Keys`/`userdata.get_keys`
2022-12-04 04:06:58 +10:00
c2d5a9c931
Banish empty conditional blocks
2022-12-04 02:11:41 +10:00
84d2866f53
Clean up usage of `LuaFile.Enabled`/`Paused`
2022-12-04 01:43:02 +10:00
f798021bba
CloseRom acts like rebooting the core, so make it just reset Lua libs (more properly fixes #3226 without any yield nonsense)
...
Slight revert of 2efae13af4
2022-12-03 04:57:58 -08:00
15b2264cb4
Use LuaThread Yield here instead of directly using LuaState's
2022-12-02 19:45:29 -08:00
51f01efdc4
Properly handle errors when running a lua script, using Resume/Yield methods added to the LuaThread class (see f904fa0d53)
2022-12-02 14:44:05 -08:00
ae11dcc6af
replace default bsnes with bsnes115
2022-12-02 20:21:21 +01:00
6174398fb4
Also reset padding when removing last Lua script ( resolves #1509 )
2022-12-03 01:06:06 +10:00
a9756b60a2
Clear OSD + surfaces when removing a Lua script ( resolves #3014 )
...
they were already being cleared when closing the Lua Console
note the "Erase Stale/Stuck Lua Drawing Layers" button does not clear OSD,
leaving that as it is for now
2022-12-03 01:02:26 +10:00
2efae13af4
prevent some NREs occurring with the new Lua stuff
2022-12-01 14:59:36 -08:00
999e487557
Add `bizstring.pad_{start,end}` helpers
2022-12-02 06:18:32 +10:00
ca72f113df
Rename `event.onmemory*`, phase 1 ( resolves #759 )
2022-12-02 05:55:42 +10:00
6381448472
decimal is not floating-point
...
fixes fdbb34dff
2022-12-02 04:27:29 +10:00
5603e5ac01
Reorder items in Tools menu
2022-12-02 04:24:24 +10:00
3dcc3ff89f
Improve handling of exceptions thrown in `Form.Load` handlers
...
obviously only benefits forms inheriting `FormBase`
2022-12-02 03:48:36 +10:00
9393e1b764
Fix #3417 and improve handling of `default.tasproj` (squashed PR #3462 )
...
* Fix #3417 and improve handling of default.tasproj
* expose SetMovieController in the MovieSession interface (please don't rely on it anywhere else)
* don't use this explicit public in the interface
(is this mentioned anywhere? i assume this is proper style)
* use this helper function
2022-12-02 03:44:56 +10:00
10a38270e5
forgot a char
2022-12-01 19:12:45 +03:00
bace52c4f8
fix #2119
2022-12-01 19:10:57 +03:00
47c494a5a6
Bump System.Drawing.Common in main solution ( #3464 )
...
Bumps [System.Drawing.Common](https://github.com/dotnet/runtime ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/dotnet/runtime/releases )
- [Commits](https://github.com/dotnet/runtime/compare/v5.0.2...v5.0.3 )
---
updated-dependencies:
- dependency-name: System.Drawing.Common
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-02 01:22:46 +10:00
45fbdb4844
Move to NLua/KeraLua/Lua5.4 ( #3361 )
2022-12-01 00:51:02 -08:00
fdbb34dff6
Lua tests ( #3373 )
2022-11-30 23:55:24 -08:00
92c1cdff22
RetroAchievements Support ( #3407 )
2022-11-30 23:51:17 -08:00
eb1cef1ffc
update mame to 0.250
2022-11-30 20:22:04 -08:00
8667dd9ee7
c# to previous commit
2022-11-27 23:29:54 -08:00
6baee38717
add n64 to multidisk bundler list
2022-11-27 05:51:47 -08:00
9420c8b21c
merge latest ares, hook up its new N64DD support, make ares use AxisContraint (see #3453 ), some other cleanups here
2022-11-27 05:44:00 -08:00
c23b063733
basic virtualpad + default controls for TIC80, mark it as released
2022-11-26 19:54:45 -08:00
c49a8d338c
Prefix `socketServerScreenShot` blob with length too ( resolves #3461 )
...
fixes b1602dae0
2022-11-26 18:42:10 +10:00
b8182f9149
Extract `ConcatArray` helper
2022-11-26 18:42:05 +10:00
1df6ce4e38
Fix key release events with modifiers not getting handled correctly ( #3402 )
2022-11-25 11:00:44 +01:00
bae71326bf
Fix hex editor for MAME when Open Advanced is not used
2022-11-25 01:31:02 -08:00
9a0403617b
Clean up SHA1
2022-11-24 20:15:35 +10:00
4566b744d9
Remember trusted ext. tools
2022-11-24 20:06:27 +10:00
f9ac3c4b32
Clean up `MainForm.ExternalToolMenuItem_DropDownOpening`
2022-11-24 20:06:20 +10:00
e269bfd49f
Log window - when copying pasting "MD5:2345" and Sha1, strip the md5 and sha1 out. I just want the number if I'm copying pasting the single line. If someone finds this objectionable, feel free to revert, but this savesme a lot of time
2022-11-23 10:54:59 -06:00
392d126173
remove an unused method
2022-11-23 10:11:45 -06:00
683aa263a0
Include `ControllerDefinition._orderedControls` in clone ctor
...
I don't think this is used, but as the caching was new in 2.8, going to include
this just in case
2022-11-23 15:35:45 +10:00
52acda9a02
Re-add an assignment in `InputManager.SyncControls` ( fixes #3458 )
...
partially reverts 781c152bf
2022-11-23 15:29:02 +10:00
3f352792a6
remove unused using from experiments in previous commit
2022-11-22 09:18:51 -08:00
da5fae0b01
make a new "FixedGrowthList" and use it for the StringLogs
...
this is mostly to workaround OOM issues with VERY large movies (>134217728 frames).
so large just the list of string references is "too big" and exceeds the .net 2GB limit.
even the on disk method fails here, as the offsets list (note, long and reference are the same size) becomes too big
this probably gives a bit of speedup for "normal" movies, as the generous 16MB growth amount would likely be plenty for the movie, although i haven't test this much
2022-11-22 09:10:19 -08:00
b967e6028d
Fix inconsistent application of colours from GTK theme, if available
...
still no idea why I can set dark theme on Ubuntu but not Manjaro, but now menus
won't use a white-to-black gradient with white text
2022-11-23 02:51:54 +10:00
589823d009
GPGX: add setting to disable per-line sprite limit
...
- resolves #3440
- includes manually cherry-picked e0ef0902e96bd9d71cb49c64505e755007e7452c
2022-11-22 14:44:39 +01:00
248e87b6d1
try to load a different core if an autodetected mame rom ends up failing to load
2022-11-21 18:28:56 -08:00
51826c4c17
Fix wrong MBC5 mapper being given a battery
...
0x1A is MBC5+RAM, 0x1B is MBC5+RAM+BATTERY
2022-11-19 20:44:55 -08:00
0cb63e8d6a
BSNESv115+: Implement overscan and aspect ratio correction settings
2022-11-18 13:08:27 +01:00
0bd182e6cc
properly handle "NO GOOD DUMP KNOWN" mame rom hashes
...
(note, these roms are not actually in the romset, so the singular hash in movies doesn't have to be affected here)
2022-11-17 17:45:49 -08:00
d507246033
c# side for previous commit
2022-11-16 21:33:55 -08:00
d0266816a5
Fix #3448 . Support MAME 7z romsets
2022-11-16 17:32:20 -08:00
4479fec74d
Add in the actual c# code for 5ae4470466
...
Apparently forgot to actually add this in for the commit >:
2022-11-16 15:35:37 -08:00
62c3b4b8e3
Use a small dll for handling the msabi<->sysv adapter ( #3451 )
...
make a small dll for handling the msabi<->sysv adapter, using only assembly (taken from generated optimized rustc output) and handcrafted unwind information (c# exceptions in a callback seem to work fine in testing)
additionally, allow floating point arguments. this really only needs to occur on the c# side. msabi and sysv agree on the first 4 floating point args and for returns, so no work actually has to be done adapting these
with assembly being used, we can guarantee rax will not be stomped by compiler whims (and avoid potential floating point args from being trashed)
2022-11-16 09:02:13 -08:00
a0de42b1b3
remove struct hack, it's not actually needed
...
out double is System.Double& while double is System.Double, so it doesn't actually trip paramenter verifier
2022-11-15 01:12:31 -08:00
eec86ad81a
Use actual doubles for figuring out aspect ratio
...
Fixes issues when mame sends over < 1 bounds which round down to 0 with a long cast (resulting in div by 0 exceptions)
Also fix some oopsies with incorrect function signatures.
Remove MAME string docs as they aren't really relevant anymore, as only MameGetString handles lua string handling now
2022-11-15 00:57:30 -08:00
715f4f497c
add some missing mame mnemonics
2022-11-11 08:45:02 -08:00
c21fedc76a
BSNESv115+: add option for disabling ppu sprite limit
2022-11-10 23:22:17 +01:00
066297d5e7
MAME Waterbox ( #3437 )
2022-11-10 00:05:25 -08:00
e7e587d625
Restore old behaviour of "Always use recent path for ROMs"
...
fixes 41d46dd37#1574
2022-11-08 06:30:12 +10:00
948084a97e
Use `Movie.NotActive` extension instead of negated `IsActive`
2022-11-07 06:10:37 +10:00
84cc71e454
Use `DialogResult.IsOk` extension everywhere and clean up
2022-11-07 06:03:55 +10:00
36cb62a792
Create and use `ToolStripDropDownItem.ReplaceDropDownItems` extension
2022-11-07 06:03:55 +10:00
5df9879842
Refactor `MultiDiskFileSelector.BrowseButton_Click`
2022-11-07 05:27:15 +10:00
04f34ac7af
Add `Util.BreakDebuggerIfAttached` helper
2022-11-07 04:37:34 +10:00
f1f0f1695c
Encapsulate `OpenFileDialog`/`SaveFileDialog`
2022-11-05 09:10:11 +10:00
2db5235319
Cache and reuse `FilesystemFilterSet`s
2022-11-05 09:10:11 +10:00
1232157cc1
Improve caching of `FilesystemFilterSet.ToString`
2022-11-05 09:10:11 +10:00
c153505b58
Invert some conditionals to reduce nesting
2022-11-05 09:10:10 +10:00
df63853cd5
Add `IDialogParent` interface to a couple of config dialogs
2022-11-05 09:10:05 +10:00
8949b1aa6b
Make sure `CheckLib` in `Program` static ctor disposes GUI properly
2022-11-04 07:08:54 +10:00
c891cc2cb5
Don't ignore mGBA skip BIOS setting when recording ( resolves #2465 )
...
also disable skip BIOS with TAS profile and enable with Casual profile
also removed `DeterministicEmulation ||= !SkipBios`, does it matter?
2022-11-03 12:04:16 +10:00
77f824ab55
Clean up `MGBAHawk.DeterministicEmulation` assignment
2022-11-03 11:56:01 +10:00
13a01340de
Refactor Libretro ControllerDef generation, fixing input display
...
see #3360
2022-11-03 11:02:53 +10:00
781c152bf6
Remove old ControllerDef copying that was messing with ControlsOrdered
2022-11-03 11:02:52 +10:00
a8f571f2d6
Reinstate `GameInfo.NullInstance`'s name, and only instantiate it once
...
reverts 8dcea2470
2022-11-03 11:02:44 +10:00
3e79e68d1d
Dedup in `CheatEdit.GetCheat`
2022-11-02 01:05:12 +10:00
414c21609b
Disallow updating cheats when multiple rows selected ( resolves #1726 )
2022-11-02 01:01:09 +10:00
5ae23c63bf
Change "Edit" button in Cheats dialog to read "Overwrite"
...
kept the mnemonic because idk
2022-11-02 01:00:16 +10:00
fd2772707b
Update `forms.drawImageRegion` documentation with a diagram
...
only embeds on TASVideos Wiki, which I held off on updating because there are a
lot of changes and we can do them all at once
2022-10-30 18:19:23 +10:00
8ee75879e6
Rework MAME integration a bit
...
The periodic callback is now used as a way to service "commands" sent from the main thread
Upon servicing a command, the mame thread will set the current command to NO_CMD then wait for the main thread allow the mame thread to continue
During this wait, the main thread may optionally set the next command (done here for STEP -> VIDEO), ensuring the next callback will service that command
A dummy "WAIT" command can be sent to trigger this waiting behavior, allowing the main thread to safely touch mame while the mame thread is frozen (important for mem accesses and probably savestates?)
A/V sync is also reworked. We can assume that 1/50 of a second worth of samples will be sent each sound callback. We can also assume 1/FPS of a second worth of time will be advanced each frame advance
So, we can just give hawk 1/FPS worth of samples every GetSamplesSync, if they are available. If we have less (probable on first few frames), we'll just give all the samples, and hope it balances out later.
2022-10-29 17:07:50 -07:00
cc71882059
BSNES Memory Domain Fixes ( #3423 )
...
* Use SameBoy submodule symlink for BSNES
* SGB memory domains
* Fix SGB saveram issues (extra data like rtc will be saved correctly now here)
* Various cleanups, avoid unneeded unsafe use, a little better EnterExit use
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2022-10-28 19:22:49 -07:00
256a8617e9
Fix #3399 by always calling UpdateViewerMouseover
2022-10-27 01:30:41 +02:00
dd33e92a9f
ensure ClockRate in the Bk2Header uses . instead of ,
2022-10-21 02:34:59 -07:00
c8d4e606af
suppress updates while rebooting core, fixes #3424
2022-10-21 02:19:22 -07:00
f29113287e
add Jaguar to MultiDiskBundler menu
2022-10-11 21:51:26 -07:00
2b4d9c0c7d
Add debug utility to byteswap N64 roms
2022-10-11 10:12:49 +10:00
5b859960e9
Move types for debug menu to own files
2022-10-11 10:12:49 +10:00
82c3b471a5
Minor refactors to byteswapping (N64 rom loading and Lua bit library)
2022-10-11 10:12:45 +10:00
bb4ba2184f
Fix `forms.*` acting on every LuaPictureBox, not the specified one
...
fixes #3395
this has been broken since introduction in 2ddadeae2
2022-10-08 11:11:40 +10:00
7930a79cef
Prompt to disable cheats when starting movie playback ( resolves #3389 )
2022-10-08 10:42:10 +10:00
28c53cfa21
Fix `APIContainer.Comm` not having `HTTP`/`Sockets` on first boot
2022-10-06 11:53:11 +10:00
2fa46efda6
add jaguar db, change db parser to prefer the strongest hash available, fix potential edge case if a crc32: prefix is present (and simplify the code)
2022-10-04 22:05:38 -07:00
c547a20f8e
Use `LoadOther` for GBS files, cleanup the code a little, update SameBoy version info
2022-10-03 15:49:09 -07:00
9528a2030f
GBS support using SameBoy
2022-10-03 01:55:14 -07:00
0c6f0523a0
Update sameboy, expose audio channel enable/disabling, cleanup settings to go through a single call/struct
2022-10-02 21:40:00 -07:00
8732e561a1
Better Jaguar Virtual Width/Height
...
Jaguar VPad
Proper Jaguar default controls
Remove a lot of unneeded `ReSharper disable once UnusedMember.Global` in vpads (Global has been gone for a while now...)
Set VirtualJaguar to released
2022-10-02 18:53:34 -07:00
2e5c62f632
default Jaguar bios to not be skipped, some games rely on Jaguar bios running on boot
2022-09-30 23:54:13 -07:00
be771c134c
default to KSeries bios instead of MSeries bios, as it seems to be more compatible
2022-09-30 21:56:19 -07:00
5f509525bc
[virtualjaguar] less screen changing spam
2022-09-30 21:44:34 -07:00
158c897702
Use `Google.FlatBuffers` NuGet package and check in new Nyma codegen
2022-09-30 05:33:18 +10:00
5544bc526a
Add missing import
...
fixes 9e9e041bb
2022-09-30 03:52:05 +10:00
9e9e041bba
Fix AOoRE when loading TAStudio w/ cheats(?)
...
partially reverts dd4f9aaf6
2022-09-30 03:25:13 +10:00
f8a4524df7
add in missing platform framerates, add in Jaguar CD iding for movie file, fix aspect ratio for jaguar
2022-09-28 17:25:34 -07:00
79d43dab1d
Extract constants used for `NamedLuaFunction.Event`
2022-09-29 08:54:23 +10:00
9815b377d1
Also protect against mutation of `IEnumerable` for `onconsoleclose`
...
see 7a26546cfdc66b4357
2022-09-29 08:54:16 +10:00
7a26546cfc
Maybe fix mutation of IEnumerable (`InvalidOperationException`)
...
fixes 3024bc0d0
2022-09-29 05:21:08 +10:00
70a21ee07e
push c# side for memtrack support
2022-09-28 03:28:01 -07:00
9fa38b8d78
Fix #3398
2022-09-27 13:58:56 +02:00
b2bacdecd2
Fix double call to pure method
2022-09-25 22:26:41 +10:00
3cbdd36fe0
Deduplicate some code in `MainForm`
2022-09-25 07:04:21 +10:00
728f393eb1
Clean up `MainForm.CheckHotkey`
2022-09-25 07:04:21 +10:00
d7c79a5f03
Fix "Toggle All Cheats" hotkey behaviour re: separators
2022-09-25 07:04:13 +10:00
3122078dfd
tweak jaguar cpu tracelogger
2022-09-24 06:23:24 -07:00
ff5c8d4e52
more jag disasm tweaks
2022-09-24 04:38:06 -07:00
c92c2bf661
fix jag risc disasm
2022-09-24 04:30:05 -07:00
38b4b98fc0
minor touchups to jag risc disassembler
2022-09-24 04:29:00 -07:00
c9618b3f92
c# side to jag debugging improvements
2022-09-24 04:15:05 -07:00
6113f3c17b
partial jagcd support (doesn't seem to completely work here)
...
fix some issues with vjaguar cleanup
add mem/trace callbacks and get/set reg support
2022-09-23 01:05:41 -07:00
71e3dfed74
fix #3388
2022-09-18 22:44:26 -07:00
38d3d36199
fix opcode address in exec callbacks + tracing (thanks prefetch)
...
sp/lr/pc for r13/r14/r15 for tracing
fix a bad for threaded renderer's thread start callback
2022-09-18 02:39:31 -07:00
5e34dc6166
Always savestate expansion pak regardless of settings.
...
All the disable expansion pak setting actually does is tell the game the expansion pak is not available.
However, not all games actually abide by this, some will use the expansion pak area anyways.
Video plugins also end up just using a "segfault test" to determine if the expansion pak is present or not
So video plugins may use the expansion pak area too
This ends up causing savestates sometimes just crashing the game if the expansion pak ends up used
Resolves #3092 , other state issues might be solved with this (I suspect #3328 is caused by this)
2022-09-17 13:11:31 -07:00
de38781081
Implement Rumble for Nyma
2022-09-17 01:36:51 -07:00
de1e7eef69
Document socket response format
2022-09-16 22:37:15 +10:00
afccbe8aa6
Fix hang with "Go to Address" dialog in RamSearch
...
resolves #3384 , fixes cc4acd9c64
2022-09-14 19:39:03 -07:00
1bf2bb758c
Change serialisation of Jaguar VSystemID
...
also fixed line ending
2022-09-12 17:13:15 +10:00
483258a04d
virtualjaguar port, resolves #1907
2022-09-11 21:38:46 -07:00
34c504d7b9
update ds disassembler
2022-09-10 20:53:05 -07:00
d2965c2185
If dummy sound chosen in config, try DirectSound (maybe fixes #3379 )
...
- if DirectSound fails (i.e. dummy is in config for a reason), then skip the
error dialog as the user has probably seen it already, and set it back to dummy
- if DirectSound succeeds, leave it, it will be written to config (there's a
mute setting for people who really don't want sound)
- copied the init config code so s/DirectSound/OpenAL/ on Linux
- could probably try OpenAL on Windows when DirectSound fails but whatever
2022-09-08 08:39:25 +10:00
707ec53bd5
Move `SoundConfig.ApplyNewSoundDevice` logic to callsite
2022-09-08 08:23:01 +10:00
6f0953aaa3
Implement snes graphics debugger for the new bsnes core ( #3367 )
...
* Partial port of graphics debugger to new BSNES
* minimal "working" copy-paste
* small fix for the previous commit
* Implement more stuff
* no idea whose responsibility "EnterExit" is but this should work
* add support for backdropcolor
i have 0% trust in this code
* implement mode7, apply backcolor on load
* 🙈
un-"implement" the nonfunctional scanlinehookmanager as well as the non-functional palette setting logic
- this may actually break config lol
* don't break libsnes config
* Provide IBSNESForGfxDebugger in the subbsnes core
* Remove redundant semicolon
* Clean up diff of `comboPalette_SelectedIndexChanged`
* Fix crash
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
2022-09-03 19:13:56 +02:00
28d62e69d7
Enable menu mnemonics (Alt+X) for MainForm on Linux
2022-09-03 19:59:08 +10:00
f024986ffc
Added 'Edit marker frame' feature (squashed PR #3351 )
...
* Added 'Edit marker frame' feature
* Changed Edit Marker Frame icon to clock
* Hotkey tooltip + Prevent changing to a frame that already has marker
* Forgot to delete this icon, was replaced by Clock.png
* De-rookie here and there
* Clean up diff
2022-09-03 12:08:23 +10:00
09e8c7a9b6
ensure ds firmware settings represent sync settings if real firmware isn't used
...
resolves possible cause for #3377
2022-09-02 15:11:34 -07:00
70906c9004
quick fail is the user is somehow running EmuHawk as a 32 bit process
2022-08-29 17:01:26 -07:00
b588212e17
remove unused using (cruft from experimentation), remove unneeded enum values
2022-08-29 16:36:32 -07:00
e198122691
output a more helpful error message on windows for GetErrorMessage
2022-08-29 16:33:41 -07:00
06226e78cf
add way to obtain error message in ILinkedLibManager, use it to display an error code for init lib checks
2022-08-29 15:34:44 -07:00
463780a875
more cleanly deal with dummy hashes
...
fixes a515672
2022-08-28 03:13:23 -07:00
a515672d4d
fix #3159
2022-08-28 02:56:31 -07:00
14f470a9a7
Improve encapsulation of `ToolFormBase` props
2022-08-28 03:39:18 +10:00
faf4a8b24f
Remove unused "TAStudio states" path
...
TAStudio prop unused since 5bf21e391b1296dd9b
2022-08-28 03:09:59 +10:00
c761d6d807
fix changing mupen expansion pack setting
2022-08-26 13:30:44 -07:00
a344ee2288
Fix modifier key check in `TAStudio.TasView_MouseDown`
2022-08-24 09:44:24 +10:00
61c34eca74
Minor refactor to not mutate local in `TAStudio.TasView_MouseDown`
2022-08-24 09:44:17 +10:00
352977c7ea
speedup HashRegion/ReadByteRange/WriteByteRange for waterbox cores (doesn't do anything for non-wbx cores)
2022-08-23 03:09:23 -07:00
5906fd154e
Fix typo
...
fixes a95c4f182
2022-08-22 01:21:22 +10:00
afdfa065bd
missed apostrophe somehow
2022-08-19 23:46:03 -07:00
9174d17bd8
tic80 settings for enabling/disabling controllers, proper mnemonics
2022-08-19 23:43:55 -07:00
98a8cdf693
remove gongshell, add "simple" code for opening win32 context menu (gongshell's only actual use), re: #2261
2022-08-19 00:24:50 -07:00
64bc762439
Mute new MSB3270 warnings
...
no sure if these are the result of a .NET SDK update or my NuGet experiment
2022-08-18 17:16:40 +10:00
3a3494aedb
Add missing attribute to `events.can_use_callback_params` param
2022-08-18 17:12:15 +10:00
8d484ac196
Hardcode edge cases in `MovieConversionExtensions` to pass test
...
the argument in every real call is from `IMovie.Filename`, which is never
assigned null, and I don't think it's assigned anything but an absolute path
2022-08-17 19:05:32 +10:00
2ecb572892
fix nyma light guns, resolves #3359
2022-08-17 01:57:40 -07:00
7cde8bb466
Add and use 2 extension methods for splitting path into dir+filename
2022-08-17 17:35:07 +10:00
dce961357a
Refactor `IGameInfo.FilesystemSafeName` extension
...
it doesn't make any sense to split this string into dir+filename, it shouldn't
contain a slash
2022-08-17 17:35:07 +10:00
2b59cfc1c4
Small refactor in `DiscMountJob.RunBizHawk`
2022-08-17 17:35:07 +10:00
10478e23f1
Remove redundant dir exists checks
2022-08-17 17:35:07 +10:00
f228b01bdf
Rename `IMainFormForTools.SetWindowText` to `UpdateWindowTitle`
...
in practice there is only one implementation and it just called the other method
(which is inherited from `FormBase`)
2022-08-17 17:35:06 +10:00
d5bf542a3c
Cache `ToolStripRenderer` used by `FormBase.FixBackColorOnControls`
2022-08-17 17:35:06 +10:00
322ed164bf
Remove backing field of `FormBase.BlocksInputWhenFocused`
2022-08-17 17:34:59 +10:00
3958348e94
Add auto save state on close (squashed PR #3218 )
...
resolves #1861
* Add configuration for auto-saving state on exit
* Update MainForm to auto save on close game if configured
* Fix config serialization test.
* Revert unnecessary changes to Designer file
* Move autosave configuration into Save States menu off of File
* Undo previous test changes
* Remove explicit size on menu item.
* Fix logic
2022-08-17 14:27:50 +10:00
7ffa605b28
BSNESv115: fix crash when audio output is disabled
...
(fixes 039d822144
2022-08-17 01:35:02 +02:00
039d822144
BSNESv115+: Replace the 'snes_audio_sample' callback with a dynamic audio sample vector to reduce callbacks ( #3010 )
...
* BSNESv115+: Replace the 'snes_audio_sample' callback with a dynamic audio sample vector to reduce callbacks
* fix integration for subbsnes core
* reduce buffer allocations
- also make frame setter private now that it's possible
2022-08-15 20:50:26 +02:00
f1e11dfc36
simplify Stream.ReadAllBytes extension and use it more
2022-08-15 20:35:57 +02:00
31c7f59e86
fix some edge cases with new zip compression
2022-08-15 10:59:27 -07:00
0ff4aca182
[Gambatte] Remote control controls and remote control emulation expanded to HuC1 IR and CGB IR (previously only done in HuC3)
2022-08-15 02:49:34 -07:00
aba3359dde
Add CPP's testroms to GB testroms project
2022-08-14 16:21:27 +10:00
18a7201004
Fix building testroms project
...
fixes b8d5dd899
2022-08-14 00:33:12 +10:00
a5652ee3bc
Backport `IEnumerable.Order`/`OrderDescending` shorthand
...
at time of writing, in .NET 7 preview
https://github.com/dotnet/runtime/pull/70525
2022-08-13 02:18:26 +10:00
929432086f
BSNESv115: add dedicated subframe core ( #3281 )
...
* BSNESv115: allow subframe inputs
* BSNESv115: Implement ICycleTiming
may be correct, not sure
* BSNESv115: add dedicated subframe core
I have probably overlooked something...
* Don't implement ICycleTiming in the non-subframe core
requires re-implementing the "FrameAdvance" function in the subframe core
* Register previously missing services in the subframe core as well
* Wire up SubBsnes everywhere in the frontend
* Change reset cycle to reset instruction
* Deduplicate some code
* Slightly rework frame advance logic. The main intent here is to prevent a case where two frames are ran within a single "frame." The current code probably wouldn't crash due to that, but best not to do that.
Also make SGB work here. A bit of a joke since you really can only abuse it for subframe resets, but might as well especially with the settings implying it's possible (and someone is bound to complain).
Co-authored-by: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com>
2022-08-10 23:08:44 +02:00
1a27aae45b
update sameboy
2022-08-10 12:34:46 -07:00
afb0b8a435
maybe fix tests?
2022-08-10 02:55:01 -07:00
5be8b0aab9
Zstd Compression ( #3345 )
...
Deflate compression in rewinder is now zstd compression
Binary blobs in zip files are zstd compressed (text is uncompresed for user ease).
All wbx cores and resources are re-compressed with zstd, wbx build scripts are changed to account for this. Shaves off a bit with download size and it's faster to decompress to.
2022-08-09 23:33:28 -07:00
32e8afcedc
Implement hardware accelerated CRC32 and SHA1, using them if possible ( #3348 )
...
* Implement hardware accelerated CRC32 and SHA1, use them if possible.
CRC32's generic function is also replaced with zlib's as it is much more performant than our implementation
Full hash of a ~731MB disc took only ~369 ms with this, and the generic CRC32 isn't so far behind at ~659 ms
SHA1 should perform 4x faster if the user's CPU supports the SHA instructions.
Co-authored-by: YoshiRulz <OSSYoshiRulz@gmail.com>
Co-authored-by: Morilli <35152647+Morilli@users.noreply.github.com>
2022-08-09 23:30:17 -07:00
0236a820ec
Unindent `RomLoader.MakeGameFromDisc`
2022-08-06 09:22:51 +10:00
8f153fd503
Restore PS2 sysID and add some others from RomLoader
2022-08-06 09:22:51 +10:00
5cd37c76b2
dobie removal cleanup
...
fixes 89972a3579
2022-08-05 03:32:09 -07:00
1452f831af
Fix Lua Wiki export, add more notes to fill in some of the holes
...
frameadvance loop is documented now so for the first time you can write a script
without reading someone else's :O imagine that
2022-08-05 11:41:24 +10:00
7bb4b28093
Remove dumb in `MainForm.WindowTitle` so you can see FPS w/ chromeless
...
(window title is shown in the toolbar / application switcher on Win and Linux)
2022-08-05 07:23:43 +10:00
22a328cd36
Remove unused service props
...
unused since 1ce8a368d70e0954f2
2022-07-30 09:26:18 +10:00
5c48cb96fd
When starting new `.tasproj` from SaveRAM, don't clone array twice
2022-07-30 09:26:06 +10:00
d3c42f5dfc
Only shift right by 1 for volume with Gambatte, sounds very close to SameBoy, probably resolves #3338
2022-07-28 17:27:30 -07:00
ccc11be896
Explicitly discard required-but-unused `IStatable` service prop
2022-07-28 05:51:38 +10:00
787b413913
Change Basic Bot's addresses to `ulong?`
...
fixes empty address fields being saved as `0x0`, see #3326
2022-07-28 05:48:05 +10:00
5f572442c4
Save game info to `.bot` files and check when loading ( resolves #3340 )
2022-07-28 05:27:13 +10:00
140e340a8d
Add Analyzer rule to warn of `FirstOrDefault` on list of structs
2022-07-28 03:06:01 +10:00
8453c0e44d
Fix exception on opening Play Movie dialog with multiple movies
...
fixes 9211007a1
2022-07-27 05:08:33 +10:00
bd58bde07c
Hopefully block edge cases where global `GameInfo` is uninitialised
...
`Game == null` conditions in `MainForm` ctor looked unreachable, so I changed
them to `Game.IsNullInstance()` which is what I assume was intended, and added
an assert to `RomLoader` in case a bug is introduced later
2022-07-26 07:59:57 +10:00
d84da4ec4b
wire up sameboy's rumble
2022-07-25 00:10:46 -07:00
8dcea24703
Fix `GameInfo.NullInstance` having a name... why did it have a name
2022-07-25 11:15:19 +10:00
d796210437
Cancel tool loading when services aren't satisfied ( fixes #3329 )
...
also cleaned up other calls
2022-07-25 10:52:02 +10:00
070e7035b3
Ensure there can be no edge cases involving SGXCD sysID
...
breaks config, in case you care about setting a custom save dir for PCE
2022-07-25 08:15:24 +10:00
3d42b19797
Pass `VSystemID.Raw.NULL`, not `null`, for `SystemId`
2022-07-25 08:15:17 +10:00
cb468ba806
pull in latest sameboy master, add stub camera pixel callback to prevent nondeterminism, wire disabling joypad bounce as a sync setting, various cleanup
2022-07-24 04:35:03 -07:00
e2a36c7242
DisplayConfig defaults button should whack the padding back to 0
2022-07-22 16:38:42 -04:00
3b181ba6e4
DisplayManager - fix crashes when setting absurdly large padding values ( fixes #3321 )
2022-07-22 16:09:49 -04:00
6eafdf7156
Fixed issue where the Copy button in Basic Bot is not toggled on/off properly.
...
If the Copy button is enabled, but there is no best attempt recorded, it will crash BasicBot / EmuHawk if it attempts to copy a null Log of the best attempt.
2022-07-23 05:49:50 +10:00
d8fc32f1a8
[mGBA] Add in missing save types
2022-07-21 15:38:59 -07:00
0f6e6a5a03
Enable MA0084 and fix noncompliance (except in Cores)
...
"Local variable should not hide other symbols"
2022-07-22 07:28:32 +10:00
d142555ec3
Enable MA0066 and fix noncompliance
...
"Hash table unfriendly type is used in a hash table"
2022-07-22 07:28:31 +10:00
41d46dd37d
Fix `%recent%` in Paths config
...
broken since introduction in 017743133
2022-07-22 07:28:25 +10:00
9211007a18
Fix bug in `PlayMovie.PreHighlightMovie` heuristics
...
for the record, the bug was that it had `_movieList[indices[0]]` in the loop
instead of `_movieList[indices[i]]`
2022-07-22 05:06:05 +10:00
3f2a07e582
Fix remaining MA0098 code style warnings
...
"Use indexer instead of LINQ methods"
fixes 17df5673d
2022-07-22 04:51:56 +10:00
17df5673d2
Enable MA0098 and fix noncompliance
...
"Use indexer instead of LINQ methods"
2022-07-22 03:51:47 +10:00
ee11385f10
Enable MA0031 and fix noncompliance
...
"Optimize Enumerable.Count() usage"
2022-07-22 03:51:47 +10:00
b1ad34839a
Enable MA0029 and fix noncompliance
...
"Combine LINQ methods"
2022-07-22 03:51:47 +10:00
26b6a1c4a9
Enable MA0020 and fix noncompliance
...
"Use direct methods instead of LINQ methods"
2022-07-22 03:51:47 +10:00
697c10e3e6
Enable MA0015 and fix noncompliance
...
"Specify the parameter name in ArgumentException"
needed to update package because this rule was broken until now
2022-07-22 03:51:46 +10:00
92c4714be1
Enable CA2208 and MA0043 and fix noncompliance
...
"Instantiate argument exceptions correctly" and
"Use nameof operator in ArgumentException"
2022-07-22 03:51:45 +10:00
YoshiRulz