Commit Graph

4119 Commits

Author SHA1 Message Date
harry 4944faf618 Cleaned up -Wunused-result warnings for usage of fgets. fgets from stdin should really never fail so just added nullptr return handling to silence warning. 2023-01-29 11:42:32 -05:00
harry 421c7b35e7 Resolved strncpy -Wstringop-truncation warning in Qt NES header editor. 2023-01-29 11:28:58 -05:00
harry 727e403917 A couple more int compare sign warning fixes. 2023-01-28 22:51:33 -05:00
harry 5a98a7fc0d Re-enable int comparison sign mismatch compiler warnings. 2023-01-28 20:28:51 -05:00
harry 7c3c3caf93 More int comparison sign mismatch compiler warning fixes. 2023-01-28 20:24:17 -05:00
harry 213f4e2579 More fixes for int compare sign mismatch warnings in Qt TAS Editor. 2023-01-28 16:24:04 -05:00
harry 7910da7805 More int comparison sign mismatch compiler warning fixes. 2023-01-28 16:03:05 -05:00
harry 7a40075f3e Build fix for ssize_t not being available in windows. 2023-01-28 15:05:58 -05:00
harry c075cdca4f More int comparison sign mismatch compiler warning fixes. 2023-01-28 14:05:21 -05:00
harry 4434974350 Cleaned up int comparison sign mismatches in Qt TasEditor markers. 2023-01-28 13:49:09 -05:00
harry d530bab2e7 Resolved gcc -Wsign-compare compiler warnings in state.cpp. 2023-01-28 09:11:42 -05:00
harry 5b9385b2c8 Resolved int comparison compiler warning. 2023-01-28 09:09:58 -05:00
harry a45aa73a4a Fix for int conversion compiler warning. 2023-01-28 08:04:05 -05:00
harry 5582df13d7 A few signed/unsigned int comparison mismatch compiler warning fixes. 2023-01-28 07:54:31 -05:00
harry c2dc8cd25b A few more int conversion compiler warning fixes. 2023-01-28 07:49:24 -05:00
harry 2d158a8298 Updated a few types to size_t to match std. 2023-01-27 21:01:51 -05:00
harry a81632b7e1 Changed compiler attribute checking to play nice with older compilers. 2023-01-27 20:38:47 -05:00
harry d4d4001d32 Added a guard to not double define __WIN_DRIVER__ macro. 2023-01-27 08:14:58 -05:00
harry 85dfcef243 One more compiler warning fix for size_t to long conversion. 2023-01-27 08:06:28 -05:00
harry a9562cd655 Cleaned up a few compiler warnings caused by last commit. 2023-01-26 08:03:18 -05:00
harry 5e9e80eddc Change EMUFILE fseek,ftell, and other related functions to use types that follow the C standard (long int for position offsets and size_t for sizes). This allows for larger max file sizes on unix platforms and cleaner code that better maps to the C standard. 2023-01-25 21:46:30 -05:00
harry b338d4a037 Fix for UBSAN error: left shift of negative value 2023-01-25 20:36:32 -05:00
harry 01821d89b5 Fix for Qt GUI Avi codec save settings to support max file path. 2023-01-23 22:26:56 -05:00
harry 41878d95ef Added Qt empty scan code to Qt Key map for Mac OS platform. QKeyEvent::nativeScanCode() does not return valid codes on Mac OS, so this backup conversion method will not work on that platform. 2023-01-23 21:40:59 -05:00
harry 53288c0a75 Cleaned up native scan code to Qt key conversion code for windows. Use known key definitions instead of hardcoded values when possible. 2023-01-23 21:20:19 -05:00
harry f4a9fa6898 Comment out debug print statements for Qt keyscan code. 2023-01-22 21:51:29 -05:00
harry 39aafe7a88 Cleaned up native scan code to Qt key conversion code for linux. Use known key definitions instead of hardcoded values when possible. 2023-01-22 21:15:56 -05:00
Alexey 'Cluster' Avdyukhin 9a74d64b2c Fix for #510, for Windows 2023-01-22 21:32:13 +04:00
Alexey 'Cluster' Avdyukhin 99dc99831c Fix for #510 2023-01-22 20:43:30 +04:00
harry a4a799feef Changed Qt GUI TAS editor recent menu to show file name separated by some space and then full path to file. This is so that the file name can still be read when the full path is ridiculusly long. 2023-01-22 10:00:00 -05:00
harry 6d622cc787 Fix for Qt GUI TAS editor to support max file path for fm3 files. 2023-01-22 09:55:20 -05:00
harry 93c0e13572 Fix for Qt GUI wave file recording to support max file path length. 2023-01-22 09:45:22 -05:00
harry 44a5c58e44 Added realloc error checking in convert_fcm function to fix cppcheck warning. 2023-01-21 12:32:52 -05:00
harry b9385118bd Further protect against overlapping string copy by checking if pointers are different... just to be sure it is safe. 2023-01-21 12:11:41 -05:00
harry 26f623f5ea Fix crash in Qt GUI for movie player file path parser. 2023-01-21 11:59:56 -05:00
harry 821e82a069 Fix indentation and add braces to silence empty while loop body compiler warning. 2023-01-21 11:41:55 -05:00
harry aad52488ac Bug fix for ASAN error overlapping strcpy source and destination caused curMovieFilename being passed to openRecordingMovie which copies over itself. Changed type from char array to std::string whose assign function will allocate new memory to copy to before deleting the old string buffer. 2023-01-21 09:59:50 -05:00
harry 2b468be264 Changed temp save/load state file path variables to be std::string. 2023-01-20 23:53:29 -05:00
harry 2f7b4abab2 Reset std::strings lastSavestateMade and lastLoadstateMade using clear method. 2023-01-20 23:42:05 -05:00
harry 47435295ff Fixed if conditionals using lastSavestateMade address that always evaluates to true. Changed lastSavestateMade and lastLoadstateMade to std::string instead of char buffer, ensures proper initialization at startup and allows for unix max path. 2023-01-20 22:37:17 -05:00
harry f0a4e8bd11 Added a proper contructor to CHEATF_SUBFAST struct to fix clang compiler initializer warning. 2023-01-20 22:02:32 -05:00
harry 8fc3ea8ba2 Added FCEU_UNUSED and FCEU_MAYBE_UNUSED macros to help silence certain unused variable and function warnings. Used FCEU_MAYBE_UNUSED to silence unused static function warnings (until it can be deemed that these functions will never be needed). Also, cleaned up a few other unused variable warnings. 2023-01-20 21:50:26 -05:00
harry 5f44e8f374 For Qt GUI, fixed http references to https://fceux.com to avoid redirection. 2023-01-19 06:45:15 -05:00
zeromus ebf0c2c737 update 225 from fceumm to get 255 support too. 2023-01-18 11:05:43 -06:00
Alexey 'Cluster' Avdyukhin b40cb9bcf1 Added separator to the menu (win) 2023-01-17 16:55:00 +04:00
harry 5c1c71be67 For Qt GUI, added feature that allows for lua script loading via file drag and drop operations. 2023-01-17 07:02:03 -05:00
harry dd77569621 More large filepath parsing updates for Qt GUI. 2023-01-16 21:11:09 -05:00
harry 1adffbdf00 Modified Qt GUI recent ROM menu items to show the ROM base name following by a tab space and then the full path. This allows for the ROM file name to be in view in the event that the full path is excessively long. 2023-01-16 20:57:26 -05:00
harry 38089b62c0 Fix for Qt GUI compiler warnings in iNesHeaderEditor for potential stack buffer overflows on snprintf usage. 2023-01-16 20:34:00 -05:00
harry f589dfed05 Merge branch 'master' of github.com:TASEmulators/fceux 2023-01-16 20:21:16 -05:00
harry 42039004b5 Fix for Qt GUI symbolic debug filename widget size exploding when the ROM file path is large. 2023-01-16 20:21:10 -05:00
zeromus 3501ab9a40 add mapper 354 from fceu-mm 2023-01-16 10:34:13 -06:00
harry 50a7bb70c8 Changed Qt symbolic debugger file save function to use std::string for filepath. 2023-01-16 09:50:38 -05:00
harry ba47f169ca Fixed stack buffer overflow in Qt GUI loading a ROM with a large filepath from file dialog. 2023-01-16 09:44:32 -05:00
harry 3564f61849 Changed Qt GUI NL filename utility functions to operate on std::string arguments instead of char buffers to better allow for large file paths. 2023-01-16 09:35:22 -05:00
harry 097c8dc79d Increase configSys file parsing line buffer to be able to handle 4096 characters. This allows for unix max file path accomodation. 2023-01-16 09:33:55 -05:00
harry 5760a26863 Add include cart.h to ines.h for CartInfo definition. 2023-01-16 09:09:59 -05:00
harry 4c9a0ad7cf Increased array size of LoadedRomFName buffer to allow for max unix filepath length. Remove duplicate extern definitions in cpp and instead include ines.h header which contains official extern definition. 2023-01-16 08:42:33 -05:00
harry 600588910f Another build fix for Qt GUI. 2023-01-15 04:38:53 -05:00
harry 2be7794ab5 Build fix for Qt GUI. 2023-01-15 01:44:34 -05:00
harry 8a59bd3191 Qt GUI build fix for new ffmpeg macro that expands to a C++20 designated initializer that is not supported by earlier compiler standards. 2023-01-15 01:04:39 -05:00
harry 210069b78a Change temp stack variable that holds full ROM path from fixed char array to std::string. This will allow for larger file paths. 2023-01-14 22:43:45 -05:00
harry c837c8981c For QT GUI added logic to check for an FCEUX_CONFIG_DIR environment variable to specify the folder where fceux data resides. This allows users to specify there own data folder that doesn't have a .fceux hidden folder get auto created. 2023-01-14 18:34:03 -05:00
harry 90d03a6374 For Qt GUI, add libav version preprocessor guard to make sure that AV_OPT_TYPE_UINT64 definition exists before using it in source. Fixes issue #578 2023-01-13 01:18:58 -05:00
harry a3240e9c2e Qt GUI deprecation usage fixes for ffmpeg 5.1.x libavutil. Code is now compatible with new AVChannelLayout data structure. Used proper version macros so that code is still setup to be backwards compatible with ffmpeg 4.x 2023-01-13 00:45:44 -05:00
harry ff24dd7a68 For win64 Qt GUI build, disable annoying data type conversion/comparison warnings. 2023-01-12 21:33:05 -05:00
harry ec4d76707c Reset Qt GUI audio buffer samples to zero when killing SDL sound. 2023-01-11 21:57:51 -05:00
harry 37bf5c9bf2 Added logic to Qt GUI to protect against invalid audio sample rates or buffer sizes being fed from the command line to the sound system. Sound will use default values if inputs are deemed invalid. Fixes issue #603 2023-01-11 21:38:29 -05:00
harry cc1e6a8f8b Minor change to Qt GUI window focus audio mute logic. Ensure that it is always re-computed on a window active change event. 2023-01-11 21:08:55 -05:00
harry 739c01f051 Added Qt GUI sound mute function. This function is accessible either via hot key or checkbox on sound config window. Mute state is a config parameter and will persist between application boots. Fixes issue #591 2023-01-11 20:47:11 -05:00
harry e06d1cd506 Modified Qt GUI parseFilepath to output std::string types instead of char * buffers to remove file path length limitations. 2023-01-10 21:14:10 -05:00
harry 4dd8943724 Added negative index protections into GetCHRAddress to protect against a large unsigned number being passed and interpretted as a negative number. Caught by gcc UBSAN. 2023-01-10 17:42:45 -05:00
Alexey 'Cluster' Avdyukhin d1368c8213 Debugger and hex editor fix for Vs. System ROMs 2023-01-07 19:46:10 +04:00
Alexey 'Cluster' Avdyukhin c9cdca11c4 Comments for mapper 342 2023-01-07 19:40:59 +04:00
Alexey 'Cluster' Avdyukhin e1c20e4928 Removed some warnings 2023-01-07 19:27:04 +04:00
harry 2c5c3a9fe4 Fix for compiler sprintf usage warning: too many arguments for format. 2023-01-07 02:52:55 -05:00
harry 4c71af3212 Fix for apparent logic error of self-comparison always evaluates to true. Resolves g++ compiler warning. 2023-01-07 02:51:34 -05:00
harry 6ae834a1df Changed interface to Qt GUI function getDirFromFile to pass reference to std::string so that returned string will not have string length limitations. Buffer size will grow as needed for the path and will not be allocated on the stack. 2023-01-07 01:47:45 -05:00
harry 4e54ea54ac Refactor Qt GUI function fceuExecutablePath to be more efficient. Since the path to the executable never changes during the lifetime of the process, save it off the first time this function is called for later use. Function interface changed to just pass back a pointer to the saved string. Saves on stack memory and is more efficient since it does not have to continually copy data onto the stack. 2023-01-07 01:19:29 -05:00
harry b3717c008b Refactor Qt GUI function getDirFromFile to use QFileInfo to get absolute directory path. Also, added a input buffer size argument to prevent string copy buffer overflows. Fixes issue #598. 2023-01-07 00:43:35 -05:00
harry 77b894df0e Changed Qt debugger data save file extension to be .fdb instead of .dbg so that it does not conflict/overwrite ld65 debug symbol files. Fixes issue #600. 2023-01-06 23:27:06 -05:00
Alexey 'Cluster' Avdyukhin 552be94c1a
Merge pull request #596 from Kagamiin/feature/vrc-irq-cycle-mode
Implementing cycle IRQ mode for Konami VRC mappers
2023-01-06 18:18:50 +04:00
Alexey 'Cluster' Avdyukhin 04e1b32675 Linux build fix 2023-01-06 18:04:45 +04:00
Alexey 'Cluster' Avdyukhin ac18eb3c37 Vs. System - unused DIP switches replaced with second coin and service buttons 2023-01-06 17:58:02 +04:00
Alexey 'Cluster' Avdyukhin 598a291daf Vs. System error messages and DIP switch visualization 2023-01-06 16:50:33 +04:00
Alexey 'Cluster' Avdyukhin 2c35a6dfae Allow to open HEX editor when emulation is not paused + minor fix 2023-01-06 16:37:47 +04:00
Alexey 'Cluster' Avdyukhin e6e17ded38 Linux build fix 2023-01-06 16:34:46 +04:00
Alexey 'Cluster' Avdyukhin 4c215246fe Minor GUI fix 2023-01-06 16:31:31 +04:00
Alexey 'Cluster' Avdyukhin d2aed113b8 More NES 2.0 header fields: Vs. System settings, expansion type 2023-01-06 16:03:34 +04:00
Alexey 'Cluster' Avdyukhin 88ad9ceca9 Mapper 342 update 2022-12-23 20:35:35 +04:00
Kagamiin~ 77b252bf50 Implementing cycle IRQ mode for Konami VRC mappers 2022-12-21 15:16:29 -03:00
Alexey 'Cluster' Avdyukhin a04df761a9 Mapper 470 2022-12-21 12:30:04 +04:00
Alexey 'Cluster' Avdyukhin f3675320d8 Fixed IPS loader to prevent double archive browser 2022-12-19 14:55:53 +04:00
Alexey 'Cluster' Avdyukhin f53c2470fc Submappers 268.8 and 268.9 2022-12-16 20:10:21 +04:00
Alexey 'Cluster' Avdyukhin 9ae27c7ded Mapper 268, submappers 6 and 7 2022-12-12 23:38:56 +04:00
Alexey 'Cluster' Avdyukhin 47c2ce5a38 Mapper 268, support for ROMs with 1 MiB CHR-ROM 2022-12-12 23:13:42 +04:00
Alexey 'Cluster' Avdyukhin 773eaa868c Mapper 268, submappers 8,9 merged into 2,3 and fixed (https://www.nesdev.org/wiki/Talk:NES_2.0_Mapper_268) + refactoring 2022-12-12 17:48:56 +04:00
Alexey 'Cluster' Avdyukhin 0fb86b9740 Fixed broken UNROM-512 emulation + some refactoring 2022-12-07 20:04:27 +04:00
Alexey 'Cluster' Avdyukhin 853b2718b7 Removed debug messages 2022-12-06 22:51:41 +04:00
Alexey 'Cluster' Avdyukhin b6bf83db7f Mapper 268, submappers 8,9 2022-12-06 17:59:26 +04:00