dolphin/Source/Core/DolphinQt
Martino Fontana bd3cf67cbc Debugger: Rework temporary breakpoints
Before:
1. In theory there could be multiple, but in practice they were (manually) cleared before creating one
2. (Some of) the conditions to clear one were either to reach it, to create a new one (due to the point above), or to step. This created weird behavior: let's say you Step Over a `bl` (thus creating a temporary breakpoint on `pc+4`), and you reached a regular breakpoint inside the `bl`. The temporary one would still be there: if you resumed, the emulation would still stop there, as a sort of Step Out. But, if before resuming, you made a Step, then it wouldn't do that.
3. The breakpoint widget had no idea concept of them, and will treat them as regular breakpoints. Also, they'll be shown only when the widget is updated in some other way, leading to more confusion.
4. Because only one breakpoint could exist per address, the creation of a temporary breakpoint on a top of a regular one would delete it and inherit its properties (e.g. being log-only). This could happen, for instance, if you Stepped Over a `bl` specifically, and pc+4 had a regular breakpoint.

Now there can only be one temporary breakpoint, which is automatically cleared whenever emulation is paused. So, removing some manual clearing from 1., and removing the weird behavior of 2. As it is stored in a separate variable, it won't be seen at all depending on the function used (fixing 3., and removing some checks in other places), and it won't replace a regular breakpoint, instead simply having priority (fixing 4.).
2024-07-05 21:33:22 +02:00
..
Achievements Merge pull request #12896 from LillyJadeKatrin/retroachievements-visual-improvements 2024-06-30 01:30:34 -04:00
Config Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
Debugger Debugger: Rework temporary breakpoints 2024-07-05 21:33:22 +02:00
FIFO Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
GameList Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
InfinityBase IOS/USB: Use Enum for Infinity Base Positions 2024-06-27 20:57:27 +01:00
NetPlay Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
QtUtils PPCSymbolDB: GetDescription by std::string_view 2024-04-13 00:19:01 -07:00
Settings Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
SkylanderPortal Change Default Skylander File Selection Types 2024-05-17 02:52:50 +01:00
Styles/Dark Made progress bars more legible in dark mode 2024-06-29 07:02:17 -04:00
TAS TAS Input: Enable hotkeys and controller input when Input has focus 2024-05-31 15:14:44 -07:00
AboutDialog.cpp AboutDialog: Update copyright year to 2024 2024-06-24 15:06:54 -04:00
AboutDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
CMakeLists.txt Merge pull request #12728 from OatmealDome/mac-version-numbers-2 2024-05-30 01:13:32 -04:00
CheatSearchFactoryWidget.cpp Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
CheatSearchFactoryWidget.h DolphinQt: Rewrite cheat search GUI. 2021-09-15 19:05:49 +02:00
CheatSearchWidget.cpp DolphinQt: Properly Delete (Some) Widgets 2024-04-30 11:17:28 -07:00
CheatSearchWidget.h DolphinQt: Allow Cheat Search to create multiple AR codes when selecting multiple lines. 2024-03-17 01:29:39 -05:00
CheatsManager.cpp Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
CheatsManager.h CheatsManager/CheatSearchWidget: Avoid Global System Accessor 2024-03-11 20:51:15 -07:00
ConvertDialog.cpp DolphinQt: Remove unnecessary qOverloads 2023-11-04 14:14:14 -07:00
ConvertDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DiscordHandler.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
DiscordHandler.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DiscordJoinRequestDialog.cpp Remove most uses of StringFromFormat in favor of fmt 2022-10-12 16:50:47 -07:00
DiscordJoinRequestDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DolphinEmu.entitlements DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements 2022-05-18 20:23:17 -04:00
DolphinEmuDebug.entitlements DolphinQt: Add com.apple.security.cs.allow-dyld-environment-variables to entitlements 2022-05-18 20:23:17 -04:00
DolphinQt.manifest DolphinQt: dont set dpi awareness in manifest 2023-04-25 10:49:46 -07:00
DolphinQt.rc Move DolphinQt2 to DolphinQt 2018-07-07 00:48:38 +02:00
DolphinQt.vcxproj Created AchievementBox Qt object 2024-05-01 06:43:20 -04:00
DolphinQt.vcxproj.user msbuild: use default Project attrs 2022-04-27 15:26:43 -07:00
GBAHost.cpp Qt/Core: Refactor GBA Core accessors 2021-07-24 14:54:57 +02:00
GBAHost.h Qt: Implement GBA host and widget 2021-07-13 16:43:28 +02:00
GBAWidget.cpp Core::RunOnCPUThread: Avoid Global System Accessor 2024-03-28 10:10:03 -07:00
GBAWidget.h GBAWidget: Add missing override specifiers 2023-12-13 10:12:18 -05:00
GCMemcardCreateNewDialog.cpp Add wrapper function to disable hotkeys for QFileDialog 2021-10-09 22:43:56 -04:00
GCMemcardCreateNewDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
GCMemcardManager.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
GCMemcardManager.h GCMemcardManager: Shorten-up EnumMap definitions 2023-06-08 13:05:13 -04:00
Host.cpp TAS Input: Enable hotkeys and controller input when Input has focus 2024-05-31 15:14:44 -07:00
Host.h TAS Input: Enable hotkeys and controller input when Input has focus 2024-05-31 15:14:44 -07:00
HotkeyScheduler.cpp Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
HotkeyScheduler.h Add Hotkeys for Skylanders Portal and Infinity Base Menus 2023-05-26 13:36:08 -07:00
Info.plist.in Set LSApplicationCategoryType to games 2023-01-10 11:34:42 +00:00
Main.cpp Core: Remove RunAsCPUThread 2024-03-23 03:33:26 -07:00
MainWindow.cpp Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
MainWindow.h Merge pull request #11497 from vyuuui/debugger_assembler_ui 2023-12-16 21:15:31 +00:00
MenuBar.cpp Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
MenuBar.h Revert "Audit uses of IsRunning and GetState" 2024-06-26 20:36:46 +02:00
NANDRepairDialog.cpp Qt: Make custom dialog for NAND Repair. 2022-08-28 03:11:17 +02:00
NANDRepairDialog.h Qt: Make custom dialog for NAND Repair. 2022-08-28 03:11:17 +02:00
NKitWarningDialog.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
NKitWarningDialog.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
RenderWidget.cpp Core: Store current state in less places 2024-06-21 20:46:44 +02:00
RenderWidget.h Remove rounded corners on emulation render window 2024-04-28 12:41:39 +03:00
ResourcePackManager.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
ResourcePackManager.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Resources.cpp DolphinQt: cache icons instead of single pixmaps 2023-04-25 12:34:27 -07:00
Resources.h DolphinQt: cache icons instead of single pixmaps 2023-04-25 12:34:27 -07:00
RiivolutionBootWidget.cpp Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
RiivolutionBootWidget.h Disable memory patches in hardcore mode 2023-12-02 16:41:16 -05:00
SearchBar.cpp treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
SearchBar.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Settings.cpp DolphinQt: fix two -Wunused-lambda-capture warnings 2024-06-23 00:13:58 +01:00
Settings.h Merge pull request #12878 from LillyJadeKatrin/retroachievements-hardcore-state-changed 2024-06-23 18:13:56 -04:00
ToolBar.cpp Core::GetState: Avoid Global System Accessor 2024-04-08 16:23:23 -07:00
ToolBar.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Translation.cpp Remove most uses of StringFromFormat in favor of fmt 2022-10-12 16:50:47 -07:00
Translation.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Updater.cpp DolphinQt: Properly Delete (Some) Widgets 2024-04-30 11:17:28 -07:00
Updater.h Qt/Updater: Remove unused member variable. 2022-11-15 00:56:08 +01:00
WiiUpdate.cpp DolphinQt: Set window decorations for all top-level QWidgets. 2023-08-12 16:54:54 +02:00
WiiUpdate.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
pch_qt.cpp msbuild: add pch for dolphinqt 2022-06-21 13:35:14 -07:00
pch_qt.h msbuild: add pch for dolphinqt 2022-06-21 13:35:14 -07:00
qt.conf Move DolphinQt2 to DolphinQt 2018-07-07 00:48:38 +02:00
qt.conf.win DolphinQt/CMake: Building on Windows 2019-05-12 00:05:10 +02:00
qt6.natvis Add support for building against Qt 6 2022-05-02 22:39:33 -07:00
resource.h treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00