dolphin/Source/Core
Léo Lam 5021a13aa9
DSPHLE: Fix running and is_stream checks in AX HLE
A voice is considered running if and only if `running` equals 1,
not if `running` is not equal to 0.

This fixes https://bugs.dolphin-emu.org/issues/12508 because for some
reason *The Sims 2 - Castaway* sets `running` to 8 when a stream
finishes playing; previously our AX HLE would just loop the voice
and eventually crash after accessing invalid memory addresses.

Thanks to JMC47 and delroth's help, I've verified that this is the
correct check for the following ucodes:

GC:
* 0x3ad3b7ac
* 0x3daf59b9
* 0x4e8a8b21
* 0x07f88145
* 0xe2136399
* 0x3389a79e

Wii:
* 0x347112ba
* 0xfa450138
* 0xadbc06bd

And while I was fixing the running check, I noticed that the is_stream
field was also being handled incorrectly, so I've fixed that as well.
2021-07-14 19:21:35 +02:00
..
AudioCommon treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
Common Merge pull request #9870 from OatmealDome/ui-thread 2021-07-13 03:29:49 +02:00
Core DSPHLE: Fix running and is_stream checks in AX HLE 2021-07-14 19:21:35 +02:00
DiscIO Merge pull request #9854 from JosJuice/wia-ice 2021-07-06 13:05:09 +02:00
DolphinNoGUI treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
DolphinQt GeneralWidget: Convert Adapter tooltip to BalloonTip 2021-07-09 10:10:36 -07:00
InputCommon QuartzKeyboardAndMouse: Ensure windowNumber is fetched on the main thread 2021-07-06 04:46:27 -04:00
MacUpdater treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
UICommon GameFile: don't download covers for empty game IDs 2021-07-11 17:14:43 +01:00
UpdaterCommon UpdaterCommon: Use File::Copy() on non-macOS platforms 2021-07-09 12:56:23 -04:00
VideoBackends Fix indirect textures when format is not ITF_8 2021-07-08 15:48:14 -07:00
VideoCommon Merge pull request #9881 from blaahaj/postprocessing-fix 2021-07-14 13:14:17 +10:00
WinUpdater treewide: convert GPLv2+ license info to SPDX tags 2021-07-05 04:35:56 +02:00
CMakeLists.txt WinUpdater: Add CMakeLists.txt 2019-05-08 23:59:04 +02:00
DolphinLib.ARM64.props Implement ArmFPURoundMode.cpp 2021-04-25 15:56:19 +02:00
DolphinLib.props NetPlay: Refactor some functions into a common header 2021-07-06 06:41:23 -04:00
DolphinLib.vcxproj JitCommon: Signed 32-bit division magic constants 2021-03-07 18:27:36 +01:00
DolphinLib.vcxproj.user msbuild: bundle all dolphin "core" code into single library 2021-01-27 14:29:49 -08:00
DolphinLib.x64.props msbuild: bundle all dolphin "core" code into single library 2021-01-27 14:29:49 -08:00