e2543ea801
DolphinQt2: Resolve unused lambda capture warnings
...
Resolves -Wunused-lambda-capture warnings.
2018-05-14 10:11:47 -04:00
db4d8d7ad3
Merge pull request #6854 from lioncash/access
...
Jit/CachedInterpreter: Minor cleanup to code buffer accesses
2018-05-14 07:49:22 +02:00
7437f2efdc
JitArm64: Clean up code buffer accesses in DoJit()
...
Done for the same reason this was done for Jit64. Avoids constantly
indexing for the same known object instance over and over.
2018-05-13 22:11:01 -04:00
f4affa3d1d
CachedInterpreter: Clean up code buffer accesses in Jit()
...
Done similarly for the reasons Jit64 was done. Localizes indexing to one
place instead of repeatedly indexing the same place.
2018-05-13 22:11:01 -04:00
a16c0a6e16
Jit64: Clean up code buffer accesses in DoJit()
...
Moves the codebuffer access variables closer to their first use, and
gets rid of multiple indexing expressions. We already know which op
we're accessing in particular, so just make a reference to it and access
it instead of duplicating the expression all over the place.
2018-05-13 22:10:56 -04:00
f8e5e7126c
Merge pull request #6849 from leoetlino/oops
...
WiiSave: Fix out-of-bounds read
2018-05-13 23:34:32 +02:00
345838d517
Merge pull request #6842 from spycrab/qt_map_apply
...
Qt/Mapping: Fix mapping changes not being applied instantly
2018-05-13 23:34:18 +02:00
3fbfa4335e
WiiSave: Fix out-of-bounds read
...
Fixes the count argument for WriteArray. (I used it like WriteBytes.)
Whoops.
2018-05-13 23:18:28 +02:00
c7a0b6c9f8
Merge pull request #6831 from spycrab/qt_memcard_fixes
...
Qt/GCMemcardManager: Fix multiple issues
2018-05-13 23:14:46 +02:00
2be8c35d6d
Merge pull request #6844 from leoetlino/wii-save-cleanup2
...
WiiSave: Reuse IOS services where possible
2018-05-13 23:08:28 +02:00
74d561085c
Merge pull request #6848 from lioncash/guard
...
DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator
2018-05-13 22:21:40 +02:00
b03c433543
DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator
...
Prevents potential double inclusion issues from ever happening.
2018-05-13 16:11:30 -04:00
8f44423a5b
Merge pull request #6846 from spycrab/qt_native_sep
...
Qt: Use native dir separators
2018-05-13 22:10:10 +02:00
6c38e4b47f
Merge pull request #6847 from lioncash/fs-include
...
FilesystemWidget: Replace DiscIO includes with forward declarations
2018-05-13 22:08:09 +02:00
d1d584d16b
FilesystemWidget: Replace DiscIO includes with forward declarations
...
Avoids the need to use an ugly ifdef around a header, and also resolves
an indirect inclusion in PropertiesDialog.
2018-05-13 16:01:16 -04:00
1fe92b8be7
Merge pull request #6845 from lioncash/patch-dlg
...
NewPatchDialog/PatchesWidget: Use forward declarations where applicable
2018-05-13 22:00:43 +02:00
07b57c7ac6
Merge pull request #6843 from lioncash/patch
...
PatchEngine: Minor changes
2018-05-13 21:58:55 +02:00
5673a64612
Qt: Use native dir separators
2018-05-13 21:51:38 +02:00
5fd8cec7ea
PatchEngine: Add s_ prefix to file-scope variables
...
Brings the translation unit in line with the convention used elsewhere
in the codebase.
2018-05-13 15:46:55 -04:00
0995cfef6a
PatchEngine: Make PatchType an enum class
...
Makes the enum strongly typed. A function for retrieving the string
representation of the enum is also added, which allows hiding the array
that contains all of the strings from view (i.e. we operate on the API,
not the exposed internals). This also allows us to bounds check any
querying for the strings.
2018-05-13 15:46:51 -04:00
799e4154be
PatchesWidget: Convert Core and UICommon includes into forward declarations
...
Avoids propagating inclusions through UI headers
2018-05-13 15:38:58 -04:00
df3f9af6d7
NewPatchDialog: Convert PatchEngine include into a forward declaration
...
Avoids needing to include Core headers in UI-related header files,
preventing unintentional propagation.
2018-05-13 15:34:46 -04:00
b405a1fbb1
WiiSave: Reuse ES::GetInstalledTitles
...
Same thing, less code, no manual FS access.
2018-05-13 21:28:35 +02:00
a2ffe010f3
WiiSave: Reuse IOSC::Sign for signing
2018-05-13 21:28:35 +02:00
07caac1d23
WiiSave: Reuse IOSC for AES decryption/encryption
...
The SD key is already in IOSC.
This also prevents WiiSave from exposing an external library as part
of its interface.
2018-05-13 21:25:58 +02:00
9e2f9db94c
Qt/Mapping: Fix mapping changes not being applied instantly
2018-05-13 21:21:31 +02:00
e67cbd462b
Merge pull request #6841 from spycrab/qt_fix_rtmfocus
...
Qt/RenderWidget: Fix render-to-main focus
2018-05-13 21:16:26 +02:00
b9ae157835
Qt/RenderWidget: Fix render-to-main focus
2018-05-13 21:08:34 +02:00
a166cf2481
PatchEngine: Give Patch and PatchEntry default member initializers
...
Avoids potentially using the values uninitialized. While we're at it,
also drop the prefixed underscores from one of the constructors.
2018-05-13 15:08:32 -04:00
7a5e51cda7
Merge pull request #6840 from lioncash/iostream
...
DolphinQt2/NewPatchDialog: Remove unused <iostream> include
2018-05-13 20:12:15 +02:00
15a522fe9b
DolphinQt2/NewPatchDialog: Remove unused <iostream> include
...
Including <iostream> causes a static constructor to be injected into the
translation unit, even if the everything from the header itself is
unused.
2018-05-13 14:04:22 -04:00
9d1157f695
Merge pull request #6839 from spycrab/qt_start_top
...
Qt: Fix render widget not being on top when using -n / -e
2018-05-13 18:20:00 +02:00
e828c243f3
Merge pull request #6836 from leoetlino/wii-save-cleanup
...
WiiSave: (not so) Minor cleanup
2018-05-13 18:19:22 +02:00
17795a615b
Merge pull request #6838 from spycrab/qt_map_save
...
Qt/ControllersWindow: Fix changing devices while emulation is running
2018-05-13 18:17:13 +02:00
80b3d7ccb8
WiiSave: Allow users to specify export directory
...
Export and ExportAll now open a directory picker (that defaults to the
previous default directory, i.e. the Dolphin user dir).
Also removes the need to return the path in the export functions since
the user knows which path they chose.
2018-05-13 17:42:56 +02:00
87e5cd73dc
WiiSave: Use std::array instead of C arrays
...
Makes copying, comparing more readable
2018-05-13 17:42:55 +02:00
a93d816c28
WiiSave: Move dialogs to UI code
...
This moves the result dialogs to DolphinQt2, since WiiSave should not
really be responsible for interacting with the user as a simple
Wii save importing/exporting class.
This also fixes Wii save import/export showing result dialogs twice,
once from WiiSave, and another time from DolphinQt2.
2018-05-13 17:42:55 +02:00
41c4486c65
WiiSave: Clean up constructors
...
Move the import/export operation into separate functions, as it doesn't
really make sense for the constructor to do *everything*, including
printing success/failure message boxes.
The existing constructor was split into two: one that takes a path,
and another taking a title ID. This makes it more obvious what is
actually done when a path/TID is passed and also clarifies what
parameters should be passed. (No more magic 0 or "" value.)
2018-05-13 17:42:55 +02:00
fbf36b85d2
WiiSave: Remove unused Extract() member function
2018-05-13 17:42:55 +02:00
956df21bd7
WiiSave: Use Common::BigEndianValue to simplify parsing
...
Gets rid of the need to manually cast when reading/writing, which is
error prone and repetitive.
2018-05-13 17:42:55 +02:00
fb39efbf90
WiiSave: Fix struct member naming
2018-05-13 17:42:55 +02:00
bae8bcde0a
WiiSave: Do not expose internal constants
2018-05-13 17:42:55 +02:00
00bc1f28f2
Rename CWiiSaveCrypted to WiiSave
2018-05-13 17:42:55 +02:00
fa77e09239
Qt: Fix render widget not being on top when using -n / -e
2018-05-13 17:32:29 +02:00
5564150dd6
Merge pull request #6833 from leoetlino/dns
...
Use resolver to get default DNS nameserver
2018-05-13 15:49:50 +02:00
73bc20ead4
Use resolver to get default DNS nameserver
2018-05-13 14:05:23 +02:00
2ca75ae05a
Qt/ControllersWindow: Fix changing devices while emulation is running
2018-05-13 14:04:39 +02:00
99dff10d43
Merge pull request #6837 from spycrab/qt_position
...
Qt/RenderWidget: Save position and size using QSettings
2018-05-13 11:47:04 +02:00
c267262a66
Merge pull request #6786 from stenzek/crop-negative-y
...
RenderBase: Ensure the draw size does not exceed the window size
2018-05-13 08:55:59 +02:00
760a0be28a
Qt/RenderWidget: Save position and size using QSettings
2018-05-13 01:27:56 +02:00
Lioncash