b61ce51d3b
IOS/Network/IP/Top: Separate behaviors into their own functions
...
Localizes behavior and separates the code out from the IOCtl/IOCtlV
switch blocks.
2017-03-09 20:58:45 -05:00
ef74c5eabd
Merge pull request #5051 from stenzek/renderer-fixes
...
VideoBackends: Fix crashes introduced by #4999
2017-03-09 21:06:50 +01:00
135733e285
Volume: Use ReadSwapped more
...
Most of the Volume code was written before this
convenience function was added. Let's use it more.
Also deleting m_pReader nullptr checks that are
unnecessary because of Read (which ReadSwapped calls)
already having a nullptr check.
2017-03-09 21:03:28 +01:00
cf848b7c42
Merge pull request #5045 from JosJuice/unify-setting-game-metadata
...
Unify the way of setting game ID, title ID, revision
2017-03-09 18:13:02 +00:00
ab616145c2
Get the right game ID for SSBB's Masterpiece partitions
2017-03-09 18:47:40 +01:00
e04245a10e
ConfigManager: Hack for getting the right revision on ES_Launch
2017-03-09 18:07:20 +01:00
dc42f7fb28
Merge pull request #4991 from leoetlino/config-loaders
...
New config loaders
2017-03-09 16:56:14 +00:00
ced1614cac
Unify the way of setting game ID, title ID, revision
...
The existing code from ConfigManager, ES and MIOS is merged
into a new set of functions called SetRunningGameMetadata.
2017-03-09 15:34:14 +01:00
2cd240af0d
VideoBackends: Move max texture size to VideoConfig
...
This stops the virtual method call from within the Renderer constructor.
The initialization here for GL had to be moved to VideoBackend, as the
Renderer constructor will not have been executed before the value is
required.
2017-03-10 00:04:13 +10:00
4012166085
VideoCommon: Fix crash at startup with virtual XFB enabled
2017-03-09 23:39:48 +10:00
2f02cc2996
IOS/SSL: Make sure we are using a correct cert/key
...
This adds a check to the SSL code to make sure we are using the correct
client certificate and key (and root CA).
Now, instead of silently failing, the user will be notified whenever a
file is missing or when it is invalid, i.e. when the hash does not
match; this is likely to happen for existing users as the program
linked in the network guide extracted the wrong certs :(
2017-03-09 13:57:23 +01:00
40cdd32760
GCMemcard: Mark class constructors explicit where applicable
...
Prevents potential implicit instantation.
2017-03-08 19:11:16 -05:00
883bec873f
Merge pull request #4939 from sjnewbury/gamelist-text
...
Always use visible text in GameList
2017-03-08 22:38:23 +00:00
dc224cba3c
IOS/ES: Partially restore hack to fake IOS titles
...
This partially restores a hack which causes ES to fake ticket views for
IOS titles.
This is necessary because we still allow users to boot games from the
game list, so, with no way of making sure the required IOSes are
installed beforehand, games may OSPanic() when they try to reload to
some IOS version and just find out that the IOS is not installed
(something which *never* happens on the real console, of course).
A warning is printed in the logs to make sure technical users know the
IOS titles are being faked. To try and keep things accurate in all
other cases, this hack is only active when it is needed (when the
current title is a disc title which was launched from the game list).
2017-03-08 23:09:10 +01:00
cd826cee34
Merge pull request #5039 from leoetlino/es-import-hash-check
...
IOS/ES: Check the content hash during imports
2017-03-09 10:58:06 +13:00
68adcbd209
Don't special-case nogui exe name on Apple.
2017-03-08 13:17:49 -08:00
be8de62b88
Merge pull request #5041 from JosJuice/hi-2007
...
PatchEngine: Remove an unneeded comment
2017-03-08 21:23:40 +01:00
08954e99f5
PatchEngine: Remove an unneeded comment
2017-03-08 21:03:10 +01:00
a1f874a66b
ConfigManager: Remove m_strName
...
m_strName has limited usefulness, because GetInternalName()
can be inaccurate or even completely wrong. It was almost
completely unused anyway.
2017-03-08 21:01:57 +01:00
ac3bf7ad0b
DVDInterface: Assert IsDiscInside() in GetVolume()
2017-03-08 19:27:04 +01:00
a176bf0229
DVDInterface: Remove VolumeIsValid
...
It's the same as IsDiscInside.
2017-03-08 19:27:00 +01:00
3b632f5990
DVDInterface: Remove SetDiscInside
...
It's only a call to SetLidOpen now.
2017-03-08 19:26:56 +01:00
167d16ded6
DVDInterface: Remove the SetLidOpen parameter
...
The lid must always be consistent with whether a disc is inserted.
Callers shouldn't be able to set inconsistent states.
2017-03-08 19:26:50 +01:00
900793ef1d
DVDInterface: Remove s_disc_inside
...
There's no point in having a variable for whether there is a disc
when it's simpler to just directly check whether there is a disc.
2017-03-08 19:26:31 +01:00
28f4793785
Always use visible text in GameList
...
Depending upon the desktop colour scheme, the light/dark
GameList backgrounds can cause the always white text
to become unreadble.
Use the common luminance approximation algorithm to
determine whether black text should be used instead.
2017-03-08 18:03:51 +00:00
740e4d0992
DVDInterface: Move a check from SetDiscInside to SetLidOpen
2017-03-08 18:35:40 +01:00
0abf875a3f
DVDInterface: Call SetDiscInside when setting volume
...
SetDiscInside is an implementation detail that callers shouldn't
have to call on their own.
2017-03-08 18:35:40 +01:00
daa5ff9a81
IOS/ES: Check the content hash during imports
...
This adds a hash check for imported contents. IOS does it for security;
we do it for a somewhat different reason, to catch content decryption
bugs before incorrectly decrypted contents get written to the NAND,
which can cause titles to be corrupted.
Either way, we should have been doing this check in all cases.
2017-03-08 16:32:38 +01:00
489d90b6f3
Merge pull request #4999 from stenzek/renderer-statics
...
VideoCommon: Eliminate static state in Renderer
2017-03-08 11:02:20 +01:00
9c1eac1f4f
Merge pull request #4944 from vladfi1/framedump
...
Framedump extensions
2017-03-08 11:01:53 +01:00
a911d256a7
Merge pull request #5018 from Tilka/trunc
...
VideoCommon: remove unnecessary trunc()
2017-03-08 11:01:17 +01:00
096f58b172
Save new framedump options.
2017-03-08 01:38:40 -08:00
bc9db6de56
Moved NoGUI out of DolphinWx.
2017-03-08 01:24:18 -08:00
6a89cf0201
Moved X11Utils into UICommon.
2017-03-08 01:24:10 -08:00
7cc5604a2c
Merge pull request #5033 from vladfi1/nogui-user
...
Parse user directory on nogui CLI.
2017-03-08 10:04:12 +01:00
ac914e939b
Merge pull request #5035 from lioncash/out-of-bounds
...
GCAdapter_Android: Fix an array bounds overrun in Read()
2017-03-08 10:01:34 +01:00
b69d3f13cb
common: Don't include intrin.h in a namespace
...
Fixes compilation with VS2017
2017-03-08 06:55:06 +01:00
cf68ecf066
core: Add missing include
2017-03-08 06:55:05 +01:00
028da93d35
Merge pull request #5030 from sepalani/fix_pr_5002
...
Fix a vector assertion introduced by PR #5002
2017-03-07 23:23:11 +13:00
cfc909f422
Merge pull request #4867 from lioncash/simplify
...
Boot_WiiWAD: Simplify state_checksum()
2017-03-07 18:27:50 +13:00
52f22e240b
Merge pull request #5031 from lioncash/cast
...
CachedInterpreter: Get rid of an unnecessary cast
2017-03-07 18:11:00 +13:00
4d02d38bf0
Merge pull request #5032 from lioncash/const
...
Memmap/PowerPC: Remove unnecessary const on function declaration parameters
2017-03-07 18:10:31 +13:00
b914edd441
GCAdapter_Android: Fix an array bounds overrun in Read()
...
s_controller_payload is 37 bytes long, but Read() would copy 0x37 (a.k.a
55) bytes, overrunning the array.
2017-03-06 23:05:17 -05:00
26f7f55a66
GeneralConfigPane: Fix analytics sizer's right side being misaligned by 5 units
2017-03-06 22:19:54 -05:00
ac3586f46c
Parse user directory on nogui CLI.
2017-03-06 12:24:38 -08:00
4d1a4ba759
PowerPC: Remove unnecessary const on function declaration parameters
2017-03-06 14:10:33 -05:00
248a04f68f
Memmap: Remove unnecessary const on function declaration parameters
...
const, when used on value type parameters in the declaration,
is superfluous. This doesn't really convey any information to take note
of when using the function. This only matters in the definition when you
want to prevent accidental modification.
e.g.
// Header
void CalculateSomething(int lhs, int rhs);
// Definition
void CalculateSomething(const int lhs, const int rhs)
{
// lhs and rhs can't accidentally be modified
}
2017-03-06 14:08:07 -05:00
a9c570a9f8
CachedInterpreter: Get rid of an unnecessary cast
...
This is only ever used to read a value and not modify data, so this can
just be constructed by value.
2017-03-06 13:18:46 -05:00
7d681f9c93
Merge pull request #5016 from leoetlino/es-di-gettmd
...
IOS/ES: Implement ES_DIGetTMDView (and GetTMDViewSize)
2017-03-07 00:05:47 +13:00
bc1990ce5d
Fix a vector assertion introduced by PR#5002
2017-03-06 01:41:42 +00:00
71c0e30655
Appease linter.
2017-03-05 17:29:46 -08:00
fbff74c1eb
Warn on invalid video codec.
2017-03-05 17:08:59 -08:00
9155af5103
GetDumpPath function.
2017-03-05 17:08:59 -08:00
8c24387509
Use ffv1 if user requests it.
2017-03-05 17:08:59 -08:00
f9f4381461
Merge pull request #4525 from RisingFog/gci_dtm
...
GCI Folder support for TAS Recording/Playback
2017-03-06 13:26:16 +13:00
5193813b50
GCI Folder support for TAS Recording/Playback
2017-03-05 19:12:09 -05:00
029ff4d9e5
Merge pull request #5022 from lioncash/header
...
BTStub: Get rid of an unnecessary forward declaration in the cpp file
2017-03-05 19:03:56 -05:00
dd8b0e3c3f
IOS/ES: Fix logging type for dumping unknown ioctlvs
2017-03-06 00:38:13 +01:00
5049451a85
IOS/ES: Implement ES_DIGetTMDView (and GetTMDViewSize)
...
This is required for online updates to work in the system menu.
2017-03-05 22:44:58 +01:00
f80f875e27
BTStub: Get rid of an unnecessary forward declaration in the cpp file
...
This should be using the header file in order to find the function name.
2017-03-05 09:51:47 -05:00
9373c7eca9
Update Visual Studio build files
2017-03-05 15:47:25 +01:00
711f1cb7a3
Add core loaders to cmake
2017-03-05 15:47:25 +01:00
b93609e1ff
Movie configuration loader
2017-03-05 15:47:25 +01:00
1902f9f35a
NetPlay configuration loader
2017-03-05 15:47:25 +01:00
b0d54a67cc
GameConfigLoader: Fix issues mentioned in code review
2017-03-05 15:47:25 +01:00
fa98d07f7a
GameConfigLoader: Implement missing Save function
2017-03-05 15:47:24 +01:00
4761afe179
GameConfigLoader: Ignore unknown entries
...
It's not necessarily an issue. For example, memory breakpoints are
handled in a different location.
2017-03-05 15:47:24 +01:00
9dbb6f9022
Game configuration loader
2017-03-05 15:47:24 +01:00
1eb11b55a0
Base configuration loader
2017-03-05 15:47:24 +01:00
94d35ab7cb
Implement command line option setting
2017-03-05 15:47:23 +01:00
ead8be9d19
Move IniFile section chunk handling to IniFile::Section
2017-03-05 15:47:23 +01:00
b7a1c6f504
Logging: Add CORE type
2017-03-05 15:47:23 +01:00
7fa14169e9
Merge pull request #5007 from lioncash/swap
...
Common: Move byte swapping utilities into their own header
2017-03-05 09:45:29 -05:00
8a72e84ece
VideoCommon: remove unnecessary trunc()
2017-03-05 01:53:54 +00:00
c2594695b8
Merge pull request #5001 from leoetlino/es-titles
...
IOS/ES: Fix ES_GetTitles and implement ES_GetOwnedTitles
2017-03-05 14:28:28 +13:00
c21193c6f5
Merge pull request #5015 from lioncash/sysconf
...
SysConf: const correctness changes
2017-03-05 13:41:43 +13:00
0e5a367ca3
SysConf: const-correctness
2017-03-04 19:19:42 -05:00
1ebd2cd7c3
SysConf: Get rid of pointer casts
2017-03-04 19:06:22 -05:00
606e25607d
Merge pull request #5013 from degasus/androidstudio
...
Android: Update android studio + gradle.
2017-03-04 18:41:16 -05:00
52e8486b7c
IOS/ES: Refactor GetTitles into a utility function
2017-03-04 20:33:35 +01:00
1525396ecf
IOS/ES: Properly handle missing TMD in GetStoredTMD
...
When the TMD doesn't exist on the NAND, IOS returns -106.
This commit also changes IsValid() to not check for the TMD validity,
since this is not always something we want. (IOS can have different
error codes when the TMD is missing, or even worse, simply assume
that the TMD is valid.)
2017-03-04 20:33:35 +01:00
b1ffbef5ce
IOS/ES: Implement ES_GetOwnedTitles
2017-03-04 20:33:35 +01:00
35995e98d7
IOS/ES: Fix GetTitles implementation
...
IOS determines installed titles by looking at /title, not uid.sys,
which is more like a history of installed titles. And it does not care
at all about the installed TMD (or even if it is present at all).
2017-03-04 20:33:34 +01:00
7304cb0f8e
Merge pull request #5011 from stenzek/d3d-texture-corruption
...
D3D11: Use default usage for TextureCache entries
2017-03-04 15:55:58 +01:00
a3f79f88cd
Android: Update android studio + gradle.
...
Android studio 2.3 finally displays the result of the native compilation, so C++ warnings are now shown in the build log.
2017-03-04 15:53:40 +01:00
725d5bc3a1
D3D11: Drop unused method ReplaceRGBATexture2D
2017-03-04 22:37:10 +10:00
526fa9bc85
D3D11: Use D3D11_USAGE_DEFAULT for all TextureCache textures
2017-03-04 22:36:33 +10:00
3c511f2a94
Merge pull request #5003 from lioncash/memory
...
UICommon: Make GetNewDisassembler() return a unique_ptr
2017-03-04 12:14:35 +01:00
01143d761e
Merge pull request #5006 from lioncash/settings
...
ControllerEmu: Initialize settings class' values to default values on construction
2017-03-04 12:13:24 +01:00
4cea9a2f99
Vulkan: Fix underflow in StreamBuffer::WaitForClearSpace
...
This could cause the assertion on line 212 to fail when uploading large
amounts of data in between command buffer executions.
2017-03-04 18:07:04 +10:00
459a5ab554
Android: Move screenshot waiting logic to Renderer
2017-03-04 16:53:16 +10:00
811eafda57
VideoCommon: Store last window request width/height
...
This avoids the need to send a window resize event every frame.
2017-03-04 16:53:12 +10:00
00a0a91513
VideoCommon: Move last EFB scale handling to CalculateTargetSize
2017-03-04 16:53:07 +10:00
afc25fdca0
VideoCommon: Rename Renderer s_ prefixes to m_
2017-03-04 16:42:21 +10:00
238a70b006
VideoCommon: Move some common initialization logic to RenderBase
2017-03-04 16:42:16 +10:00
277829d842
VideoCommon: Eliminate static state in Renderer
2017-03-04 16:39:50 +10:00
de230f3ebe
Merge pull request #4998 from stenzek/vulkan-aspect-changes
...
Vulkan: Fix issue where target rectangle changes weren't detected
2017-03-03 21:47:29 -08:00
552c0d8404
Common: Move byte swapping utilities into their own header
...
This moves all the byte swapping utilities into a header named Swap.h.
A dedicated header is much more preferable here due to the size of the
code itself. In general usage throughout the codebase, CommonFuncs.h was
generally only included for these functions anyway. These being in their
own header avoids dumping the lesser used utilities into scope. As well
as providing a localized area for more utilities related to byte
swapping in the future (should they be needed). This also makes it nicer
to identify which files depend on the byte swapping utilities in
particular.
Since this is a completely new header, moving the code uncovered a few
indirect includes, as well as making some other inclusions unnecessary.
2017-03-03 17:18:18 -05:00
b592e4887e
BooleanSetting: Initialize m_value to default_value in the constructor
...
Ensures all class state is initialized to valid values on construction.
2017-03-03 14:09:48 -05:00
25e70570b5
NumericSettings: Initialize m_value to default_value in the constructor
...
Ensures that all class state is initialized to valid values.
2017-03-03 14:06:16 -05:00
Lioncash