ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
33,562 Commits 5 Branches 11 Tags 1.3 GiB
Commit Graph

25007 Commits

Author SHA1 Message Date
JosJuice e63b00e562 Fix translatable strings which contain non-positional arguments 2020-11-20 20:24:30 +01:00
Léo Lam f82145d9dd
EXI_DeviceMemoryCard: Use std::array 2020-11-20 19:41:23 +01:00
Léo Lam f81062f561
EXI_DeviceMemoryCard: Use enum class for Command 2020-11-20 19:38:07 +01:00
Léo Lam b2f00be637
EXI_DeviceMemoryCard: Fix member variable names 2020-11-20 19:37:39 +01:00
Léo Lam 1f15119f80
EXI_DeviceMemoryCard: Use override rather than virtual 2020-11-20 19:36:34 +01:00
Léo Lam 279197b278
EXI_DeviceMemoryCard: Use more efficient overload of find_last_of 2020-11-20 19:36:34 +01:00
Léo Lam 4ad88ce2e4
EXI_DeviceMemoryCard: Clean up casts and implicit conversions 2020-11-20 19:36:33 +01:00
Léo Lam e144d20dd6
EXI_DeviceMemoryCard: Remove unused include 2020-11-20 18:51:16 +01:00
Léo Lam 2631243379
EXI_DeviceMemoryCard: Rename variables to follow our naming conventions 2020-11-20 18:51:16 +01:00
Léo Lam 542c49bab0
Core: Fix invalid lambda captures 
PR #9260 made the MsgAlert macros use lambdas so that local
constexpr variables can be added while keeping the ability to
return a boolean from the macros.

Unfortunately, C++17 forbids referring to structured bindings in lambda
captures. This is fixed in P1091R3 but we cannot rely on C++20 yet...
 2020-11-20 18:27:56 +01:00
Léo Lam f45a4a5916
Merge pull request #9263 from lioncash/core-log2 
Core: Convert logging over to fmt pt.2
 2020-11-20 16:36:47 +01:00
Léo Lam 88cc1b7c8a
DSP: Fix one DEBUG_LOG call 2020-11-20 16:21:05 +01:00
Lioncash a0f9b041a0 Core: Convert logging over to fmt pt.2 
Continues the core migration of logs up to the EXI handling code.
 2020-11-20 10:05:44 -05:00
Léo Lam 419dfe4be4
Merge pull request #9260 from leoetlino/fmt-checks 
Common/Log: Add compile-time format string checks
 2020-11-20 16:05:25 +01:00
Jonathan Marek a20e69ff51
Vulkan: fix validation error in bSupportsGeometryShaders=false case 
In CreateDescriptorSetLayouts(), one less dynamic binding is created when
bSupportsGeometryShaders=false. Reduce the dynamicOffsetCount argument by
one in that case. Avoids this validation error:

Attempting to bind 3 descriptorSets with 2 dynamic descriptors, but
dynamicOffsetCount is 3. It should exactly match the number of dynamic
descriptors. The Vulkan spec states: dynamicOffsetCount must be equal to
the total number of dynamic descriptors in pDescriptorSets

Signed-off-by: Jonathan Marek <jonathan@marek.ca>

[Applied clang-format]
Signed-off-by: Léo Lam <leo@leolam.fr>
 2020-11-20 12:23:34 +01:00
Léo Lam c580a70a12
Merge pull request #9210 from Dentomologist/regions-show-hide-all 
DolphinQt: Add Show/Hide All options to gamelist region menu
 2020-11-20 11:35:22 +01:00
Dentomologist 7ded075561 DolphinQt: Add Show/Hide All options to gamelist region menu 2020-11-19 20:39:49 -08:00
Léo Lam 7f7fd4d8d3
Merge pull request #9220 from jordan-woyak/ext-crypto 
WiimoteEmu: Implement extension encryption edge case.
 2020-11-20 02:28:17 +01:00
Léo Lam bca82bb942
Merge pull request #9239 from altimumdelta/FFDUMP_Separate_Logging 
FrameDump Logging: Separate log type and migrate to fmt
 2020-11-20 02:21:57 +01:00
Léo Lam 5921a93d71
Merge pull request #9247 from Dentomologist/fix-updater-temporary-folder 
Fix updater not always cleaning up temp directory
 2020-11-20 02:01:43 +01:00
Léo Lam eff566b318
Merge pull request #9258 from lioncash/core-log 
Core: Convert logging over to fmt pt. 1
 2020-11-19 20:32:19 +01:00
Lioncash 958cbf38a4 Core: Convert logging over to fmt pt. 1 
Converts up to the DSP-related files for easier reviewing, the rest will
be progressively moved over after this change gets merged.
 2020-11-19 14:21:06 -05:00
Léo Lam e3247b567d
Merge pull request #9185 from Losuc/skipEFBaccessHotkey 
Add a Skip EFB Access Hotkey
 2020-11-19 17:28:45 +01:00
Léo Lam dde6090e98
Common/MsgHandler: Add compile-time format string checks 2020-11-19 17:09:24 +01:00
Léo Lam 62eeb05519
Common: Validate the number of {} fields in format strings 
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].

As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.

[1] https://github.com/fmtlib/fmt/issues/492
 2020-11-19 17:09:24 +01:00
Léo Lam 47c91696ee
Common/Log: Check format strings 
Helps with catching incorrect format strings.

PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
 2020-11-19 17:09:24 +01:00
Admiral H. Curtiss 83c235b7cb WiiUtils: Create Wii Shop log files when installing a WAD. 
Fixes https://bugs.dolphin-emu.org/issues/12269
 2020-11-19 03:26:27 +01:00
Léo Lam 4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt 
VideoCommon: Migrate over to fmt
 2020-11-18 11:10:48 +01:00
Lioncash 3d9b2aa005 VideoCommon: Migrate over to fmt 
Migrates off the printf-based formatting where applicable.
 2020-11-17 21:23:58 -05:00
Léo Lam eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot 
DolphinQt: Don't return 0x04 bytes from tr
 2020-11-18 02:31:13 +01:00
Léo Lam 31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel 
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
 2020-11-18 02:14:51 +01:00
Léo Lam 0339889806
Merge pull request #9251 from sepalani/sockopt 
IP/Top: Add missing sockopt
 2020-11-18 02:10:37 +01:00
JosJuice 52c615f1b1 Remove a redundant i18n comment 2020-11-17 18:23:27 +01:00
JosJuice 9a01c3fb9f Use positional arguments in all translatable fmt strings 
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
 2020-11-16 13:28:11 +01:00
Dentomologist 6dcf7643e5 Fix updater not always cleaning up temp directory 
Updater was only deleting TempUpdate folder when an error occured.
 2020-11-13 12:25:53 -08:00
JosJuice 53da97208a DolphinQt: Don't return 0x04 bytes from tr 
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
 2020-11-12 19:44:44 +01:00
Léo Lam 8a621c2d5e
Merge pull request #9236 from lioncash/log-backend 
VideoBackends: Migrate logging over to fmt
 2020-11-12 14:51:28 +01:00
Léo Lam ec5313fe24
Merge pull request #9204 from fbastos1/master 
fix emulator issue #12139
 2020-11-12 14:43:35 +01:00
Lioncash d8e1921b57 InputCommon: Migrate over to fmt-capable panic alerts 
Continues the migration over to fmt.
 2020-11-12 02:29:26 -05:00
Lioncash 689eec5304 DiscIO: Make use of fmt-capable panic alerts 
Migrates the DiscIO code over to fmt.
 2020-11-11 01:09:42 -05:00
LC ae83685b0b
Merge pull request #9237 from lioncash/msghandler 
Common/MsgHandler: Add fmt-capable variants of the alert macros
 2020-11-11 00:34:45 -05:00
altimumdelta f44b13ffcd FrameDump Logging: Separate log type and migrate to fmt 2020-11-10 17:17:43 +01:00
LC 0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt 
ShaderGenCommon: Rename WriteFmt() to Write()
 2020-11-09 22:08:42 -05:00
Lioncash 7b21f7af2e Common/MsgHandler: Add fmt-capable variants of the alert macros 
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
 2020-11-09 08:48:17 -05:00
LC 43e2f0e88f
Merge pull request #9235 from lioncash/ui-log 
UICommon: Migrate logging over to fmt
 2020-11-09 07:28:28 -05:00
JosJuice ee52f465b1 Android: Fix rotating EmulationActivity after boot fails 
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
 2020-11-09 10:38:49 +01:00
Lioncash 21dd7a8ebb Vulkan: Migrate logging over to fmt 
Migrates the vulkan backend over to the fmt-capable logger.
 2020-11-09 03:26:16 -05:00
Lioncash 23a8baa605 Software: Migrate logging over to fmt 
Migrates the software backend over to the fmt-capable logger.
 2020-11-09 03:14:01 -05:00
Lioncash 413d64e7fc OpenGL: Migrate logging over to fmt 
Migrates over to the fmt-capable logger.
 2020-11-09 03:09:09 -05:00
Lioncash 4d9a7c7a54 D3DCommon: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 03:03:26 -05:00
Lioncash 2345d5f98d D3D: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 03:02:00 -05:00
Lioncash d7834bd6b4 D3D12: Migrate logging over to fmt 
Migrates the logging over to the fmt-capable logger.
 2020-11-09 02:59:51 -05:00
Lioncash 52f2fadb36 UICommon: Migrate logging over to fmt 
A very simple change that continues the migration of the logs over to
fmt.
 2020-11-09 02:39:55 -05:00
Lioncash a5b28f1f07 ShaderGenCommon: Rename WriteFmt() to Write() 
Now that we've converted all of the shader generators over to using fmt,
we can drop the old Write() member function and perform a rename
operation on the WriteFmt() to turn it into the new Write() function.

All changes within this are the removal of a <cstdarg> header, since the
previous printf-based Write() required it, and renaming. No functional
changes are made at all.
 2020-11-09 02:31:49 -05:00
LC add2b44eb7
Merge pull request #9197 from lioncash/uber-pixel 
UberShaderPixel: Migrate over to fmt
 2020-11-09 02:13:57 -05:00
altimumdelta 77dc289517 CPUDetect: Indicate slow PDEP/PEXT only for Zen1/+/2 (Family 23) 2020-11-08 14:27:24 +01:00
Admiral H. Curtiss cae741584b InputCommon: Return error, if any, from ControlReference::SetExpression(). 2020-11-08 01:04:33 +01:00
JosJuice a348efe947 Fix dereferencing nullptr BootParameters 2020-11-06 09:34:53 +01:00
Sepalani 4e32ec35a7 IP/Top: Add missing sockopt 2020-11-05 19:51:20 +04:00
JosJuice 28aa04312c Common/LinearDiskCache: Replace std::fstream with File::IOFile 
File::IOFile is better suited to this type of task.
Split out from a future PR.
 2020-11-05 00:31:17 +01:00
Jordan Woyak a9c643e698 WiimoteEmu: Implement extension encryption edge case. 2020-11-04 15:22:06 -06:00
Markus Wick 069840fb7e
Merge pull request #9218 from JosJuice/aarch64-hle-hooks 
JitArm64: Implement HLE function hooking
 2020-11-04 10:29:37 +01:00
Jordan Woyak 3cd4c56645
Merge pull request #9203 from nick-michael/virtual-notches 
Logic & UI for "Virtual Notches"
 2020-11-03 17:10:54 -06:00
Nick Michael 55dd3d7337 Virtual Notch settings and UI for octagonal stick 2020-11-03 22:06:27 +00:00
Jordan Woyak d2f80a4595
Merge pull request #9138 from martymac/VK_NULL_HANDLE-fix 
Fix build on FreeBSD i386 - nullptr vs VK_NULL_HANDLE
 2020-11-03 08:28:11 -06:00
JosJuice fe986b6161 JitArm64: Implement HLE function hooking 
Closely based on the x86-64 implementation.
Fixes https://bugs.dolphin-emu.org/issues/10965.
 2020-11-03 09:48:22 +01:00
Ganael Laplanche d456e2e391 Resolve VkDeviceMemory/nullptr type mismatch to fix build on FreeBSD i386 2020-11-03 07:47:43 +01:00
Léo Lam cbaf8f82ec
Merge pull request #9214 from OatmealDome/macos-bind 
Top: Set port when connecting a socket to find the default interface
 2020-11-02 22:17:38 +01:00
Léo Lam 5b9cd83137
Merge pull request #8758 from sepalani/so-shutdown 
Socket: Abort pending operations on shutdown
 2020-11-02 21:52:28 +01:00
OatmealDome dd688f4eb0 Top: Set port when connecting a socket to find the default interface 2020-11-02 13:27:38 -05:00
JosJuice 4bb0ac918b Simplify Arm64GPRCache::Flush 
`flush = cond ? flush : true` makes little sense when `flush`
is always true at that point.
 2020-11-01 19:48:57 +01:00
Losucaru 407ef8b596 Add a Skip EFB Access from CPU Hotkey 2020-10-29 21:03:06 -03:00
Thomas May 72e1131123
Common: Fix logger related crash when HTTP response is empty 2020-10-29 21:20:59 +01:00
Felipe d7fa75ef64 modify file export to create folder in OS when explicitly extracting a directory 2020-10-29 15:20:46 -04:00
LC fe727ed1d0
Merge pull request #9194 from leoetlino/offsetof-warning 
IOS/USB: Fix -Winvalid-offset warnings
 2020-10-29 12:53:11 -04:00
LC 752b1048df
Merge pull request #9196 from Dentomologist/update-register-view-debug-font 
DolphinQt: Update register view font when Debug Font changes
 2020-10-29 12:52:02 -04:00
Dentomologist 5fe7528855 DolphinQt: Update register view font when Debug Font changes 
Resolves https://bugs.dolphin-emu.org/issues/12261

Co-authored-by: Léo Lam <leo@leolam.fr>
 2020-10-29 09:31:14 -07:00
JMC47 6a3a71cfd7
Merge pull request #9141 from Techjar/but-for-how-long 
Re-enable GPU Texture Decoding under MoltenVK
 2020-10-29 01:22:13 -04:00
Sergei Trofimovich 447de580ab Source/Core/Common/Config/Config.cpp: add missing <mutex> include 
Noticed missing include as a build failure on gcc-11:

```
[ 15%] Building CXX object Source/Core/Common/CMakeFiles/common.dir/Config/Config.cpp.o
Source/Core/Common/Config/Config.cpp:23:24:
  error: 'unique_lock' in namespace 'std' does not name a template type
    23 | using WriteLock = std::unique_lock<std::shared_mutex>;
        |                        ^~~~~~~~~~~
Source/Core/Common/Config/Config.cpp:11:1:
  note: 'std::unique_lock' is defined in header '<mutex>';
  did you forget to '#include <mutex>'?
```

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
 2020-10-28 08:53:15 +00:00
Lioncash dc72edf0e2 UberShaderPixel: Migrate over to fmt 
Completes the migration over to using the fmt-formatting WriteFmt
function. The next PR will rename all usages of WriteFmt, while
simultaneously getting rid of the old printf code.
 2020-10-27 13:25:11 -04:00
Shawn Hoffman 2ebe02fd1b dolphinqt msbuild: do not moc TASSlider.h 2020-10-26 18:37:46 -07:00
Léo Lam 2d921da860
FileUtil: Fix format string 
Fixes a recent regression: https://github.com/dolphin-emu/dolphin/pull/9187#issuecomment-716835091
 2020-10-26 22:47:56 +01:00
Léo Lam d2a2ec870d
Merge pull request #9171 from lioncash/pixel 
PixelShaderGen: Migrate over to fmt
 2020-10-26 20:35:47 +01:00
Léo Lam 07e6d008bd
Merge pull request #9187 from lioncash/commonlog 
Common: Migrate logging to fmt
 2020-10-26 19:01:26 +01:00
Léo Lam 7f66de062c
Merge pull request #9188 from jordan-woyak/stop-caring-about-old-avcodec-versions 
VideoCommon/FrameDump: Remove code for older versions of avcodec.
 2020-10-26 18:55:48 +01:00
Léo Lam aae72c3e75
Merge pull request #9195 from jordan-woyak/mem-warning 
DolphinQt: Add a warning to the MEM1/MEM2 override setting description.
 2020-10-26 18:49:33 +01:00
Léo Lam 23c9179fb6
Merge pull request #9071 from orbea/cmake 
cmake: Silence warnings.
 2020-10-26 18:48:42 +01:00
Jordan Woyak 15914b749c DolphinQt: Add a warning to the MEM1/MEM2 override setting description. 2020-10-25 12:54:42 -05:00
Léo Lam 8b9a0c9e09
IOS/USB: Fix -Winvalid-offset warnings 
Unfortunately, compilers will issue warnings when using offsetof with
non-standard layout types even when offsetof actually works fine here;
just having a virtual function is enough to trigger the warning...

Let's just stop the scan threads explicitly in destructors instead of
relying on member destruction order.
 2020-10-24 14:02:38 +02:00
iwubcode 8a4773bc91 VideoCommon: update vcproj file to set HAS_OPENGL 2020-10-23 17:08:53 -05:00
iwubcode a34745926e VideoCommon: remove HAS_OPENGL from VideoBackendBase 2020-10-23 17:00:32 -05:00
iwubcode 272717b3f4 VideoCommon: update vcproj file to set HAS_VULKAN 2020-10-23 17:00:05 -05:00
iwubcode d12380f26b VideoCommon: rename USE_VULKAN to HAS_VULKAN in VideoBackendBase 2020-10-23 16:59:22 -05:00
Lioncash 5de2244acf PixelShaderGen: Migrate over to fmt 
Continues the migration of the shader generators over to fmt.

After this, all that remains in the Ubershader pixel generator.
 2020-10-23 17:17:55 -04:00
Jordan Woyak 4902146329 VideoCommon/FrameDump: Remove code for older versions of avcodec. 2020-10-23 14:43:50 -05:00
Lioncash 4e8df93f41 Common: Migrate logging to fmt 
Continues the migration of our code over to the fmt logger.
 2020-10-23 14:58:03 -04:00
Léo Lam 285b926e92
Merge pull request #8782 from Pokechu22/missing-serial-version-data 
Explain how to fix "Serial and/or version data is missing"
 2020-10-23 20:44:06 +02:00
Léo Lam e89db89d9e
Merge pull request #9098 from jordan-woyak/wm-report-duplication 
WiimoteReal: Only duplicate data reports when speaker data is enabled.
 2020-10-23 20:38:25 +02:00
mazes-80 f375ee72a2
CMake: Add option to enable/disable Vulkan video backend 2020-10-23 20:14:46 +02:00
JosJuice 908d6f8fa0
Merge pull request #9179 from leoetlino/available-video-backends 
VideoCommon: Get rid of the global g_available_video_backends
 2020-10-23 20:02:21 +02:00