9639dde114
Address review comments on old code
2019-11-23 17:48:44 +01:00
8e2b12e1ea
GameDetailsDialog: Use labels instead of icons
2019-11-23 17:48:44 +01:00
2e13353201
GameDetailsDialog: Convert layout to ConstraintLayout
...
This also removes the FAB from GameDetailsDialog. It was
previously outside of the visible area and thus unusable.
2019-11-23 17:48:43 +01:00
4f1511043c
GameDetailsDialog: Fix banner placeholder
2019-11-23 17:48:43 +01:00
ec91674d07
GameDetailsDialog: Show game ID and revision
2019-11-23 17:48:43 +01:00
84e616337d
GameDetailsDialog: Remove the screenshot ImageView
...
It takes up a lot of space on the screen, and the functionality for
saving these screenshots isn't in Dolphin anymore as far as I can tell.
2019-11-23 17:48:43 +01:00
100e7e2b3d
GameDetailsDialog: Hide description if empty
...
In particular, Wii games don't have descriptions.
2019-11-23 17:48:43 +01:00
100f032e2f
GameDetailsDialog: Don't use CircleImageView for banners
...
Because trying to fit a 3:1 banner into a circle looks very awkward.
Also move the banner below the title/description now that it
takes up more space horizontally.
2019-11-23 17:48:42 +01:00
fcb96a179d
GameDetailsDialog: Actually load the banner
2019-11-23 17:48:42 +01:00
c2952c466f
Bring back game banner loading code deleted in 3f21975
2019-11-23 17:48:42 +01:00
5ed0cf8e0e
Rename GameSettingsDialog to GamePropertiesDialog
...
Since it no longer only contains settings.
2019-11-23 17:48:42 +01:00
00c4dad784
Android: Bring back the game details dialog
...
It was made inaccessible in e19922c593b697
2019-11-23 17:48:41 +01:00
870912722e
Revert "Android: Remove dead code and related lib <circleimageview>"
...
This reverts commit 593b69728d
2019-11-23 17:35:19 +01:00
4305a9ac57
Merge pull request #8482 from rafaeltoledo/rt/material-fix
...
Moves AlertDialogs imports to AndroidX and fix tabs background color
2019-11-23 16:56:39 +01:00
8453277479
Moves `AlertDialog`s imports to AndroidX and fix tabs background color
2019-11-23 10:50:12 -03:00
a06da596e5
Merge pull request #8485 from lioncash/imu
...
InputCommon/IMU*: Remove unnecessary includes
2019-11-22 22:31:57 +01:00
af37d09b0f
Merge pull request #8484 from lioncash/input-func
...
InputCommon/FunctionExpression: Minor cleanup
2019-11-22 22:31:31 +01:00
91993b46d9
InputCommon/IMU*: Remove unnecessary includes
...
Trims out unnecessary includes to avoid unnecessary header dependencies.
This also resolves indirect inclusions of <optional> within
IMUAccelerometer.h and IMUGyroscope.h
2019-11-22 15:41:38 -05:00
814fd165af
InputCommon/FunctionExpression: Use Yoda conditions, we do not
...
The general convention in the codebase is to compare the non-constant
value/string with the constant value/string, not the other way around.
2019-11-22 15:36:18 -05:00
1f6077922b
InputCommon/FunctionExpression: Remove unnecessary 'else' in MakeFunctionExpression()
...
Given all conditional bodies only contain a return, the use of else here
isn't necessary.
This has the benefit of consistently vertically aligning the names.
2019-11-22 15:36:18 -05:00
10fea99d80
InputCommon/FunctionExpression: Make MakeFunctionExpression() take a std::string_view
...
There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
2019-11-22 15:36:18 -05:00
ddf8abf507
InputCommon/FunctionExpression: Remove unused LOOP_MAX_REPS constant
...
This isn't used anywhere in the translation unit, so we can remove it.
2019-11-22 15:36:18 -05:00
64bc6f53fd
InputCommon/FunctionExpression: Remove cyclical include
...
This header was including itself, which is likely not intended.
2019-11-22 15:36:18 -05:00
cb8fbe872e
InputCommon/FunctionExpression: Collapse namespaces
...
Since we target C++17, we can collapse the namespaces into a single
declaration specifier.
2019-11-22 15:36:14 -05:00
28f7c5fb2a
Merge pull request #8483 from lioncash/input
...
InputCommon: Make use of fmt where applicable
2019-11-22 20:53:11 +01:00
6586ecc7a8
InputCommon/FunctionExpression: include <algorithm>
...
std::min/std::max are used within this translation unit, so it needs to
be included to prevent potential compilation failures.
2019-11-22 14:41:13 -05:00
e8edc49bbe
InputCommon: Make use of fmt where applicable
...
Continues the migration over to fmt
2019-11-22 14:38:26 -05:00
bc449fb98f
Merge pull request #8480 from JosJuice/volumeverifier-block-future
...
VolumeVerifier: Fix a copypaste error
2019-11-22 11:42:50 -05:00
abc14536b1
Merge pull request #7864 from rafaeltoledo/master
...
Bumps compile API to 29 (Q) and removes deprecated calls and unnecessary casts
2019-11-22 17:29:37 +01:00
2d1f32efb4
Bumps compile API to 29 (Q) removes unecessary casts and deprecated
...
calls
2019-11-22 13:17:37 -03:00
4e713238d9
VolumeVerifier: Fix a copypaste error
...
This was completely wrong, but I guess it happened to work correctly
anyway due to timing reasons (MD5 is faster than SHA-1 + AES).
2019-11-22 13:39:04 +01:00
a9cf8670e0
Merge pull request #8224 from Pokechu22/wiimote-eeprom
...
Write the entirety of the Wiimote EEPROM, in a per-Wiimote file
2019-11-20 22:03:53 +01:00
9ef526c708
Merge pull request #8471 from Simonx22/AndroidX
...
Android: migrate to AndroidX
2019-11-20 21:36:28 +01:00
6d193d3b5a
Translation resources sync with Transifex
2019-11-20 18:18:12 +01:00
d66050375c
Merge pull request #8347 from hosaka-corp/frame-advance-alignment
...
Align frame advance and movies to full field boundaries
2019-11-19 19:26:35 +01:00
dae01b1a3b
Merge pull request #8346 from DacoTaco/master
...
GCMemcardManager : icon drawing takes to much cpu time
2019-11-18 23:37:11 +01:00
9c5c3c055e
Align frame advance and movies to full field boundaries
2019-11-18 15:05:06 -06:00
162b7c2ca3
Merge pull request #8477 from jordan-woyak/accel-indicator-flip
...
DolphinQt: Fix accelerometer mapping indicator flipped X axis.
2019-11-17 18:35:49 -05:00
282470e312
DolphinQt: Fix accelerometer mapping indicator flipped X axis.
2019-11-17 16:41:06 -06:00
4d4a095c76
Reset Wiimotes on force stop and when starting MIOS
2019-11-17 12:20:26 -08:00
a23609562d
Replace magic disconnect channel number with a constant
2019-11-17 12:20:25 -08:00
5477409847
Write the entirety of the Wiimote EEPROM, in a per-Wiimote file
...
Previously, only Mii data was written. Additionally, the file containing mii data was shared for all Wiimotes, which made it a lot less useful.
Additionally, the file was read/written on each Wiimote read, even though the whole EEPROM was kept in memory. This was bad for performance and not particularly necessary (it did enforce that the data was properly shared between all Wiimotes, but that's not something I want).
2019-11-17 12:20:19 -08:00
d6eb75b272
GCMemcardManager : Performance boost
2019-11-17 20:45:24 +01:00
97f9f252cc
Merge pull request #8464 from jordan-woyak/wm-emu-errorcode
...
WiimoteEmu: Minor accuracy fixes.
2019-11-17 10:39:18 +01:00
bc1aa3640b
Merge pull request #8302 from AdmiralCurtiss/gcmemcard-comments
...
GCMemcard: Read comments, banners, and icons via logical data offsets instead of physical ones.
2019-11-17 10:34:06 +01:00
3b67d0d90a
GCMemcard: Read icons according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
110d6c1da3
GCMemcard: Read banners according to logical data offsets instead of physical data offsets. Also gets rid of some undefined behavior.
2019-11-17 01:42:26 +01:00
2f119bd206
GCMemcard: Move Icon and Banner constants to the GCMemcard header.
2019-11-17 01:42:26 +01:00
58f21830bd
GCMemcard: Read file comments according to logical data offsets instead of physical data offsets.
2019-11-17 01:42:26 +01:00
770605bc80
GCMemcard: Add method to read an arbitrary block of bytes from a save file.
2019-11-17 01:42:26 +01:00
JosJuice