Commit Graph

42095 Commits

Author SHA1 Message Date
JosJuice 962230f91e Core: Store current state in less places
Core::GetState reads from four different pieces of state: s_is_stopping,
s_hardware_initialized, s_is_booting, and CPUManager::IsStepping.
I'm keeping that last one as is for now because there's code in Dolphin
that sets it directly, but we can unify the other three to make things
easier to reason about.

This commit also gets rid of s_is_started. This was previously used in
Core::IsRunningAndStarted to ensure true wouldn't be returned until the
CPU thread was started, but it wasn't used in Core::GetState, so
Core::GetState would happily return State::Running after we had
initialized the hardware but before we had initialized the CPU thread.
As far as I know, there are no callers that have any real need to know
whether the boot process is currently initializing the hardware or the
CPU thread. Perhaps once upon a time there was a desire to make the
apploader debuggable, but a long time has passed without anyone stepping
up to implement it, and the way CBoot::RunApploader is implemented makes
it rather difficult. So this commit makes all the functions in Core.cpp
consider the core to still be starting until the CPU thread is started.
2024-06-21 20:46:44 +02:00
Admiral H. Curtiss 04c246d11f
Merge pull request #12837 from JosJuice/cmake-one-tests-binary
CMake: Put all unit tests in one binary
2024-06-10 22:47:45 +02:00
Admiral H. Curtiss 6b2dc1cae8
Merge pull request #12839 from nvllsvm/fix_extract_success_quiet
Suppress extract success message when quiet flag is set
2024-06-10 22:25:23 +02:00
Admiral H. Curtiss 4930567981
Merge pull request #12845 from iwubcode/texture_config_compare_type
VideoCommon: add texture type to texture config comparison
2024-06-10 22:24:08 +02:00
Admiral H. Curtiss e405ad4206
Merge pull request #12827 from nlebeck/mathutil-tests-2
Add some unit tests for the `Rectangle` class
2024-06-10 22:22:20 +02:00
Admiral H. Curtiss e7e1322c57
Merge pull request #12835 from icup321/master
GameINI: Ubisoft updates
2024-06-10 18:38:03 +02:00
Admiral H. Curtiss db921ed4b5
Merge pull request #12840 from TryTwo/Fix_batch_mode_again
MainWindow: Fix batch mode (again).
2024-06-10 18:36:20 +02:00
Admiral H. Curtiss 5589e1e00f
Merge pull request #12830 from VampireFlower/aliases
Assembler: Add aliases for r1 and r2
2024-06-10 18:35:40 +02:00
Niel Lebeck 9b0dcc83d1 Add some unit tests for the `Rectangle` class 2024-06-09 16:28:35 -07:00
TryTwo 28c28623a8 MainWindow: Don't save UI geometry in batch mode. Batch mode was erasing the UI geometry for the sessions where batch mode is off. Render widget is still saved. 2024-06-08 23:27:56 -07:00
iwubcode fa5a6547c6 VideoCommon: add texture type to texture config comparison 2024-06-08 14:28:11 -05:00
JosJuice 6c5ceaa06d
Merge pull request #12820 from JosJuice/jit64-simplity-test-bit
Jit64: Clean up the test_bit variable
2024-06-08 10:10:29 +02:00
icup321 f910678dd4 GameINI: Ubisoft updates
Update several INI GameSettings for Ubisoft games
Undo name changes
2024-06-07 02:38:16 -04:00
Andrew Rabert 896bb509ab Suppress extract success message when quiet flag is set 2024-06-06 17:55:59 -04:00
Admiral H. Curtiss 81b6bfaa1e
Merge pull request #12832 from JosJuice/retro-achievements-less-ifdefs
Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined
2024-06-06 22:42:53 +02:00
VampireFlower 473db6882d r32 doesn't exist 2024-06-06 13:05:45 -06:00
VampireFlower 8f03d9e8ca handle sp and rtoc as GPR aliases
Co-Authored-By: mitaclaw <140017135+mitaclaw@users.noreply.github.com>
2024-06-06 13:05:43 -06:00
JosJuice f404edb4dc CMake: Put all unit tests in one binary
We currently have 32 different binaries containing unit tests. At least
when I build for Android, each one takes up over 200 MiB, and linking
them all increases my incremental build times by over a minute. I'd
like to change this for the sake of my productivity and disk space.

For reference, MSBuild is already putting all tests in a single binary.
2024-06-06 19:30:43 +02:00
Admiral H. Curtiss ca22d0af57
Merge pull request #12833 from JosJuice/opensles-set-running
Android: Implement OpenSLESStream::SetRunning
2024-06-06 12:27:48 +02:00
JosJuice 22aa88109f Use a stub AchivementManager when USE_RETRO_ACHIEVEMENTS isn't defined
This lets us reduce the number of USE_RETRO_ACHIEVEMENTS ifdefs in the
code base, reducing visual clutter. In particular, needing an ifdef for
each call to IsHardcodeModeActive was annoying to me. This also reduces
the risk that someone writes code that accidentally fails to compile
with USE_RETRO_ACHIEVEMENTS disabled.

We could cut down on ifdefs even further by making HardcodeWarningWidget
always exist, but that would result in non-trivial code ending up in the
binary even with USE_RETRO_ACHIEVEMENTS disabled, so I'm leaving it out
of this PR. It's not a lot of code though, so I might end up revisiting
it at some point.
2024-06-06 08:26:20 +02:00
Admiral H. Curtiss 47fae68b0f
Merge pull request #12831 from TryTwo/Fix_batch_mode
MainWindow: Fix batch mode
2024-06-06 03:55:22 +02:00
Admiral H. Curtiss a85d89af39
Merge pull request #12626 from MikeIsAStar/remove-erroneous-continue-statement
MMU: Remove erroneous continue statement
2024-06-06 03:54:59 +02:00
Admiral H. Curtiss e233a30ffc
Merge pull request #12834 from jordan-woyak/sdcard-sfd
FatFsUtil: Generate a non-partitioned image in our folder-to-sdcard conversion.
2024-06-05 13:50:11 +02:00
Scott Mansell d3c4061c42
Merge pull request #12826 from MayImilae/newdefaultbadges
RetroAchievements - New Default Badges
2024-06-05 20:15:48 +12:00
Scott Mansell dbe7616bdd
Merge pull request #12817 from iwubcode/imgui-mouse-position-event
VideoCommon: use imgui mouse position event when the mouse position changes
2024-06-05 18:50:26 +12:00
Scott Mansell a57962cedb
Merge pull request #12825 from iwubcode/texture_cache_sampler_split
VideoCommon: pull texture sampler out of texture cache for later reuse
2024-06-05 18:16:24 +12:00
Jordan Woyak 98e6a95e87 FatFsUtil: Generate a non-partitioned image in our folder-to-sdcard conversion. 2024-06-04 15:17:05 -05:00
JosJuice a3c23353c0 Android: Implement OpenSLESStream::SetRunning 2024-06-04 19:32:04 +02:00
JosJuice c04460d88b
Merge pull request #12580 from LillyJadeKatrin/retroachievements-bugfix
Add user agent to headers for all RetroAchievements server calls
2024-06-04 13:41:01 +02:00
TryTwo fa00728d3e MainWindow: Check for batch mode before show(). 2024-06-04 00:26:58 -07:00
LillyJadeKatrin 9499e14209 Add user agent to headers for all RetroAchievements server calls
Requested agent syntax is "Dolphin/5.0-23456"
2024-06-03 00:24:43 -04:00
MayImilae ea325023ab Replaces the temporary Retroachievement
default badges.
2024-06-02 07:42:40 -07:00
iwubcode c2bc2ccd23 VideoCommon: pull texture sampler out of texture cache so that it can be used in other places in the future 2024-06-01 23:21:04 -05:00
iwubcode 51b69bb339 VideoCommon: use imgui mouse position event when the mouse position changes 2024-05-31 22:31:54 -05:00
Admiral H. Curtiss 46a89936ae
Merge pull request #12780 from TryTwo/BreakpointWidget_Direct_Edit
BreakpointWidget: Add ability to directly edit breakpoints
2024-06-01 04:25:19 +02:00
TryTwo 3526f3cd9f
Color unused cells and disabled rows.
(bug?) Does not update on dark/light style change, as no signals are sent.
2024-06-01 03:42:25 +02:00
TryTwo 1396e927c7
BreakpointWidget: Give conditionals a popup text entry on click. 2024-06-01 03:42:25 +02:00
TryTwo e52b814eb2
BreakpointWidget: Direct editing of address cells. Prevent symbol cells from being affected. 2024-06-01 03:42:24 +02:00
TryTwo b740671792
BreakpointWidget: Make buttons, removing selecting row on clicking, and fix OnContextMenu which relied on select rows.
Add functions to edit breakpoints.
2024-06-01 03:42:18 +02:00
Admiral H. Curtiss 2b386cdcdc
Merge pull request #12812 from LillyJadeKatrin/retroachievements-close-fixes
Properly reset Discord presence after game close
2024-05-31 20:18:22 +02:00
Admiral H. Curtiss 0e6db07203
Merge pull request #12794 from TryTwo/PR_Windows_Initialize_Fix
MainWindow, Bugfix: Initialize geometries before calling GetWindowSystemInfo
2024-05-31 20:00:37 +02:00
Admiral H. Curtiss 171596ac74
Merge pull request #12315 from Dentomologist/interfacepane_add_balloontips
InterfacePane: Add BalloonTips
2024-05-31 19:41:55 +02:00
Dentomologist de9326bd53
InterfacePane: Add BalloonTip to user style combobox 2024-05-31 19:10:30 +02:00
Dentomologist 33b64d6c91
InterfacePane: Add BalloonTip to cursor visible radio buttons 2024-05-31 19:09:00 +02:00
Dentomologist a581fa2bfa
InterfacePane: Add BalloonTip to lock mouse checkbox 2024-05-31 19:07:33 +02:00
Dentomologist 9ed1688d09
InterfacePane: Add BalloonTip to pause on focus lost checkbox 2024-05-31 19:06:50 +02:00
Dentomologist 14f01bb12c
InterfacePane: Add BalloonTip to show active title checkbox 2024-05-31 19:06:11 +02:00
Dentomologist c5532b19e6
InterfacePane: Add BalloonTip to enable on-screen display checkbox 2024-05-31 19:05:35 +02:00
Dentomologist 16cdd0a961
InterfacePane: Add BalloonTip to use panic handlers checkbox 2024-05-31 19:04:57 +02:00
Dentomologist dc15a555c9
InterfacePane: Add BalloonTip to confirm on stop checkbox 2024-05-31 19:04:18 +02:00