556323561c
Do not update hotkey assignments on window close
...
If this commit is not applied, then the previous commit will cause hotkeys to be saved if there is a syntax error when hitting "OK" and the user presses the X to close the window.
This commit only applies changes to hotkey config if no syntax error occurs.
2021-09-27 16:21:28 -04:00
242bce27a1
Do not accept on hotkey syntax errors
...
Previously you could type whatever gibberish you wanted into the formula bar, press OK, and receive a modal syntax error window. Closing the syntax error window would cause the hotkey config window to close as well, and your gibberish would be applied to the hotkey assignment.
This commit requires that a syntax error does not occur before accept() is called.
2021-09-27 14:28:08 -04:00
753a1595bf
Merge pull request #10122 from malleoz/record-hotkeys-without-game-running
...
HotkeyScheduler: Check for certain hotkeys in game list
2021-09-23 11:32:43 -04:00
e5051c516f
Check for certain hotkeys in game list
...
There are certain hotkeys that we absolutely want to be able to use
without being in-game. Presently, no hotkeys are recognized unless we
are in-game.
I've identified and moved the following hotkeys to be checked before the
HotkeyScheduler checks to see if the Core is running:
- Open
- Exit
- Start Recording
- Refresh Game List
Note that Play Recording should also be implemented here, however it
looks like there is no signal for a PlayRecording() function, so this
will have to be handled in a later PR once that signal is created and
implemented.
2021-09-23 10:46:04 -04:00
0d8ad5f53a
Merge pull request #10008 from JosJuice/android-remove-emulationstate
...
Android: Remove the EmulationState class
2021-09-22 11:07:19 +02:00
53d7d595e6
Android: Remove the EmulationState class
...
The purpose of this class was to keep track of state which the
emulation core was already keeping track of. This is rather risky -
if we update the state of one of the two without updating the other,
the two become out of sync, leading to some rather confusing problems.
This duplicated state was removed from EmulationState in the
previous commits, so now there isn't much left in the class.
Might as well move its members directly into EmulationFragment.
2021-09-21 16:34:00 +02:00
2cd09b8eb3
Android: Remove synchronized keywords from EmulationState
...
These methods are only being called from the GUI thread anyway...
2021-09-21 16:33:59 +02:00
3eb07e9772
Android: Don't rely on onPause for pausing before destroying surface
...
Fixes a crash which was uncovered (or just made more likely?)
by the previous commit.
2021-09-21 16:33:57 +02:00
446e2d9119
Android: Remove state from EmulationState
2021-09-21 16:32:47 +02:00
2c564a0b9d
Android: Remove mSurface from EmulationState
2021-09-21 16:31:55 +02:00
cc84799c7f
Merge pull request #10117 from AdmiralCurtiss/disc-content-comparators
...
DiscIO/DirectoryBlob: Fix swapped DiscContent comparison operators.
2021-09-21 02:24:42 -04:00
6684e26ae2
DiscIO/DirectoryBlob: Fix swapped DiscContent comparison operators.
2021-09-21 08:01:21 +02:00
22f7c07caf
Merge pull request #10081 from sepalani/mem-hex0
...
MemoryWidget: Simplify the search logic
2021-09-20 22:17:20 +02:00
7ec02ee4d3
Merge pull request #10116 from malleoz/tas-input-gui-changes
...
StickWidget: Inscribe stick circle within a square
2021-09-20 14:04:36 -04:00
3bc9f66336
Inscribe StickWidget ellipse in square
...
Previously, it was not clear where the boundary of the StickWidget was when interacting outside of the circle. This aims to restore the gray square present in the Wx-era.
2021-09-20 13:18:13 -04:00
94cba46467
MemoryWidget: Simplify the search logic
...
Fix leading nul bytes being ignored in hex search
2021-09-20 20:46:26 +04:00
6129290d31
Merge pull request #10057 from JosJuice/jitarm64-divwx
...
JitArm64: Optimize divwx
2021-09-20 15:37:57 +02:00
a25f4fab20
Merge pull request #10080 from lioncash/membf
...
MemoryInterface: Migrate bitfields over to Common::BitField
2021-09-20 14:54:27 +02:00
b43cee8fe4
Merge pull request #10098 from AdmiralCurtiss/scan-dir-tree-trailing-slash
...
Common/FileUtil: Strip trailing path separator in ScanDirectoryTree().
2021-09-20 14:50:11 +02:00
276ea43237
Merge pull request #10102 from lioncash/netplay
...
NetPlayClient: Split out OnData() into smaller functions
2021-09-20 14:41:47 +02:00
29d236068c
Merge pull request #10104 from AdmiralCurtiss/cheats-manager-ux
...
Cheats Manager UX improvements.
2021-09-20 14:30:04 +02:00
28e6e8752c
Merge pull request #10113 from JosJuice/tas-input-latency
...
DolphinQt: Reduce latency of TAS input's controller input passthrough
2021-09-20 14:26:13 +02:00
e7c0b8ecbd
Merge pull request #10114 from AdmiralCurtiss/disc-addresses
...
Core/DiscIO: Extract disc and partition constants to DiscUtils.h.
2021-09-20 14:25:59 +02:00
ad410009bb
Core/DiscIO: Extract disc and partition constants to DiscUtils.h.
2021-09-19 22:43:52 +02:00
70a9003947
Merge pull request #10109 from JosJuice/android-clear-confirmation
...
Android: Show confirmation dialog for clearing game settings
2021-09-19 16:10:22 -04:00
57f71a55f8
Merge pull request #10110 from JosJuice/remove-request-refresh-info
...
Core: Remove s_request_refresh_info
2021-09-19 16:09:58 -04:00
ca2589f7df
Merge pull request #10103 from AdmiralCurtiss/cheat-search-length-underflow
...
Core/CheatSearch: Avoid length underflow on new search.
2021-09-19 16:09:43 -04:00
1a5e0c2084
DolphinQt: Reduce latency of TAS input's controller input passthrough
...
Fixes https://bugs.dolphin-emu.org/issues/12676 .
Needs testing to see if this impacts performance when controller
inputs are changing.
2021-09-19 17:08:10 +02:00
31ca114721
Merge pull request #10068 from leoetlino/more-low-mem1-constants
...
IOS: Add missing writes of low MEM1 constants
2021-09-19 09:45:01 -04:00
b0fc95ee31
Merge pull request #10112 from JMC47/kingkongxfb
...
Disable Immediate XFB in King Kong
2021-09-19 15:27:21 +02:00
c1349fa613
Disable Immediate XFB in King Kong
...
The game has extra XFB copies in some menus, messing up framepacing on
VRR monitors and breaking vsync in general.
2021-09-19 09:15:24 -04:00
ca064b55fe
Merge pull request #10111 from JosJuice/networkwidget-hidden
...
DolphinQt: Don't update NetworkWidget when hidden
2021-09-18 09:33:45 -04:00
0a973ddcbb
DolphinQt: Don't update NetworkWidget when hidden
...
Like 92a655c
2021-09-18 14:41:11 +02:00
b0144d88d9
Merge pull request #10108 from phire/always-disable-bb
...
BPStructs: ensure side effects are same
2021-09-18 08:05:21 -04:00
ce80a96aee
BPStructs: ensure side effects are same
...
Missed this side effect when fixing crash in Mario Kart Wii wifi
2021-09-18 23:58:24 +12:00
e5ed9ee920
Core: Remove s_request_refresh_info
...
It's only used for frame stepping. We can use s_frame_step instead.
2021-09-18 13:39:38 +02:00
a3ce8d61fd
Android: Show confirmation dialog for clearing game settings
2021-09-18 12:35:46 +02:00
a6baca6bf6
Merge pull request #10107 from OatmealDome/amd-subgroup-reduction
...
VulkanContext: Disable subgroup reduction on Macs with AMD GPUs
2021-09-17 16:19:58 +02:00
7e8f5208fe
VulkanContext: Disable subgroup reduction on macOS with AMD GPUs
2021-09-16 23:32:10 -04:00
2d1ec6332b
Merge pull request #10106 from phire/fix-negative-efb-copies
...
BPStructs: Ignore malformed efb copies
2021-09-16 21:04:03 -04:00
7c7609f5b9
BPStructs: Ignore malformed efb copies
2021-09-17 12:42:23 +12:00
a0f7e3110d
Merge pull request #10105 from Pokechu22/mmxc-texture-filtering
...
GameINI: Disable force texture filtering for Mega Man X Collection
2021-09-16 20:15:48 -04:00
e902eda495
GameINI: Disable force texture filtering for Mega Man X Collection
2021-09-16 17:05:07 -07:00
d14d7595f2
Translation resources sync with Transifex
2021-09-16 21:12:03 +02:00
7379450633
Merge pull request #10092 from JosJuice/android-cheats
...
Android: Add cheat GUI
2021-09-16 19:21:33 +02:00
0ca4c6dbd4
Android: Add save button to cheats activity
...
By request. Matches the settings activity.
2021-09-16 18:48:40 +02:00
ffa25c4cf5
Android: Allow $ line when entering cheat code
...
Port of cda442d
2021-09-16 18:48:40 +02:00
53ae1a0725
Android: Add Gecko code downloading
2021-09-16 18:48:39 +02:00
47efd3317d
Android: Fix CheatsActivity d-pad navigation
...
Special shoutout to Android for not having RTL compatible
variants of nextFocusRight and nextFocusLeft.
Ideally we would have some way to block the user from using
the d-pad to switch between the two panes when in portrait mode,
or make the list pane act as if it's to the left of the details
pane rather than the right when the details pane is open, but I
don't know of a good way to do this. SlidingPaneLayout doesn't
really seem to have been implemented with d-pad navigation in mind.
Thankfully, landscape is the most important use case for gamepads.
2021-09-16 18:48:39 +02:00
215492152c
Android: Show warning when Enable Cheats is off
2021-09-16 18:48:39 +02:00
sowens99