6a29e8fa58
Android: Use EmulationActivity.launchFile() for StartupHandler
2019-07-18 22:35:24 +10:00
9961e2866a
Android: Support opening .dff files
...
This is also shared by the disc change code, but changing discs to a
.dol doesn't make sense either.
2019-07-18 22:35:23 +10:00
34e6a41d05
Android: Support opening files directly
...
This enables us to boot FIFO logs as well as homebrew directly, without
having to add it to the game list first.
2019-07-18 22:35:12 +10:00
6a6bbd7071
Android: Support bypassing game file cache to parse file
2019-07-18 22:35:12 +10:00
a77b571da7
Merge pull request #8250 from JosJuice/bitrate-setting
...
Add dumping bitrate setting to GUI and increase default value
2019-07-18 22:17:13 +10:00
199c565bf5
DolphinQt: Add the dumping bitrate setting to the graphics config
...
Fixes https://bugs.dolphin-emu.org/issues/10250
2019-07-18 12:20:21 +02:00
a6dcaed415
DolphinQt: Move frame dumping settings to new group box
2019-07-17 20:07:40 +02:00
f6a755e1ab
Change the default dumping bitrate from 2.5 Mbps to 25 Mbps
...
2.5 Mbps looks noticeably bad even at native resolution.
2019-07-17 19:55:37 +02:00
2b9389202e
VideoCommon: Remove unused MathUtil.h include from VideoCommon.h
...
This header doesn't actually make use of MathUtil.h within itself, so
this can be removed. Many other source files used VideoCommon.h as an
indirect include to include MathUtil.h, so these includes can also be
adjusted.
While we're at it, we can also migrate valid inclusions of VideoCommon.h
into cpp files where it can feasibly be done to minimize propagating it
via other headers.
2019-07-16 20:54:34 -04:00
13a454d603
Common/SettingsHandler: Use fmt for printing out the serial number
...
Same thing, less code.
2019-07-16 04:23:20 -04:00
af576839d8
Common/SettingsHandler: Use std::string_view where applicable
...
Allows passed in strings to be non-allocating.
2019-07-16 04:15:25 -04:00
9dd8f82e78
Merge pull request #8247 from lioncash/core-include
...
Core/HW/AddressSpace: Remove unnecessary inclusion of Core.h
2019-07-16 14:32:18 +10:00
2b00eefbef
DolphinQt/Debugger: Replace AddressSpace.h inclusions with a forward declaration
2019-07-15 23:20:26 -04:00
df0d4b6aea
Core/HW/AddressSpace: Remove unnecessary inclusion of Core.h
...
This is only included to satisfy the use of our type aliases. Given
that, we can just include CommonTypes.h, lessening dependencies on core
headers.
2019-07-15 23:13:55 -04:00
ac6d70b82b
Core/FifoAnalyzer: Use std::array where applicable
...
This lets us convert CalculateVertexElementSizes() from a function using
an out pointer into one that simply returns the array data as a return
value.
It also lets us dehardcode some values, as we can just query
std::array's size() member function instead.
2019-07-15 07:37:35 -04:00
73db402010
Core/FifoAnalyzer: Convert DecodeMode enum into an enum class
...
Makes the enumeration elements strongly typed.
2019-07-15 07:37:30 -04:00
1606528093
Merge pull request #8234 from JosJuice/version-in-title
...
Show Dolphin version in render window title
2019-07-15 13:05:08 +02:00
0b11f15158
Fix VolumeVerifier considering Wii Menu WADs to have wrong region
2019-07-15 12:42:13 +02:00
53779aa732
Core/FifoAnalyzer: Make functions internally linked where applicable
...
These functions are only used internally within FifoAnalyzer.cpp, so
they can be hidden from external use.
2019-07-14 20:37:21 -04:00
946571b759
TextureCache: Support reinterpreting formats for VRAM textures
2019-07-14 19:16:27 +10:00
77f406c8a8
TextureCache: Combine ApplyPaletteToEntry and ConvertTexture
2019-07-14 14:07:37 +10:00
dfae87d69a
TextureConversionShader: Swap bytes for RG8/GB8 format
...
Matches the software renderer.
2019-07-14 13:36:43 +10:00
533f6bfeb9
Merge pull request #8203 from JosJuice/android-no-copy-to-gameini
...
Android: Don't copy global INIs into game INIs
2019-07-13 18:05:04 +02:00
2f5e6cfff1
Merge pull request #8218 from leoetlino/context
...
Use separate libusb contexts to avoid thread safety issues
2019-07-11 17:28:19 +02:00
4c649d1a5d
Merge pull request #8238 from lioncash/video-stats
...
VideoCommon/Statistics: Minor cleanup changes
2019-07-11 20:34:48 +10:00
9c245655fb
VideoCommon/Statistics: Remove unused DECSTAT macro
...
This isn't used anywhere, so it can be removed. This also potentially
fixes an underlying compilation error waiting to happen, given DECSTAT
could have potentially been used, someone disables statistics (for
whatever reason), then gets a compilation error due to the #else case
not containing an empty definition of DECSTAT.
2019-07-10 23:40:13 -04:00
d4337eebde
VideoCommon/Statistics: Rename stats global to g_stats
...
Makes the global variable follow our convention of prefixing g_ on
global variables to make it obvious in surrounding code that it's not a
local variable.
2019-07-10 23:34:54 -04:00
9802a5e16b
VideoCommon/Statistics: Make all member functions non-static
...
Rather than making Statistics' member functions operate on the global
variable instance of itself, we can make these functions member
functions and operate on a by-instance state, removing the direct
dependency on the global variable itself.
This also makes for less reading, as there's no need to repeat "stats."
for all variable accesses.
2019-07-10 23:24:37 -04:00
a99c7d01e1
VideoCommon/Statistics: Normalize statistic variable names
...
Normalizes all variables related to statistics so that they follow our
coding style.
These are relatively low traffic areas, so this modification isn't too
noisy.
2019-07-10 23:19:10 -04:00
44fe5812b9
Fix FIFO player crashing when USE_MEMORYWATCHER is defined
2019-07-10 20:43:15 +02:00
d2d7bf5c3b
Common/DebugInterface: Remove GetInstructionSize()
...
This is completely unused, so it can be removed.
2019-07-09 14:19:40 -04:00
92c1782726
Common/DebugInterface: Mark a few member functions as const
...
Quite a few member functions act as a means to query information. Given
these don't actually modify object state, they can be made const.
2019-07-09 14:19:40 -04:00
d4d485b692
Common/DebugInterface: Make return value of GetColor() a u32
...
At its only usage point, its return value is stored into a u32, and the
default implementation returns 0xFFFFFFFF (-1), which would be an
unsigned integer. Given all of the bits are used to determine a color,
it makes slightly more sense to treat this as an unsigned value as
opposed to a signed one.
2019-07-09 14:19:38 -04:00
a9a9b193bb
Common/DebugInterface: Use forward declarations where applicable
...
We're allowed (by the standard) to forward declare types within
std::vector, so we can replace direct includes with forward declarations
and then include the types where they're directly needed.
While we're at it, we can remove an unused inclusion of <cstring>, given
nothing in the header uses anything from it. This also revealed an
indirect inclusion, which this also resolves.
2019-07-08 18:59:11 -04:00
98101bbbe4
Core: Use fmt where applicable for DebugInterface implementations
...
These are trivial enough that they're basically one-to-one conversions
with minor changes of syntax.
2019-07-08 18:52:59 -04:00
457bff92c1
Common/DebugInterface: Use u32 instead of unsigned int consistently
...
Previously u32 was being used for part of the interface and unsigned int
was being used for other parts. This makes the interface fully consistent by
using only one type.
We opt for u32 here given they communicate the same thing (for platforms
we care about where int is 32-bit), while also being less to read.
2019-07-08 18:52:45 -04:00
b1b9c6aa1e
Common/DebugInterface: Default virtual destructor
...
While we're at it, we can also default the constructor and destructor of
inheriting classes in their respective cpp file to prevent the
construction and destruction of non-trivial types being inlined into
other regions of code.
2019-07-08 17:44:58 -04:00
bc8778203e
Common/Watches: std::move strings where applicable
...
Allows calling code to move the std::string into the Watch instances,
avoiding copies.
2019-07-08 17:41:06 -04:00
f3579e788d
Show Dolphin version in render window title
...
This was in DolphinWX but not DolphinQt. It's useful for telling if
users who post screenshots have an up-to-date version of Dolphin.
The old implementation of this prepended the version in DolphinWX code
rather than Core code, but I thought it'd be simpler to do it in Core.
2019-07-08 15:03:00 +02:00
445759aed1
Mark "WASAPI (Exclusive Mode)" as translatable
...
While "WASAPI" doesn't need to be translated, "Exclusive Mode" does.
2019-07-07 18:22:22 +02:00
398aa2a9f9
Merge pull request #8231 from JosJuice/debugger-hidden
...
DolphinQt: Don't update debug widgets when hidden
2019-07-07 07:35:06 -04:00
da87638ea2
Fix GDB stub
2019-07-07 05:17:33 +01:00
92a655c8b9
DolphinQt: Don't update debug widgets when hidden
...
Saves on CPU usage when pausing/unpausing with the debugger disabled.
This is especially important when using frame advance rapidly.
2019-07-06 11:30:17 +02:00
64de900da4
Qt/ControllersWindow: Fix radio buttons not getting disabled
...
Only happens if the controller window hasn't been opened before.
2019-07-05 16:50:37 +02:00
ce30efc6cf
Common/GekkoDisassembler: Don't print out '\0' as a character
...
Prevents a few instructions from having mangled names in some cases.
2019-07-03 20:12:50 -04:00
e24789b4fb
Add a hotkey for inserting/ejecting the SD card
2019-07-03 22:44:51 +02:00
36166c9b4f
Android: Don't copy default game INIs into user game INIs
...
This isn't as serious as copying global INIs into user game INIs,
but still not good. We want to be able to remove settings from
default game INIs and have those removals apply.
2019-07-02 19:28:43 +02:00
7f841e9bfd
Android: Suggest deleting game INIs if they contain global INI data
2019-07-02 19:28:38 +02:00
7652023407
Android: Don't copy global INIs into game INIs
...
See the source code comment in the next commit for why this is bad.
2019-07-02 19:27:42 +02:00
0a7395bfba
Merge pull request #8128 from altimumdelta/FrameDumpUpgradePrep1
...
Code: Rename AVIDump to FrameDump
2019-06-30 21:13:19 +10:00
1df655e376
VideoCommon: Rename AVIDump to FrameDump
2019-06-30 13:02:39 +02:00
0d2c3e6efc
Merge pull request #8219 from Pokechu22/float-watch
...
Show values as floats in watch
2019-06-30 11:34:29 +10:00
ae0843f53d
Show values as floats in watch
2019-06-29 12:04:20 -07:00
e388f01e11
Merge pull request #8215 from CookiePLMonster/appverifier-sanitize
...
Fixed various errors spotted with Application Verifier
2019-06-30 01:27:25 +10:00
f151570b2d
Merge pull request #8118 from 8times9/move-windowontop
...
Qt/InterfacePane: Move "Keep Window on Top" to Render Window section
2019-06-30 00:46:12 +10:00
341ce45ed6
Merge pull request #8176 from VinDuv/handle-open-files
...
QtGui: Handle file open events
2019-06-29 22:22:46 +10:00
8a122de999
Merge pull request #8192 from Miksel12/qt-changes
...
Reorder graphics config
2019-06-29 22:21:53 +10:00
a88deda307
Merge pull request #8193 from lioncash/disasm
...
Common/GekkoDisassembler: Minor changes
2019-06-29 10:38:36 +02:00
0c626e6ebc
Merge pull request #8202 from lioncash/build
...
DolphinQt/CMakeLists: Leverage windeployqt for determining libraries and plugins to copy
2019-06-29 10:29:58 +02:00
0dfff81a56
Merge pull request #8205 from Techjar/crop-fix
...
VideoCommon/RenderBase: Fix crop
2019-06-29 10:24:37 +02:00
a9099fc96b
Merge pull request #8207 from lioncash/macro
...
VideoCommon/Statistics: Use std::array for projection values
2019-06-29 09:36:33 +02:00
274b52acb2
Merge pull request #8216 from CookiePLMonster/cpu-override-tick-fix
...
Fix CPU Clock Override checkbox not updating with GameINI
2019-06-29 08:48:01 +02:00
75b2b53be2
Merge pull request #8200 from randomstuff/detach_driver
...
Automatically detach/reattach bluetooth driver in passthrough
2019-06-29 08:46:59 +02:00
e647503eb2
Core/HW/WiimoteReal: add missing Linux include
...
IOLinux.cpp should include <sys/select.h> as it uses select() functionality.
On certain platforms it's included implicitly by other headers, which is why
it compiled before. This makes it also work on musl platforms.
2019-06-29 02:17:58 +02:00
58c78a495d
Merge pull request #8213 from JosJuice/filesystem-u8string
...
Work around C++20 std::filesystem changes related to u8string
2019-06-28 19:42:34 +02:00
6fd435fdff
Merge pull request #8208 from lioncash/fmt
...
Core/IOS: Use fmt where applicable
2019-06-28 18:53:47 +02:00
e50a6f4c46
Reorder graphics config
2019-06-26 21:59:47 +02:00
e85fa26768
BTReal: Use FromThread::ANY for USB transfer replies
...
libusb transfer callbacks might be called immediately during transfer
submission in some cases. (libusb doesn't even specify what thread
the callback is invoked on.) In other words, it is possible to reach
the transfer callback from the CPU thread, and not just from the
USB event handling thread.
So CoreTiming::FromThread::NON_CPU is incorrect and should instead
be ANY.
2019-06-26 17:55:51 +02:00
cf60a9a7f7
Use separate libusb contexts to avoid thread safety issues
...
Unfortunately, it appears that using libusb's synchronous transfer API
from several threads causes nasty race conditions in event handling and
can lead to deadlocks, despite the fact that libusb's synchronous API
is documented to be perfectly fine to use from several threads (only
the manual polling functionality is supposed to require special
precautions).
Since usbdk was the only real reason for using a single libusb context
and since usbdk (currently) has so many issues with Dolphin, I think
dropping support for it in order to fix other backends is acceptable.
2019-06-26 17:55:51 +02:00
09aadf0e9c
Fix CPU Clock Override checkbox not updating with GameINI - also bold it if it's overriden
2019-06-23 22:39:26 +02:00
5f0b4d8da5
Fix a crash in DSPTool on malformed command line
2019-06-23 21:55:51 +02:00
9eab3feddf
Fix out of bounds read in HttpRequest::Impl::Fetch logging
2019-06-23 21:44:51 +02:00
6c21811090
Make DolphinAnalytics a true singleton - static local variables are initialized in a thread safe manner since C++11
...
Also works around a Visual Studio 2017 bug where static inline class fields are destructed multiple times
2019-06-23 21:43:47 +02:00
dacba85a08
UpdaterCommon: Hide Updater before Dolphin quits
2019-06-23 19:47:18 +02:00
396546f5c0
Config/ARCodeWidget: Add option for alphabetical sorting
2019-06-22 19:54:13 +02:00
1d43d9afc1
Config/GeckoCodeWidget: Add option for alphabetical sorting
2019-06-22 19:54:13 +02:00
93393a288c
Qt/ARCodeWidget: Support drag and drop reordering
2019-06-22 19:54:13 +02:00
389351c6c0
Qt/GeckoCodeWidget: Support drag and drop reordering
2019-06-22 19:54:13 +02:00
c0a6fa5dcc
Work around C++20 std::filesystem changes related to u8string
2019-06-21 18:34:21 +02:00
d68f62c0f5
Core/NetPlayServer: Fix empty error messages when adding session to the index fails
2019-06-20 20:55:38 +02:00
84b9b37fef
Merge pull request #8210 from spycrab/httpreq_error_msg
...
Common/HttpRequest: Use CURLOPT_ERRORBUFFER for error messages
2019-06-20 10:59:25 -07:00
ba4c1c5947
Common/HttpRequest: Use CURLOPT_ERRORBUFFER for error messages
2019-06-20 19:44:51 +02:00
63bb646721
Fix opening controller config when there is no profile directory
...
https://bugs.dolphin-emu.org/issues/11771
2019-06-20 18:35:14 +02:00
980085e106
Core/IOS: Use fmt where applicable
2019-06-20 11:50:02 -04:00
c1c5276729
VideoCommon/VertexShaderManager: Use std::array where applicable
...
We can use this to shorten up the initialization code a little bit.
Despite being saved to savestates, this is a non-breaking change.
2019-06-20 08:13:04 -04:00
2e74a4447a
VideoCommon/Statistics: Remove unused setter macros for statistics
...
Now that the floating point members are assigned in bulk, we can remove
their setter macro. While we're at it, we can also remove the setter for
unsigned int, given it's not used.
2019-06-20 08:06:23 -04:00
04c06ec661
VideoCommon/Statistics: Use std::array for projection values
...
Makes the members within the interface much nicer to look at, and also
makes copying them over much nicer too.
2019-06-20 08:06:20 -04:00
3cafd0ae81
Merge pull request #8171 from Pokechu22/backend-changing-fix
...
Disallow changing the backend when running when software renderer is currently selected
2019-06-20 13:58:01 +02:00
4edf174b61
Merge pull request #8180 from lioncash/fmt
...
Core/Movie: Use fmt where applicable
2019-06-20 13:56:15 +02:00
973bba7c1e
Merge pull request #8191 from lioncash/ini
...
Common/IniFile: Use std::string_view where applicable
2019-06-20 13:44:20 +02:00
4885130799
Merge pull request #8194 from lioncash/common-msg
...
Common/MsgHandler: Tidy up interface and namespace code
2019-06-20 13:37:24 +02:00
baf02194c1
Merge pull request #8195 from lioncash/macro
...
VideoCommon/Statistics: Remove preprocessor macro
2019-06-20 13:29:27 +02:00
9c33f658a5
Simplify std::filesystem usage a little in Boot.cpp
...
If path_b is absolute, (path_a / path_b) will be the same as path_b.
2019-06-20 10:42:56 +02:00
fab15edb53
Replace <experimental/filesystem> includes with <filesystem>
...
https://bugs.dolphin-emu.org/issues/11770
2019-06-20 10:39:56 +02:00
4f1f55093f
Common/MsgHandler: Namespace code within the Common namespace
...
Closes another gap in the Common library where code isn't being
namespaced under it.
2019-06-19 16:03:55 -04:00
e7dd46a531
Common/MsgHandler: Brace if statement in MsgAlert
...
The condition travels more than one line, so the body should be braced.
While we're at it, make the comparison against nullptr explicit.
2019-06-19 16:03:33 -04:00
0eddf6dd8f
Common/MsgHandler: Use std::string's empty for emptiness checking in MsgAlert
...
Provides more straightforward code compared to negating a length check.
2019-06-19 16:00:16 -04:00
16afac9da9
Merge pull request #7927 from weihuoya/android-key-map
...
android: simplify config loading code
2019-06-19 11:51:00 +02:00
08421db52f
VideoCommon/RenderBase: Fix crop
...
This fixes some mistakes from #8049 that caused crop to behave like
stretch and have a funny offset.
2019-06-18 18:34:13 -04:00
ff96dc0e6f
Merge pull request #8199 from lioncash/namespace
...
General: Use nested namespace specifiers where applicable
2019-06-18 11:33:08 +02:00
Stenzek