70ee5234ba
Merge pull request #8188 from JosJuice/android-game-details
...
Android: Bring back and update the game details dialog
2019-11-25 11:31:37 +01:00
8339793918
Android: Fix displaying checkbox settings with no description
...
https://bugs.dolphin-emu.org/issues/11904
2019-11-25 00:14:40 +01:00
ac77df9e90
Merge pull request #8490 from vadosnaprimer/dumping
...
2 minor dumping fixes
2019-11-25 10:38:44 +13:00
45ba745bc8
Merge pull request #8320 from CookiePLMonster/cpu-lock-yield-fix
...
Do not yield to UI from PauseAndLock
2019-11-24 20:12:04 +01:00
cb6a632c60
fix missing frame when you start another dump without closing dolphin
2019-11-24 18:02:38 +03:00
15e6e7ddd2
figure out new segment on the fly right in FrameDump::Start()
2019-11-24 18:02:36 +03:00
17a0336b53
Merge pull request #8489 from lioncash/ui-fmt
...
UICommon: Make use of fmt where applicable
2019-11-24 12:08:58 +01:00
b28db1d4e6
UICommon: Make use of fmt where applicable
...
Continues the migration to using fmt.
Notably, this allows safely converting a map within USBUtils over to
containing string view instances, rather than std::string instances, as
fmt safely handles the formatting of string views.
2019-11-23 19:41:40 -05:00
ec895f544c
Merge pull request #8486 from lioncash/dualshock
...
InputCommon/DualShockUDPClient: Minor cleanup
2019-11-24 00:46:19 +01:00
3a2d3aa9d2
Merge pull request #8488 from tinyredpanda/simplify-wstring-conversion
...
Simplify wstring to QString conversion
2019-11-24 00:17:32 +01:00
6fbbc2683e
VideoCommon: Make use of fmt outside of shader generators
...
Migrates most of VideoCommon over to using fmt, with the exception being
the shader generator code. The shader generators are quite large and
have more corner cases to deal with in terms of conversion (shaders have
braces in them, so we need to make sure to escape them).
Because of the large amount of code that would need to be converted, the
conversion of VideoCommon will be in two parts:
- This change (which converts over the general case string formatting),
- A follow up change that will specifically deal with converting over
the shader generators.
2019-11-23 16:00:45 -05:00
9639dde114
Address review comments on old code
2019-11-23 17:48:44 +01:00
8e2b12e1ea
GameDetailsDialog: Use labels instead of icons
2019-11-23 17:48:44 +01:00
2e13353201
GameDetailsDialog: Convert layout to ConstraintLayout
...
This also removes the FAB from GameDetailsDialog. It was
previously outside of the visible area and thus unusable.
2019-11-23 17:48:43 +01:00
4f1511043c
GameDetailsDialog: Fix banner placeholder
2019-11-23 17:48:43 +01:00
ec91674d07
GameDetailsDialog: Show game ID and revision
2019-11-23 17:48:43 +01:00
84e616337d
GameDetailsDialog: Remove the screenshot ImageView
...
It takes up a lot of space on the screen, and the functionality for
saving these screenshots isn't in Dolphin anymore as far as I can tell.
2019-11-23 17:48:43 +01:00
100e7e2b3d
GameDetailsDialog: Hide description if empty
...
In particular, Wii games don't have descriptions.
2019-11-23 17:48:43 +01:00
100f032e2f
GameDetailsDialog: Don't use CircleImageView for banners
...
Because trying to fit a 3:1 banner into a circle looks very awkward.
Also move the banner below the title/description now that it
takes up more space horizontally.
2019-11-23 17:48:42 +01:00
fcb96a179d
GameDetailsDialog: Actually load the banner
2019-11-23 17:48:42 +01:00
c2952c466f
Bring back game banner loading code deleted in 3f21975
2019-11-23 17:48:42 +01:00
5ed0cf8e0e
Rename GameSettingsDialog to GamePropertiesDialog
...
Since it no longer only contains settings.
2019-11-23 17:48:42 +01:00
00c4dad784
Android: Bring back the game details dialog
...
It was made inaccessible in e19922c593b697
2019-11-23 17:48:41 +01:00
870912722e
Revert "Android: Remove dead code and related lib <circleimageview>"
...
This reverts commit 593b69728d
2019-11-23 17:35:19 +01:00
4305a9ac57
Merge pull request #8482 from rafaeltoledo/rt/material-fix
...
Moves AlertDialogs imports to AndroidX and fix tabs background color
2019-11-23 16:56:39 +01:00
fe9e7d5578
Prefer MessageBoxW to MessageBoxA
2019-11-23 13:56:05 +00:00
8453277479
Moves `AlertDialog`s imports to AndroidX and fix tabs background color
2019-11-23 10:50:12 -03:00
5dbabef355
Simplify wstring to QString conversion
2019-11-23 13:23:46 +00:00
334e2768f5
InputCommon/DualShockUDPClient: Use an alias for the clock type
...
Makes code slightly less verbose without exposing the whole chrono
header to the current source file.
2019-11-22 17:06:10 -05:00
db9e592765
InputCommon/DualShockUDPClient: Use deduction guides for lock_guard
...
With C++17, we can use template deduction guides provided by the
standard library. This allows the omission of the mutex type itself.
2019-11-22 17:06:10 -05:00
278d03f737
InputCommon/DualShockUDPClient: Make use of std::array where applicable
...
Provides the same semantics of a C array, but is much nicer to work
with.
Notably, it makes all cases of performing comparisons with said arrays
significantly less reading-involved.
2019-11-22 17:06:07 -05:00
5be9505ab3
Signal DSP thread after unlocking DSP mutex
2019-11-22 23:00:42 +01:00
a06da596e5
Merge pull request #8485 from lioncash/imu
...
InputCommon/IMU*: Remove unnecessary includes
2019-11-22 22:31:57 +01:00
af37d09b0f
Merge pull request #8484 from lioncash/input-func
...
InputCommon/FunctionExpression: Minor cleanup
2019-11-22 22:31:31 +01:00
e30ff7c327
DSPLLE: Put DSP thread in idle state if it's paused to prevent a deadlock
...
DSP thread is considered "idle" when it signals s_ppc_event and waits for s_dsp_event,
without putting it in this state when m_dsp_thread_mutex is locked it was possible to
create a deadlock between a DSP thread, emulation thread and Qt thread by accessing
Config menu immediately after booting up the game
2019-11-22 22:07:41 +01:00
67097b4574
InputCommon/DualShockUDPClient: Relocate settings to top of source file
...
This is a small namespace, so we can move it to the top of the file to
get it out of the way of everything else.
2019-11-22 15:56:29 -05:00
4488719a76
InputCommon/DualShockUDPClient: In-class initialize members where applicable
...
Deduplicates members within the constructor's initializer list.
2019-11-22 15:56:29 -05:00
544d6cbe52
InputCommon/DualShockUDPClient: Add missing header guard
...
Prevents potential inclusion issues from occurring.
2019-11-22 15:56:26 -05:00
91993b46d9
InputCommon/IMU*: Remove unnecessary includes
...
Trims out unnecessary includes to avoid unnecessary header dependencies.
This also resolves indirect inclusions of <optional> within
IMUAccelerometer.h and IMUGyroscope.h
2019-11-22 15:41:38 -05:00
814fd165af
InputCommon/FunctionExpression: Use Yoda conditions, we do not
...
The general convention in the codebase is to compare the non-constant
value/string with the constant value/string, not the other way around.
2019-11-22 15:36:18 -05:00
1f6077922b
InputCommon/FunctionExpression: Remove unnecessary 'else' in MakeFunctionExpression()
...
Given all conditional bodies only contain a return, the use of else here
isn't necessary.
This has the benefit of consistently vertically aligning the names.
2019-11-22 15:36:18 -05:00
10fea99d80
InputCommon/FunctionExpression: Make MakeFunctionExpression() take a std::string_view
...
There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
2019-11-22 15:36:18 -05:00
ddf8abf507
InputCommon/FunctionExpression: Remove unused LOOP_MAX_REPS constant
...
This isn't used anywhere in the translation unit, so we can remove it.
2019-11-22 15:36:18 -05:00
64bc6f53fd
InputCommon/FunctionExpression: Remove cyclical include
...
This header was including itself, which is likely not intended.
2019-11-22 15:36:18 -05:00
cb8fbe872e
InputCommon/FunctionExpression: Collapse namespaces
...
Since we target C++17, we can collapse the namespaces into a single
declaration specifier.
2019-11-22 15:36:14 -05:00
28f7c5fb2a
Merge pull request #8483 from lioncash/input
...
InputCommon: Make use of fmt where applicable
2019-11-22 20:53:11 +01:00
6586ecc7a8
InputCommon/FunctionExpression: include <algorithm>
...
std::min/std::max are used within this translation unit, so it needs to
be included to prevent potential compilation failures.
2019-11-22 14:41:13 -05:00
e8edc49bbe
InputCommon: Make use of fmt where applicable
...
Continues the migration over to fmt
2019-11-22 14:38:26 -05:00
5b6e7aabcf
Fixed 11874 (leading 0s ignored by debugger)
2019-11-22 19:16:34 +00:00
bc449fb98f
Merge pull request #8480 from JosJuice/volumeverifier-block-future
...
VolumeVerifier: Fix a copypaste error
2019-11-22 11:42:50 -05:00
JosJuice