Commit Graph

18325 Commits

Author SHA1 Message Date
YoshiRulz f79b7e5be4
Fix order of arguments to GetRelativePath
These have been backwards since the feature was added (5f2e2f39b). Does the
Windows implementation of GetRelativePath not return weird results?
2021-01-10 22:43:40 +10:00
YoshiRulz ea0d6b04d8
Fix code style 2021-01-10 19:30:18 +10:00
alyosha-tas bcee6d4d39 Fix syncless recorder 2021-01-09 22:20:16 -05:00
alyosha-tas a67d01f04d Update cheat inde on button press: Fixes #2550 2021-01-09 20:05:10 -05:00
nattthebear 75a655fdd8 Fix screwup in romloader xmlgame handling
This may have only affected Saturn in practice.  Whoops!  Fixes #2557.
2021-01-09 11:45:16 -05:00
YoshiRulz 9ed56cdc6e
Remove cached global ICodeDataLogger (emu core) in CDL (fixes #2553)
fixes 234642ed0; this was never going to work because the setter will only be
called by `ServiceInjector.UpdateServices` during a core restart, at which time
the previous core should already have been `Dispose`d. If you want to call
`.SetCDL(null)` on the core when restarting (even though closing the CDL window
already does that three times?), do it in the core's `Dispose` implementation.
2021-01-09 23:13:36 +10:00
YoshiRulz 71ad6deff3
Ensure existing global IEmulator is disposed when reassigning it 2021-01-09 23:02:22 +10:00
YoshiRulz 5078ac392b
Simplify null-safety checks in GetEnumFromDescription<T : Enum> 2021-01-09 05:13:57 +10:00
YoshiRulz 979afcb54d
Do something cleverer than throwing NRE in a few places 2021-01-09 05:08:09 +10:00
YoshiRulz e976e0c2ad
Use nameof in DeepEquality, fix typo 2021-01-09 04:54:02 +10:00
nattthebear ecafbde89d Let's not break the entire fucking program brahs 2021-01-08 13:41:15 -05:00
YoshiRulz 0272684cdf
Fix domain names in GBHawk CDL (fixes #2552)
fixes 7e00b7892
2021-01-09 02:55:14 +10:00
nattthebear 5a8c58de3c Look mom, I'm using the new C# 2021-01-08 08:52:24 -05:00
nattthebear cbdcba9643 Fix BS93 garbage
Probably.  Not sure what this does anymore, but 4 is right and 6 is wrong.
2021-01-06 11:20:37 -05:00
YoshiRulz 0ea597ded5
Fix GBA Game Shark code conversion (fixes #2545) 2021-01-06 18:47:05 +10:00
YoshiRulz fa5ed36f63
Add boilerplate for unit testing GameSharkDecoder
should fail without the following commit
2021-01-06 18:46:36 +10:00
YoshiRulz ab3846906f
Use type checks for DecodeResult/InvalidCheatCode 2021-01-06 17:25:05 +10:00
YoshiRulz 966b8a974a
string.Trim doesn't remove NUL
I'm also skeptical of the `if (bs93/*=br.ReadBytes(6)*/ == "BS93") { ... }` just
after this, it doesn't seem the condition can ever be met...
2021-01-06 16:54:23 +10:00
YoshiRulz c1a734a04d
Update the NuGet deps which should be safe to update 2021-01-02 20:31:54 +10:00
YoshiRulz 4e668612c7
Convert LoadCueJob.TrackInfo to a readonly struct 2021-01-02 20:15:17 +10:00
YoshiRulz 84a6c5a426
Convert CUE_File.Command.* to readonly structs with a superinterface 2021-01-02 20:05:06 +10:00
YoshiRulz 277f57eebd
Convert CompileCueJob.CompiledCueIndex to a readonly struct 2021-01-02 18:35:00 +10:00
YoshiRulz d87066c634
Convert Blob_ECM.IndexEntry to a readonly struct 2021-01-02 18:14:12 +10:00
YoshiRulz bb1f7da864
Remove duplicate class Blob_WaveFile.Blob_RawFile 2021-01-02 17:52:23 +10:00
YoshiRulz 449130e081
Move inner classes of Disc up a level, make Disc not partial 2021-01-02 17:40:39 +10:00
YoshiRulz e24c4c3971
Move CDFS (iso-parser) to new external project, update upstream info 2021-01-02 17:34:13 +10:00
YoshiRulz 333cae15cd
Convert IN_* props of jobs to ctor-initialised readonly fields 2021-01-02 16:10:57 +10:00
nattthebear f284fda3a6 Object.Equals(object) overrides should not throw
Especially not if you pass null.  null is simply not equal to this, that's all.  The post condition is satisfiable; you can return false.
2021-01-01 17:06:59 -05:00
YoshiRulz 51b62629c6
Enable nullability in most of the remaining files in BizHawk.Common 2021-01-02 02:39:13 +10:00
SuuperW 021d8e6e92 Fix: LuaSandbox wasn't reverting current directory after sandboxed operations. Appears to be a regression from commit 5e89e56. 2021-01-01 06:34:05 -06:00
alyosha-tas 89c69c382c GBHawk: implement LCDC write glitch for gbc-acid-hell 2020-12-30 19:31:30 -05:00
YoshiRulz 90c0214d5e
Add prop IMemoryApi.MainMemoryName, further delegate mainmemory lib 2020-12-30 16:02:05 +10:00
YoshiRulz 1619b33e8e
Fix overlapping/duplicate controls in FirmwaresConfig's menu on Mono 2020-12-30 01:25:30 +10:00
YoshiRulz a80dbfa76b
Fix crash when clicking on column headers in FirmwaresConfig on Mono 2020-12-30 00:07:47 +10:00
YoshiRulz d0edf350f2
Finish my nullability pass over ControlExtensions.cs 2020-12-30 00:03:39 +10:00
YoshiRulz 2de32ed59a
Move more sound classes to Client.Common 2020-12-29 17:04:02 +10:00
YoshiRulz 9cfe9485ef
Fix covariant arrays (passing ASupertype[] where AType[] is expected) 2020-12-29 16:53:31 +10:00
YoshiRulz 206a3e30c8
Cleanup instantiation of FirmwaresManager and PathConfig
and remove unused MainForm interface prop
2020-12-29 16:26:01 +10:00
YoshiRulz 18ebfecc97
Move GuiApi (impl.) to Client.Common 2020-12-29 15:53:47 +10:00
YoshiRulz 7edf3b36ad
Extract a tiny interface from DisplayManager for ApiHawk 2020-12-29 15:52:57 +10:00
YoshiRulz 0704db5940
Move OSDManager to Client.Common and move types to own files 2020-12-29 15:40:13 +10:00
YoshiRulz 23a8387dc1
Replace IBlitterFont w/ the type wrapped by its sole inheritor 2020-12-29 15:36:37 +10:00
YoshiRulz 47670714b5
Remove WinForms dep from GuiApi (impl.) 2020-12-29 15:08:01 +10:00
YoshiRulz 8e67d82bd5
Rename file to match type name 2020-12-29 15:00:55 +10:00
YoshiRulz f431faf65c
Move some DiscoHawk logic to Emulation.DiscSystem 2020-12-29 15:00:25 +10:00
YoshiRulz 1a21765be6
Fix assembly resolution in DiscoHawk on Mono
without this the program wouldn't open at all, I assume all of its actual
functions will just workTM now
2020-12-29 01:33:57 +10:00
YoshiRulz a0c7e9c7fb
Fix non-string resource in DiscoHawk 2020-12-29 01:26:56 +10:00
YoshiRulz c0cf40b68e
Check for MAME's lib before instantiating the MAME core (fixes #2538) 2020-12-29 01:04:36 +10:00
nattthebear f4e98fd9bd
Refactor ZWinderBuffer to allow use of arbitrary backing Streams (#2536) 2020-12-27 18:36:42 -05:00
YoshiRulz bcf5347823
Use C# 9 improvements to switch / "pattern matching" 2020-12-28 00:07:06 +10:00