Commit Graph

85 Commits

Author SHA1 Message Date
adelikat a40e37eda6 Qunatizer - delete more unused stuff, removes a warning 2020-03-19 10:23:36 -05:00
adelikat e16dc33722 move some PathManager methods to a PathUtils class in BizHawk.Common 2020-03-15 15:59:10 -05:00
adelikat 33a14327b7 move most logic from PathManager to extension methods in BizHawk.Common 2020-03-15 15:45:11 -05:00
adelikat 348cbd18df
Remove PathManager code that had dependencies on Globals (#1881)
* move one usage of Firwmare method into Firmware config where it is better suited

* PathManager - remove unused code

* move some PathEntry specific logic out of PathManger and into PathEntryCollection extension methods

* PathManager - detangle some exe pathing logic from Global.Config usage, clarify what a completely broken method should actuall do

* move more logic from PathManager to PathEntryCollection extension method

* move absolute path creation to PathEntryCollection, lots of refactoring and simplifying of PathEntries usage

* simplify PathEntryColleciton usage more

* simplify PathEntryCollection more

* break PathEntry classes into separate files, a bit of cleanup

* move Rom path logic out of PathManager into PathEntryCollectionExtensions

* move config UseRecentForRoms and LastRomPath into PathEntries, note that this is a breaking change for previous configs, those values will revert back to default values

* move SaveRamPath logic from PathManager to PathEntryCollections

* move cheats path logic from PathManager to PathEntryCollection

* move another method out of PathManager

* move some Retro hacks to PathEntryCollections, exposes more implicit dependencies

* move savestate logic out of PathManager to PathEntryCollection

* move more logic out of PathManager

* move some savestate logic out of PathManager, move most to MainForm where it is used, detangle some implicit dependencies from SaveSlotManager

* rename method

* move more logic from PathManager to PathCollectionEntry

* movie final Global.Config.PathEntries logic out of PathManager and into PathEnties
2020-03-15 15:12:36 -05:00
adelikat a884282fa4 remove CoreComm NominalX/Y, those values never different from buffer w/h for cores that set them which were only the gb/gba platforms and the original dualGb. The result defaulted to a very random 640x480. Instead just use the buffer w/h, which is a very reasonable video default 2020-03-14 17:06:42 -05:00
adelikat 9584ff1f53 use switch expressions in some various places in EmuHawk, and some other simplifications 2020-03-04 20:18:43 -06:00
adelikat dff8a536f0 address some typos 2020-02-28 13:09:05 -06:00
adelikat e744511573 misc cleanups 2020-02-25 15:14:14 -06:00
adelikat 72d4b0ac46 use inline out 2020-02-25 15:14:13 -06:00
YoshiRulz 3afcf416e8
Follow attribute class best practices, cleanup docs on attributes 2020-02-19 03:54:50 +10:00
Zach 61fff4cbce
Fix ffmpeg race condition. (#1841) 2020-02-18 07:25:52 -06:00
adelikat 626efe8caf put control extension methods into the EmuHawk names space isntead of a custom one. We want these to be found and used, and most dialogs use them 2020-02-03 12:54:32 -06:00
adelikat ef13754f79 consistent variable naming in config.cs 2020-01-25 10:57:39 -06:00
YoshiRulz b1e02fbdce
Enable SA1106 and fix noncompliance
"Code should not contain empty statements"
i.e. don't put a semicolon there
2020-01-25 18:06:34 +10:00
YoshiRulz bfde89b9f3
Enable SA1139 and fix noncompliance
"Use literal suffix notation instead of casting"
2020-01-25 07:55:48 +10:00
YoshiRulz 126bb4736b
Move commented-out code blocks to #if false
CBB doing Cores or Bizware
2020-01-13 11:14:16 +10:00
YoshiRulz dd4f9aaf64
Use ranges 2020-01-13 06:59:40 +10:00
adelikat 8885b38281 quantizer code - space to tabs, other cleanups 2020-01-03 18:35:13 -06:00
adelikat 101a403420 cleanups in AV code 2020-01-03 18:25:46 -06:00
YoshiRulz 060255471b
Improve exception docs in BizHawk.Client.EmuHawk 2020-01-02 21:51:37 +10:00
adelikat 0f33e2b1e7 cleanup display manager code 2019-12-31 11:14:10 -06:00
adelikat 0082de7c0a cleanup Quantizer.cs 2019-12-31 10:24:57 -06:00
adelikat 64ea9afee5 cleanups 2019-12-31 10:17:55 -06:00
YoshiRulz 7cd29c0f54
Finish moving Win32 imports to BizHawk.Common, organise, and cleanup 2019-12-21 18:33:11 +10:00
YoshiRulz 7ea8fb185a
Congregate, organise, and cleanup some Win32 imports and their usages 2019-12-21 18:21:51 +10:00
adelikat 28305339f9 VideoWriterChooserForm - pass in dependencies 2019-12-17 09:50:38 -06:00
adelikat 6be6dbbce6 cleanup VideoWriterChooserForm 2019-12-17 09:46:03 -06:00
YoshiRulz 8c059aa43c
Replace helper methods with readonly bool IsUnixHost and cleanup 2019-11-04 14:30:05 +10:00
adelikat 942d9fc75e Simplify OS checks with some helpful methods 2019-11-03 16:04:42 -06:00
YoshiRulz b7249a99a5
Extract shell command helpers 2019-08-12 20:00:42 +10:00
YoshiRulz 2642ef4049
Remove empty docs 2019-06-06 16:41:10 +10:00
YoshiRulz ceb490828f
Fix docs "not placed on a valid language element" 2019-05-29 21:04:12 +10:00
YoshiRulz 35056ae2d9
Remove #if WINDOWS, using runtime check where applicable 2019-05-18 20:17:02 +10:00
James Groom 779975f689
Use nameof 2019-03-28 14:17:14 +11:00
YoshiRulz e6374ef477
Use string interpolation 2019-03-19 00:06:37 +10:00
zeromus b23cba072b fix ffmpeg webm support (fixes #1477) 2019-02-05 15:29:40 -05:00
nattthebear 0114e39489 change all uses of -c:a libvo_aac to -c:a aac because the ffmpeg we're packaging now no longer supports the former 2019-01-20 09:20:52 -05:00
feos d1e7fc10fd make ffmpeg segment numeration the same as vfw has 2018-09-21 23:43:50 +03:00
feos 0869c4b31c ffmpeg writer:
- make all formats editable (only custom is saved tho)
- deduce extension (since -f is required)
- restore ffv1
- fix #1325
2018-09-16 00:31:09 +03:00
feos 9d64e23982 ffmpeg dumper: ffv1 is dead, long live libx264rgb!
http://tasvideos.org/forum/viewtopic.php?p=473878#473878
2018-08-23 20:09:06 +03:00
feos 50fdeb59e1 ffmpeg writer: lossless avi command (ffv1, dolphin style)
reorder options, make commands easier to read
2018-02-25 15:03:47 +03:00
nattthebear aac25082d0 Video dumping: Store the audiosync option in configuration, and default it to true. If the emulator's av output is perfect, the two will produce identical results. In every instance I'm aware of where the emulator's av output is not perfect, the audio sync mode will produce better results. 2017-06-16 14:11:43 -04:00
nattthebear 803190e6b4 protip: When refactoring, it's not OK to just make it not work. Fixes #873 2017-06-15 20:40:38 -04:00
nattthebear ebe789eed2 heh 2017-05-10 07:45:23 -04:00
adelikat 59139ab266 Spell out Numerator and Denominator 2017-05-05 11:25:38 -05:00
adelikat 62a13d961d Move VsyncNum and VsyncDen out of CoreComm and into IVideoProvider 2017-05-05 11:21:37 -05:00
J.D. Purcell 3d6b1da94d Whitespace only (indentation fixes/cleanup). 2017-04-19 20:34:30 -04:00
adelikat 912a2d7346 misc code cleanups in AV code 2017-04-18 12:27:44 -05:00
J.D. Purcell ed3bf0e62b Fix mixed line endings. 2017-04-15 15:53:02 -04:00
J.D. Purcell b2a28339d1 Use 'nameof' operator. 2017-04-10 08:36:42 -04:00