ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Video dumping: Store the audiosync option in configuration, and default it to true. If the emulator's av output is perfect, the two will produce identical results. In every instance I'm aware of where the emulator's av output is not perfect, the audio sync mode will produce better results.

This commit is contained in:
nattthebear 2017-06-16 14:11:43 -04:00
parent a4c6d04a18
commit aac25082d0
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BizHawk.Client.Common/config/Config.cs
View File

@ -398,6 +398,7 @@ namespace BizHawk.Client.Common
public string AVICodecToken = "";
public int GifWriterFrameskip = 3;
public int GifWriterDelay = -1;
public bool VideoWriterAudioSync = true;
#region emulation core settings

3
BizHawk.Client.EmuHawk/AVOut/VideoWriterChooserForm.cs
View File

@ -47,7 +47,7 @@ namespace BizHawk.Client.EmuHawk
/// <param name="list">list of IVideoWriters to choose from</param>
/// <param name="owner">parent window</param>
/// <returns>user choice, or null on Cancel\Close\invalid</returns>
public static IVideoWriter DoVideoWriterChoserDlg(IEnumerable<VideoWriterInfo> list, IWin32Window owner, out int resizew, out int resizeh, out bool pad, out bool audiosync)
public static IVideoWriter DoVideoWriterChoserDlg(IEnumerable<VideoWriterInfo> list, IWin32Window owner, out int resizew, out int resizeh, out bool pad, ref bool audiosync)
{
VideoWriterChooserForm dlg = new VideoWriterChooserForm
{
@ -76,6 +76,7 @@ namespace BizHawk.Client.EmuHawk
c.Enabled = false;
}
dlg.checkBoxASync.Checked = audiosync;
DialogResult result = dlg.ShowDialog(owner);
IVideoWriter ret;

3
BizHawk.Client.EmuHawk/MainForm.cs
View File

@ -3120,6 +3120,7 @@ namespace BizHawk.Client.EmuHawk
videowritername = Global.Config.VideoWriter;
}
_dumpaudiosync = Global.Config.VideoWriterAudioSync;
if (unattended && !string.IsNullOrEmpty(videowritername))
{
aw = VideoWriterInventory.GetVideoWriter(videowritername);
@ -3127,7 +3128,7 @@ namespace BizHawk.Client.EmuHawk
else
{
aw = VideoWriterChooserForm.DoVideoWriterChoserDlg(VideoWriterInventory.GetAllWriters(), this,
out _avwriterResizew, out _avwriterResizeh, out _avwriterpad, out _dumpaudiosync);
out _avwriterResizew, out _avwriterResizeh, out _avwriterpad, ref _dumpaudiosync);
}
if (aw == null)