YoshiRulz
4fc3d9bd40
Update Meziantou.Analyzer and enable new rule MA0160
...
"Use ContainsKey instead of TryGetValue"
I checked the source and MA0159 "Use 'Order' instead of 'OrderBy'" looks
for the LINQ method in the BCL specifically, not by signature, so we
can't replace our bespoke `OrderBySelfAnalyzer` :(
2024-09-02 22:34:11 +10:00
CasualPokePlayer
57d6355083
Use VersionInfo user agent for rcheevos too
2024-09-01 12:41:25 -07:00
YoshiRulz
e9aba0557e
Use correct product name in `User-Agent` value
2024-09-02 05:31:19 +10:00
YoshiRulz
cda23dd38e
Move `User-Agent` value to `VersionInfo` and ensure it's valid
...
fixes e22082c6b
2024-09-02 05:21:56 +10:00
CasualPokePlayer
133ff5a77e
Suppress the context menu if right click has a binding
2024-08-31 19:07:57 -07:00
CasualPokePlayer
e22082c6b4
Set a user agent for HttpCommunication
2024-08-31 19:07:57 -07:00
YoshiRulz
5b5652d01e
Revert "Update VersionInfo.cs"
...
This reverts commit b9d8af8854
.
Per https://github.com/TASEmulators/BizHawk/wiki/Release-checklist this
should be done immediately before release.
The reason for that is to avoid having several values for dev builds
between releases, a "stable API" if you will.
2024-08-31 22:50:44 +10:00
feos
b9d8af8854
Update VersionInfo.cs
2024-08-31 09:46:54 +03:00
YoshiRulz
c138e38951
Ask the user to reconsider quitting if A/V recording ( resolves #4017 )
2024-08-31 12:34:35 +10:00
YoshiRulz
31b0a29d2d
Refactor `MainForm`'s `Closing` handler
2024-08-31 11:37:55 +10:00
CasualPokePlayer
aeda8f1659
Add microphone button for melonDS
...
This changes the behavior so the user just has to press the microphone button to blow the mic, where the volume of the blowing can be controlled with the mic volume axis (but now the neutral value of mic volume is 100 rather than 0)
2024-08-30 17:35:18 -07:00
CasualPokePlayer
1ce8b855c7
remove app.config dpi stuff
...
mono does not like this (fixes #4002 )
2024-08-30 17:11:22 -07:00
CasualPokePlayer
d70daae5d6
Create Contains impl for arrays, fix device id blacklist detection
2024-08-30 16:10:54 -07:00
CasualPokePlayer
c54102b3a6
prevent Broadwell gpus from using GL interop
...
a user reported to me they just get a crash in DxopenDevice, although yet their pc does not have a dual gpu setup, indicating the drivers for their gpu are rather bad
Intel HD Graphics 5500 was the specific gpu, but i'll just be safe and blacklist all of Broadwell
2024-08-30 01:07:15 -07:00
Morilli
ea1dcf5b22
Simplify SearchEngineSettings ctor
2024-08-30 02:23:40 +02:00
Morilli
82fa98fc7d
Ensure the ram search changes column is in a consistent state
...
the settings store whether or not the column should be visible even though that should be controlled by the Mode setting alone
2024-08-30 02:21:39 +02:00
YoshiRulz
10ebea4dda
Ban `BitConverter.To*`
...
I was hoping not to mute this Analyzer for the Cores project, but there
were a couple usages of `BitConverter` there that were too far gone into
dumb territory to fix in this commit
2024-08-30 00:17:01 +10:00
Morilli
15ac8e2905
Fix cursor icon position in horizontal tastudio orientation
...
necessary with 00228a1f20
2024-08-29 08:22:25 +02:00
YoshiRulz
f09e72e7e0
Clean up `WatchValueBox.SetFromRawInt`
2024-08-29 06:43:14 +02:00
Morilli
d479cb4366
Delete ConversionTests.cs
2024-08-29 06:23:56 +02:00
Morilli
a51ed03c02
move ReinterpretAsF32 to a common location and use it more
...
as well as its inverse
2024-08-29 06:17:40 +02:00
Morilli
5588d68e4a
make DifferentBy uint as well
2024-08-29 05:54:05 +02:00
Morilli
b4bcb5755d
fix some exception types
...
can these even occur?
2024-08-29 05:39:48 +02:00
Morilli
6d9c74b7ea
change a bunch of stuff to uint
...
- closes #4001
2024-08-29 05:35:50 +02:00
Morilli
564b916499
remove unused function
2024-08-29 05:35:27 +02:00
Morilli
3c218c6642
Optimize RamSearchEngine.Preview
2024-08-29 05:35:27 +02:00
CasualPokePlayer
53436e81f5
fix GDI+ on Linux (again)
2024-08-28 20:26:00 -07:00
YoshiRulz
ef028dfea4
Add comment to `TasMovie.AddTasProjLumps`
...
fixes 884110e61
2024-08-29 13:11:27 +10:00
Morilli
884110e61a
Fix TasMovie save when TasStateManager is null
2024-08-28 03:47:38 +02:00
Morilli
74dcd81b85
don't control stop movie in TAStudio movie load
...
was removed in b6a0688be0
, and while not strictly required this will leak TasMovies otherwise.
2024-08-28 03:47:38 +02:00
Morilli
8956657a34
lazy-initialize TasStateManager and markers
...
This is a bit of a dangerous change. Ideally this will fix the TasStateManager being initialized twice for loaded movies and have no other noticable effect.
2024-08-28 03:46:14 +02:00
Morilli
532dc06e64
tweak TasMovie.StartNewRecording slightly
...
StartNewRecording is now always called for new tas projects in TAStudio, and the marker change code in there caused the Changes bool to get set and never cleared.
2024-08-27 23:43:55 +02:00
Morilli
b6c031beaa
Update window titles properly in TAStudio
...
Some change at some point removed code that implicitly triggered window title updates, so they weren't always correct now.
2024-08-27 23:41:52 +02:00
Morilli
4194870f6f
Add tasmovies to recent list on load
...
This was removed in 42aa9d991d
, but I don't remember if it was intentional or a mistake.
In any case it feels bad to open tas movies and not get them added to the recent list.
2024-08-27 23:37:48 +02:00
Morilli
00228a1f20
Tweak some InputRoll values
...
- see #3708
A bit experimental, let's just see how it feels.
2024-08-27 18:53:06 +02:00
YoshiRulz
eaf9906741
Leave a note re: `$(EmitCompilerGeneratedFiles)`
2024-08-27 22:57:33 +10:00
CasualPokePlayer
3c1248547f
This should be Max, not Min
2024-08-25 22:10:27 -07:00
CasualPokePlayer
0a9c2dc276
Don't allow 0 width/height rectangle to be used with GDI+'s buffered graphics
2024-08-25 22:09:10 -07:00
CasualPokePlayer
f9883f6700
remove ?
2024-08-25 18:32:53 -07:00
CasualPokePlayer
f18c2467de
Undo previous commits, try setting glx depth explicitly (probably isn't what's needed? maybe it is? ehhh)
...
TODO: this seems to be an issue anyways with buggy nvidia drivers under xwayland, perhaps that setup can be detected and forced over to GDI+?
2024-08-25 18:30:10 -07:00
CasualPokePlayer
516a021add
Try making this actually work
2024-08-25 17:37:41 -07:00
CasualPokePlayer
bb456e45be
Try to workaround some Linux Nvidia driver bug
2024-08-25 15:48:14 -07:00
Morilli
436be60222
cleanup and fix GenericDebugger.DecrementCurrentAddress
2024-08-25 21:07:40 +02:00
Morilli
1ea8cf2f36
check disassembler address properly in GenericDebugger.Disassemble
...
- closes #3524
- the address was not checked on the first call
- the comparison needs to be >=, not >
2024-08-25 21:01:06 +02:00
YoshiRulz
3d37901677
Nix expr: Regen NuGet lockfile
...
fixes c882fe4ea5
2024-08-26 04:10:28 +10:00
YoshiRulz
93fe2c8b6a
Ban some more BCL methods (not used anywhere)
2024-08-26 02:01:06 +10:00
YoshiRulz
67f87b15c4
Ban runtime asserts without a message
2024-08-26 02:00:50 +10:00
YoshiRulz
8e12e44411
Ban `Control.Focus`
...
"Focus is a low-level method intended primarily for custom control
authors. Instead, application programmers should use the Select method
or the ActiveControl property for child controls, or the Activate method
for forms." --MSDN
2024-08-26 01:21:40 +10:00
YoshiRulz
2dd87d78f9
Use binary literals instead of `Convert.ToByte` in `D64`
2024-08-25 23:34:09 +10:00
YoshiRulz
c882fe4ea5
Add official `BannedApiAnalyzers` and ban some string parsing methods
2024-08-25 23:31:16 +10:00