ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tweak TasMovie.StartNewRecording slightly 

StartNewRecording is now always called for new tas projects in TAStudio, and the marker change code in there caused the Changes bool to get set and never cleared.
This commit is contained in:
Morilli 2024-08-27 23:43:55 +02:00
parent b6c031beaa
commit 532dc06e64
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/BizHawk.Client.Common/movie/tasproj/TasMovie.cs
View File

@ -75,7 +75,7 @@ namespace BizHawk.Client.Common
get => base.StartsFromSavestate;
set
{
Markers.Add(new TasMovieMarker(0, value ? "Savestate" : "Power on"), true);
Markers.Add(new TasMovieMarker(0, value ? "Savestate" : "Power on"), skipHistory: true);
base.StartsFromSavestate = value;
}
}
@ -123,8 +123,8 @@ namespace BizHawk.Client.Common
public override void StartNewRecording()
{
ClearTasprojExtras();
Markers.Add(0, StartsFromSavestate ? "Savestate" : "Power on");
ChangeLog = new TasMovieChangeLog(this);
Markers.Add(new TasMovieMarker(0, StartsFromSavestate ? "Savestate" : "Power on"), skipHistory: true);
ClearChanges();
base.StartNewRecording();
}
@ -350,7 +350,6 @@ namespace BizHawk.Client.Common
private bool IsReserved(int frame)
{
// Why the frame before?
// because we always navigate to the frame before and emulate 1 frame so that we ensure a proper frame buffer on the screen
// users want instant navigation to markers, so to do this, we need to reserve the frame before the marker, not the marker itself

1
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs
View File

@ -592,7 +592,6 @@ namespace BizHawk.Client.EmuHawk
MainForm.FirmwareManager,
Config.DefaultAuthor);
tasMovie.ClearChanges();
_ = StartNewMovieWrapper(tasMovie, isNew: true);
// clear all selections