Commit Graph

20297 Commits

Author SHA1 Message Date
YoshiRulz 384a4e1e18
Bump version info post-release 2023-05-04 08:10:07 +10:00
YoshiRulz 99fb1ba905
Fix typo in release package script
fixes e0e5a68c5
worked in CI ¯\_(ツ)_/¯
2023-05-04 03:18:14 +10:00
YoshiRulz e0e5a68c50
Refactor release package script, shrinking output slightly
more shrinking may be possible, but there are diminishing returns, especially
when MAME is so big (#3505)
2023-05-04 03:08:06 +10:00
CasualPokePlayer 36fae775d4 Prevent annoying waits when using firmware manager with DSi NANDs present 2023-05-03 02:19:56 -07:00
CasualPokePlayer 5f6d70ac46 Fix random crashes with rcheevos. The issue was that rc_runtime_t can store pointers to itself, which is bad when rcheevos expected the user to allocate that struct and did not provide functions for that. I've added that functionality and PR'd it (I'll fixup submodule to point to upstream when it's merged)
PR can be found here: https://github.com/RetroAchievements/rcheevos/pull/239
Also minor fixes wrt the ContinueWith usage in InternalDoRequest
2023-05-03 01:54:57 -07:00
Morilli 76c8b33f16 least-effort "fix" octoshock exe load hard crash 2023-05-03 07:40:39 +02:00
Morilli a5efc8f93b fix, update and rebuild octoshock project 2023-05-03 07:35:53 +02:00
CasualPokePlayer 248b8ab984 Fixup bad threading (no, you cannot access rcheevo's _runtime in a separate thread! main thread use only!). Should fix up some random crashes
Slightly change up the request model, now InternalDoRequest does not block
Fixup logic of ToSoftcoreMode (and comments so it isn't screwed up again)
2023-05-02 21:47:09 -07:00
CasualPokePlayer 8ef1d93891 Prevent UI thread deadlocking on Dispose()'ing rcheevos stuff 2023-05-02 17:18:31 -07:00
CasualPokePlayer b9a983f1fe Fix typo causing crash with SMSHawk with RetroAchievements & Hardcore Mode 2023-05-02 17:08:39 -07:00
CasualPokePlayer 41d94e4262 Change up multithreaded rendering in melonDS
Instead of creating a new Task and destroying it every frame, just create a new thread and call the delegate when needed.
Also allow for rendering a frame twice, this is actually possible anyways (albeit rarely done).
This should also help against a potential deadlock due to the Task.Wait call on the UI thread (which has special semantics in WinForms)
Also minor nitpicks in RCheevos code
2023-05-02 16:52:48 -07:00
CasualPokePlayer b517228475 Refactor rcheevo http requests (again). This should better protect against the UI thread deadlocking due to Task semantics with WinForms 2023-05-01 03:50:49 -07:00
vadosnaprimer e065263ff2 MAME does mark bad dumps, but it only keeps their info if good dump is not known yet. once a good dump appears, its info replaces the bad one.
so simply sticking to newest rom sets is the safest, otherwise there's little user control, because there's no global list of all known dumps with indications which of them are bad and what to use instead.
2023-04-30 14:07:08 +03:00
CasualPokePlayer 2010f5e15c disable leaderboard list form, for now, and revert efa6505
see that commit for details on issues with this form (this form is kind of useless anyways, meh)
2023-04-28 18:37:06 -07:00
YoshiRulz 8a5921182e
Add Analyzer to disallow discarding locals e.g. `_ = result;`
fixes 70bd081a9, a2185d9ef
2023-04-29 01:52:43 +10:00
CasualPokePlayer a2185d9ef0 fix 70bd081a93
The entire call is skipped in release mode if you place it inside a Debug.Assert.
2023-04-28 03:14:56 -07:00
CasualPokePlayer a6deee765f fix stackoverflows in mame with games using k001006_device (e.g. windheat) 2023-04-27 00:55:12 -07:00
YoshiRulz 66f26bb1c1
Create and use `IDictionary.GetValueOrPut{,New,New1}` extensions 2023-04-27 17:25:03 +10:00
YoshiRulz fa48278354
Enable MEN014 and fix noncompliance
"Prefer TryGetValue"
2023-04-27 17:24:55 +10:00
CasualPokePlayer c8589de5c6 fix #3648 2023-04-26 23:05:11 -07:00
sverx 102dee9622
Fix some SMS audio inaccuracies (squashed PR #3602)
* fix noise audio channel on SMS VDP

* Update SN76489sms.cs

also, white noise is generated by XORing bits 0 and 3, not 0 and 1, on an SMS/GG VDP

* Update SN76489sms.cs

reverting commit #7b857e7
2023-04-27 15:46:52 +10:00
Daniel Parks dd30a389a0 TAStudio/PatternsForm: Block deletion of loop entry which would cause a crash 2023-04-27 15:14:44 +10:00
Daniel Parks 07ba36956a TAStudio/PatternsForm: Allow looping to entry zero 2023-04-27 15:14:44 +10:00
YoshiRulz 0960661509
Remove a dependency on Git from build scripts
see ddc3e929e
2023-04-26 22:36:11 +10:00
YoshiRulz 9cbd238997
Convert `GenericDebugger.DisasmOp` to a struct 2023-04-23 19:08:19 +10:00
YoshiRulz 70bd081a93
Refactor `ServiceInjector` 2023-04-23 17:41:55 +10:00
YoshiRulz c5d6a66e01
Resolve TODO re: memoisation in `GenericDebugger` 2023-04-23 17:41:55 +10:00
YoshiRulz 4b001a48a9
Dedup `GenericDebugger.EngageDebugger` 2023-04-23 17:41:55 +10:00
YoshiRulz ac3e76309f
Use helper prop here 2023-04-23 17:41:54 +10:00
YoshiRulz bcdeec369a
Move commented-out code to `#if false` 2023-04-23 17:41:50 +10:00
Morilli 396e876320 Optimize TAStudio column drawing by caching PlayerNumber for each column name
TAStudio previously called `PlayerNumber(...)` for each visible cell with the column's name, only to determine whether its player number is odd or even.

Because that function uses regex and is potentially called extremely often, this had a noticable impact on fps.

I've decided to just cache the odd/even playernumber result in a dictionary for faster access, which while not being my preferred way of handling this at least results in a decent speedup.
2023-04-23 00:15:43 +02:00
Morilli afb92870e4 TargetName -> AssemblyName
this fixes the winforms designer in Rider, let's hope it doesn't break anything though
2023-04-22 13:51:13 +02:00
CasualPokePlayer f3c58d816d fix #3643 2023-04-22 04:39:12 -07:00
CasualPokePlayer a8aced4474
Workaround crashes in MAME's zlib decompression code (#3639)
* Workaround crashes in MAME's zlib decompression code (see https://github.com/TASEmulators/BizHawk/issues/3615)

* Use using block, only catch InvalidDataException (what will be thrown if the zip entry has an unsupported (likely lzma) compression method)
2023-04-20 09:29:03 -07:00
CasualPokePlayer efa6505826 prevent crashes when loading up leaderboard forms
apparently some game had 2002 leaderboards which caused a crash when making a form for every one of them in the leaderboard list, I guess windows has a limit on the amount of forms that can be active at once?
this is a quick hack to prevent such a crash, design needs to be rethought
2023-04-20 09:00:16 -07:00
Morilli 1356bc6a3f i guess this is required oops
fixes bc16a2cdaa
2023-04-20 12:31:33 +02:00
Moritz Bender bc16a2cdaa
Implement IBasicMovieInfo interface for IMovie (#3634)
* Implement IBasicMovieInfo interface for IMovie

this allows parsing basic movie fields into an own class that is independent from Bk2Movie/TasMovie

This is mainly useful for the PlayMovie dialog which can now load movie information from files on disk without having to go through the entire Bk2Movie/TasMovie loading process

* don't potentially iterate input log twice

* Optimize LoadFramecount
2023-04-20 10:43:02 +02:00
CasualPokePlayer 9b278d3130 fix space/tabbing in gamedb_n64 from cf88e61875 2023-04-19 23:26:32 -07:00
CasualPokePlayer cf88e61875 c# side changes to use the split ares' binaries
resolves #3614 and #3617
2023-04-19 23:23:12 -07:00
CasualPokePlayer 3701aef5a4 split ares binaries for interpreter vs recompiler 2023-04-19 23:22:00 -07:00
CasualPokePlayer 8cf820da4d Don't send invalid paths to MAME
Waterbox cores can't create files anyways, and trying to send in ? might make MAME try to make the directory anyways (which crashes due to the syscall for that being unimplemented), while "" will not do that
2023-04-19 18:41:05 -07:00
nattthebear 281e3be4a8
bare minimum implementation of getpid/getppid (#3641) 2023-04-19 21:29:45 -04:00
CasualPokePlayer a9dc924c11 Changes in MAME to partially address #3565
Needs #3641 pulled for it to be properly fixed
2023-04-19 18:03:45 -07:00
YoshiRulz 681629adb1
Add Waterbox core build dirs to .gitignore
fixes b5e2a0c42
2023-04-20 08:23:44 +10:00
YoshiRulz b5e2a0c422
Move some .gitignore entries to nested dirs 2023-04-19 15:59:34 +10:00
YoshiRulz 675c38dee8
Ensure .gitignore entries are absolute when they should be 2023-04-19 15:59:34 +10:00
YoshiRulz 0890185b51
Remove .gitignore entries for subprojects that no longer exist 2023-04-19 15:59:34 +10:00
CasualPokePlayer 955139454a fix Jaguar CD homebrew hashing wrt retroachievements 2023-04-18 22:38:13 -07:00
CasualPokePlayer a46c47d271 git ignore build directory for waterboxhost 2023-04-18 21:35:58 -07:00
CasualPokePlayer 4268c50617 Fix RetroAchievements rich presence not working
Cleanup this code so it plays nicer with BizHawk's "run everything on the main thread" (+ WinForms not playing nice with async methods)
Resend any game session start / achievement unlocks / leaderboard triggers if they failed. Wait for all achievement unlocks and leaderboard triggers to finish on Dispose() (mostly for catching them when user closes BizHawk)
Update rcheevos to 10.7.0
2023-04-18 21:35:58 -07:00