Commit Graph

16736 Commits

Author SHA1 Message Date
nattthebear 09f75c281c Play musical names with MemoryBlock
The refactoring of platform abstractions should never have changed the name of the public interface.  No one cares about MemoryBlockWindows or MemoryBlockUnix - those names are impl details.
2020-05-21 12:59:36 -04:00
nattthebear 7bda234fe1 Port upstream gpgx commit
56f3d64265

Theoretically fixes https://github.com/TASVideos/BizHawk/issues/1390 but I haven't tested it
2020-05-21 10:39:59 -04:00
nattthebear 3b207f54ce 32x - fix crash, fixes #1826
Trigger condition:  Any 32x rom smaller than 4MB in total size that tries to read out of bounds between its actual end and the 4MB limit

I've fixed the emulator crash, but I do not know if such roms are actually mirroring correctly - they probably aren't
2020-05-21 10:04:12 -04:00
YoshiRulz 72c0fab145
Update BuildTest*.sh
fixes 1bfaaab87
2020-05-21 17:37:29 +10:00
YoshiRulz 174a7cc46d
Silence NU1702 (Framework dep in Standard project) 2020-05-21 17:33:53 +10:00
YoshiRulz 69b8539d55
Fix defaults button in GenericCoreConfig not updating _settingsChanged 2020-05-21 17:32:26 +10:00
YoshiRulz 6e0148d921
Cleanup references 2020-05-21 17:25:35 +10:00
YoshiRulz ab1dca3e41
Fix NRE on passing empty string to LoadRom, simplify HawkFile creation
HawkFile now correctly sets FullPathWithoutMember to "" and Exists to false,
meaning RomLoader will return false instead of crashing.
2020-05-21 17:00:43 +10:00
YoshiRulz 9ae272e778
Import MainSlnCommon.props in BizHawk.Tests
fixes 1bfaaab87
2020-05-21 16:39:46 +10:00
YoshiRulz 7ddf6c26b9 Refactor DiscMountJob.RunBizHawk() to remove goto 2020-05-21 04:45:01 +00:00
YoshiRulz b2982825d8 Make DiscJob abstract 2020-05-21 04:45:01 +00:00
YoshiRulz 6f813edbdb Move some private helper methods to local methods in DiscSystem 2020-05-21 04:45:01 +00:00
YoshiRulz d436b9b9aa Fix colection/LINQ usage in DiscSystem
except the garbage that is byte[].Skip().Take(), I CBB fixing that
2020-05-21 04:45:01 +00:00
YoshiRulz 0ccf30396d Use modern `??=`, `is`, casts, etc. in DiscSystem 2020-05-21 04:45:01 +00:00
YoshiRulz ae22cd9f1b Use explicit visibility modifiers in DiscSystem 2020-05-21 04:45:01 +00:00
YoshiRulz 0706b96afe Fix encapsulation of IN_*/OUT_* in DiscSystem
these properties imply builder semantics but the classes aren't builders
2020-05-21 04:45:01 +00:00
nattthebear 21cdf5120b
Revamp waterbox build environment and runtime. (#2027)
Create an all new waterbox build environment:
WSL2 + Ubuntu 20.04 LTS (Other linuxes may work)
Musl libc with waterbox customizations
LLVM's libclang-rt, libunwind, libcxxabi, libcxx
Static linking to elf files

Compared with the old system, this is easier to set up a dev env for and easier to update in the future. The executables are larger but produce smaller savestates due to static linking. The modern toolchain means advanced library features and language features that sometimes appear in some upstream cores will be reusable.
2020-05-20 15:34:24 -04:00
alyosha-tas acf7926629 Add iscgb flag for subgbhawk 2020-05-20 15:04:05 -04:00
alyosha-tas 8ef5c18fcb GBHawk: bug fix and start wok on audio 2020-05-20 11:32:03 -04:00
adelikat b5ad1e636e add .uze (uzbox) to the Load Rom dialog filter 2020-05-19 20:48:53 -05:00
adelikat 123dbcc46d make uzebox and pcfx games not throw an exception on load, fixes #2022 2020-05-19 20:46:07 -05:00
adelikat 0a12f9e742 more tests for Bk2LogEntryGenerator 2020-05-19 20:29:55 -05:00
adelikat 0b5047b64a fix test namings, make Client.Common internals visible to tests, add a Bk2LogGenerator tests (more to come) 2020-05-19 20:05:12 -05:00
adelikat 1bfaaab872 https://www.youtube.com/watch?v=Ya2xifdO_l0 2020-05-19 19:55:08 -05:00
adelikat 21e4d30f98 remove another string extension method that was unused, and consolidate classes 2020-05-19 19:37:52 -05:00
adelikat 6d7d36c1d0 delete HowMany() extension method and just use .Count() instead, the one value add of null/empty checking was never utilized anyway 2020-05-19 19:30:24 -05:00
adelikat 96b0b37673 consolidate and rename tests project into a single project, delete commented out tests, add a unit tests that tests a thing 2020-05-19 19:24:53 -05:00
YoshiRulz d91c477e5a Add test projects and solution using MSTest, add scripts, upgrade CI 2020-05-19 23:54:14 +00:00
adelikat 0f1f463bcb I nitpick interface refactor 2020-05-19 18:01:09 -05:00
YoshiRulz 74a6da509a
Add NumLock and PrintScreen to OpenTK and to DirectInput->OpenTK map 2020-05-19 23:47:54 +10:00
YoshiRulz 2c817e3057
Use Range.Count extensions 2020-05-19 23:37:59 +10:00
YoshiRulz 7613748390
Fix some code flagged by StyleCop
SA1106 x4, SA1113 x2, SA1142 x2, SA1206
2020-05-19 23:33:16 +10:00
alyosha-tas c96a233d5d GBHawk: Speed switch timing fix. 2020-05-18 15:43:51 -04:00
feos e075012b70
Rundum (#2019)
fix #1701
fix #1285

Co-authored-by: nattthebear <goyuken@gmail.com>
2020-05-18 21:11:18 +03:00
RetroEdit 4555be85bc
tastudio: fix Changes wrongly being set false (#2018)
tastudio: fix Changes wrongly being set false
2020-05-18 12:29:23 -05:00
adelikat 28d859e2d8 SavestateManager - make a public method private 2020-05-18 11:59:25 -05:00
RetroEdit 88b038f24e
Improve frame insertion/deletion efficiency, particularly for undos (#2017)
* Replace unnecessary fromHistory parameters

* Improve frame insert efficiency, particularly for undos

* Improve frame delete efficiency, particularly for undos
2020-05-18 10:58:29 -05:00
adelikat 4b6e6d996a Simplify some Bkm code 2020-05-17 15:34:47 -05:00
adelikat 100fc2bad5 Rewinder - remove message callback, I dont' think this message is worth the code, especially since mainform always adds a message 2020-05-17 15:14:40 -05:00
adelikat 78c1482720 Rewinder - remove Movie active check when deciding about keeping the last frame of a rewind. It seems to work without it, but more significantly, rewind is not MOVIE SAFE, it used to be disabled while recording, and somehow got enabled, I guess someone wanted their desyncs 2020-05-17 15:06:23 -05:00
adelikat 1e0ae62041 Rewinder - pass stuff in, instead of using globals 2020-05-17 15:01:44 -05:00
adelikat b140143791 Watch classes - remove "LIAR logic" 2020-05-17 13:35:49 -05:00
adelikat b2d482ea66 Hex editor - cleanup a bit 2020-05-17 12:26:53 -05:00
adelikat 07225c06de oops - fix multi-byte views in hex editor 2020-05-17 12:25:04 -05:00
adelikat 5ffc26b5e9 AutoFireStickyXorAdapter - pass in on/off instead of getting them directly from Global.Config 2020-05-17 11:59:24 -05:00
adelikat c91b17877d Simplify MovieSession a bit 2020-05-17 11:23:52 -05:00
adelikat 3e354ed230 Simplify Movie extensions ToBk2() 2020-05-17 11:22:22 -05:00
adelikat 42356dd32b roll back RomLoader cleanups from e4563570f9, ref implicit tuples and todos don't make the situation better 2020-05-17 11:05:44 -05:00
adelikat 604f4ce833 TasStateManager - simplify MaxState logic and actually fix the math so it isn't 2x of what is intended 2020-05-17 10:41:39 -05:00
adelikat 45fd7ee81e nuke most of SubstringExtensions, and make it where i can at least read it 2020-05-17 10:39:24 -05:00