ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify Movie extensions ToBk2()

This commit is contained in:
adelikat 2020-05-17 11:22:22 -05:00
parent 42356dd32b
commit 3e354ed230
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/BizHawk.Client.Common/movie/conversions/MovieConversionExtensions.cs
View File

@ -77,7 +77,7 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
return tas;
}
public static IMovie ToBk2(this IMovie old, bool copy = false, bool backup = false)
public static IMovie ToBk2(this IMovie old)
{
var bk2 = new Bk2Movie(old.Filename.Replace(old.PreferredExtension, Bk2Movie.Extension));
@ -87,11 +87,6 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
bk2.AppendFrame(input);
}
if (!copy)
{
old.Truncate(0); // Trying to minimize ram usage
}
bk2.HeaderEntries.Clear();
foreach (var kvp in old.HeaderEntries)
{
@ -116,11 +111,6 @@ namespace BizHawk.Client.Common.MovieConversionExtensions
bk2.BinarySavestate = old.BinarySavestate;
bk2.SaveRam = old.SaveRam;
if (!backup)
{
bk2.Save();
}
return bk2;
}

4
src/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.MenuItems.cs
View File

@ -185,7 +185,7 @@ namespace BizHawk.Client.EmuHawk
private void SaveBk2BackupMenuItem_Click(object sender, EventArgs e)
{
_autosaveTimer.Stop();
var bk2 = CurrentTasMovie.ToBk2(copy: true, backup: true);
var bk2 = CurrentTasMovie.ToBk2();
MessageStatusLabel.Text = "Exporting to .bk2...";
Cursor = Cursors.WaitCursor;
Update();
@ -258,7 +258,7 @@ namespace BizHawk.Client.EmuHawk
MessageBox.Show("This core requires emulation to be on the last frame when writing the movie, otherwise movie length will appear incorrect.\nTAStudio can't handle this, so Export BK2, play it to the end, and then Save Movie.", "Warning", MessageBoxButtons.OK, MessageBoxIcon.Warning);
}
var bk2 = CurrentTasMovie.ToBk2(true, true);
var bk2 = CurrentTasMovie.ToBk2();
MessageStatusLabel.Text = "Exporting to .bk2...";
Cursor = Cursors.WaitCursor;
Update();