Commit Graph

147 Commits

Author SHA1 Message Date
adelikat d4c8615e95 remove unused usings and other redundancies 2020-04-23 20:33:18 -05:00
adelikat 70633419ac
Refactor TasMovie and add interface (#1940)
* create ITasMovie interface, still lots of todos

* interface for TasMovie.ChangeLog

* rename method

* interface more TasMovie things

* file rename

* interface more ITasMovie things

* make Bk2Movie and TasMovie internal, rely on interfaces for behavior and MovieService for instantiation

* MovieService cleanup

* cleanup TasBranch handling and simplify ITasMovie api

* more branch logic cleanup and ITasMovie simplificaiton

* more cleanup of branch handling

* more ITasMovie simplification

* nitpick cleanup

* Use IMovie.GetInputLogEntry instead of GetLogEntries

* more ITasMovie cleanup

* move come ITasMovie properties to TasBranchCollection

* TasMovie cleanup

* simplify ITasMovie more

* cleanup
2020-04-19 13:38:45 -05:00
adelikat 03a7ea8438 IMovie.PopulateWithDefaultHeaderValues() - pass in dependencies instead of using Globals 2020-04-14 17:30:32 -05:00
adelikat e62c2e3646 PlayMovie dialog - simplify a bit 2020-04-07 15:28:27 -05:00
YoshiRulz e1951b9fc5
Cleanup PathExtensions
Fixes f02295455/c731e1168/5c7135d67
2020-03-21 13:45:58 +10:00
adelikat 33a14327b7 move most logic from PathManager to extension methods in BizHawk.Common 2020-03-15 15:45:11 -05:00
adelikat 348cbd18df
Remove PathManager code that had dependencies on Globals (#1881)
* move one usage of Firwmare method into Firmware config where it is better suited

* PathManager - remove unused code

* move some PathEntry specific logic out of PathManger and into PathEntryCollection extension methods

* PathManager - detangle some exe pathing logic from Global.Config usage, clarify what a completely broken method should actuall do

* move more logic from PathManager to PathEntryCollection extension method

* move absolute path creation to PathEntryCollection, lots of refactoring and simplifying of PathEntries usage

* simplify PathEntryColleciton usage more

* simplify PathEntryCollection more

* break PathEntry classes into separate files, a bit of cleanup

* move Rom path logic out of PathManager into PathEntryCollectionExtensions

* move config UseRecentForRoms and LastRomPath into PathEntries, note that this is a breaking change for previous configs, those values will revert back to default values

* move SaveRamPath logic from PathManager to PathEntryCollections

* move cheats path logic from PathManager to PathEntryCollection

* move another method out of PathManager

* move some Retro hacks to PathEntryCollections, exposes more implicit dependencies

* move savestate logic out of PathManager to PathEntryCollection

* move more logic out of PathManager

* move some savestate logic out of PathManager, move most to MainForm where it is used, detangle some implicit dependencies from SaveSlotManager

* rename method

* move more logic from PathManager to PathCollectionEntry

* movie final Global.Config.PathEntries logic out of PathManager and into PathEnties
2020-03-15 15:12:36 -05:00
adelikat 079a0a4104 HeaderKeys - CONSTANTSDONTNEEDTOBEALLCAPS 2020-03-01 16:36:47 -06:00
YoshiRulz 9829fd699b Unify helpers for generating file extension lists (for open/save) 2020-02-20 21:59:20 +00:00
adelikat 656f2b814e Move IEmulator extensions to the Emulation.Common namespace, the intent is that these are used and serve as built in functionality, so it's overly tedious to when most situations require both Common and an additional extensions namespace 2020-02-15 12:33:15 -06:00
adelikat 4b7a7dd293
Make Binary states default and Textstates opt-in for cores (#1848)
* Rewind & State config - remove the default option

* remove the savestate type of default, not that this is a breaking config change for anyone that had specifically set savestates to text

* remove BinaryStatesPreferred from IStatable and use config setting when starting movies from "Now" in record movie dialog

* remove BinaryStatesPreferred from cores

* make text savestates an extension method off of IStatable and an inteface ITextStatable it uses if the core implements it. This will allow cores to opt in to text states if desired

* make cores with actual text savestate impleemntations get ITextStatable, remove text state logic from cores that just have a binary as as text implementation
2020-02-15 10:22:26 -06:00
adelikat 626efe8caf put control extension methods into the EmuHawk names space isntead of a custom one. We want these to be found and used, and most dialogs use them 2020-02-03 12:54:32 -06:00
adelikat c2bec296e6 simplify some repeated boilerplate on the DragEnter event by consolidating it to an extension method 2020-02-03 12:42:28 -06:00
adelikat ef13754f79 consistent variable naming in config.cs 2020-01-25 10:57:39 -06:00
adelikat afd460f1d2 pass in globals to Play/Record movie dialogs 2019-12-22 14:18:17 -06:00
adelikat 5fe25d03ad Play/Reocrd movie dialogs - pass in mainform 2019-12-17 11:24:34 -06:00
YoshiRulz 7f07949816
Migrate serialised images to separate files, removing duplicates 2019-12-07 05:24:24 +10:00
adelikat b54904028e Record dialog - fix padding of Ok/Cancel buttons 2019-12-01 16:13:14 -06:00
adelikat 1239149af5 cleanup movie forms 2019-11-02 11:05:01 -05:00
adelikat 5fa5674260 EditSubtitles - fix message typo, simplify, TryParse instead of catching parse errors, fix a NRE 2019-11-02 10:50:52 -05:00
J.D. Purcell 39b54f7202 Fix missing UI usings. 2019-11-02 00:38:50 -04:00
adelikat 2a6225940b PlayMovie - use listview in virtual mode instead of VirtualListView 2019-10-19 14:18:43 -05:00
James Groom 90b0574bc3
Remove unnecessary calls to ToList (e.g. in foreach)
squashed PR #1591
2019-10-13 15:50:57 +00:00
YoshiRulz e6374ef477
Use string interpolation 2019-03-19 00:06:37 +10:00
YoshiRulz 13152d670f
Rewrite MovieView_ColumnClick, also fixes typo 2019-02-24 15:49:10 +10:00
YoshiRulz a572b220f6
Fix typo copying to clipboard during loop 2019-02-24 15:48:09 +10:00
feos 57fd6051e9 fix #1246 the easy way 2018-09-21 23:43:51 +03:00
feos 4ef17b8662 better anchor items in Play Movie dialog
it appears at fixed size anyway, but shrinking it was breaking the layout
2018-09-21 23:43:51 +03:00
alyosha-tas 549b484c21 Increase Subtitle Maker frame limit 2018-03-16 18:48:19 -04:00
nattthebear ebe789eed2 heh 2017-05-10 07:45:23 -04:00
adelikat 28da1e215f misc code formatting improvements in random files in EmuHawk 2017-04-17 15:23:31 -05:00
J.D. Purcell b53502eed8 Spaces -> tabs. 2017-04-15 16:37:30 -04:00
adelikat 117e0b07e7 Pass the core instance to the record movie dialog 2016-12-04 12:51:48 -06:00
adelikat 604ed74ff9 remove some usages of VideoProviderGlue by checking for VideoProvider availability before doing some dependent processes 2016-12-04 10:30:51 -06:00
feos 35a07f42eb subtitles:
- trim trailing spaces
- sort by frame and then by Y pos (to properly order multiline subs)
- concat multilines (optionally) on export
- option to skip color tag on export
todo: fix multiline ordering for export
2016-06-29 00:32:43 +03:00
zeromus 66683b16ed replace "Ok" with "OK" 2016-03-26 21:50:33 -05:00
zeromus d7186c9e6f remove c#6isms 2016-01-21 21:22:26 -06:00
Adam Sturge 2f11a3adca Updated brace alignment 2016-01-15 19:16:35 -08:00
Adam Sturge 7949e2e182 Added Directory.Exists check for Movie director when clicking the browse button 2016-01-15 19:14:59 -08:00
Hathor86 1e2f4e12be Watch refactoring
Some improvement when you get Available types. Used to return a new
array each time you call the function. It has been transformed into an
IEnumrable and yield return.
DisplayType, PreviousType and Watchsize have been moved outside the
Watch Class
2015-11-28 22:52:00 +01:00
zeromus a283b2d1b9 fix threading bug in movie scanner 2015-08-05 16:37:17 -05:00
adelikat 490adc905e Support recording movies that start from SaveRam, note: as of this changeset tastudio does not support this concept and may interact in weird ways with saveram-anchored movies 2015-07-26 15:41:22 -04:00
jdpurcell a660aa3c57 EditSubtitlesForm - Revert changes from r7614 caused by WinForms designer not running at 96 DPI. 2015-02-08 14:23:44 +00:00
goyuken 82fcd0bc5e refactor IVideoProvider into a service. uses in mainform and friends are still hacky 2015-01-14 22:37:37 +00:00
adelikat e2033c9d2e AsStatable() and also update statusbar saveslots on CloseRom() 2014-12-05 00:52:16 +00:00
adelikat bdccb6d400 Record Movie - remove the "Now" option if the core doesn't implement IStatable 2014-11-30 17:37:22 +00:00
adelikat 76148ae111 Break off savestate functionality from IEmulator into IStatable and refactor things accordingly. Still todo (a big todo): EmuHawk should gracefully handle a core that is not an IStatable by disabling functionality dependent upon it (Savestates, Rewind, Tastudio, etc) 2014-11-30 16:42:58 +00:00
goyuken ff54192fdc fix missing movie extension for game names that have a . at Length-4 2014-11-30 04:02:31 +00:00
adelikat 829ee72914 Tastudio - make comment editor always in edit mode, make it modeless, add a save button 2014-11-02 15:20:17 +00:00
adelikat b10ef0b1a4 EditCommentsForm - some code and whitespace cleanup 2014-11-02 15:07:19 +00:00