ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #1246 the easy way

This commit is contained in:
feos 2018-09-21 23:31:46 +03:00
parent 39305d3c3e
commit 57fd6051e9
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BizHawk.Client.EmuHawk/movie/PlayMovie.cs
View File

@ -479,7 +479,13 @@ namespace BizHawk.Client.EmuHawk
}
break;
case HeaderKeys.PLATFORM:
if (kvp.Value != Global.Game.System)
// feos: previously it was compared against Global.Game.System, but when the movie is created
// its platform is copied from Global.Emulator.SystemId, see PopulateWithDefaultHeaderValues()
// the problem is that for GameGear and SG100, those mismatch, resulting in false positive here
// I have a patch to make GG and SG appear as platforms in movie header (issue #1246)
// but even with it, for all the old movies, this false positive would have to be worked around anyway
// TODO: actually check header flags like "IsGGMode" and "IsSegaCDMode" (those are never parsed by bizhawk)
if (kvp.Value != Global.Emulator.SystemId)
{
item.BackColor = Color.Pink;
}