Commit Graph

7594 Commits

Author SHA1 Message Date
DimitriPilot3 bb827eb837 Apply (a variation of) the first patch attached to issue 4608. This should limit the amount of ACL packet loss due to the 200Hz timing (which is now 150Hz if you disable Wiimote Speaker) and the handling of the ACL pool when it's occasionally full (which this improves by dropping one packet instead of letting the "pointers" overlap which would make packets unreachable).
See comment #6 for more details on the changes to WII_IPC_HLE_Device_usb.

In addition to that, rework some comments a bit (such as those from the
original patch; plus Ayuanx's one about maintaining Wiimote timing, which lost
relevance since r7272 which made Wiimote::Update timing independent from IPC
timing), and remove an unused global variable (event for watchdog hack)...

In short, this should address *some* of the Wiimote disconnection and/or "forgotten extension" problems that appeared with r7272 and/or r7394.  To prevent the "ACL queue is full" warnings from appearing (View->Show Log), pay attention to the amount of enabled Wiimotes (use as few as possible, connect the extra Wiimotes only when needed), and make sure to disable the "Disable Wiimote Speaker" option (if unneeded or causing problems) in the game properties.  If possible, make sure to use real Wiimotes instead of emulated ones, as well.
If Wiimotes disconnect forever (and cannot be reconnected using the Alt+Fx hotkeys), open the Wiimote config window, set the faulty Wiimote's type to "None", close/reopen the window, and set the previous Wiimote type back.

Note that it's not a *complete* fix for issue 4608!  This only fixes about half (or maybe third) of the possible causes of this issue...  But at least this should make the accurate Wiimote emulation (I mean, with the limitation of the ACL queue included) more usable in some cases (such as multi-player).
Nope, I didn't (and can't yet) perform in-depth tests on the real hardware myself (unlike some developers), I just rely on the given "accurate" code and numbers (such as the 10-packet limit implemented by godisgovernment)...
Maybe I'll get to fixing other problem "causes" (if I feel like doing it), maybe not in a while...  After all, I have other hobbies, and it's the summer holidays for me...

Anyway, feel free to test and comment.

Update issue 4667
Update issue 4608
Update issue 4604
Update issue 4583
Update issue 4436
Update issue 4353
Update issue 4013

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7675 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-12 15:49:08 +00:00
baby.lueshi ebce13fba7 The read-only movie flag now taken into account for save states. Fixes Issue 4463.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7674 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-11 20:15:05 +00:00
Shawn Hoffman 2b9b4a3306 Make PatchAddEdit complain and not modify entry if fields are invalid instead of just filling in zeros. Fixes issue 4291.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7672 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-09 21:00:30 +00:00
Marko Pusljar d9ad549349 anti-minimize workaround (MainWindowPosX/Y = -32000 prob)
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7670 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-07 19:54:47 +00:00
Marko Pusljar cac36b8161 added 1.5x, 2.5x, 4x internal resolution
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7669 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-05 01:11:03 +00:00
pierre 1f2adf0563 VideoCommon: Always update pixel shader constants when tevregs change
This time, it doesn't break the games i tested, and still fixes
Metroid Prime 3 texts/colors.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7668 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-04 13:49:40 +00:00
pierre 951e20ae73 Revert r7665. Breaks about all other games.
Sorry, MP3 users will have to wait a bit longer.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7666 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-03 21:57:49 +00:00
pierre e090a92c7e VideoCommon: Always update pixel shader constants when tevregs change
Fixes texts staying visible and strange colors in Metroid Prime 3.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7665 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-03 20:48:22 +00:00
pierre f7a1fabade Adjust the character counts in the debug views to more closely resemble the original pixel counts
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7664 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-03 20:47:18 +00:00
NeoBrainX 3c10f9f3e9 Various UI and documentation improvements to the GFX debugger.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7661 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-01 20:59:57 +00:00
pierre cedda90477 Improve text positioning in debug views by adding a static pixel offset
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7660 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-01 18:32:18 +00:00
pierre ac62849351 Make the debug views use the actual rendered pixel size of the fonts.
Fixes debug view rendering on non-96dpi displays.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7659 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-07-01 14:20:33 +00:00
pierre 7b00c2a6f7 PPC-Jit: Fix cache invalidation when doing a memory exception on 64bit
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7658 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-30 20:34:44 +00:00
pierre ea95e603b2 JIT: Get rid of SHLs with shifts of 1, 2, 3
Also contains a few other minor jit code optimizations.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7657 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-30 20:25:37 +00:00
pierre 383d12185f JIT: Use RAX instead of INVALID_REG for offsetOrBaseReg in MScaled
Fixes asserts triggering in WriteRex with 32bits.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7656 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-30 19:17:53 +00:00
Marko Pusljar 78529e2eb6 dsp/jit - super super tiny speed up
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7655 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-30 17:31:48 +00:00
LPFaint99 913ca56e03 use same region memcards as the nand title that is being launched
... this patch has been sitting in my working copy for ages :O
fixes issue 4657.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7653 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-30 01:12:45 +00:00
pierre 6cdb40a194 JIT: Add support for memory accesses with scaled index register but without base register
This is mostly useful for removing SHLs by constant 1, 2, 3, which this
commit implements in one place.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7652 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-29 22:40:01 +00:00
pierre 1f170130e8 DSP/Jit: Combine clrp memory writes back to two 32bit writes
This time without the (char*)/(u64*) confusion.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7651 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-29 22:11:39 +00:00
LPFaint99 e5140085ba Wii Save Export no longer requires anything additional to create saves that can be copied to the wii
thanks to shuffle2 for the NG_id, NG_key_id, NG_priv, NG_sig from his wii

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7644 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-27 20:48:15 +00:00
baby.lueshi 4e6d9f930b More features/fixes for the TAS Input plugin. Buttons added to window and input is restricted to the 1st controller only (until multicontroller support is added). Fixed bug with sliders not appearing correctly on Linux.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7643 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-27 19:44:27 +00:00
LPFaint99 f95bcfc1c2 Wii Save Export can now successfully create data.bin files that the wii will accept as long as the user has their wii's private keys.
requires NG-id, NG-key-id, NG-priv, NG-sig
sorry for not fixing this sooner, I forgot that I cleared my wiis private keys before the initial commit

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7642 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-27 06:19:23 +00:00
Glenn Rice 46b95db6c7 Remove the Danish translation from the build.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7636 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-26 16:56:10 +00:00
baby.lueshi 2441f29ffd Fix scons build, please comment if it's still broken
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7623 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-24 15:50:27 +00:00
NeoBrainX bf29ea9635 Version bump for CPack in trunk as well ;)
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7622 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-24 15:28:43 +00:00
baby.lueshi d81caf3bc6 missed files from r7620
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7621 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-24 06:57:15 +00:00
baby.lueshi d8fc690838 New "TAS Input" feature for precise joystick inputs. The feature is still a work in progress, but is functional. Currently overwrites any joystick/keyboard analog inputs and does so for all controllers.
Renamed OnFrame.cpp/h to a more accurate Movie.cpp/h. Made some small changes that may improve movie synchronization.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7620 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-24 06:50:50 +00:00
Shawn Hoffman 2309e36b28 Revert changes made for 3.0 release 2011-08-20 14:05:43 -07:00
NeoBrainX 35d1599724 Tag Dolphin 3.0
git-svn-id: https://dolphin-emu.googlecode.com/svn/tags/3.0@7615 8ced0084-cf51-0410-be5f-012b33b47a6e

3.0: Removed SVNRevGen stuff; changed revision string to 3.0; Removed installer since it was vastly outdated; Bumped CMake major version to 3

git-svn-id: https://dolphin-emu.googlecode.com/svn/tags/3.0@7616 8ced0084-cf51-0410-be5f-012b33b47a6e

3.0: Add the languages which were chosen to be release-worthy.
Uhm, unless I forgot something important, I guess we can declare 3.0 as officially released now and stuff. Cheers ;)

git-svn-id: https://dolphin-emu.googlecode.com/svn/tags/3.0@7617 8ced0084-cf51-0410-be5f-012b33b47a6e

3.0: Fix SCons build

git-svn-id: https://dolphin-emu.googlecode.com/svn/tags/3.0@7627 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-23 23:11:12 +00:00
Glenn Rice 2d1fef2989 The user Config directory in the dolphin emu distributed files is now an empty directory (since the portable file has been removed). Hence that directory should be created and not copied. This fixes a downstream packaging issue. Downstream packages strip empty directories from the install. So users of those packages will find that their settings are not saved.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7613 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-23 12:21:08 +00:00
Sonicadvance1 693f276a68 Small update for disabled Fog for older hardware that fails to divide by zero in shaders
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7612 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-20 05:48:12 +00:00
Glenn Rice bc416a552e Make sure the play button is disabled while a game is starting when not rendering to main. This should fully resolve issue 4602.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7608 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-19 01:22:34 +00:00
Glenn Rice c2475f852e If hardware fails to initialize when emulation starts, die gracefully. This should fix issue 4602.
Also don't try to save and load states when the emulator is not running.  This should fix most of issu 4600.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7607 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-18 04:04:48 +00:00
Glenn Rice b705b92075 On linux don't check to see if the xdg-screensaver program is present at build time. Just build in the code to call the program. If the program does not exist it will silently fail, and the screensaver will not be inhibited.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7606 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-17 13:14:55 +00:00
NeoBrainX 73744a991a Properly enable audio backend changes.
Fixes issue 4601.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7605 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-17 09:35:03 +00:00
NeoBrainX ced315f677 Properly destroy cheat manager window when closed.
Fixes issue 4595.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7604 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-17 09:19:13 +00:00
Marko Pusljar 0fcf1d6197 PPC/faddsx/jit - fix for Starfox Assault (invisible boss problem)
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7599 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-15 18:12:51 +00:00
DimitriPilot3 d4d7e2515f Apply the simple NULL-checking patch from issue 4311.
Judging by the feedback provided by other OSX users, this appears to fix the crash when starting Dolphin on OSX with devices that have an empty name.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7598 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-15 12:50:47 +00:00
skidau 5bdf27d159 Adjusted the IPC_HLE timing to fix the stuck rumble problem in some games. Fixes issue 4532.
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7597 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-14 15:12:55 +00:00
DimitriPilot3 98536df915 Make sure to reserve() exactly the right amount of elements for the std::vector before filling it with CheatSearchResult's, in order to prevent automatic re-allocations.
It turns out that this (somewhat) gets rid of memory-related exceptions which used to occur (especially) during 8-bit cheat searches.  At least this is the case with my computer that has 3GB of RAM (the issue didn't seem to be caused by 100% of RAM usage, however).

Hopefully you'll be able to perform the following steps without errors now:
1. Open any game in Dolphin;
2. Go to Tools->Cheats Manager, and open the "Cheat Search" tab;
3. Preferably set the "Data Size" to 8-bit (the smaller, the more initial search results);
4. Press the "New Scan" button;
5. Use the "Unknown" search filter (which won't narrow the results down at all);
6. Press the "Next Scan" button.

(oh, and fix a typo in a comment I introduced in r6791 :p)

Anyway, make sure to tell me any eventual errors/regressions.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7596 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-13 15:47:02 +00:00
NeoBrainX c84cddc83a Revert r7078.
Downgrades Cg to 3.0.0007 again since the November release caused too much trouble for some users.
Fixes issue 4107.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7595 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-13 11:17:36 +00:00
NeoBrainX 880cd14710 Wiimote configuration dialog: Select first Wiimote tab by default.
Fixes issue 4587.

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7594 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-11 23:38:39 +00:00
LPFaint99 1d29204ae6 Windows: Sets the cwd to the folder that dolphin.exe resides in.
Removes the ugliness that was the portable file, and now creating a shortcut or file association is less of a pain
it is still necessary to modify the file association from ".../dolphin.exe" "%1" to ".../dolphin.exe" /e "%1"

git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7593 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-11 20:45:09 +00:00
NeoBrainX 8244efcc02 Revert r7421 and r7422.
Should fix issue 4413.


git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7592 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-11 19:37:21 +00:00
Rodolfo Osvaldo Bogado e5210de9d5 just a little cleanup to maintain minimal interfaces
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7591 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-10 19:16:09 +00:00
Sonicadvance1 3fceffd8c0 We need to require at least shader 2.0a now
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7590 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-08 03:09:07 +00:00
Marko Pusljar 81844b8955 dsplle - small optimization for my previous commit + some cleaning
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7589 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-05 12:35:11 +00:00
LPFaint99 b808af1d7f fix infinitely recursive deletion from r7587 and actually update locations of content.map and uid.sys
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7588 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-05 07:42:40 +00:00
LPFaint99 2c4bc6d94c fix a small oversight to changing NAND root, update locations of content.map and uid.sys
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7587 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-05 06:30:01 +00:00
Jordan Woyak 450b5c9c33 fix build
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@7586 8ced0084-cf51-0410-be5f-012b33b47a6e
2011-06-05 01:44:07 +00:00