73fde6d84d
Merge pull request #6923 from lioncash/prototype
...
DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype
2018-05-20 23:02:26 +02:00
437c954b60
DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype
...
Tidies up the interface a little (and prevents a linker error from
occurring in the future, should it ever have been called).
2018-05-20 16:42:13 -04:00
c145d7ee63
Merge pull request #6922 from lioncash/interface
...
VideoBackendBase: Include parameter names in member function declarations
2018-05-20 22:39:31 +02:00
ba94ffd51d
VideoBackendBase: Include parameter names in member function declarations
...
Given this is a base class, we should clearly state what the parameters
to the functions in its exposed interface actually mean or represent.
This avoids needing to hunt for the definition of the functions in cpp
files.
While we're at it, normalize said parameter names so they follow our
naming guidelines.
2018-05-20 16:27:16 -04:00
7563c82162
Merge pull request #6921 from lioncash/mmu
...
MMU: Avoid sign conversions in EFB_Read and EFB_Write
2018-05-20 22:18:40 +02:00
edb38ff144
MMU: Avoid sign conversions in EFB_Read and EFB_Write
...
There's no reason to use int here as opposed to an unsigned value.
Video_AccessEFB() takes its arguments as u32 values, so we'd be doing
sign conversions for no reason here (along with causing avoidable
compiler warnings).
2018-05-20 16:13:53 -04:00
0337ca116a
Interpreter_SystemRegisters: Check processor privilege level in mfspr and mtspr
...
If a program executing in user mode tries to write to any SPRs other than
XER, LR, or CTR registers, then a program exception occurs. Similarly
this also applies for reading SPRs as well, however the upper and lower
timebase halves can also be read (but not written to).
2018-05-20 15:51:52 -04:00
8af8c58eb9
Merge pull request #6917 from spycrab/qt_mpbtn_size
...
Qt/MappingButton: Enforce more consistent size
2018-05-20 21:27:41 +02:00
f7323a4419
Merge pull request #6916 from spycrab/qt_indicator_aa
...
Qt/MappingIndicator: Improve render quality
2018-05-20 21:21:08 +02:00
0e8aa213a3
Qt/MappingButton: Enforce more consistent size
2018-05-20 21:20:45 +02:00
b4f1c489a3
Qt/MappingIndicator: Center trigger labels
2018-05-20 21:16:14 +02:00
4284952538
Merge pull request #6919 from lioncash/nop
...
Interpreter_LoadStore: No-op dcbt and dcbtst if HID0.NOOPTI is set
2018-05-20 20:33:38 +02:00
d05c1b257c
Interpreter_LoadStore: No-op dcbt and dcbtst if HID0.NOOPTI is set
...
If HID0.NOOPTI is set, then dcbt and dcbtst are no-oped globally. We
currently don't perform data cache emulation, but we put this in anyway
so this detail isn't forgotten about if data cache emulation is
introduced at some point in the future.
2018-05-20 14:23:51 -04:00
5ce1b83d97
Merge pull request #6918 from lioncash/cast
...
Interpreter_LoadStore: Remove unnecessary cast in lhzx()
2018-05-20 20:21:16 +02:00
940f41f593
Interpreter_LoadStore: Remove unnecessary cast in lhzx()
...
This is only moving a smaller unsigned integral type into a larger
unsigned integral type, so there's no loss of information that could
occur.
2018-05-20 14:06:59 -04:00
4b0f8d9f85
ES: Implement VerifySign
...
This implements ES_VerifySign which is notably used by the system menu
when importing saves.
Now *all* ES commands that are actually used by titles are implemented.
2018-05-20 20:04:53 +02:00
cec7fded60
IOSC: Implement VerifyPublicKeySign for ECC
2018-05-20 20:04:53 +02:00
b86f1ea7b3
ES / IOSC: Add support for ECC certificates
2018-05-20 20:04:53 +02:00
a974c69058
Merge pull request #6866 from leoetlino/ec-cleanup
...
ec: General cleanup
2018-05-20 20:04:19 +02:00
67ce7e34e9
UnitTests: Add basic tests for ec crypto code
...
Verifies that PrivToPub and ComputeSharedSecret give expected results.
2018-05-20 19:59:26 +02:00
355b1b5d5b
ec: Improve readability and clarity
...
- Move all of the ec functions into the Common::ec namespace.
- Give the public functions better names and some usage information.
- Move all of the "elt" related functions into an "elt" class including
all of the arithmetic operations, so that the logic becomes clearer
and feels less like assembly.
This also makes it much more obvious what the parameters are, instead
of only using unsigned char* (which doesn't tell anything about what
the pointer is used for or the size).
- Similarly, add a new "Point" class and move point functions there.
Overload the arithmetic operators to make calculations easier to read
2018-05-20 19:59:26 +02:00
e83591f188
ec: Avoid exposing internal function
2018-05-20 19:59:26 +02:00
b9dd94b9b2
bn: Use int instead of u32 for sizes
...
The loops relied on unsigned integer overflow, which is not immediately
obvious. Replace them with less clever variants that are clearer.
Also implement bn_compare using std::memcmp.
2018-05-20 19:59:26 +02:00
46cc57ba33
Merge pull request #6915 from spycrab/cmake_wx_msg
...
CMakeLists: Remove "Enabling GUI" from the "Wx enabled" message
2018-05-20 12:49:32 -04:00
b0b14853c4
Qt/MappingIndicator: Improve render quality
2018-05-20 17:50:26 +02:00
94a4c05640
CMakeLists: Remove "Enabling GUI" from the "Wx enabled" message
2018-05-20 17:12:27 +02:00
56e91bfdc1
Merge pull request #6429 from JosJuice/png-banners-uicommon
...
Reimplement custom PNG banners in game list
2018-05-20 15:39:07 +02:00
cc42b4354d
Reimplement custom PNG banners in game list
...
Fixes https://bugs.dolphin-emu.org/issues/10938
and makes PNG banners available in DolphinQt2 for the first time.
2018-05-20 15:34:03 +02:00
86c676ab04
Merge pull request #6291 from JosJuice/remove-soil
...
Replace usage of SOIL with libpng
2018-05-20 14:16:31 +02:00
10ff6d73c2
Fix compatibility with versions of libpng older than 1.5
2018-05-20 13:44:42 +02:00
c51ae9c62a
Remove SOIL altogether from the project.
2018-05-20 13:44:42 +02:00
6d0143647e
VideoCommon: Remove a workaround mutex used for SOIL
2018-05-20 13:44:41 +02:00
17e65a7167
VideoCommon: Replace SOIL with libpng for hires textures
2018-05-20 13:44:38 +02:00
0706add584
Merge pull request #6699 from 404-Name-Not-Found/alphabetize-gecko-qt
...
Adds a toggleable function for sorting the gecko codes alphabetically to the gecko code menu
2018-05-20 11:13:38 +02:00
c7f0c7484d
GeckoCodeWidget: Add a Sort button
2018-05-20 11:05:11 +02:00
eae45e0e2c
Merge pull request #6911 from lioncash/analyst
...
PPCAnalyst: Replace memset usages with list initialization
2018-05-20 10:45:44 +02:00
464bfb073e
Merge pull request #6912 from spycrab/qt_jit_widget
...
Qt/JITWidget: Add object name
2018-05-20 10:44:21 +02:00
f7b188c7b4
Qt/JITWidget: Add object name
2018-05-20 03:58:54 +02:00
ced806a00a
PPCAnalyst: Replace memset usages with list initialization
...
Allows the use of non-trivially-copyable objects within the relevant
structs should it ever be needed.
2018-05-19 18:37:54 -04:00
07e0b9c0d2
Merge pull request #6907 from spycrab/qt_gfx_sr_backend
...
Qt/SoftwareRendererWidget: Fix backend info not getting updated properly
2018-05-19 23:33:24 +02:00
ef803613d0
Qt/SoftwareRendererWidget: Fix backend info not getting updated properly
2018-05-19 23:28:23 +02:00
9387b7dd32
Merge pull request #6910 from lioncash/analyst
...
PPCAnalyst: Clean up indexing expressions in Analyze()
2018-05-19 23:25:59 +02:00
5de99288bf
PPCAnalyst: Clean up indexing expressions in Analyze()
...
Given we just access the same member repeatedly, just use a reference
and avoid repeated unnecessary indexing.
2018-05-19 15:31:38 -04:00
c6bd237534
Merge pull request #6908 from Tilka/warnings
...
Fix -Wignored-qualifiers warnings
2018-05-19 21:06:29 +02:00
9ec557761d
Merge pull request #6909 from spycrab/qt_gfx_progscan
...
Qt/AdvancedWidget: Save progressive scan when toggled
2018-05-19 21:05:52 +02:00
49f8d5aefb
Qt/AdvancedWidget: Save progressive scan when toggled
2018-05-19 20:59:30 +02:00
72d38ac615
Merge pull request #6906 from spycrab/qt_gfx_prettytitle
...
Qt/GraphicsWindow: Show display name in title
2018-05-19 20:50:16 +02:00
1993eb436c
Fix -Wignored-qualifiers warnings
2018-05-19 17:18:45 +01:00
bc504d9f84
Qt/GraphicsWindow: Show display name in title
2018-05-19 17:44:22 +02:00
e54880e9f3
Merge pull request #6903 from spycrab/qt_toolbar
...
Qt/ToolBar: Fix checkbox not properly reflecting toolbar visibility
2018-05-19 17:19:06 +02:00
Léo Lam