Léo Lam
49c9c1ee40
Merge pull request #6853 from aldelaro5/qt-debugger-hotkey-fixes
...
Qt debugger hotkey fixes
2018-05-18 19:06:17 +02:00
spycrab
9bdf7c4b5a
Merge pull request #6890 from aldelaro5/qt-fix-random-windows
...
Qt/CheatWarningWidget: properly supply a parent for the widget
2018-05-18 08:08:42 +02:00
aldelaro5
6dd5a3a866
Qt/CheatWarningWidget: properly supply a parent for the widget
...
Because it wasn't parented properly, it would show briefly the widget in its own window when creating an ARCodeWidget or a GeckoCodeWidget which would occur when accessing the game properties page or when the state changes to pause/running.
2018-05-18 01:31:43 -04:00
Tilka
cbc85d928b
Merge pull request #6860 from Zexaron/qt_generalwidget_remove_wrong_description
...
Qt/GeneralWidget remove unnecesary description wiring
2018-05-18 02:24:08 +01:00
aldelaro5
0a2357f044
Qt/hotkeys: do not show the debugging tab if the debugger is disabled
2018-05-17 07:22:34 -04:00
spycrab
54d81ed13a
Qt/SettingsWindow: Wrap tabs in scrollareas
2018-05-15 20:13:12 +02:00
spycrab
e922f91cc3
Qt/GeneralWidget: Restore the adapter properly
2018-05-14 21:16:20 +02:00
Léo Lam
5b15060127
Merge pull request #6857 from spycrab/qt_minor_win
...
Qt: Minor window fixes
2018-05-14 19:11:56 +02:00
Zexaron
ff971b1a6f
Qt/GeneralWidget remove unnecesary description wiring
2018-05-14 18:18:18 +02:00
spycrab
ca5dc25694
Merge pull request #6858 from lioncash/capture
...
DolphinQt2: Resolve unused lambda capture warnings
2018-05-14 16:47:55 +02:00
spycrab
26b1048975
Merge pull request #6850 from lioncash/moc
...
DolphinQt2: Add missing Q_OBJECT macro to all QObject-related classes missing it
2018-05-14 16:29:53 +02:00
Lioncash
e2543ea801
DolphinQt2: Resolve unused lambda capture warnings
...
Resolves -Wunused-lambda-capture warnings.
2018-05-14 10:11:47 -04:00
spycrab
7e9bf12246
Qt: Minor window fixes
...
* Remove some more "What's this?" buttons
* Add some missing titles
2018-05-14 11:10:04 +02:00
Léo Lam
345838d517
Merge pull request #6842 from spycrab/qt_map_apply
...
Qt/Mapping: Fix mapping changes not being applied instantly
2018-05-13 23:34:18 +02:00
Lioncash
222fe58e25
DolphinQt2: Add missing Q_OBJECT macro to all QObject-related classes missing it
...
Without this macro, if any signals or slots were attempted to be used,
they wouldn't work; neither would various other features of the Qt
meta-object system. This can also lead to weird behavior in other
circumstances. Qt's documentation specifically states:
"Therefore, we strongly recommend that all subclasses of QObject use the
Q_OBJECT macro regardless of whether or not they actually use signals,
slots, and properties."
on its page for "The Meta-Object System", which can be seen here:
https://doc.qt.io/qt-5/metaobjects.html
Let's opt for "always do the right thing", and keep the code extensible
for the future and not have random things blow up on us.
2018-05-13 17:33:32 -04:00
JosJuice
74d561085c
Merge pull request #6848 from lioncash/guard
...
DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator
2018-05-13 22:21:40 +02:00
Lioncash
b03c433543
DolphinQt2: Add missing header guards for CheatCodeEditor and MappingIndicator
...
Prevents potential double inclusion issues from ever happening.
2018-05-13 16:11:30 -04:00
Léo Lam
8f44423a5b
Merge pull request #6846 from spycrab/qt_native_sep
...
Qt: Use native dir separators
2018-05-13 22:10:10 +02:00
Léo Lam
6c38e4b47f
Merge pull request #6847 from lioncash/fs-include
...
FilesystemWidget: Replace DiscIO includes with forward declarations
2018-05-13 22:08:09 +02:00
Lioncash
d1d584d16b
FilesystemWidget: Replace DiscIO includes with forward declarations
...
Avoids the need to use an ugly ifdef around a header, and also resolves
an indirect inclusion in PropertiesDialog.
2018-05-13 16:01:16 -04:00
Léo Lam
1fe92b8be7
Merge pull request #6845 from lioncash/patch-dlg
...
NewPatchDialog/PatchesWidget: Use forward declarations where applicable
2018-05-13 22:00:43 +02:00
Léo Lam
07b57c7ac6
Merge pull request #6843 from lioncash/patch
...
PatchEngine: Minor changes
2018-05-13 21:58:55 +02:00
spycrab
5673a64612
Qt: Use native dir separators
2018-05-13 21:51:38 +02:00
Lioncash
0995cfef6a
PatchEngine: Make PatchType an enum class
...
Makes the enum strongly typed. A function for retrieving the string
representation of the enum is also added, which allows hiding the array
that contains all of the strings from view (i.e. we operate on the API,
not the exposed internals). This also allows us to bounds check any
querying for the strings.
2018-05-13 15:46:51 -04:00
Lioncash
799e4154be
PatchesWidget: Convert Core and UICommon includes into forward declarations
...
Avoids propagating inclusions through UI headers
2018-05-13 15:38:58 -04:00
Lioncash
df3f9af6d7
NewPatchDialog: Convert PatchEngine include into a forward declaration
...
Avoids needing to include Core headers in UI-related header files,
preventing unintentional propagation.
2018-05-13 15:34:46 -04:00
spycrab
9e2f9db94c
Qt/Mapping: Fix mapping changes not being applied instantly
2018-05-13 21:21:31 +02:00
Lioncash
a166cf2481
PatchEngine: Give Patch and PatchEntry default member initializers
...
Avoids potentially using the values uninitialized. While we're at it,
also drop the prefixed underscores from one of the constructors.
2018-05-13 15:08:32 -04:00
Lioncash
15a522fe9b
DolphinQt2/NewPatchDialog: Remove unused <iostream> include
...
Including <iostream> causes a static constructor to be injected into the
translation unit, even if the everything from the header itself is
unused.
2018-05-13 14:04:22 -04:00
spycrab
17795a615b
Merge pull request #6838 from spycrab/qt_map_save
...
Qt/ControllersWindow: Fix changing devices while emulation is running
2018-05-13 18:17:13 +02:00
spycrab
2ca75ae05a
Qt/ControllersWindow: Fix changing devices while emulation is running
2018-05-13 14:04:39 +02:00
Léo Lam
6763a3fce1
Config: Add support for enums
...
This makes it possible to use enums as the config type.
Default values are now clearer and there's no need for casts
when calling Config::Get/Set anymore.
In order to add support for enums, the common code was updated to
handle enums by using the underlying type when loading/saving settings.
A copy constructor is also provided for conversions from
`ConfigInfo<Enum>` to `ConfigInfo<underlying_type<Enum>>`
so that enum settings can still easily work with code that doesn't care
about the actual enum values (like Graphics{Choice,Radio} in DolphinQt2
which only treat the setting as an integer).
2018-05-12 18:10:26 +02:00
spycrab
242fadc76f
Qt/MappingButton: Fix occasionally broken indicator
2018-05-11 12:37:48 +02:00
spycrab
146979f67e
Qt/IOWindow: Fix crash
2018-05-10 21:12:19 +02:00
spycrab
be007b436c
Qt/GraphicsWindow: Fix software renderer breaking layout
2018-05-10 12:08:23 +02:00
spycrab
074a17482b
Qt/GraphicsWindow: Refresh settings on construction
2018-05-10 12:08:23 +02:00
spycrab
6a34f2b47c
Qt/GeneralWidget: Fix "No" response to backend switch confirmation
2018-05-10 12:08:23 +02:00
spycrab
b7b6b5162c
Qt/GeneralWidget: Refresh backend settings properly
2018-05-10 12:08:23 +02:00
spycrab
18c7d295c9
Qt/FilesystemWidget: Fix moc compilation
2018-05-09 22:35:27 +02:00
Starsam80
ebf6149ad4
Qt: Use `addLayout` instead of `addItem` when adding layouts
2018-05-08 17:54:47 -06:00
Anthony
1ec3a4db6c
Merge pull request #6763 from spycrab/qt_fix_prog
...
Qt/AdvancedWidget: Fix "Enable Progressive Scan"
2018-05-07 09:59:32 -07:00
Anthony
46236920ef
Merge pull request #6767 from spycrab/qt_whatsthis2
...
Qt: Make dialogues more consistent
2018-05-07 09:58:15 -07:00
spycrab
a2448c5b66
Qt/GeneralWidget: Various fixes
2018-05-07 17:50:03 +02:00
Markus Wick
6f0ad84a5e
Merge pull request #6764 from spycrab/qt_fix_rtm
...
Qt: Fix "Render To Main"
2018-05-07 17:33:56 +02:00
spycrab
7cd30810a3
Qt: Make dialogues more consistent
2018-05-06 18:05:56 +02:00
Léo Lam
7a9e1a240e
Merge pull request #6757 from JosJuice/qt-filesystem-extraction
...
DolphinQt2: Fix disc extraction inconsistencies with DolphinWX
2018-05-06 13:24:06 +02:00
spycrab
6f65238efc
Qt: Fix "Render To Main"
2018-05-06 04:51:13 +02:00
spycrab
6442b32aeb
Qt/AdvancedWidget: Fix "Enable Progressive Scan"
2018-05-06 03:16:43 +02:00
JosJuice
33211d8690
DolphinQt2: Don't show pop-ups in the middle of extracting a whole disc
2018-05-05 18:31:46 +02:00
JosJuice
f48fac5b55
DolphinQt2: Allow picking "Extract Files..." on disc/partition
...
DolphinWX already does this.
2018-05-05 18:31:44 +02:00