62eeb05519
Common: Validate the number of {} fields in format strings
...
Unfortunately, {fmt} allows passing too many arguments to a format call
without raising any runtime or compile-time error [1].
As this is a common source of bugs since we started migrating to {fmt},
this commit adds some custom logic to validate the number of
replacement fields in format strings in addition to {fmt}'s own checks.
[1] https://github.com/fmtlib/fmt/issues/492
2020-11-19 17:09:24 +01:00
47c91696ee
Common/Log: Check format strings
...
Helps with catching incorrect format strings.
PanicAlertFmt already uses FMT_STRING and fmt::make_args_checked.
2020-11-19 17:09:24 +01:00
7e9a2dcc72
Merge pull request #9261 from AdmiralCurtiss/shop-logs
...
WiiUtils: Create Wii Shop log files when installing a WAD.
2020-11-19 16:49:34 +01:00
83c235b7cb
WiiUtils: Create Wii Shop log files when installing a WAD.
...
Fixes https://bugs.dolphin-emu.org/issues/12269
2020-11-19 03:26:27 +01:00
4d26f6ad95
Fixed non-UTF8 chars in PeakFinder.cpp
2020-11-18 19:50:40 +00:00
59c362d002
Translation resources sync with Transifex
2020-11-18 18:14:57 +01:00
4eecb8fd11
Merge pull request #9248 from lioncash/video-fmt
...
VideoCommon: Migrate over to fmt
2020-11-18 11:10:48 +01:00
3d9b2aa005
VideoCommon: Migrate over to fmt
...
Migrates off the printf-based formatting where applicable.
2020-11-17 21:23:58 -05:00
eb1581bbcc
Merge pull request #9246 from JosJuice/translation-eot
...
DolphinQt: Don't return 0x04 bytes from tr
2020-11-18 02:31:13 +01:00
31d7be521c
Merge pull request #7714 from cristian64/avoid_leaking_gamelistmodel
...
DolphinQt: Avoid leaking the GameListModel instance to gracefully shutdown the GameTracker and prevent a crash on exit
2020-11-18 02:14:51 +01:00
0339889806
Merge pull request #9251 from sepalani/sockopt
...
IP/Top: Add missing sockopt
2020-11-18 02:10:37 +01:00
b8bc6c3c86
Merge pull request #9256 from JosJuice/android-keep
...
Android: Add @Keep annotation to things accessed using JNI
2020-11-18 01:01:34 +01:00
8119318907
Merge pull request #9257 from JosJuice/redundant-i18n
...
Remove a redundant i18n comment
2020-11-18 00:56:58 +01:00
52c615f1b1
Remove a redundant i18n comment
2020-11-17 18:23:27 +01:00
07be82d64f
Merge pull request #9253 from JosJuice/positional-arguments
...
Use positional arguments in all translatable fmt strings
2020-11-17 18:02:39 +01:00
a8d385c705
Android: Add @Keep annotation to things accessed using JNI
...
This acts as a hint to both people and automated tools
that a variable or method shouldn't be renamed or removed.
2020-11-17 14:11:51 +01:00
9a01c3fb9f
Use positional arguments in all translatable fmt strings
...
We want to use positional arguments in translatable strings
that have more than one argument so that translators can change
the order of them, but the question is: Should we also use
positional arguments in translatable strings with only one
argument? I think it makes most sense that way, partially
so that translators don't even have to be aware of the
non-positional syntax and partially because "translatable
strings use positional arguments" is an easier rule for us
to remember than "transitional strings which have more than
one argument use positional arguments". But let me know if
you have a different opinion.
2020-11-16 13:28:11 +01:00
4c9b226bd6
Merge pull request #9252 from JosJuice/fmt-version-requirement
...
CMake: Bump fmt version requirement to 7.1.0
2020-11-16 07:12:54 -05:00
56e68e7b72
CMake: Bump fmt version requirement to 7.1.0
...
We use make_args_checked, which was added in 7.1.0.
2020-11-16 13:06:20 +01:00
6dcf7643e5
Fix updater not always cleaning up temp directory
...
Updater was only deleting TempUpdate folder when an error occured.
2020-11-13 12:25:53 -08:00
53da97208a
DolphinQt: Don't return 0x04 bytes from tr
...
tr calls with more than one argument would have a 0x04 byte
in the returned string when no translation was found
(which always is the case when using Dolphin in English).
2020-11-12 19:44:44 +01:00
8a621c2d5e
Merge pull request #9236 from lioncash/log-backend
...
VideoBackends: Migrate logging over to fmt
2020-11-12 14:51:28 +01:00
ec5313fe24
Merge pull request #9204 from fbastos1/master
...
fix emulator issue #12139
2020-11-12 14:43:35 +01:00
c991f00479
Merge pull request #9244 from lioncash/input-panic
...
InputCommon: Migrate over to fmt-capable panic alerts
2020-11-12 14:41:50 +01:00
d8e1921b57
InputCommon: Migrate over to fmt-capable panic alerts
...
Continues the migration over to fmt.
2020-11-12 02:29:26 -05:00
93212049ac
Merge pull request #9242 from lioncash/disc-panic
...
DiscIO: Make use of fmt-capable panic alerts
2020-11-12 02:22:21 -05:00
161f8c3fad
Android: Warn when path in config is unavailable
...
Content URIs stop working if Dolphin loses permissions,
which happens for instance when reinstalling Dolphin.
2020-11-11 18:56:15 +01:00
9e3e325add
Merge pull request #9243 from JosJuice/android-input-overlay-null
...
Android: Add null check for InputOverlay
2020-11-11 11:22:41 +01:00
32ad2dcec3
Android: Add null check for InputOverlay
...
Hopefully fixes https://bugs.dolphin-emu.org/issues/12316 .
2020-11-11 10:38:49 +01:00
689eec5304
DiscIO: Make use of fmt-capable panic alerts
...
Migrates the DiscIO code over to fmt.
2020-11-11 01:09:42 -05:00
ae83685b0b
Merge pull request #9237 from lioncash/msghandler
...
Common/MsgHandler: Add fmt-capable variants of the alert macros
2020-11-11 00:34:45 -05:00
f44b13ffcd
FrameDump Logging: Separate log type and migrate to fmt
2020-11-10 17:17:43 +01:00
0a2564a89d
Merge pull request #9234 from lioncash/rename-fmt
...
ShaderGenCommon: Rename WriteFmt() to Write()
2020-11-09 22:08:42 -05:00
ff4b7ca7f4
Remove Android-specific settings from UISettings.cpp
...
They are unused, since there is no C++ code that touches
these settings. See the discussion in PR 9152, which is
a PR that adds a lot more Android-specific settings.
2020-11-09 21:41:00 +01:00
e260f9815c
Android: Move orientation setting to main settings screen
...
I moved it from the main settings screen to the in-game menu
in PR 8439 so that it could be changed while a game is running,
but now that the main settings can be accessed while a game is
running, there's no reason to not put it in the main settings.
https://bugs.dolphin-emu.org/issues/12067
2020-11-09 21:41:00 +01:00
7b21f7af2e
Common/MsgHandler: Add fmt-capable variants of the alert macros
...
Adds an interface that uses fmt under the hood, which is much more
flexible than printf, particularly for localization purposes, given fmt
supports positional formatters in a cross-platform manner out of the box
with no configuration necessary.
2020-11-09 08:48:17 -05:00
43e2f0e88f
Merge pull request #9235 from lioncash/ui-log
...
UICommon: Migrate logging over to fmt
2020-11-09 07:28:28 -05:00
72997c17d0
Merge pull request #9229 from JosJuice/android-emulationactivity-finish
...
Android: Handle failed boots correctly
2020-11-09 10:46:08 +01:00
8181a7b3dd
Android: Remove unnecessary ANativeWindow_release call
...
This is already handled by SurfaceDestroyed. In the worst case,
the extra code could even race with SurfaceDestroyed if they
are triggered at the same time, but this is highly improbable.
2020-11-09 10:38:50 +01:00
d982afd1ef
Android: Fix alert messages when EmulationActivity is being destroyed
...
The previous commit made this easy to reproduce when launching
an invalid disc image with the phone rotated incorrectly.
2020-11-09 10:38:50 +01:00
ee52f465b1
Android: Fix rotating EmulationActivity after boot fails
...
Time for yet another new iteration of working around the
"surface destruction during boot" problem...
This time, the strategy is to use a mutex in MainAndroid.cpp.
2020-11-09 10:38:49 +01:00
d06830b274
Android: Only show emulation menu toast if boot succeeds
2020-11-09 10:33:53 +01:00
0280f3557c
Android: Finish EmulationActivity from C++
...
This makes EmulationActivity automatically close if booting
fails, and lets us get rid of s_emulation_end_event.
2020-11-09 10:33:52 +01:00
21dd7a8ebb
Vulkan: Migrate logging over to fmt
...
Migrates the vulkan backend over to the fmt-capable logger.
2020-11-09 03:26:16 -05:00
23a8baa605
Software: Migrate logging over to fmt
...
Migrates the software backend over to the fmt-capable logger.
2020-11-09 03:14:01 -05:00
413d64e7fc
OpenGL: Migrate logging over to fmt
...
Migrates over to the fmt-capable logger.
2020-11-09 03:09:09 -05:00
4d9a7c7a54
D3DCommon: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:03:26 -05:00
2345d5f98d
D3D: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 03:02:00 -05:00
d7834bd6b4
D3D12: Migrate logging over to fmt
...
Migrates the logging over to the fmt-capable logger.
2020-11-09 02:59:51 -05:00
52f2fadb36
UICommon: Migrate logging over to fmt
...
A very simple change that continues the migration of the logs over to
fmt.
2020-11-09 02:39:55 -05:00
Léo Lam