Commit Graph

38928 Commits

Author SHA1 Message Date
MayImilae ef0d386954 Remove Memory Card Path from the Wrote OSD Message
A few weeks ago, a vtuber tweeted that they had to remove a vod of their stream because Dolphin Emulator showed some personal information during the steam, and left a warning to everyone else that Dolphin shows the account name of the computer. And yea, we do, we show the full directory of the memory card every time a memory card is written, and due to mandatory Microsoft account nonsense, that is very likely to contain someone’s real name.

Fortunately this is very easy for us to solve. This change simply removes the filename from wrote memory card contents string. That’s it. All functionality of the wrote memory card OSD message remains the same, it just doesn’t say where the memory card is anymore.

There are lots of other potential solutions to this but after talking on IRC it seems the simplest one is the best.
2023-01-21 21:19:51 -08:00
Joshua de Reeper 18fd0d7dcd Use Core timing instead of thread
Skylander code tidy ups

Convert c array to std::array and fix comments

Formatting fixes/review changes

Variable comment

Migrate portal to System Impl and code tidy ups

Use struct

Restore review changes

Minor fix to schedule transfer method

Change descriptors to hex and fix comments
2023-01-22 14:50:30 +13:00
Joshua de Reeper f76a6789a0 Emulate Skylanders within Dolphin
Ported the code from RPCS3, with improvements made to the handling of control messages and audio transfers, Co-Authored with @mandar1jn

Missing new line chars

Co-Authored-By: mandar1jn <49076509+mandar1jn@users.noreply.github.com>
2023-01-22 14:50:30 +13:00
Pierre Bourdon 9fe1d80920
Merge pull request #11457 from delroth/remove-stable-track
DolphinQt/Settings: remove 'stable' track from auto-updater options
2023-01-21 06:48:04 +01:00
Pierre Bourdon c49517c6c9
Merge pull request #11438 from Pokechu22/gtest-submodule
Externals: Convert gtest to a submodule and update to v1.12.1
2023-01-20 22:15:51 +01:00
Pokechu22 597f8f1b87 Externals: Convert gtest to a submodule and update to v1.12.1 2023-01-20 11:43:34 -08:00
JMC47 d1aacf8547
Merge pull request #11464 from shockdude/turntable-range-fix
Fix DJ Turntable extension's table range
2023-01-20 12:04:28 -05:00
OatmealDome d40dbe4670 DolphinQt: Add workaround for Qt 6.3+ bug on Linux
See https://bugs.dolphin-emu.org/issues/12913 for more information.
2023-01-20 03:06:04 -05:00
shockdude a32b85691b Fix Turntable extension's table range 2023-01-18 19:17:09 -08:00
Pierre Bourdon 1b333727e9
Merge pull request #11463 from JMC47/DisableVISkipWW
Disable VI Skip in Wind Waker and Twilight Princess
2023-01-19 01:45:20 +01:00
JMC47 7e9bd34519 Disable VI Skip in Wind Waker and Twilight Princess
These games do some funky VI stuff which causes VI Skip
to be completely incompatible with them, so let's disable it.
2023-01-18 19:43:24 -05:00
Pierre Bourdon 8d5edb13a9
Merge pull request #11367 from Sam-Belliveau/lagbegone
VideoCommon: VI Skip
2023-01-19 01:20:01 +01:00
Charles Lombardo b598b6ec72 Android: Add about dialog 2023-01-18 15:58:06 -05:00
Charles Lombardo bbb83054af Android: Expose custom rtc options 2023-01-18 01:56:05 -05:00
Charles Lombardo d63462a14e Android: Add missing headers 2023-01-18 01:55:39 -05:00
Charles Lombardo 6448d6dbe7 Android: Expose emulated memory size override
Update BooleanSetting.java
2023-01-18 01:55:39 -05:00
Pierre Bourdon 1cd11b8f3a
Merge pull request #11381 from skyfloogle/traversal-fix-1
Netplay: Fix traversal connections occasionally not working
2023-01-17 23:40:24 +01:00
Pierre Bourdon 4fc6488844
Merge pull request #11362 from alucryd/feat/system-libmgba
try for system libmgba first
2023-01-17 23:35:02 +01:00
Pierre Bourdon 283f21717b
Merge pull request #11454 from OatmealDome/implot-demo-be-gone
implot: Don't compile `implot_demo.cpp`
2023-01-17 23:30:58 +01:00
Pierre Bourdon a7d1683149
Merge pull request #11432 from Pokechu22/generic-vertex-loader-test-error
VertexLoader: Fix loading tangent/binormal caches with NormalIndex3
2023-01-17 23:30:29 +01:00
Pierre Bourdon 686ac363ba
Merge pull request #11456 from MayImilae/remove-boot-from-dvd
Remove Boot from DVD Backup
2023-01-17 23:27:59 +01:00
Pierre Bourdon c527aea40d
Merge pull request #11453 from JosJuice/revert-open-user-dir-qt-hotfix
Revert "MenuBar: Tweak string for open user folder option"
2023-01-17 23:27:09 +01:00
John Papetti e2db9cd142
NetKDTime: Use UTC timestamp 2023-01-17 13:59:01 -05:00
Charles Lombardo 96c8a7ee1f Android: Expose texture filtering options 2023-01-17 11:13:02 -05:00
Charles Lombardo 23331e4367 Android: Expose frame dump compression level 2023-01-17 11:13:02 -05:00
Shawn Hoffman dff7f20f9d windows: prefer os version from registry
this value is not modified by compatibility mode
drop reporting service pack numbers. no longer used
2023-01-17 01:38:00 -08:00
Pierre Bourdon 3342947446
DolphinQt/Settings: remove 'stable' track from auto-updater options
We've decided this track will never be used in the future. Releases will
continue using the "beta" branch internally, though we'll have the
user-visible strings use a different name instead.

(Note: Dolphin provided builds have always defaulted to 'beta' as the
auto-update track, so anyone who set 'stable' did so manually.)
2023-01-17 08:34:55 +01:00
Charles Lombardo 6373c9225b Android: Expose accurate cpu cache toggle 2023-01-17 01:10:46 -05:00
Charles Lombardo bc64392692 Android: Expose pause on panic toggle 2023-01-17 01:08:40 -05:00
Pierre Bourdon 10fd768898
Merge pull request #11420 from t895/copy-profile
Android: Copy baseline profile during release builds
2023-01-17 04:48:30 +01:00
MayImilae dcc10cff11 Remove Boot from DVD Backup
This should be a fairly easy merge, assuming I didn’t mess anything up. TL:DR no one uses it and it’s not great.

Boot from DVD Backup is an ancient feature with origins in the Megacommit. Back then, GameCube and Wii games were quite large relative to drives of the time. For example, in 2008, the most common hard drive sizes were 320GB and 512GB. On the 320GB drive I personally had at the time, as little as 42 Wii ISOs could have filled it entirely! And that’s ignoring any other files one might want to put onto a drive. Backup DVDs allowed users to burn relatively cheap DVD media and store their GameCube and Wii dumps in a Dolphin accessible way that didn’t eat into their precious HDD space. It had compromises, even then, but in 2008… I mean honestly users probably wouldn’t even notice those compromises with how Dolphin barely even worked at all back then.

Obviously, today the storage space concerns are not as big of an issue. According to seagate the average hard drive it sells today is 8TB. For typical laptops purchased now, the -minimum- selection for storage is usually 1TB. You can even buy a name brand 4TB external hard drive for $100. GC and Wii ISOs are not as big as they once were, relatively anyway. Plus flash drives and SD cards are super cheap and way faster than disc drives ever were. For anyone that has limited drive space, removable flash media can fulfill this offloading role far better than backup DVD media ever could.

Also no one has DVD drives anymore. That’s kind of an important detail.

But to see if Booting from DVD Backup even still worked, I decided to give it a try. I have an ASUS BW-16D1HT, a badass Bluray XL reading and burning drive, connected to my Windows 11 Threadripper 5975WX machine. A super fast drive on a super fast machine is as good as it possibly can get for this feature. So I bought a spindle of DVD-Rs, burned a couple of discs and gave it a try. Surprisingly, it does still work. However, as expected, it introduces a lot of stuttering. Testing Prime 1 and Prime 3, in both games stuttering was introduced whenever the DVD Drive had to suddenly seek. Spikes of 50ms occurred constantly, but I observed 150ms and even over 1000ms stutters! The worst was a three second stutter, when loading Elysia in Prime 3. I could even hear the stutters - any time the drive suddenly made a harsh seeking noise, the game would have a hard stutter. It worked but, it has some serious compromises.

Boot from DVD Backup isn’t great, using removable flash media or external hard drives is a FAR better option for anyone with limited storage space today, and no one can even use this feature anymore because their computers don’t even have disc drives. It’s time for Boot from DVD Backup to go!

So I did my best on the cleanup but I’m bound to have left some bits. Especially in translation - I didn’t get any warnings or anything there that could help point me to where to clean that up. Please review!
2023-01-16 18:32:43 -08:00
Charles Lombardo a3b7510505 Android: Expose skip main menu toggle 2023-01-16 20:39:33 -05:00
OatmealDome dc4284652c implot: Don't compile implot_demo.cpp 2023-01-16 13:49:20 -05:00
Admiral H. Curtiss 0e1c2501be
Merge pull request #11442 from Simonx22/spirv-cross_branch-rename
.gitmodules: change SPIRV-Cross branch to main
2023-01-16 19:36:26 +01:00
JosJuice 716dabde96
Merge pull request #11447 from t895/save-state-fix
Android: Fix large strings in save/load savestate fragment
2023-01-16 19:09:37 +01:00
JosJuice 59b276ea87
Merge pull request #11448 from t895/nav-fix-api-26
Android: Fix navigation bar buttons appearing invisible on API 26
2023-01-16 18:45:06 +01:00
JosJuice 8f88297122 Revert "MenuBar: Tweak string for open user folder option"
This reverts commit 6788bda6c9.

The user folder can be either global or local. If it is local,
we shouldn't call it global.

See also da0be24b2f.
2023-01-16 18:31:16 +01:00
Pierre Bourdon aacd66bd5b
Merge pull request #11451 from OatmealDome/open-user-dir-qt-hotfix
MenuBar: Tweak string for open user folder option
2023-01-16 10:47:27 +01:00
Pierre Bourdon bb64b0ee44
Merge pull request #10708 from OatmealDome/win-user-dir
UICommon: Change default user directory location to AppData on Windows
2023-01-16 10:34:41 +01:00
OatmealDome 6788bda6c9 MenuBar: Tweak string for open user folder option 2023-01-16 04:31:12 -05:00
Pierre Bourdon 2d783f86bc
Merge pull request #11450 from OatmealDome/open-user-dir-qt
MenuBar: Add action which opens the user folder
2023-01-16 10:21:19 +01:00
OatmealDome 869aa9eb55 MenuBar: Add action which opens the user folder 2023-01-16 04:08:19 -05:00
OatmealDome cc68d5321f UICommon: Set UserConfigPath in the registry to AppData User for backwards compatibility 2023-01-16 01:37:14 -05:00
OatmealDome 3896934d5e UICommon: Use the old User directory in Documents if it exists 2023-01-16 01:37:14 -05:00
OatmealDome 75d87ff90e UICommon: Change default User directory location to AppData 2023-01-16 01:37:14 -05:00
JMC47 c4f4ecbb62
Merge pull request #11449 from phire/resetThrottle
Reset Throttle on savestate load
2023-01-15 21:47:42 -05:00
Charles Lombardo b1e05c9125 Android: Remove pre-generated baseline profile 2023-01-15 21:16:55 -05:00
Charles Lombardo 19aa9247be Android: Copy baseline profile during release builds 2023-01-15 21:16:55 -05:00
Scott Mansell 7c202ab411 Reset throttle on savestate load 2023-01-16 14:18:42 +13:00
Charles Lombardo dbe03a4f76 Android: Fix navigation bar buttons appearing invisible on API 26 2023-01-15 18:36:22 -05:00