Commit Graph

42535 Commits

Author SHA1 Message Date
Martino Fontana f9450f1460 GameINI: SVX.ini: Replace `EFBToTextureEnable=False` with `ImmediateXFBEnable=False`
To fix flickering pre-rendered cutscenes, the former doesn't do anything anymore, while the latter does.
2024-07-27 15:42:12 +02:00
Dentomologist d627b78c46 Adjust order and spacing of various #includes
Move some #includes around to match the Contributing guidelines.
2024-07-26 14:28:34 -07:00
LillyJadeKatrin 347aab7ab3 Fixed achievements not working after a disc change. 2024-07-25 20:46:46 -04:00
OatmealDome 87b7009c12
Merge pull request #12723 from mitaclaw/cached-interpreter-2.0
Cached Interpreter 2.0
2024-07-24 01:36:39 -04:00
mitaclaw 6c3024c3b1 CachedInterpreter: Combine Interpret, CheckDSI, CheckProgram, and WritePC
I tried making the new templated Interpret callback test only the relevant exceptions (EXCEPTION_DSI, EXCEPTION_PROGRAM, or both), but didn't find a significant performance boost in it. As I am learning, the biggest bottleneck is the number of callbacks emitted, not usually the actual contents of them.
2024-07-23 14:09:57 -07:00
mitaclaw ae43b10eff CachedInterpreter: Use `CodeOp::canEndBlock`
This was a bigger performance boost than I expected.
2024-07-23 14:07:02 -07:00
mitaclaw 818647d694 CachedInterpreter: WritePC optimizations
WritePC is now needed far less, only for instructions that end the block. Unfortunately, WritePC still needs to update `PowerPCState::npc` to support the false path of conditional branch instructions. Both drawbacks should be smoothed over by optimized cached instructions in the future.
2024-07-23 14:06:40 -07:00
mitaclaw 0282fa7adb CachedInterpreter: Exception Check Callback Micro-Optimization
This saves two register pushes / pops.
2024-07-23 14:06:22 -07:00
mitaclaw f79520a906 Cached Interpreter 2.0
It now supports variable-sized data payloads and memory range freeing. It's a little faster, too.
2024-07-23 14:06:21 -07:00
Tilka 5f4f974b48
Merge pull request #12950 from AdmiralCurtiss/achievement-fix-badge-network-error
AchievementManager: Fix incorrect check on network request return value in FetchBadge()
2024-07-23 20:16:54 +01:00
Admiral H. Curtiss c71ccb548e
AchievementManager: Fix incorrect check on network request return value in FetchBadge() 2024-07-23 20:49:12 +02:00
Admiral H. Curtiss 2d8f54fdd2
Merge pull request #12862 from SuperSamus/debugger-fixes
Debugger: Various fixes
2024-07-23 20:36:34 +02:00
Admiral H. Curtiss 7db5caf43e
Merge pull request #12943 from Tilka/list_recursively
DolphinTool: list filesystem recursively
2024-07-23 19:56:07 +02:00
Tilka 933da0788d
Merge pull request #12910 from ReillyBrogan/fix-minizip-ng
cmake: Fix building with system minizip-ng
2024-07-23 18:55:51 +01:00
Tilka 199cc899bc
Merge pull request #12948 from mitaclaw/jit-getters
Emitters: Define Trivial Getters Inline
2024-07-23 14:14:33 +01:00
mitaclaw ffc7bcfbf8 Emitters: Define Trivial Getters Inline 2024-07-21 21:35:29 -07:00
Dentomologist 384e044437 QtUtils/ClearLayoutRecursively: Fix potential crash
Use QObject->deleteLater() instead of the delete operator to destroy
child widgets of the layout. This prevents crashes caused by pending
events trying to access the now-destroyed widget.
2024-07-21 17:36:05 -07:00
Tillmann Karras 191b36976c DolphinTool: list filesystem recursively 2024-07-21 19:16:00 +01:00
Tilka 7bd2a7bde3
Merge pull request #12945 from Tilka/erase_if
Use C++20 erase_if() instead of erase(remove_if()) (NFC)
2024-07-21 19:06:55 +01:00
Tilka 652245006d
Merge pull request #12946 from SimoneN64/master
Fix double-definition under newlib
2024-07-21 19:06:25 +01:00
SimoneN64 2dcb612497 Change OperandDesc variables to not be underscore-prefixed in order to comply with https://eel.is/c++draft/lex.name#3.1 (fixes compilation under newlib; e.g. devkitPro) 2024-07-21 18:35:38 +02:00
Tillmann Karras 982893b04c Use C++20 erase_if() instead of erase(remove_if()) (NFC) 2024-07-21 16:36:06 +01:00
Admiral H. Curtiss 1fcb2ee5c1
Merge pull request #12936 from vabold/ios-inaccuracy
IOS: Fix return code inaccuracy
2024-07-19 21:27:07 +02:00
Admiral H. Curtiss 139e6f6f1b
Merge pull request #12941 from LillyJadeKatrin/retroachievements-leaderboard-spam-fix
RetroAchievements - Leaderboard Spam Fix
2024-07-18 21:15:38 +02:00
Admiral H. Curtiss 9175665198
Merge pull request #12939 from Avasam/patch-1
Disable Dual Core in Death Jr.: Root of Evil
2024-07-18 21:11:53 +02:00
Admiral H. Curtiss 3169bc913f
Merge pull request #12940 from LillyJadeKatrin/retroachievements-prior-unlock-bug
Fixed incorrect unlock information in Achievements dialog
2024-07-18 21:11:35 +02:00
LillyJadeKatrin 8bb2f98c6a Properly Populate Player Index
The player_index field in question is ultimately what gets used to determine which ranks get displayed in the leaderboards chart, and because this was missing the chart was simply displaying the top four results no matter what.
2024-07-17 22:53:15 -04:00
LillyJadeKatrin 5ccd157c94 Re-enable Leaderboards Tab 2024-07-17 22:51:43 -04:00
LillyJadeKatrin e7504d0b12 Remove Leaderboard Fetch when Getting Info
The cause of the leaderboard spam was primarily this call where if there was an attempt to get leaderboard info and there wasn't already, there would be a fetch request. This is bad for many reasons: some games have hundreds of boards that will be fetched at startup, if there's simply no data to populate that board, this will just continue to fetch every time the dialog needs to update. To mitigate this, I simply don't load leaderboard information until there are events for that leaderboard - less information for the player, sadly, but heavily cuts down on the number of leaderboard fetches.
2024-07-17 22:51:24 -04:00
LillyJadeKatrin d19aa934ae Fixed incorrect unlock information in Achievements dialog 2024-07-17 04:36:53 -04:00
Avasam 130d594c82 Disable Dual Core in Death Jr.: Root of Evil 2024-07-16 22:06:21 -04:00
OatmealDome cc3ff347b4
Merge pull request #12928 from LillyJadeKatrin/retroachievements-disable-lboard-tab
Disable Leaderboards Tab
2024-07-15 21:33:08 -04:00
OatmealDome 802abbb288
Merge pull request #12937 from AdmiralCurtiss/achievements-login-error-message
AchievementManager: Don't point to stack for login error message
2024-07-15 18:53:01 -04:00
Admiral H. Curtiss 63e1419396
AchievementManager: Don't point to stack for login error message 2024-07-15 23:24:04 +02:00
OatmealDome 505fe5cc0e
Merge pull request #12935 from AdmiralCurtiss/achievements-default-badges
AchievementManager: Improve player/game badge handling and fix crash when no badge is loaded
2024-07-15 16:40:51 -04:00
Aiden c50689355b IOS: Fix return code inaccuracy
Co-Authored-By: Mike <99037623+MikeIsAStar@users.noreply.github.com>
2024-07-15 16:11:15 -04:00
Admiral H. Curtiss 50b318cc31
Qt/AchievementHeaderWidget: Don't crash when we get an empty player or game badge 2024-07-15 21:55:47 +02:00
Admiral H. Curtiss d665175a2b
AchievementManager: Return the default player and game badges if the current one isn't loaded yet
This saves some copying and fixes an issue where the default badges disappear after a game was closed
2024-07-15 21:55:23 +02:00
JMC47 549b16d442
Merge pull request #12932 from AdmiralCurtiss/colo-xd-gci-patches
GameINI: Enable Pokémon Colosseum/XD save patches by default
2024-07-15 15:00:38 -04:00
Admiral H. Curtiss b18661f15d
Merge pull request #12931 from AdmiralCurtiss/cannot-pause-message
AchievementManager: Improve error message for repeated pausing
2024-07-15 12:05:45 +02:00
Admiral H. Curtiss 7e7273a335
GameINI: Enable Pokémon Colosseum/XD save patches by default 2024-07-15 03:44:05 +02:00
OatmealDome 12a1607385
Merge pull request #12749 from LillyJadeKatrin/retroachievements-menubar
Show Achievements in Menu Bar always
2024-07-14 19:13:08 -04:00
Admiral H. Curtiss 7a36d5373a
AchievementManager: Improve error message for repeated pausing 2024-07-14 23:09:53 +02:00
Admiral H. Curtiss a0fc8e6b13
Merge pull request #12929 from LillyJadeKatrin/retroachievements-leaderboard-fixes
Fix Leaderboards Tab
2024-07-14 16:47:59 +02:00
LillyJadeKatrin 0108ecebcb Fix Leaderboards Tab
Now that we have some test data, it wasn't showing up in the leaderboards tab; this fixes it to ensure (1) that the right ID is being passed to UpdateRow and (2) the map of leaderboard entries is being populated correctly.
2024-07-14 10:13:27 -04:00
Admiral H. Curtiss a273dc2de2
Merge pull request #12924 from JosJuice/ra-unverified-ini-osd
RetroAchievements: Show OSD messages also for unverified INI files
2024-07-14 04:15:05 +02:00
Admiral H. Curtiss f23460ab42
Merge pull request #12927 from OatmealDome/old-tools
Tools: Remove unused and broken scripts
2024-07-14 04:13:19 +02:00
Admiral H. Curtiss f928fe97af
Merge pull request #12925 from LillyJadeKatrin/retroachievements-unlocked-progress
Achievements Progress Bar Tweaks
2024-07-14 04:11:02 +02:00
Admiral H. Curtiss ca40eeecff
Merge pull request #12926 from OatmealDome/macos-system-libs
BuildMacOSUniversalBinary: Disable usage of most system-provided libraries
2024-07-12 16:49:03 +02:00
Admiral H. Curtiss 95933d5158
Merge pull request #12907 from GaryOderNichts/fix/init_ipc_running
IOS::HLE::EmulationKernel::InitIPC: Fix WiiIPC ack generation
2024-07-12 16:48:37 +02:00