mitaclaw
ffc7bcfbf8
Emitters: Define Trivial Getters Inline
2024-07-21 21:35:29 -07:00
Dentomologist
384e044437
QtUtils/ClearLayoutRecursively: Fix potential crash
...
Use QObject->deleteLater() instead of the delete operator to destroy
child widgets of the layout. This prevents crashes caused by pending
events trying to access the now-destroyed widget.
2024-07-21 17:36:05 -07:00
Tillmann Karras
191b36976c
DolphinTool: list filesystem recursively
2024-07-21 19:16:00 +01:00
Tilka
7bd2a7bde3
Merge pull request #12945 from Tilka/erase_if
...
Use C++20 erase_if() instead of erase(remove_if()) (NFC)
2024-07-21 19:06:55 +01:00
Tilka
652245006d
Merge pull request #12946 from SimoneN64/master
...
Fix double-definition under newlib
2024-07-21 19:06:25 +01:00
SimoneN64
2dcb612497
Change OperandDesc variables to not be underscore-prefixed in order to comply with https://eel.is/c++draft/lex.name#3.1 (fixes compilation under newlib; e.g. devkitPro)
2024-07-21 18:35:38 +02:00
Tillmann Karras
982893b04c
Use C++20 erase_if() instead of erase(remove_if()) (NFC)
2024-07-21 16:36:06 +01:00
Admiral H. Curtiss
1fcb2ee5c1
Merge pull request #12936 from vabold/ios-inaccuracy
...
IOS: Fix return code inaccuracy
2024-07-19 21:27:07 +02:00
Admiral H. Curtiss
139e6f6f1b
Merge pull request #12941 from LillyJadeKatrin/retroachievements-leaderboard-spam-fix
...
RetroAchievements - Leaderboard Spam Fix
2024-07-18 21:15:38 +02:00
Admiral H. Curtiss
9175665198
Merge pull request #12939 from Avasam/patch-1
...
Disable Dual Core in Death Jr.: Root of Evil
2024-07-18 21:11:53 +02:00
Admiral H. Curtiss
3169bc913f
Merge pull request #12940 from LillyJadeKatrin/retroachievements-prior-unlock-bug
...
Fixed incorrect unlock information in Achievements dialog
2024-07-18 21:11:35 +02:00
LillyJadeKatrin
8bb2f98c6a
Properly Populate Player Index
...
The player_index field in question is ultimately what gets used to determine which ranks get displayed in the leaderboards chart, and because this was missing the chart was simply displaying the top four results no matter what.
2024-07-17 22:53:15 -04:00
LillyJadeKatrin
5ccd157c94
Re-enable Leaderboards Tab
2024-07-17 22:51:43 -04:00
LillyJadeKatrin
e7504d0b12
Remove Leaderboard Fetch when Getting Info
...
The cause of the leaderboard spam was primarily this call where if there was an attempt to get leaderboard info and there wasn't already, there would be a fetch request. This is bad for many reasons: some games have hundreds of boards that will be fetched at startup, if there's simply no data to populate that board, this will just continue to fetch every time the dialog needs to update. To mitigate this, I simply don't load leaderboard information until there are events for that leaderboard - less information for the player, sadly, but heavily cuts down on the number of leaderboard fetches.
2024-07-17 22:51:24 -04:00
LillyJadeKatrin
d19aa934ae
Fixed incorrect unlock information in Achievements dialog
2024-07-17 04:36:53 -04:00
Avasam
130d594c82
Disable Dual Core in Death Jr.: Root of Evil
2024-07-16 22:06:21 -04:00
OatmealDome
cc3ff347b4
Merge pull request #12928 from LillyJadeKatrin/retroachievements-disable-lboard-tab
...
Disable Leaderboards Tab
2024-07-15 21:33:08 -04:00
OatmealDome
802abbb288
Merge pull request #12937 from AdmiralCurtiss/achievements-login-error-message
...
AchievementManager: Don't point to stack for login error message
2024-07-15 18:53:01 -04:00
Admiral H. Curtiss
63e1419396
AchievementManager: Don't point to stack for login error message
2024-07-15 23:24:04 +02:00
OatmealDome
505fe5cc0e
Merge pull request #12935 from AdmiralCurtiss/achievements-default-badges
...
AchievementManager: Improve player/game badge handling and fix crash when no badge is loaded
2024-07-15 16:40:51 -04:00
Aiden
c50689355b
IOS: Fix return code inaccuracy
...
Co-Authored-By: Mike <99037623+MikeIsAStar@users.noreply.github.com>
2024-07-15 16:11:15 -04:00
Admiral H. Curtiss
50b318cc31
Qt/AchievementHeaderWidget: Don't crash when we get an empty player or game badge
2024-07-15 21:55:47 +02:00
Admiral H. Curtiss
d665175a2b
AchievementManager: Return the default player and game badges if the current one isn't loaded yet
...
This saves some copying and fixes an issue where the default badges disappear after a game was closed
2024-07-15 21:55:23 +02:00
JMC47
549b16d442
Merge pull request #12932 from AdmiralCurtiss/colo-xd-gci-patches
...
GameINI: Enable Pokémon Colosseum/XD save patches by default
2024-07-15 15:00:38 -04:00
Admiral H. Curtiss
b18661f15d
Merge pull request #12931 from AdmiralCurtiss/cannot-pause-message
...
AchievementManager: Improve error message for repeated pausing
2024-07-15 12:05:45 +02:00
Admiral H. Curtiss
7e7273a335
GameINI: Enable Pokémon Colosseum/XD save patches by default
2024-07-15 03:44:05 +02:00
OatmealDome
12a1607385
Merge pull request #12749 from LillyJadeKatrin/retroachievements-menubar
...
Show Achievements in Menu Bar always
2024-07-14 19:13:08 -04:00
Admiral H. Curtiss
7a36d5373a
AchievementManager: Improve error message for repeated pausing
2024-07-14 23:09:53 +02:00
Admiral H. Curtiss
a0fc8e6b13
Merge pull request #12929 from LillyJadeKatrin/retroachievements-leaderboard-fixes
...
Fix Leaderboards Tab
2024-07-14 16:47:59 +02:00
LillyJadeKatrin
0108ecebcb
Fix Leaderboards Tab
...
Now that we have some test data, it wasn't showing up in the leaderboards tab; this fixes it to ensure (1) that the right ID is being passed to UpdateRow and (2) the map of leaderboard entries is being populated correctly.
2024-07-14 10:13:27 -04:00
Admiral H. Curtiss
a273dc2de2
Merge pull request #12924 from JosJuice/ra-unverified-ini-osd
...
RetroAchievements: Show OSD messages also for unverified INI files
2024-07-14 04:15:05 +02:00
Admiral H. Curtiss
f23460ab42
Merge pull request #12927 from OatmealDome/old-tools
...
Tools: Remove unused and broken scripts
2024-07-14 04:13:19 +02:00
Admiral H. Curtiss
f928fe97af
Merge pull request #12925 from LillyJadeKatrin/retroachievements-unlocked-progress
...
Achievements Progress Bar Tweaks
2024-07-14 04:11:02 +02:00
Admiral H. Curtiss
ca40eeecff
Merge pull request #12926 from OatmealDome/macos-system-libs
...
BuildMacOSUniversalBinary: Disable usage of most system-provided libraries
2024-07-12 16:49:03 +02:00
Admiral H. Curtiss
95933d5158
Merge pull request #12907 from GaryOderNichts/fix/init_ipc_running
...
IOS::HLE::EmulationKernel::InitIPC: Fix WiiIPC ack generation
2024-07-12 16:48:37 +02:00
LillyJadeKatrin
193c863f20
Disable Leaderboards Tab
...
Emergency PR to disable the leaderboards tab for launch if we are not satisfied with its testing yet.
2024-07-12 07:45:04 -04:00
OatmealDome
4550fc3ab5
Tools: Remove check-includes.py
...
Include sorting has been enforced by clang-format and lint since ~2015.
2024-07-11 15:01:15 -04:00
OatmealDome
8bd2cb40e5
Tools: Remove CleanFiles.py
...
This tool doesn't seem to work properly anymore, even after fixing the path in main().
2024-07-11 15:01:10 -04:00
OatmealDome
3db641ab4c
Tools: Remove buildbot-try.sh
...
try support was removed from the buildbot master in dolphin-emu/sadm@336d0e6064 .
2024-07-11 15:01:05 -04:00
OatmealDome
22aed354f5
Tools: Remove gameini-ratings-from-wiki.sh
...
We haven't been storing ratings in GameINIs since #6569 .
2024-07-11 14:49:29 -04:00
GaryOderNichts
82b97ca904
IOS::HLE::EmulationKernel::InitIPC: Fix WiiIPC ack generation
2024-07-11 19:41:28 +02:00
LillyJadeKatrin
e035db9127
Update game progress bar to match achievement progress bar
2024-07-10 18:51:37 -04:00
OatmealDome
40f2b1a1c2
BuildMacOSUniversalBinary: Disable usage of most system-provided libraries
2024-07-10 17:33:38 -04:00
LillyJadeKatrin
073426ead7
Force progress bar to 100% on completed achievements
2024-07-10 08:51:13 -04:00
JosJuice
1bf12a50c2
RetroAchievements: Show OSD messages also for unverified INI files
...
Currently we're showing OSD messages for unknown patches in known INI
files, but not for unknown patches in unknown INI files. I don't think
this distinction makes much sense to the user. If there's a patch the
user can't use, they probably want to be aware of that fact.
2024-07-10 13:16:54 +02:00
Admiral H. Curtiss
321c4649a5
Merge pull request #12921 from VampireFlower/master
...
BreakpointWidget: Correct icon position
2024-07-10 03:25:49 +02:00
VampireFlower
afa6e26e5d
BreakpointWidget: Correct icon position
...
Co-Authored-By: TryTwo <10532806+TryTwo@users.noreply.github.com>
2024-07-09 15:20:56 -07:00
Admiral H. Curtiss
bb03fc04cc
Merge pull request #12922 from JosJuice/android-approved-list-crash
...
RetroAchievements: Delay calling LoadApprovedList
2024-07-09 15:27:37 +02:00
JosJuice
e6b9091ffc
RetroAchievements: Skip LoadApprovedList if there are no patches
...
There being no active patches is by far the most common case, so let's
optimize for this case.
2024-07-09 09:55:51 +02:00
JosJuice
f59678842b
RetroAchievements: Delay calling LoadApprovedList
...
0c14b0c8a7
made Dolphin load a file from
the Sys folder the first time AchievementManager::GetInstance() is
called. Because Android calls AchievementManager::GetInstance() from
setBackgroundExecutionAllowedNative, this had two negative consequences
on Android:
1. The first time setBackgroundExecutionAllowedNative gets called is
often before directory initialization is done. Getting the path of
the Sys folder before directory initialization is done causes a crash.
2. setBackgroundExecutionAllowedNative is called from the GUI thread,
and we don't want file I/O on the GUI thread for performance reasons.
This change makes us load the data from the Sys folder the first time
the data is needed instead. This also saves us from having to load the
data at all when hardcore mode is inactive.
2024-07-09 09:55:07 +02:00