ShuriZma
/
dolphin
mirror of https://github.com/dolphin-emu/dolphin.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

JitArm64: Fix frspx with single precision source 

I haven't observed this breaking any game, but it didn't match
the behavior of the interpreter as far as I could tell from
reading the code, in that denormals weren't being flushed.
This commit is contained in:
JosJuice 2021-01-23 20:13:45 +01:00
parent 54451ac731
commit 69c14d6ec3
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
View File

@ -258,7 +258,7 @@ void JitArm64::frspx(UGeckoInstruction inst)
const u32 d = inst.FD; const u32 d = inst.FD;
const bool single = fpr.IsSingle(b, true); const bool single = fpr.IsSingle(b, true);
if (single) if (single && js.fpr_is_store_safe[b])
{ {
// Source is already in single precision, so no need to do anything but to copy to PSR1. // Source is already in single precision, so no need to do anything but to copy to PSR1.
const ARM64Reg VB = fpr.R(b, RegType::LowerPairSingle); const ARM64Reg VB = fpr.R(b, RegType::LowerPairSingle);
@ -266,6 +266,9 @@ void JitArm64::frspx(UGeckoInstruction inst)
if (b != d) if (b != d)
m_float_emit.FMOV(EncodeRegToSingle(VD), EncodeRegToSingle(VB)); m_float_emit.FMOV(EncodeRegToSingle(VD), EncodeRegToSingle(VB));
ASSERT_MSG(DYNA_REC, fpr.IsSingle(b, true),
"Register allocation turned singles into doubles in the middle of frspx");
} }
else else
{ {
@ -274,9 +277,6 @@ void JitArm64::frspx(UGeckoInstruction inst)
m_float_emit.FCVT(32, 64, EncodeRegToDouble(VD), EncodeRegToDouble(VB)); m_float_emit.FCVT(32, 64, EncodeRegToDouble(VD), EncodeRegToDouble(VB));
} }
ASSERT_MSG(DYNA_REC, b == d || single == fpr.IsSingle(b, true),
"Register allocation turned singles into doubles in the middle of frspx");
} }
void JitArm64::fcmpX(UGeckoInstruction inst) void JitArm64::fcmpX(UGeckoInstruction inst)